[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16389146#comment-16389146 ] ASF GitHub Bot commented on CB-13415: - jd0048 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-371043918 @shazron Can you please check and merge code. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13956) InAppBrowser safe-area-inset margins wrong on iPhone X
[
https://issues.apache.org/jira/browse/CB-13956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacob Weber updated CB-13956:
-
Description:
The in-app browser doesn't use the correct margins on an iPhone X, if you try
to use {{viewport-fit=cover}} along with the {{safe-area-inset-*}} constants.
To reproduce:
{code:java}
cordova create CordovaTest com.sample.cordovatest CordovaTest
cd CordovaTest
cordova platform add ios@4.5.4
cordova plugin add cordova-plugin-inappbrowser
cordova plugin add cordova-plugin-statusbar{code}
Then to make it work on the iPhone X, create a 2732x2732 image and add it to
config.xml:
{code:java}
{code}
and add {{viewport-fit=cover}} to the {{viewport}} tag of {{www/index.html}}.
Finally, create an HTML page to load in the in-app browser, and store it on
some web server:
{code:java}
html {
background-color: #00;
}
body {
border: 1px solid red;
margin-top: env(safe-area-inset-top);
margin-bottom: env(safe-area-inset-bottom);
margin-left: env(safe-area-inset-left);
margin-right: env(safe-area-inset-right);
}
{code}
Now launch this on an iPhone X simulator running iOS 11.2, attach a Safari
debugger, and open the page in an in-app browser, e.g.
{{window.open("https://myserver.com/test.html;, "_blank");}}
The attachments show what you'll see.
# Starting in portrait, the borders look correct.
# Rotate to landscape, and the left/right safe-area margins aren't applied.
# Rotate back to portrait, and now things are different. The left/right sides
have safe-area margins when they shouldn't, and the top doesn't have one when
it should.
If you load the same page directly in Safari, it behaves as expected.
The gray status-bar overlay gets in the way of seeing exactly what's happening;
see CB-13583.
was:
The in-app browser doesn't use the correct margins on an iPhone X, if you try
to use {{viewport-fit=cover}} along with the {{safe-area-inset-*}} constants.
To reproduce:
{code:java}
cordova create CordovaTest com.sample.cordovatest CordovaTest
cd CordovaTest
cordova platform add ios@4.5.4
cordova plugin add cordova-plugin-inappbrowser
cordova plugin add cordova-plugin-statusbar{code}
Then to make it work on the iPhone X, create a 2732x2732 image and add it to
config.xml:
{code:java}
{code}
and add {{viewport-fit=cover}} to the {{viewport}} tag of {{www/index.html}}.
Finally, create an HTML page to load in the in-app browser, and store it on
some web server:
{code:java}
html {
background-color: #00;
}
body {
border: 1px solid red;
margin-top: env(safe-area-inset-top);
margin-bottom: env(safe-area-inset-bottom);
margin-left: env(safe-area-inset-left);
margin-right: env(safe-area-inset-right);
}
{code}
Now launch this on an iPhone X simulator running iOS 11.2, attach a Safari
debugger, and open the page in an in-app browser, e.g.
{{window.open("https://myserver.com/test.html;, "_blank");}}
The attachments show what you'll see.
# Starting in portrait, the borders look correct.
# Rotate to landscape, and the left/right safe-area margins aren't applied.
# Rotate back to portrait, and now things are different. The left/right sides
have safe-area margins when they shouldn't, and the top doesn't have one when
it should.
If you load the same page directly in Safari, it behaves as expected.
> InAppBrowser safe-area-inset margins wrong on iPhone X
> --
>
> Key: CB-13956
> URL: https://issues.apache.org/jira/browse/CB-13956
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios, cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
> Environment: Mac OS 10.13.3, cordova-cli 8.0.0, node 8.9.4
>Reporter: Jacob Weber
>Assignee: Suraj Pindoria
>Priority: Major
> Attachments: 1. portrait.png, 2. landscape.png, 3. portrait.png,
> CordovaTest.zip
>
>
> The in-app browser doesn't use the correct margins on an iPhone X, if you try
> to use {{viewport-fit=cover}} along with the {{safe-area-inset-*}} constants.
> To reproduce:
> {code:java}
> cordova create CordovaTest com.sample.cordovatest CordovaTest
> cd CordovaTest
> cordova platform add ios@4.5.4
> cordova plugin add cordova-plugin-inappbrowser
> cordova plugin add cordova-plugin-statusbar{code}
> Then to make it work on the iPhone X, create a 2732x2732 image and add it to
> config.xml:
> {code:java}
> {code}
> and add {{viewport-fit=cover}} to the {{viewport}} tag of {{www/index.html}}.
> Finally, create an HTML page to load in the in-app browser, and store it on
> some web server:
> {code:java}
>
>
>
>
> html {
> background-color: #00;
> }
> body {
> border: 1px solid red;
> margin-top: env(safe-area-inset-top);
> margin-bottom: env(safe-area-inset-bottom);
> margin-left:
[jira] [Created] (CB-13956) InAppBrowser safe-area-inset margins wrong on iPhone X
Jacob Weber created CB-13956:
Summary: InAppBrowser safe-area-inset margins wrong on iPhone X
Key: CB-13956
URL: https://issues.apache.org/jira/browse/CB-13956
Project: Apache Cordova
Issue Type: Bug
Components: cordova-ios, cordova-plugin-inappbrowser
Affects Versions: cordova-ios 4.5.0
Environment: Mac OS 10.13.3, cordova-cli 8.0.0, node 8.9.4
Reporter: Jacob Weber
Assignee: Suraj Pindoria
Attachments: 1. portrait.png, 2. landscape.png, 3. portrait.png,
CordovaTest.zip
The in-app browser doesn't use the correct margins on an iPhone X, if you try
to use {{viewport-fit=cover}} along with the {{safe-area-inset-*}} constants.
To reproduce:
{code:java}
cordova create CordovaTest com.sample.cordovatest CordovaTest
cd CordovaTest
cordova platform add ios@4.5.4
cordova plugin add cordova-plugin-inappbrowser
cordova plugin add cordova-plugin-statusbar{code}
Then to make it work on the iPhone X, create a 2732x2732 image and add it to
config.xml:
{code:java}
{code}
and add {{viewport-fit=cover}} to the {{viewport}} tag of {{www/index.html}}.
Finally, create an HTML page to load in the in-app browser, and store it on
some web server:
{code:java}
html {
background-color: #00;
}
body {
border: 1px solid red;
margin-top: env(safe-area-inset-top);
margin-bottom: env(safe-area-inset-bottom);
margin-left: env(safe-area-inset-left);
margin-right: env(safe-area-inset-right);
}
{code}
Now launch this on an iPhone X simulator running iOS 11.2, attach a Safari
debugger, and open the page in an in-app browser, e.g.
{{window.open("https://myserver.com/test.html;, "_blank");}}
The attachments show what you'll see.
# Starting in portrait, the borders look correct.
# Rotate to landscape, and the left/right safe-area margins aren't applied.
# Rotate back to portrait, and now things are different. The left/right sides
have safe-area margins when they shouldn't, and the top doesn't have one when
it should.
If you load the same page directly in Safari, it behaves as expected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13950) All Exif data is stripped off under iOS when Camera.DestinationType is File_URI
[
https://issues.apache.org/jira/browse/CB-13950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388678#comment-16388678
]
Junran commented on CB-13950:
-
User Text to keep the line change:
- (NSData*)processImage:(UIImage*)image info:(NSDictionary*)info
options:(CDVPictureOptions*)options
{
NSData* data = nil;
switch (options.encodingType) {
case EncodingTypePNG:
data = UIImagePNGRepresentation(image);
break;
case EncodingTypeJPEG:
{
if ((options.allowsEditing == NO) && (options.targetSize.width <=
0) && (options.targetSize.height <= 0) && (options.correctOrientation == NO) &&
(([options.quality integerValue] == 100) || (options.sourceType !=
UIImagePickerControllerSourceTypeCamera))){
// use image unedited as requested , don't resize
data = UIImageJPEGRepresentation(image, 1.0);
} else {
data = UIImageJPEGRepresentation(image, [options.quality
floatValue] / 100.0f);
}
//if (options.usesGeolocation) {
NSURL *assetURL = [info
objectForKey:UIImagePickerControllerReferenceURL];
//NSDictionary *metadata =[info
objectForKey:UIImagePickerControllerMediaMetadata];
ALAssetsLibrary *library = [[ALAssetsLibrary alloc] init];
dispatch_semaphore_t sema = dispatch_semaphore_create(0);
dispatch_queue_t queue =
dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,0);
dispatch_async(queue, ^{[library assetForURL:assetURL
resultBlock:^(ALAsset *asset) {
NSDictionary *controllerMetadata =
asset.defaultRepresentation.metadata;
//NSLog(@"metadatacontrol %@", controllerMetadata);
//NSDictionary* controllerMetadata = [info
objectForKey:@"UIImagePickerControllerMediaMetadata"];
if (controllerMetadata) {
self.data = data;
self.metadata = [[NSMutableDictionary alloc] init];
NSMutableDictionary *metadataAsMutable =
[controllerMetadata mutableCopy];
//NSMutableDictionary* EXIFDictionary =
[[metadataAsMutable
objectForKey:(NSString*)kCGImagePropertyExifDictionary]mutableCopy];
NSMutableDictionary *EXIFDictionary =
[[metadataAsMutable objectForKey:(NSString
*)kCGImagePropertyExifDictionary]mutableCopy];
NSMutableDictionary *GPSDictionary =
[[metadataAsMutable objectForKey:(NSString
*)kCGImagePropertyGPSDictionary]mutableCopy];
NSMutableDictionary *RAWDictionary =
[[metadataAsMutable objectForKey:(NSString
*)kCGImagePropertyRawDictionary]mutableCopy];
if(!EXIFDictionary)
EXIFDictionary = [[NSMutableDictionary dictionary]
init];
if(!GPSDictionary)
GPSDictionary = [[NSMutableDictionary dictionary]
init];
if(!RAWDictionary)
RAWDictionary = [[NSMutableDictionary dictionary]
init];
//Add the modified Data back into the image’s metadata
[self.metadata setObject:EXIFDictionary
forKey:(NSString *)kCGImagePropertyExifDictionary];
[self.metadata setObject:GPSDictionary forKey:(NSString
*)kCGImagePropertyGPSDictionary];
[self.metadata setObject:RAWDictionary forKey:(NSString
*)kCGImagePropertyRawDictionary];
//NSLog(@"enter gpsdictionary %@", GPSDictionary);
//NSLog(@"enter exifdictionary %@", EXIFDictionary);
//NSLog(@"enter rawdictionary %@", RAWDictionary);
//NSLog(@"enter self.metadata %@", self.metadata);
if (self.metadata) {
//this will be the data CGImageDestinationRef will
write into
NSMutableData *newImageData = [NSMutableData data];
CGImageSourceRef sourceImage =
CGImageSourceCreateWithData((__bridge CFDataRef)self.data, NULL);
CFStringRef sourceType =
CGImageSourceGetType(sourceImage);
CGImageDestinationRef destinationImage =
CGImageDestinationCreateWithData((__bridge CFMutableDataRef)newImageData,
sourceType, 1, NULL);
CGImageDestinationAddImageFromSource(destinationImage, sourceImage, 0,
(__bridge CFDictionaryRef)self.metadata);
CGImageDestinationFinalize(destinationImage);
//CIImage *testImage = [CIImage
imageWithData:newImageData];
self.data = newImageData;
[jira] [Commented] (CB-13950) All Exif data is stripped off under iOS when Camera.DestinationType is File_URI
[
https://issues.apache.org/jira/browse/CB-13950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388676#comment-16388676
]
Junran commented on CB-13950:
-
I have changed the following function to keep the exif data when using
File_URI, please use or make change as you see fit, any other suggestion or
improvement is most welcome too:
- (NSData*)processImage:(UIImage*)image info:(NSDictionary*)info
options:(CDVPictureOptions*)options
{
NSData* data = nil;
switch (options.encodingType) {
case EncodingTypePNG:
data = UIImagePNGRepresentation(image);
break;
case EncodingTypeJPEG:
{
if ((options.allowsEditing == NO) && (options.targetSize.width <=
0) && (options.targetSize.height <= 0) && (options.correctOrientation == NO) &&
(([options.quality integerValue] == 100) || (options.sourceType !=
UIImagePickerControllerSourceTypeCamera))){
// use image unedited as requested , don't resize
data = UIImageJPEGRepresentation(image, 1.0);
} else {
data = UIImageJPEGRepresentation(image, [options.quality
floatValue] / 100.0f);
}
//if (options.usesGeolocation) {
NSURL *assetURL = [info
objectForKey:UIImagePickerControllerReferenceURL];
//NSDictionary *metadata =[info
objectForKey:UIImagePickerControllerMediaMetadata];
ALAssetsLibrary *library = [[ALAssetsLibrary alloc] init];
dispatch_semaphore_t sema = dispatch_semaphore_create(0);
dispatch_queue_t queue =
dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_DEFAULT,0);
dispatch_async(queue, ^{[library assetForURL:assetURL
resultBlock:^(ALAsset *asset) {
NSDictionary *controllerMetadata =
asset.defaultRepresentation.metadata;
//NSLog(@"metadatacontrol %@", controllerMetadata);
//NSDictionary* controllerMetadata = [info
objectForKey:@"UIImagePickerControllerMediaMetadata"];
if (controllerMetadata) {
self.data = data;
self.metadata = [[NSMutableDictionary alloc] init];
NSMutableDictionary *metadataAsMutable =
[controllerMetadata mutableCopy];
//NSMutableDictionary* EXIFDictionary =
[[metadataAsMutable
objectForKey:(NSString*)kCGImagePropertyExifDictionary]mutableCopy];
NSMutableDictionary *EXIFDictionary =
[[metadataAsMutable objectForKey:(NSString
*)kCGImagePropertyExifDictionary]mutableCopy];
NSMutableDictionary *GPSDictionary =
[[metadataAsMutable objectForKey:(NSString
*)kCGImagePropertyGPSDictionary]mutableCopy];
NSMutableDictionary *RAWDictionary =
[[metadataAsMutable objectForKey:(NSString
*)kCGImagePropertyRawDictionary]mutableCopy];
if(!EXIFDictionary)
EXIFDictionary = [[NSMutableDictionary dictionary]
init];
if(!GPSDictionary)
GPSDictionary = [[NSMutableDictionary dictionary]
init];
if(!RAWDictionary)
RAWDictionary = [[NSMutableDictionary dictionary]
init];
//Add the modified Data back into the image’s metadata
[self.metadata setObject:EXIFDictionary
forKey:(NSString *)kCGImagePropertyExifDictionary];
[self.metadata setObject:GPSDictionary forKey:(NSString
*)kCGImagePropertyGPSDictionary];
[self.metadata setObject:RAWDictionary forKey:(NSString
*)kCGImagePropertyRawDictionary];
//NSLog(@"enter gpsdictionary %@", GPSDictionary);
//NSLog(@"enter exifdictionary %@", EXIFDictionary);
//NSLog(@"enter rawdictionary %@", RAWDictionary);
//NSLog(@"enter self.metadata %@", self.metadata);
if (self.metadata) {
//this will be the data CGImageDestinationRef will
write into
NSMutableData *newImageData = [NSMutableData data];
CGImageSourceRef sourceImage =
CGImageSourceCreateWithData((__bridge CFDataRef)self.data, NULL);
CFStringRef sourceType =
CGImageSourceGetType(sourceImage);
CGImageDestinationRef destinationImage =
CGImageDestinationCreateWithData((__bridge CFMutableDataRef)newImageData,
sourceType, 1, NULL);
CGImageDestinationAddImageFromSource(destinationImage, sourceImage, 0,
(__bridge CFDictionaryRef)self.metadata);
CGImageDestinationFinalize(destinationImage);
[jira] [Commented] (CB-13193) Setting orientation to landscape might turn UI upside down if already in landscape
[
https://issues.apache.org/jira/browse/CB-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388670#comment-16388670
]
ASF GitHub Bot commented on CB-13193:
-
ptorrent commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape
Orientation turn up-sidedown
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-370957883
Hello,
I don't understand how works this plugin..
If I do screen.orientation.lock('portrait') , it changes nothing.
screen.orientation.lock('landscape') too..
I can always change the orientation of my screen.
If I close the application and go back inside , it's works!
Thanks for your reply
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Setting orientation to landscape might turn UI upside down if already in
> landscape
> --
>
> Key: CB-13193
> URL: https://issues.apache.org/jira/browse/CB-13193
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-screen-orientation
>Reporter: Jonathan Herdt
>Assignee: Vishal Mishra
>Priority: Major
>
> Steps to reproduce:
> # Set up an app to lock its orientation to 'landscape' at startup via
> `screen.orientation.lock('landscape')`
> # Set device to landscape-left (home button on left side)
> # Start app
> # Observe UI turning upside down
> Desired behavior: Rotation is locked but UI does not turn upside down
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13193) Setting orientation to landscape might turn UI upside down if already in landscape
[
https://issues.apache.org/jira/browse/CB-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388667#comment-16388667
]
ASF GitHub Bot commented on CB-13193:
-
ptorrent commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape
Orientation turn up-sidedown
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-370957883
Hello,
I don't understand how works this plugin..
If I do screen.orientation.lock('portrait') , it changes nothing.
screen.orientation.lock('landscape') to..
I've to close the application and go back inside and it's works.
I can always change the orientation of my screen.
Thanks for your reply
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Setting orientation to landscape might turn UI upside down if already in
> landscape
> --
>
> Key: CB-13193
> URL: https://issues.apache.org/jira/browse/CB-13193
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-screen-orientation
>Reporter: Jonathan Herdt
>Assignee: Vishal Mishra
>Priority: Major
>
> Steps to reproduce:
> # Set up an app to lock its orientation to 'landscape' at startup via
> `screen.orientation.lock('landscape')`
> # Set device to landscape-left (home button on left side)
> # Start app
> # Observe UI turning upside down
> Desired behavior: Rotation is locked but UI does not turn upside down
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13193) Setting orientation to landscape might turn UI upside down if already in landscape
[
https://issues.apache.org/jira/browse/CB-13193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388653#comment-16388653
]
ASF GitHub Bot commented on CB-13193:
-
ptorrent commented on issue #25: CB-13193: (ios) Fixed Lock iOS Landscape
Orientation turn up-sidedown
URL:
https://github.com/apache/cordova-plugin-screen-orientation/pull/25#issuecomment-370957883
Hello,
I don't understand how works this plugin..
If I do screen.orientation.lock('portrait') , it changes nothing.
screen.orientation.lock('landscape') to..
I can always change the orientation of my screen.
Thanks for your reply
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Setting orientation to landscape might turn UI upside down if already in
> landscape
> --
>
> Key: CB-13193
> URL: https://issues.apache.org/jira/browse/CB-13193
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-screen-orientation
>Reporter: Jonathan Herdt
>Assignee: Vishal Mishra
>Priority: Major
>
> Steps to reproduce:
> # Set up an app to lock its orientation to 'landscape' at startup via
> `screen.orientation.lock('landscape')`
> # Set device to landscape-left (home button on left side)
> # Start app
> # Observe UI turning upside down
> Desired behavior: Rotation is locked but UI does not turn upside down
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13954) NullPointerException when processing result from camera
[
https://issues.apache.org/jira/browse/CB-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Zacher updated CB-13954:
-
Description:
I have gotten a number of crash reports via the google play console for a null
pointer exception (see below for stack).
Over the last 60 days it has happened to 6 of my users, 28 times.
Of those 28 times, 26 were on an S8, and 2 were on an S8+.
All 28 times were on Android 7.0.
Looking at the source code, it seems to be a problem when attempting to access
the extras from the intent - the problem being that the extras return null
(which the code doesn't expect):
[https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
{code:java}
java.lang.RuntimeException:
at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
at android.app.ActivityThread.-wrap22 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:154)
at android.app.ActivityThread.main (ActivityThread.java:6776)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
Caused by: java.lang.NullPointerException:
at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
(CameraLauncher.java:514)
at org.apache.cordova.camera.CameraLauncher.onActivityResult
(CameraLauncher.java:805)
at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
(CordovaInterfaceImpl.java:152)
at org.apache.cordova.CordovaActivity.onActivityResult
(CordovaActivity.java:358)
at android.app.Activity.dispatchActivityResult (Activity.java:7282)
at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
{code}
This is the calling code:
{code:javascript}
navigator.camera.getPicture(onSuccess, onFail, {
quality: 50,
destinationType: Camera.DestinationType.DATA_URL,
sourceType: navigator.camera.PictureSourceType.CAMERA,
encodingType: Camera.EncodingType.JPEG,
targetWidth: 1024,
targetHeight: 1024,
mediaType: Camera.MediaType.PICTURE,
allowEdit: false,
correctOrientation: true,
saveToPhotoAlbum: false,
}){code}
was:
I have gotten a number of crash reports via the google play console for a null
pointer exception (see below for stack).
Looking at the source code, it seems to be a problem when attempting to access
the extras from the intent - the problem being that the extras return null
(which the code doesn't expect):
[https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
{code:java}
java.lang.RuntimeException:
at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
at android.app.ActivityThread.-wrap22 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:154)
at android.app.ActivityThread.main (ActivityThread.java:6776)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
Caused by: java.lang.NullPointerException:
at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
(CameraLauncher.java:514)
at org.apache.cordova.camera.CameraLauncher.onActivityResult
(CameraLauncher.java:805)
at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
(CordovaInterfaceImpl.java:152)
at org.apache.cordova.CordovaActivity.onActivityResult
(CordovaActivity.java:358)
at android.app.Activity.dispatchActivityResult (Activity.java:7282)
at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
{code}
> NullPointerException when processing result from camera
> ---
>
> Key: CB-13954
> URL: https://issues.apache.org/jira/browse/CB-13954
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Brad Zacher
>Priority: Major
>
> I have gotten a number of crash reports via the google play console for a
> null pointer exception (see below for stack).
>
> Over the last 60 days it has happened to 6 of my users, 28 times.
> Of those 28 times, 26 were on an S8, and 2 were on an S8+.
> All 28 times were on Android 7.0.
>
> Looking at the source code, it seems to be a problem when
[jira] [Comment Edited] (CB-13954) NullPointerException when processing result from camera
[
https://issues.apache.org/jira/browse/CB-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388607#comment-16388607
]
Brad Zacher edited comment on CB-13954 at 3/6/18 10:10 PM:
---
The reports are pretty bad in the google play dev console.
It doesn't even log the actual message thrown with the exception.
Just the exception type, and stack trace.
I have updated the description with the requested information
was (Author: bradzacher):
The reports are pretty bad in the google play dev console.
It doesn't even log the actual message thrown with the exception.
Just the exception type, and stack trace.
Over the last 60 days it has happened to 6 of my users, 28 times.
Of those 28 times, 26 were on an S8, and 2 were on an S8+.
All 28 times were on Android 7.0.
This is the calling code:
{code:javascript}
navigator.camera.getPicture(onSuccess, onFail, {
quality: 50,
destinationType: Camera.DestinationType.DATA_URL,
sourceType: navigator.camera.PictureSourceType.CAMERA,
encodingType: Camera.EncodingType.JPEG,
targetWidth: 1024,
targetHeight: 1024,
mediaType: Camera.MediaType.PICTURE,
allowEdit: false,
correctOrientation: true,
saveToPhotoAlbum: false,
})
{code}
> NullPointerException when processing result from camera
> ---
>
> Key: CB-13954
> URL: https://issues.apache.org/jira/browse/CB-13954
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Brad Zacher
>Priority: Major
>
> I have gotten a number of crash reports via the google play console for a
> null pointer exception (see below for stack).
> Looking at the source code, it seems to be a problem when attempting to
> access the extras from the intent - the problem being that the extras return
> null (which the code doesn't expect):
> [https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
>
> {code:java}
> java.lang.RuntimeException:
> at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
> at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
> at android.app.ActivityThread.-wrap22 (ActivityThread.java)
> at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
> at android.os.Handler.dispatchMessage (Handler.java:102)
> at android.os.Looper.loop (Looper.java:154)
> at android.app.ActivityThread.main (ActivityThread.java:6776)
> at java.lang.reflect.Method.invoke (Native Method)
> at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
> (ZygoteInit.java:1520)
> at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
> Caused by: java.lang.NullPointerException:
> at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
> (CameraLauncher.java:514)
> at org.apache.cordova.camera.CameraLauncher.onActivityResult
> (CameraLauncher.java:805)
> at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
> (CordovaInterfaceImpl.java:152)
> at org.apache.cordova.CordovaActivity.onActivityResult
> (CordovaActivity.java:358)
> at android.app.Activity.dispatchActivityResult (Activity.java:7282)
> at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
> {code}
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13954) NullPointerException when processing result from camera
[
https://issues.apache.org/jira/browse/CB-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Zacher updated CB-13954:
-
Description:
I have gotten a number of crash reports via the google play console for a null
pointer exception (see below for stack).
Looking at the source code, it seems to be a problem when attempting to access
the extras from the intent - the problem being that the extras return null
(which the code doesn't expect):
[https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
{code:java}
java.lang.RuntimeException:
at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
at android.app.ActivityThread.-wrap22 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:154)
at android.app.ActivityThread.main (ActivityThread.java:6776)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
Caused by: java.lang.NullPointerException:
at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
(CameraLauncher.java:514)
at org.apache.cordova.camera.CameraLauncher.onActivityResult
(CameraLauncher.java:805)
at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
(CordovaInterfaceImpl.java:152)
at org.apache.cordova.CordovaActivity.onActivityResult
(CordovaActivity.java:358)
at android.app.Activity.dispatchActivityResult (Activity.java:7282)
at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
{code}
was:
I have gotten a number of crash reports via the google play console for a null
pointer exception (see below for stack).
Looking at the source code, it seems to be a problem when attempting to access
the extras from the intent - the problem being that the extras return null
(which the code doesn't expect):
[https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
*java.lang.RuntimeException:*
at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
at android.app.ActivityThread.-wrap22 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:154)
at android.app.ActivityThread.main (ActivityThread.java:6776)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
*Caused by: java.lang.NullPointerException:*
at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
(CameraLauncher.java:514)
at org.apache.cordova.camera.CameraLauncher.onActivityResult
(CameraLauncher.java:805)
at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
(CordovaInterfaceImpl.java:152)
at org.apache.cordova.CordovaActivity.onActivityResult
(CordovaActivity.java:358)
at android.app.Activity.dispatchActivityResult (Activity.java:7282)
at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
> NullPointerException when processing result from camera
> ---
>
> Key: CB-13954
> URL: https://issues.apache.org/jira/browse/CB-13954
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Brad Zacher
>Priority: Major
>
> I have gotten a number of crash reports via the google play console for a
> null pointer exception (see below for stack).
> Looking at the source code, it seems to be a problem when attempting to
> access the extras from the intent - the problem being that the extras return
> null (which the code doesn't expect):
> [https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
>
>
> {code:java}
> java.lang.RuntimeException:
> at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
> at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
> at android.app.ActivityThread.-wrap22 (ActivityThread.java)
> at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
> at android.os.Handler.dispatchMessage (Handler.java:102)
> at android.os.Looper.loop (Looper.java:154)
> at android.app.ActivityThread.main (ActivityThread.java:6776)
> at
[jira] [Updated] (CB-13954) NullPointerException when processing result from camera
[
https://issues.apache.org/jira/browse/CB-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brad Zacher updated CB-13954:
-
Description:
I have gotten a number of crash reports via the google play console for a null
pointer exception (see below for stack).
Looking at the source code, it seems to be a problem when attempting to access
the extras from the intent - the problem being that the extras return null
(which the code doesn't expect):
[https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
{code:java}
java.lang.RuntimeException:
at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
at android.app.ActivityThread.-wrap22 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:154)
at android.app.ActivityThread.main (ActivityThread.java:6776)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
Caused by: java.lang.NullPointerException:
at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
(CameraLauncher.java:514)
at org.apache.cordova.camera.CameraLauncher.onActivityResult
(CameraLauncher.java:805)
at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
(CordovaInterfaceImpl.java:152)
at org.apache.cordova.CordovaActivity.onActivityResult
(CordovaActivity.java:358)
at android.app.Activity.dispatchActivityResult (Activity.java:7282)
at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
{code}
was:
I have gotten a number of crash reports via the google play console for a null
pointer exception (see below for stack).
Looking at the source code, it seems to be a problem when attempting to access
the extras from the intent - the problem being that the extras return null
(which the code doesn't expect):
[https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
{code:java}
java.lang.RuntimeException:
at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
at android.app.ActivityThread.-wrap22 (ActivityThread.java)
at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
at android.os.Handler.dispatchMessage (Handler.java:102)
at android.os.Looper.loop (Looper.java:154)
at android.app.ActivityThread.main (ActivityThread.java:6776)
at java.lang.reflect.Method.invoke (Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
(ZygoteInit.java:1520)
at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
Caused by: java.lang.NullPointerException:
at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
(CameraLauncher.java:514)
at org.apache.cordova.camera.CameraLauncher.onActivityResult
(CameraLauncher.java:805)
at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
(CordovaInterfaceImpl.java:152)
at org.apache.cordova.CordovaActivity.onActivityResult
(CordovaActivity.java:358)
at android.app.Activity.dispatchActivityResult (Activity.java:7282)
at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
{code}
> NullPointerException when processing result from camera
> ---
>
> Key: CB-13954
> URL: https://issues.apache.org/jira/browse/CB-13954
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Brad Zacher
>Priority: Major
>
> I have gotten a number of crash reports via the google play console for a
> null pointer exception (see below for stack).
> Looking at the source code, it seems to be a problem when attempting to
> access the extras from the intent - the problem being that the extras return
> null (which the code doesn't expect):
> [https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
>
> {code:java}
> java.lang.RuntimeException:
> at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
> at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
> at android.app.ActivityThread.-wrap22 (ActivityThread.java)
> at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
> at android.os.Handler.dispatchMessage (Handler.java:102)
> at android.os.Looper.loop (Looper.java:154)
> at android.app.ActivityThread.main (ActivityThread.java:6776)
> at
[jira] [Commented] (CB-13954) NullPointerException when processing result from camera
[
https://issues.apache.org/jira/browse/CB-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388607#comment-16388607
]
Brad Zacher commented on CB-13954:
--
The reports are pretty bad in the google play dev console.
It doesn't even log the actual message thrown with the exception.
Just the exception type, and stack trace.
Over the last 60 days it has happened to 6 of my users, 28 times.
Of those 28 times, 26 were on an S8, and 2 were on an S8+.
All 28 times were on Android 7.0.
This is the calling code:
{code:javascript}
navigator.camera.getPicture(onSuccess, onFail, {
quality: 50,
destinationType: Camera.DestinationType.DATA_URL,
sourceType: navigator.camera.PictureSourceType.CAMERA,
encodingType: Camera.EncodingType.JPEG,
targetWidth: 1024,
targetHeight: 1024,
mediaType: Camera.MediaType.PICTURE,
allowEdit: false,
correctOrientation: true,
saveToPhotoAlbum: false,
})
{code}
> NullPointerException when processing result from camera
> ---
>
> Key: CB-13954
> URL: https://issues.apache.org/jira/browse/CB-13954
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-plugin-camera
>Reporter: Brad Zacher
>Priority: Major
>
> I have gotten a number of crash reports via the google play console for a
> null pointer exception (see below for stack).
> Looking at the source code, it seems to be a problem when attempting to
> access the extras from the intent - the problem being that the extras return
> null (which the code doesn't expect):
> [https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516]
>
> *java.lang.RuntimeException:*
> at android.app.ActivityThread.deliverResults (ActivityThread.java:4520)
> at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563)
> at android.app.ActivityThread.-wrap22 (ActivityThread.java)
> at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698)
> at android.os.Handler.dispatchMessage (Handler.java:102)
> at android.os.Looper.loop (Looper.java:154)
> at android.app.ActivityThread.main (ActivityThread.java:6776)
> at java.lang.reflect.Method.invoke (Native Method)
> at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run
> (ZygoteInit.java:1520)
> at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410)
> *Caused by: java.lang.NullPointerException:*
> at org.apache.cordova.camera.CameraLauncher.processResultFromCamera
> (CameraLauncher.java:514)
> at org.apache.cordova.camera.CameraLauncher.onActivityResult
> (CameraLauncher.java:805)
> at org.apache.cordova.CordovaInterfaceImpl.onActivityResult
> (CordovaInterfaceImpl.java:152)
> at org.apache.cordova.CordovaActivity.onActivityResult
> (CordovaActivity.java:358)
> at android.app.Activity.dispatchActivityResult (Activity.java:7282)
> at android.app.ActivityThread.deliverResults (ActivityThread.java:4516)
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388412#comment-16388412 ] Jan Piotrowski (Sujan) commented on CB-13955: - Info: There is a `Makefile` that works just like the `gulpfile.js` and has the same functionality (or should have). > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13564) Multiple edit-config items for Info.plist causing error
[
https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13564:
Affects Version/s: 7.1.0
> Multiple edit-config items for Info.plist causing error
> ---
>
> Key: CB-13564
> URL: https://issues.apache.org/jira/browse/CB-13564
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: 7.1.0
>Reporter: Tom Bell
>Priority: Major
>
> I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects
> Versions" dropdown.
> I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0,
> I've got the following
> working:
> {code:xml}
> target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import
> contacts into [redacted]
>
> {code}
> However when I decided to move some stuff from an `after_prepare` hook
> script, to use edit-config, it fails with an error `doc.find is not a
> function`
> {code:xml}
> target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import
> contacts into [redacted]
>
>
> UIStatusBarStyleLightContent
>
> {code}
> If I take out the additional `` everything works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-13564) Multiple edit-config items for Info.plist causing error
[
https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Piotrowski (Sujan) updated CB-13564:
Description:
I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3.0.0,
I've got the following
working:
{code:xml}
We require permission to access your contacts so you can import
contacts into [redacted]
{code}
However when I decided to move some stuff from an `after_prepare` hook script,
to use edit-config, it fails with an error `doc.find is not a function`
{code:xml}
We require permission to access your contacts so you can import
contacts into [redacted]
UIStatusBarStyleLightContent
{code}
If I take out the additional `` everything works.
was:
I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects Versions"
dropdown.
I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0,
I've got the following
working:
{code:xml}
We require permission to access your contacts so you can import
contacts into [redacted]
{code}
However when I decided to move some stuff from an `after_prepare` hook script,
to use edit-config, it fails with an error `doc.find is not a function`
{code:xml}
We require permission to access your contacts so you can import
contacts into [redacted]
UIStatusBarStyleLightContent
{code}
If I take out the additional `` everything works.
> Multiple edit-config items for Info.plist causing error
> ---
>
> Key: CB-13564
> URL: https://issues.apache.org/jira/browse/CB-13564
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Affects Versions: 7.1.0
>Reporter: Tom Bell
>Priority: Major
>
> I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3.0.0,
> I've got the following
> working:
> {code:xml}
> target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import
> contacts into [redacted]
>
> {code}
> However when I decided to move some stuff from an `after_prepare` hook
> script, to use edit-config, it fails with an error `doc.find is not a
> function`
> {code:xml}
> target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import
> contacts into [redacted]
>
>
> UIStatusBarStyleLightContent
>
> {code}
> If I take out the additional `` everything works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13923) CordovaResourceApi.java method OpenForReadResult returns a -1 length
[
https://issues.apache.org/jira/browse/CB-13923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388276#comment-16388276
]
ASF GitHub Bot commented on CB-13923:
-
infil00p commented on issue #433: CB-13923 (android) fix -1 length for
compressed files
URL: https://github.com/apache/cordova-android/pull/433#issuecomment-370883533
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CordovaResourceApi.java method OpenForReadResult returns a -1 length
>
>
> Key: CB-13923
> URL: https://issues.apache.org/jira/browse/CB-13923
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: cordova 8.0.0
> cordova-android 7.0.0
> cordova-plugin-file 6.0.1
>Reporter: Anthony Ward
>Assignee: Joe Bowser
>Priority: Major
>
> Here are details to recreate:
> [https://github.com/AnthonyWard/cordova-file-plugin-bug]
> In *cordova-android* the CordovaResourceApi.java -> OpenForReadResult method
> returns a -1 length in certain circumstances.
> This has a knock on effect to the *cordova-plugin-file* > Filesystem.java >
> readFileAtURL method, causing file corruption as each chunk effectively has
> no end.
> There is a possible fix in the plugin cordova-plugin-file already proposed
> [https://github.com/apache/cordova-plugin-file/pull/217]
> https://issues.apache.org/jira/browse/CB-13245?jql=text%20~%20%22CordovaResourceApi%22
> Or I propose it could be fixed upstream in cordova-android here:
> [https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/CordovaResourceApi.java]
> In the method OpenForReadResult there is one path (in the catch) that leaves
> the length as -1 causing the defect
> try
> {
> assetFd = assetManager.openFd(assetPath);
> inputStream = assetFd.createInputStream(); length = assetFd.getLength();
> }
> catch (FileNotFoundException e)
> {
> // Will occur if the file is compressed.
> inputStream = assetManager.open(assetPath);
> }
> Adding length = inputStream.available(); in the catch fixes the issue for me,
> but I'm not a java developer so can't evaluate if that's a bad idea for
> another reason.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13245) Filereader.readAsText fails on Android with long text files when
[ https://issues.apache.org/jira/browse/CB-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388275#comment-16388275 ] ASF GitHub Bot commented on CB-13245: - infil00p commented on issue #217: CB-13245: (android) Fix bug caused by negative length reported for an asset URL: https://github.com/apache/cordova-plugin-file/pull/217#issuecomment-370883325 This should be fixed in Cordova, not in File. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Filereader.readAsText fails on Android with long text files when > > > Key: CB-13245 > URL: https://issues.apache.org/jira/browse/CB-13245 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-file >Affects Versions: Master > Environment: Android 7.1.1 >Reporter: Daniel Behnen >Priority: Major > > When reader.readAsText is called with an URI pointing to a local asset with a > size greater than READ_CHUNK_SIZE = 256 * 1024, loading produces corrupt > data. > The behaviour is caused by a negative length returned by > CordovaResourceApi.openForRead() when the URI is a URI_TYPE_ASSET. Given the > negative length, Filesystem.readFileAtURL() returns the whole file instead of > the desired part and FileReader.readSuccessCallback() does not check the > returned buffer size. Hence, the following chunks are attated to the buffer > regardless of whether the file was already completely read. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13564) Multiple edit-config items for Info.plist causing error
[
https://issues.apache.org/jira/browse/CB-13564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388264#comment-16388264
]
Jacob Weber commented on CB-13564:
--
I think this needs the attention of a Cordova developerthe code is pretty
complex, and I don't want to submit a patch without fully understanding it.
The error consistently happens when you try to modify Info.plist in both a
plugin and config.xml.
Here's how to reproduce it. First create a plugin that does an edit-config on
Info.plist:
{code:java}
# /sample-plugin/plugin.xml
http://cordova.apache.org/ns/plugins/1.0;
id="sample-plugin"
version="1.0.0">
Sample
foo
{code}
{code:java}
# /sample-plugin/package.json
{
"name": "sample-plugin",
"version": "1.0.0",
"description": "",
"main": "index.js",
"scripts": {
"test": "echo \"Error: no test specified\" && exit 1"
},
"author": "",
"license": "ISC"
}{code}
Then try the following:
{code:java}
$ node --version
v8.9.4
$ cordova --version
8.0.0
$ cordova create CordovaTest com.sample.cordovatest CordovaTest
$ cd CordovaTest
$ cordova platform add ios@4.5.4
$ cordova plugin add /sample-plugin/
$ rm -rf platforms/ node_modules/ plugins/ package-lock.json{code}
Then edit {{config.xml}} and add another edit-config for Info.plist:
{code:java}
bar
{code}
Then run:
{code:java}
$ cordova prepare --verbose{code}
The output will end in:
{code:java}
(node:43598) UnhandledPromiseRejectionWarning: Unhandled promise rejection
(rejection id: 1): TypeError: doc.find is not a function
(node:43598) [DEP0018] DeprecationWarning: Unhandled promise rejections are
deprecated. In the future, promise rejections that are not handled will
terminate the Node.js process with a non-zero exit code.{code}
> Multiple edit-config items for Info.plist causing error
> ---
>
> Key: CB-13564
> URL: https://issues.apache.org/jira/browse/CB-13564
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-cli
>Reporter: Tom Bell
>Priority: Major
>
> I am on 7.1.0 of `cordova-cli`, there was no `7.1.0` in the "Affects
> Versions" dropdown.
> I've updated `cordova-ios` to 4.5.3 and `cordova-plugin-contacts` to 3..0.0,
> I've got the following
> working:
> {code:xml}
> target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import
> contacts into [redacted]
>
> {code}
> However when I decided to move some stuff from an `after_prepare` hook
> script, to use edit-config, it fails with an error `doc.find is not a
> function`
> {code:xml}
> target="NSContactsUsageDescription">
> We require permission to access your contacts so you can import
> contacts into [redacted]
>
>
> UIStatusBarStyleLightContent
>
> {code}
> If I take out the additional `` everything works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
[ https://issues.apache.org/jira/browse/CB-13955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16388204#comment-16388204 ] Gandhirajan commented on CB-13955: -- Will have a check on this > No mention of 'Make' command running in 'developing-the-website' section > > > Key: CB-13955 > URL: https://issues.apache.org/jira/browse/CB-13955 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Gandhirajan >Priority: Major > > Only 'Make' installation step is mentioned in the doc. But there no mention > of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13955) No mention of 'Make' command running in 'developing-the-website' section
Gandhirajan created CB-13955: Summary: No mention of 'Make' command running in 'developing-the-website' section Key: CB-13955 URL: https://issues.apache.org/jira/browse/CB-13955 Project: Apache Cordova Issue Type: Bug Components: cordova-docs Reporter: Gandhirajan Only 'Make' installation step is mentioned in the doc. But there no mention of 'Make' command running in 'developing-the-website' section of cordova docs. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13944) Why isn't the "platforms" documentation not the README of the platform repositories and pulled into the docs?
[ https://issues.apache.org/jira/browse/CB-13944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387880#comment-16387880 ] Jan Piotrowski (Sujan) commented on CB-13944: - The big advantage of having it with the actual code would of course be to increase the probability that with releases the docs would also be updated, not after the fact as it is mostly right now (or not updated at all). > Why isn't the "platforms" documentation not the README of the platform > repositories and pulled into the docs? > - > > Key: CB-13944 > URL: https://issues.apache.org/jira/browse/CB-13944 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > The version of the platform that is installed is hard coded in the CLI. > Wouldn't it make sense to move the "platform" documentation to the README of > the platform itself and only pull in this file (like the docs already do with > plugins) so there is some connection to the actual version? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12074) Cookies are ignored on first application execution
[ https://issues.apache.org/jira/browse/CB-12074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387867#comment-16387867 ] Bren Gunning commented on CB-12074: --- I too have had to remove WKWebView from the app I am working on, due to this issue. I really don't want to have to do hacks to work around this. > Cookies are ignored on first application execution > -- > > Key: CB-12074 > URL: https://issues.apache.org/jira/browse/CB-12074 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-wkwebview-engine > Environment: Cordova 5.4.0, iOS 9.3.5 >Reporter: Maxim >Assignee: Shazron Abdullah >Priority: Major > Labels: wkwebview-known-issues > > Our application authenticates to the server. The server sets a 'JSESSIONID' > cookie. The cookie is used by the server for session management. > The issue is WKWebView does not send this cookie back to the server on > subsequent requests. However, this only happens on first execution of the > application, after its installation. Once the application closed and > re-opened, the cookies are properly sent and authentication completes > successfully. > The problematic behavior is consistent, and was observed on several devices. > On the other hand, there are no such issues with UIWebView. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13940) / vs. /index.html
[ https://issues.apache.org/jira/browse/CB-13940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387856#comment-16387856 ] Jan Piotrowski (Sujan) commented on CB-13940: - Probably just fixing which URLs the navigation (and other generated links) links to. Might be worth to also look into the `canonical` meta tag for these pages and maybe even implement automatic redirects to the correct page - but that would have to be evaluated. > / vs. /index.html > - > > Key: CB-13940 > URL: https://issues.apache.org/jira/browse/CB-13940 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Major > > Right now the docs are a mishmash of linking to `folder/` and > `folder/index.html`. > http://cordova.apache.org/docs/en/dev/guide/appdev/privacy/index.html > http://cordova.apache.org/docs/en/dev/guide/appdev/privacy/ > http://cordova.apache.org/docs/en/dev/reference/cordova-plugin-dialogs/index.html > http://cordova.apache.org/docs/en/dev/reference/cordova-plugin-dialogs/ > Both are of course totally valid - we just have to standardize on one and use > it everywhere, if possible also create a redirect rule for all "broken" links > to use the one standard we define. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7487) Writing a file doesn't show up on android MTP
[ https://issues.apache.org/jira/browse/CB-7487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387629#comment-16387629 ] ASF GitHub Bot commented on CB-7487: tvanesse commented on issue #81: CB-7487 [Android] Broadcast file write URL: https://github.com/apache/cordova-plugin-file/pull/81#issuecomment-370742949 @dpeacock Thanks for your support, I successfully tested the patch locally and will open an issue on Jira as you suggest, then a PR on Github. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Writing a file doesn't show up on android MTP > - > > Key: CB-7487 > URL: https://issues.apache.org/jira/browse/CB-7487 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android, cordova-plugin-file >Affects Versions: 3.4.0 > Environment: Nexus 5 and Windows 7 >Reporter: David Peacock >Assignee: Ian Clelland >Priority: Major > > Using the file plug-in to write out a file works, but when you use MTP to > view the file when connected to USB on Windows the file doesn't show up. > The file shows up on the device or through adb. Rebooting the device or > using things to refresh the MTP will have the file appear. This was tested > on multiple Nexus 5 devices on multiple Windows 7 machines. > Cordova should be broadcasting ACTION_MEDIA_SCANNER_SCAN_FILE on the file to > have it appear immediately. > I will be submitting a pull request on the file plug-in for a fix I've tested > and confirmed that resolves this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Comment Edited] (CB-13954) NullPointerException when processing result from camera
[ https://issues.apache.org/jira/browse/CB-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387620#comment-16387620 ] jcesarmobile edited comment on CB-13954 at 3/6/18 10:51 AM: Do the reports provide Android version? or device models? The code you use for calling camera might be also be helpful was (Author: jcesarmobile): Do the reports provide Android version? or device models? > NullPointerException when processing result from camera > --- > > Key: CB-13954 > URL: https://issues.apache.org/jira/browse/CB-13954 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Brad Zacher >Priority: Major > > I have gotten a number of crash reports via the google play console for a > null pointer exception (see below for stack). > Looking at the source code, it seems to be a problem when attempting to > access the extras from the intent - the problem being that the extras return > null (which the code doesn't expect): > [https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516] > > *java.lang.RuntimeException:* > at android.app.ActivityThread.deliverResults (ActivityThread.java:4520) > at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563) > at android.app.ActivityThread.-wrap22 (ActivityThread.java) > at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698) > at android.os.Handler.dispatchMessage (Handler.java:102) > at android.os.Looper.loop (Looper.java:154) > at android.app.ActivityThread.main (ActivityThread.java:6776) > at java.lang.reflect.Method.invoke (Native Method) > at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run > (ZygoteInit.java:1520) > at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410) > *Caused by: java.lang.NullPointerException:* > at org.apache.cordova.camera.CameraLauncher.processResultFromCamera > (CameraLauncher.java:514) > at org.apache.cordova.camera.CameraLauncher.onActivityResult > (CameraLauncher.java:805) > at org.apache.cordova.CordovaInterfaceImpl.onActivityResult > (CordovaInterfaceImpl.java:152) > at org.apache.cordova.CordovaActivity.onActivityResult > (CordovaActivity.java:358) > at android.app.Activity.dispatchActivityResult (Activity.java:7282) > at android.app.ActivityThread.deliverResults (ActivityThread.java:4516) > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13954) NullPointerException when processing result from camera
[ https://issues.apache.org/jira/browse/CB-13954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387620#comment-16387620 ] jcesarmobile commented on CB-13954: --- Do the reports provide Android version? or device models? > NullPointerException when processing result from camera > --- > > Key: CB-13954 > URL: https://issues.apache.org/jira/browse/CB-13954 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera >Reporter: Brad Zacher >Priority: Major > > I have gotten a number of crash reports via the google play console for a > null pointer exception (see below for stack). > Looking at the source code, it seems to be a problem when attempting to > access the extras from the intent - the problem being that the extras return > null (which the code doesn't expect): > [https://github.com/apache/cordova-plugin-camera/blob/e36482c7ba1e5dec07f68a246f3ecde8743d7cd6/src/android/CameraLauncher.java#L516] > > *java.lang.RuntimeException:* > at android.app.ActivityThread.deliverResults (ActivityThread.java:4520) > at android.app.ActivityThread.handleSendResult (ActivityThread.java:4563) > at android.app.ActivityThread.-wrap22 (ActivityThread.java) > at android.app.ActivityThread$H.handleMessage (ActivityThread.java:1698) > at android.os.Handler.dispatchMessage (Handler.java:102) > at android.os.Looper.loop (Looper.java:154) > at android.app.ActivityThread.main (ActivityThread.java:6776) > at java.lang.reflect.Method.invoke (Native Method) > at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run > (ZygoteInit.java:1520) > at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1410) > *Caused by: java.lang.NullPointerException:* > at org.apache.cordova.camera.CameraLauncher.processResultFromCamera > (CameraLauncher.java:514) > at org.apache.cordova.camera.CameraLauncher.onActivityResult > (CameraLauncher.java:805) > at org.apache.cordova.CordovaInterfaceImpl.onActivityResult > (CordovaInterfaceImpl.java:152) > at org.apache.cordova.CordovaActivity.onActivityResult > (CordovaActivity.java:358) > at android.app.Activity.dispatchActivityResult (Activity.java:7282) > at android.app.ActivityThread.deliverResults (ActivityThread.java:4516) > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387533#comment-16387533 ] ASF GitHub Bot commented on CB-13415: - alsorokin commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-370723726 Well I guess we have to wait until he reviews it then. I don't have enough expertise in iOS to merge it anyway :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387503#comment-16387503 ] ASF GitHub Bot commented on CB-13415: - jd0048 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-370716112 @alsorokin Also check above comment from @shazron This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13953) Cordova has a hard dependency on Gradle being on the path and JAVA_HOME being set in advance
[ https://issues.apache.org/jira/browse/CB-13953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387492#comment-16387492 ] armin commented on CB-13953: [~bowserj], you do not need to commit in the wrapper, you can allow the cordova users to do it (optionally) so we are not forced to have gradle available on the path on every machine (including automated environments) and rely on the built-in configuration. This is about 5 lines of code to fix for the ability to drop an unnecessary dependency and allow users to customize wrapper generation, I really do not understand the quick decision to close the ticket. > Cordova has a hard dependency on Gradle being on the path and JAVA_HOME being > set in advance > > > Key: CB-13953 > URL: https://issues.apache.org/jira/browse/CB-13953 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-android >Affects Versions: cordova-android-7.0.0 > Environment: android build >Reporter: armin >Assignee: Joe Bowser >Priority: Minor > Original Estimate: 8h > Remaining Estimate: 8h > > Cordova is tightly coupled with the gradle executable and it is verifying it > being on the path even though the gradle wrapper is available. Also the > JAVA_HOME has to be already available or java be on the path before running > cordova commands even though these can be set during the build. > In general there are several problems with the current gradle bootstrapping > process: > * Cordova checks for gradle being on the path and fails execution if it > isn't there even though the wrapper is already generated so gradle is not > needed at that point. The wrapper files are also on .gitignore for no reason > since committing them is fairly standard practice and they could be bundled > with cordova from the beginning to avoid dependency on gradle in general and > to tie the gradle version to the cordova version. > * In general the checks inside cordova are not sufficient to determine if a > given "requirement" is available (or will be set during the build) or not, it > should be possible to continue the build even if the build-in requirement > checks fail > * The gradle wrapper is generated by Cordova instead of the user as it > should be and as it is the gradle convention -> this means any customization > process is extremely difficult and we have no control. It is understandable > to tie the gradle version to a cordova version but this version check should > be done during execution and not before so the users can manage their own > wrapper > * Cordova is using a separate gradle file for generating the wrapper and not > the actual build.gradle file -> wrapper.gradle is being used for generation > which means any configuration from build.gradle is not respected, such as > wrapper version or wrapper customization (for example we also generate the > JAVA_HOME variable into the wrapper so we would not need java or gradle on > the path at all after the initial install, as we only have a local > installations) -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387475#comment-16387475 ] ASF GitHub Bot commented on CB-13415: - jd0048 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-370709194 @alsorokin i had test locally its showing build success for me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
