[jira] [Created] (CB-13993) Show caption text over the camera

2018-03-19 Thread ijaj mulani (JIRA)
ijaj mulani created CB-13993:


 Summary: Show caption text over the camera
 Key: CB-13993
 URL: https://issues.apache.org/jira/browse/CB-13993
 Project: Apache Cordova
  Issue Type: New Feature
  Components: cordova-android
Affects Versions: cordova-android-7.0.0
Reporter: ijaj mulani
Assignee: Joe Bowser
 Attachments: text over camera.png

h1. Allow to show caption text over the camera.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13992) Remove dependency-ls or provide option to skip npm checks

2018-03-19 Thread Zak (JIRA)
Zak created CB-13992:


 Summary: Remove dependency-ls or provide option to skip npm checks
 Key: CB-13992
 URL: https://issues.apache.org/jira/browse/CB-13992
 Project: Apache Cordova
  Issue Type: Wish
  Components: cordova-cli, cordova-fetch
Affects Versions: 8.0.0
Reporter: Zak


I noticed that our CI builds of cordova projects are very slow when adding the 
platforms - the stage where plugins are added taks a few minutes for each 
build. I did some digging around and profiling and eventually found that the 
slowest part is where `cordova-fetch` uses the `dependency-ls` module to list 
all installed dependencies of the project before and after installing each 
plugin.

This dependency runs `npm list --depth=0` under the hood which is slow (~5 
seconds per run on a relatively small Ionic project). You can test this by 
running this small script:

{{var depls = require('dependency-ls')}}
{{return depls(process.cwd())}}
{{.then(function(result) {}}
{{  console.log(result)}}
{{})}}

Note also that the dependency runs twice for each plugin in the project adding 
10 seconds per plugin. This means it can take a few minutes just to add a 
platform to the project - although this is much slower in CI/Docker build 
environments.

However, this step seems pretty redundant since the plugins are likely already 
installed via npm since they are now saved in the package.json file. I made a 
fork of cordova-fetch which removes this step completely and just uses the 
existing plugins in `node_modules` and the time to add platform drops down to 
~7 seconds (down from minutes) with no change to the actual result since the 
plugins are already there.

https://github.com/NextFaze/cordova-fetch/tree/fix/speed

Since plugins now install via npm and save to package.json by default it would 
be nice to at least provide the option to skip this npm step for plugins for 
cases where they already exist in node modules, if it can't be removed 
completely.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13986) Windows 10 builds failing with CertUtil file not found error

2018-03-19 Thread Adrian (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrian updated CB-13986:

Summary: Windows 10 builds failing with CertUtil file not found error  
(was: Windows 10 buils failing with CertUtil file not found error)

> Windows 10 builds failing with CertUtil file not found error
> 
>
> Key: CB-13986
> URL: https://issues.apache.org/jira/browse/CB-13986
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Affects Versions: 4.4.3
> Environment: PhoneGap Build using PGB CLI 6.5.0 (Cordova 4.4.3) or 
> 7.1.0 (Cordova 5.0)
> Windows 10 build only (IOS and Android are fine)
> PGB App ID 304700.
> Windows 10 app uses signing key.
> Current app version 2.6.70 (though happens with all recent versions of the 
> app)
>  
>Reporter: Adrian
>Assignee: Jesse MacFadyen
>Priority: Critical
>  Labels: Windows, phonegap-build
>
> In PhoneGap Build (PGB) Windows 10 build (with key) fails with error
> CertUtil: -importPFX command FAILED: 0x80070002 (WIN32: 2 
> ERROR_FILE_NOT_FOUND)
> Sometimes this can be resolved by requesting the same build repeatedly, 
> whereupon the build will work after 5-10 attempts.  Sometimes (as is the case 
> now) no amount of rebuild attempts fixes the error.
> Because this error can sometimes go away after repeated rebuild attempts 
> (using the same uploaded ZIP package), this clearly indicates it is a problem 
> at the PGB end, not with the ZIP package contents.
> This error has been reported on the PhoneGap Build community forums for a 
> number of months now, but no fix done.
> This is a +critical+ issue for us as we need to get a Windows 10 build for 
> our app and currently in effect the PGB Windows Build service is, for all 
> intents and purposes, DOWN.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

2018-03-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405433#comment-16405433
 ] 

ASF GitHub Bot commented on CB-13307:
-

infil00p commented on issue #286: CB-13307: (Android) Fixed issue when unable 
to load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-374373421
 
 
   I'm cool with it, but I can't even test if this fixes it because I don't 
even have the ability to pull from Google Photos when I test it.  Did that 
break on Android P?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

2018-03-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405430#comment-16405430
 ] 

Joe Bowser commented on CB-13307:
-

Can someone with a working Pixel that's not running Android P test this? 

> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13307) Accessing Google Photos on Pixel from cordova-plugin-camera

2018-03-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405432#comment-16405432
 ] 

ASF GitHub Bot commented on CB-13307:
-

infil00p commented on issue #286: CB-13307: (Android) Fixed issue when unable 
to load image with mime t…
URL: 
https://github.com/apache/cordova-plugin-camera/pull/286#issuecomment-374373421
 
 
   I'm cool with it, but I can't even test if this fixes it because I don't 
even have the ability to pull from Google Photos when I test it. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Accessing Google Photos on Pixel from cordova-plugin-camera
> ---
>
> Key: CB-13307
> URL: https://issues.apache.org/jira/browse/CB-13307
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: David Briglio
>Priority: Major
>
> Currently when trying to access some photos from Google Photos, it fails to 
> load. Android 8.0 on Google Pixel, cordova version 6.5.0, 
> cordova-plugin-camera version 2.4.1.
> Causes:
> 1) Only mimetypes "image/jpeg" and "image/png" are accepted, all other types 
> are considered an invalid image. The mimetype of the image I am loading gets 
> set to "image/*".
> 2) In FileHelper.java: when hitting the isGooglePhotosUri method, the uri 
> authority is compared against "com.google.android.apps.photos.content", where 
> the actual is "com.google.android.apps.photos.contentprovider". This causes 
> the logic to dismiss the image as not from Google Photos.
> After applying fixes for these two areas, I am able to successfully load all 
> of my images.
> Merge request [here|https://github.com/apache/cordova-plugin-camera/pull/286].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed

2018-03-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405416#comment-16405416
 ] 

ASF GitHub Bot commented on CB-13830:
-

codecov-io commented on issue #434: CB-13830: Add handlers for plugins that use 
non-Java source files
URL: https://github.com/apache/cordova-android/pull/434#issuecomment-374367300
 
 
   # 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/434?src=pr=h1) 
Report
   > Merging 
[#434](https://codecov.io/gh/apache/cordova-android/pull/434?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/cordova-android/commit/6abd6d6b477966d6a40420800376d28bacd1d940?src=pr=desc)
 will **increase** coverage by `0.07%`.
   > The diff coverage is `72.72%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/cordova-android/pull/434/graphs/tree.svg?width=650=150=pr=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/434?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master #434  +/-   ##
   ==
   + Coverage   43.95%   44.02%   +0.07% 
   ==
 Files  17   17  
 Lines1711 1715   +4 
 Branches  318  319   +1 
   ==
   + Hits  752  755   +3 
   - Misses959  960   +1
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/cordova-android/pull/434?src=pr=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[bin/templates/cordova/Api.js](https://codecov.io/gh/apache/cordova-android/pull/434/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL0FwaS5qcw==)
 | `41.88% <ø> (ø)` | :arrow_up: |
   | 
[bin/templates/cordova/lib/pluginHandlers.js](https://codecov.io/gh/apache/cordova-android/pull/434/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wbHVnaW5IYW5kbGVycy5qcw==)
 | `86.2% <72.72%> (-0.27%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/cordova-android/pull/434?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/cordova-android/pull/434?src=pr=footer).
 Last update 
[6abd6d6...5af6b01](https://codecov.io/gh/apache/cordova-android/pull/434?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>  
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Major
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
>  Path: platforms/android
>  Package: io.cordova.hellocordova
>  Name: HelloCordova
>  Activity: MainActivity
>  Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than 
> 4.0. If you have a previous platform version, you do *not* need this plugin 
> since the whitelist will be built in.
>  
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> 

[jira] [Assigned] (CB-13991) www files are required to be readonly

2018-03-19 Thread Jesse MacFadyen (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jesse MacFadyen reassigned CB-13991:


Assignee: Jesse MacFadyen

> www files are required to be readonly
> -
>
> Key: CB-13991
> URL: https://issues.apache.org/jira/browse/CB-13991
> Project: Apache Cordova
>  Issue Type: Task
>Reporter: Jesse MacFadyen
>Assignee: Jesse MacFadyen
>Priority: Major
>
> See CB-5421 for original context.
> Currently if a developer makes their www/index.html file readonly, the 
> resulting /platforms/windows/www/index.html file is also readonly, and 
> windows build tooling requires that it NOT be read-only for ensuring utf-8 
> and BOM.
>  
> This can result in an error like the following:
> {code:java}
> D:\path>phonegap platforms add windows@6
> Using cordova-fetch for cordova-windows@6
> Adding windows project...
> Creating Cordova Windows Project:
> Path: platforms\windows
> Namespace: com.example.mobile
> Name: Mobile app
> Windows project created with cordova-windows@6.0.0
> (node:6248) UnhandledPromiseRejectionWarning: Error: EPERM: operation not 
> permitted, open 'D:\path\platforms\windows\www\index.html'
> at Object.fs.openSync (fs.js:667:18)
> at Object.fs.writeFileSync (fs.js:1326:33)
> at addBOMToFile (D:\path\platforms\windows\cordova\lib\prepare.js:686:12)
> at Array.forEach ()
> at addBOMSignature (D:\path\platforms\windows\cordova\lib\prepare.js:665:1
> 0)
> at D:\path\platforms\windows\cordova\lib\prepare.js:625:13
> at _fulfilled (D:\path\platforms\windows\cordova\node_modules\q\q.js:854:5
> 4)
> at self.promiseDispatch.done (D:\path\platforms\windows\cordova\node_modul
> es\q\q.js:883:30)
> at Promise.promise.promiseDispatch (D:\path\platforms\windows\cordova\node
> _modules\q\q.js:816:13)
> at D:\path\platforms\windows\cordova\node_modules\q\q.js:624:44
> (node:6248) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either b
> y throwing inside of an async function without a catch block, or by rejecting 
> a promise which was not han
> dled with .catch(). (rejection id: 1)
> (node:6248) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, pro
> mise rejections that are not handled will terminate the Node.js process with 
> a non-zero exit code.{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed

2018-03-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405380#comment-16405380
 ] 

Joe Bowser commented on CB-13830:
-

I'm going to lower the priority, since we're really not supposed to use 
source-file for XML, but Camera is special. :/

> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>  
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Major
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
>  Path: platforms/android
>  Package: io.cordova.hellocordova
>  Name: HelloCordova
>  Activity: MainActivity
>  Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than 
> 4.0. If you have a previous platform version, you do *not* need this plugin 
> since the whitelist will be built in.
>  
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
>  already exists!
>  at copyNewFile 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
>  at install 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
>  at ActionStack.process 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>  at PluginManager.doOperation 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
>  at PluginManager.addPlugin 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
>  at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
>  at _fulfilled 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
>  at self.promiseDispatch.done 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
>  at Promise.promise.promiseDispatch 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
>  at 
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
>  already exists!
>  at copyNewFile 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
>  at install 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
>  at ActionStack.process 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>  at PluginManager.doOperation 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
>  at PluginManager.addPlugin 
> 

[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed

2018-03-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405378#comment-16405378
 ] 

ASF GitHub Bot commented on CB-13830:
-

infil00p opened a new pull request #434: CB-13830: Add handlers for plugins 
that use non-Java source files
URL: https://github.com/apache/cordova-android/pull/434
 
 
   
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   This PR adds code that handles the uninstallation of plugins that use XML 
files for provider paths.  This further segments the re-mapper code, that we 
eventually will delete.
   
   I also fixed some tabs, because my eslint was puking.
   
   ### What testing has been done on this change?
   - Ran through unit tests
   - Tested on project.
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [x] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>  
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Critical
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
>  Path: platforms/android
>  Package: io.cordova.hellocordova
>  Name: HelloCordova
>  Activity: MainActivity
>  Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than 
> 4.0. If you have a previous platform version, you do *not* need this plugin 
> since the whitelist will be built in.
>  
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
>  already exists!
>  at copyNewFile 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
>  at install 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
>  at ActionStack.process 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>  at PluginManager.doOperation 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
>  at PluginManager.addPlugin 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
>  at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
>  at _fulfilled 
> 

[jira] [Updated] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed

2018-03-19 Thread Joe Bowser (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-13830:

Priority: Major  (was: Critical)

> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>  
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Major
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
>  Path: platforms/android
>  Package: io.cordova.hellocordova
>  Name: HelloCordova
>  Activity: MainActivity
>  Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than 
> 4.0. If you have a previous platform version, you do *not* need this plugin 
> since the whitelist will be built in.
>  
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
>  already exists!
>  at copyNewFile 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
>  at install 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
>  at ActionStack.process 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>  at PluginManager.doOperation 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
>  at PluginManager.addPlugin 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
>  at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
>  at _fulfilled 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
>  at self.promiseDispatch.done 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
>  at Promise.promise.promiseDispatch 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
>  at 
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
>  already exists!
>  at copyNewFile 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
>  at install 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
>  at ActionStack.process 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>  at PluginManager.doOperation 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
>  at PluginManager.addPlugin 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
>  at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
>  at _fulfilled 
> 

[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed

2018-03-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405311#comment-16405311
 ] 

Joe Bowser commented on CB-13830:
-

This probably deserves a point release at the very least.

> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>  
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Critical
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
>  Path: platforms/android
>  Package: io.cordova.hellocordova
>  Name: HelloCordova
>  Activity: MainActivity
>  Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the 
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than 
> 4.0. If you have a previous platform version, you do *not* need this plugin 
> since the whitelist will be built in.
>  
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
>  already exists!
>  at copyNewFile 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
>  at install 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
>  at ActionStack.process 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>  at PluginManager.doOperation 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
>  at PluginManager.addPlugin 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
>  at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
>  at _fulfilled 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
>  at self.promiseDispatch.done 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
>  at Promise.promise.promiseDispatch 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
>  at 
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
>  already exists!
>  at copyNewFile 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
>  at install 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
>  at ActionStack.process 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
>  at PluginManager.doOperation 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
>  at PluginManager.addPlugin 
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
>  at 

[jira] [Created] (CB-13991) www files are required to be readonly

2018-03-19 Thread Jesse MacFadyen (JIRA)
Jesse MacFadyen created CB-13991:


 Summary: www files are required to be readonly
 Key: CB-13991
 URL: https://issues.apache.org/jira/browse/CB-13991
 Project: Apache Cordova
  Issue Type: Task
Reporter: Jesse MacFadyen


See CB-5421 for original context.

Currently if a developer makes their www/index.html file readonly, the 
resulting /platforms/windows/www/index.html file is also readonly, and windows 
build tooling requires that it NOT be read-only for ensuring utf-8 and BOM.

 

This can result in an error like the following:
{code:java}
D:\path>phonegap platforms add windows@6
Using cordova-fetch for cordova-windows@6


Adding windows project...


Creating Cordova Windows Project:

Path: platforms\windows
Namespace: com.example.mobile
Name: Mobile app

Windows project created with cordova-windows@6.0.0

(node:6248) UnhandledPromiseRejectionWarning: Error: EPERM: operation not 
permitted, open 'D:\path\platforms\windows\www\index.html'
at Object.fs.openSync (fs.js:667:18)
at Object.fs.writeFileSync (fs.js:1326:33)
at addBOMToFile (D:\path\platforms\windows\cordova\lib\prepare.js:686:12)
at Array.forEach ()
at addBOMSignature (D:\path\platforms\windows\cordova\lib\prepare.js:665:1
0)
at D:\path\platforms\windows\cordova\lib\prepare.js:625:13
at _fulfilled (D:\path\platforms\windows\cordova\node_modules\q\q.js:854:5
4)
at self.promiseDispatch.done (D:\path\platforms\windows\cordova\node_modul
es\q\q.js:883:30)
at Promise.promise.promiseDispatch (D:\path\platforms\windows\cordova\node
_modules\q\q.js:816:13)
at D:\path\platforms\windows\cordova\node_modules\q\q.js:624:44

(node:6248) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This 
error originated either b
y throwing inside of an async function without a catch block, or by rejecting a 
promise which was not han
dled with .catch(). (rejection id: 1)
(node:6248) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
deprecated. In the future, pro
mise rejections that are not handled will terminate the Node.js process with a 
non-zero exit code.{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13990) InAppBrowser should use separate OverrideUserAgent from CDVViewController

2018-03-19 Thread Jacob G (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob G updated CB-13990:
-
Summary: InAppBrowser should use separate OverrideUserAgent from 
CDVViewController  (was: use separate OverrideUserAgent from CDVViewController)

> InAppBrowser should use separate OverrideUserAgent from CDVViewController
> -
>
> Key: CB-13990
> URL: https://issues.apache.org/jira/browse/CB-13990
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Jacob G
>Priority: Major
>
> Currently, there is an OverrideUserAgent setting that will affect both the 
> core webview (i.e., that runs the main web app) as well as the inappbrowser 
> plugin. It would be great to be able to separate into two setting, i.e., have 
> an InAppBrowserOverrideUserAgent. That's because I'd like my own app to know 
> the true useragent, while sending a different useragent to other web sites.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13990) use separate OverrideUserAgent from CDVViewController

2018-03-19 Thread Jacob G (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob G updated CB-13990:
-
Summary: use separate OverrideUserAgent from CDVViewController  (was: use 
separate OverrideUserAgent from CDVViewController.h)

> use separate OverrideUserAgent from CDVViewController
> -
>
> Key: CB-13990
> URL: https://issues.apache.org/jira/browse/CB-13990
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Affects Versions: cordova-ios 4.5.0
>Reporter: Jacob G
>Priority: Major
>
> Currently, there is an OverrideUserAgent setting that will affect both the 
> core webview (i.e., that runs the main web app) as well as the inappbrowser 
> plugin. It would be great to be able to separate into two setting, i.e., have 
> an InAppBrowserOverrideUserAgent. That's because I'd like my own app to know 
> the true useragent, while sending a different useragent to other web sites.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13990) use separate OverrideUserAgent from CDVViewController.h

2018-03-19 Thread Jacob G (JIRA)
Jacob G created CB-13990:


 Summary: use separate OverrideUserAgent from CDVViewController.h
 Key: CB-13990
 URL: https://issues.apache.org/jira/browse/CB-13990
 Project: Apache Cordova
  Issue Type: Improvement
  Components: cordova-plugin-inappbrowser
Affects Versions: cordova-ios 4.5.0
Reporter: Jacob G


Currently, there is an OverrideUserAgent setting that will affect both the core 
webview (i.e., that runs the main web app) as well as the inappbrowser plugin. 
It would be great to be able to separate into two setting, i.e., have an 
InAppBrowserOverrideUserAgent. That's because I'd like my own app to know the 
true useragent, while sending a different useragent to other web sites.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13972) Requirements check failed for JDK 1.8 or greater

2018-03-19 Thread Joe Bowser (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405183#comment-16405183
 ] 

Joe Bowser commented on CB-13972:
-

[~quarkbuddha] There's no platform on it.  We really need to make it crystal 
clear that Java 9 doesn't work.

> Requirements check failed for JDK 1.8 or greater
> 
>
> Key: CB-13972
> URL: https://issues.apache.org/jira/browse/CB-13972
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: cordova-android-7.0.0
> Environment: Windows 10 64 (10.0.16229.248)
>Reporter: John M. Wargo
>Priority: Major
>
> I've got a problem with my Java config, but the CLI reports the error then 
> reports that it's deployed the app (when it hasn't).
> {{JAVA_HOME=D:\Program Files\Java\jdk-9.0.1}}
> {{(node:10316) UnhandledPromiseRejectionWarning: CordovaError: Requirements 
> check failed for JDK 1.8 or greater}}
> {{ at 
> D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\lib\check_reqs.js:370:19}}
> {{ at _fulfilled 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:854:54)}}
> {{ at self.promiseDispatch.done 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:883:30)}}
> {{ at Promise.promise.promiseDispatch 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:816:13)}}
> {{ at 
> D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:624:44}}
> {{ at runSingle 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:137:13)}}
> {{ at flush 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:125:13)}}
> {{ at _combinedTickCallback (internal/process/next_tick.js:131:7)}}
> {{ at process._tickCallback (internal/process/next_tick.js:180:9)}}
> {{(node:10316) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)}}
> {{(node:10316) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.}}
> {{[18:26:17] lint finished in 2.66 s}}{{[OK] Your app has been deployed.}}
> {{ Did you know you can live-reload changes from your app with --livereload?}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13972) Requirements check failed for JDK 1.8 or greater

2018-03-19 Thread Joe Bowser (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Joe Bowser updated CB-13972:

Priority: Major  (was: Blocker)

This is still a bug, but it really shouldn't block a release.

> Requirements check failed for JDK 1.8 or greater
> 
>
> Key: CB-13972
> URL: https://issues.apache.org/jira/browse/CB-13972
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Affects Versions: cordova-android-7.0.0
> Environment: Windows 10 64 (10.0.16229.248)
>Reporter: John M. Wargo
>Priority: Major
>
> I've got a problem with my Java config, but the CLI reports the error then 
> reports that it's deployed the app (when it hasn't).
> {{JAVA_HOME=D:\Program Files\Java\jdk-9.0.1}}
> {{(node:10316) UnhandledPromiseRejectionWarning: CordovaError: Requirements 
> check failed for JDK 1.8 or greater}}
> {{ at 
> D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\lib\check_reqs.js:370:19}}
> {{ at _fulfilled 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:854:54)}}
> {{ at self.promiseDispatch.done 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:883:30)}}
> {{ at Promise.promise.promiseDispatch 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:816:13)}}
> {{ at 
> D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:624:44}}
> {{ at runSingle 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:137:13)}}
> {{ at flush 
> (D:\dev\hardware\particle\particle-garage-controller-ionic\platforms\android\cordova\node_modules\q\q.js:125:13)}}
> {{ at _combinedTickCallback (internal/process/next_tick.js:131:7)}}
> {{ at process._tickCallback (internal/process/next_tick.js:180:9)}}
> {{(node:10316) UnhandledPromiseRejectionWarning: Unhandled promise rejection. 
> This error originated either by throwing inside of an async function without 
> a catch block, or by rejecting a promise which was not handled with .catch(). 
> (rejection id: 1)}}
> {{(node:10316) [DEP0018] DeprecationWarning: Unhandled promise rejections are 
> deprecated. In the future, promise rejections that are not handled will 
> terminate the Node.js process with a non-zero exit code.}}
> {{[18:26:17] lint finished in 2.66 s}}{{[OK] Your app has been deployed.}}
> {{ Did you know you can live-reload changes from your app with --livereload?}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13989) Ios 11.2 cancel library fail with error "has no access to assets" instead of

2018-03-19 Thread Geoffrey MUSELLI (JIRA)
Geoffrey MUSELLI created CB-13989:
-

 Summary: Ios 11.2 cancel library fail with error "has no access to 
assets" instead of 
 Key: CB-13989
 URL: https://issues.apache.org/jira/browse/CB-13989
 Project: Apache Cordova
  Issue Type: Bug
Reporter: Geoffrey MUSELLI


IMPORTANT: 4.0.2 is not available in choice. Affected version is not 4.0.1 but 
4.0.2

*Expected Behaviour*
If user cancel library, error returns should be something like: "user cancelled"

 

*Actual Behaviour*
If user cancel library, error returns is: "has no access to assets" instead of 
"user cancelled"

*Reproduce Scenario (including but not limited to)*

*Steps to Reproduce*
Create a simple app with this plugin (ie: ionic app)
Launch it on ios 11.2 (reproduced on 6s, 6s+, 7 and X)
Launch plugin
Give permission
Close app
Go to settings
Change app permission for camera
Reopen app
Launch plugin

 

*Platform and Version (eg. Android 5.0 or iOS 9.2.1)*
ios 11.2
Plugin 4.0.2

 

*(Android) What device vendor (e.g. Samsung, HTC, Sony...)*
N/A

 

*Cordova CLI version and cordova platform version*

@ionic/cli-utils : 1.19.1
ionic (Ionic CLI) : 3.19.1

global packages:

cordova (Cordova CLI) : 7.0.1

local packages:

@ionic/app-scripts : 3.1.2
Cordova Platforms : ios 4.5.1
Ionic Framework : ionic-angular 3.9.2

System:

ios-deploy : 1.9.2 
ios-sim : 6.0.0 
Node : v6.11.2
npm : 5.3.0 
OS : macOS High Sierra
Xcode : Xcode 9.2 Build version 9C40b

 

*Plugin version*

4.0.2

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-13988) Ios 11.2 request again permission is crashing

2018-03-19 Thread Geoffrey MUSELLI (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Geoffrey MUSELLI updated CB-13988:
--
Description: 
IMPORTANT: 4.0.2 is not available in choice. Affected version is not 4.0.1 but 
4.0.2

*Expected Behaviour*
 If user request to use this feature again. Permission should be requested 
again (and should work)

 

*Actual Behaviour*
 When permission request is prompted (the second time) if user click on 
"Accept" plugin crash with "has no access to camera"

*Reproduce Scenario (including but not limited to)*

*Steps to Reproduce*
 Create a simple app with this plugin (ie: ionic app)
 Launch it on ios 11.2 (reproduced on 6s, 6s+, 7 and X)
 Launch plugin
 Give permission
 Close app
 Go to settings
 Change app permission for camera
 Reopen app
 Launch plugin

 

*Platform and Version (eg. Android 5.0 or iOS 9.2.1)*
 ios 11.2
 Plugin 4.0.2

 

*(Android) What device vendor (e.g. Samsung, HTC, Sony...)*
 N/A

 

*Cordova CLI version and cordova platform version*

@ionic/cli-utils : 1.19.1
 ionic (Ionic CLI) : 3.19.1

global packages:

cordova (Cordova CLI) : 7.0.1

local packages:

@ionic/app-scripts : 3.1.2
 Cordova Platforms : ios 4.5.1
 Ionic Framework : ionic-angular 3.9.2

System:

ios-deploy : 1.9.2 
 ios-sim : 6.0.0 
 Node : v6.11.2
 npm : 5.3.0 
 OS : macOS High Sierra
 Xcode : Xcode 9.2 Build version 9C40b

 

*Plugin version*

4.0.2

 

  was:
IMPORTANT: 4.0.2 is not available in choice. Affected version is not 4.0.1 but 
4.0.2

 

### Expected Behaviour
If user request to use this feature again. Permission should be requested again 
(and should work)

### Actual Behaviour
When permission request is prompted (the second time) if user click on "Accept" 
plugin crash with "has no access to camera"

### Reproduce Scenario (including but not limited to)

 Steps to Reproduce
Create a simple app with this plugin (ie: ionic app)
Launch it on ios 11.2 (reproduced on 6s, 6s+, 7 and X)
Launch plugin
Give permission
Close app
Go to settings
Change app permission for camera
Reopen app
Launch plugin

 Platform and Version (eg. Android 5.0 or iOS 9.2.1)
ios 11.2
Plugin 4.0.2

 (Android) What device vendor (e.g. Samsung, HTC, Sony...)
N/A

 Cordova CLI version and cordova platform version

@ionic/cli-utils : 1.19.1
 ionic (Ionic CLI) : 3.19.1

global packages:

cordova (Cordova CLI) : 7.0.1

local packages:

@ionic/app-scripts : 3.1.2
 Cordova Platforms : ios 4.5.1
 Ionic Framework : ionic-angular 3.9.2

System:

ios-deploy : 1.9.2 
 ios-sim : 6.0.0 
 Node : v6.11.2
 npm : 5.3.0 
 OS : macOS High Sierra
 Xcode : Xcode 9.2 Build version 9C40b


 Plugin version

4.0.2

 


> Ios 11.2 request again permission is crashing
> -
>
> Key: CB-13988
> URL: https://issues.apache.org/jira/browse/CB-13988
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Affects Versions: 4.0.1
>Reporter: Geoffrey MUSELLI
>Priority: Major
>
> IMPORTANT: 4.0.2 is not available in choice. Affected version is not 4.0.1 
> but 4.0.2
> *Expected Behaviour*
>  If user request to use this feature again. Permission should be requested 
> again (and should work)
>  
> *Actual Behaviour*
>  When permission request is prompted (the second time) if user click on 
> "Accept" plugin crash with "has no access to camera"
> *Reproduce Scenario (including but not limited to)*
> *Steps to Reproduce*
>  Create a simple app with this plugin (ie: ionic app)
>  Launch it on ios 11.2 (reproduced on 6s, 6s+, 7 and X)
>  Launch plugin
>  Give permission
>  Close app
>  Go to settings
>  Change app permission for camera
>  Reopen app
>  Launch plugin
>  
> *Platform and Version (eg. Android 5.0 or iOS 9.2.1)*
>  ios 11.2
>  Plugin 4.0.2
>  
> *(Android) What device vendor (e.g. Samsung, HTC, Sony...)*
>  N/A
>  
> *Cordova CLI version and cordova platform version*
> @ionic/cli-utils : 1.19.1
>  ionic (Ionic CLI) : 3.19.1
> global packages:
> cordova (Cordova CLI) : 7.0.1
> local packages:
> @ionic/app-scripts : 3.1.2
>  Cordova Platforms : ios 4.5.1
>  Ionic Framework : ionic-angular 3.9.2
> System:
> ios-deploy : 1.9.2 
>  ios-sim : 6.0.0 
>  Node : v6.11.2
>  npm : 5.3.0 
>  OS : macOS High Sierra
>  Xcode : Xcode 9.2 Build version 9C40b
>  
> *Plugin version*
> 4.0.2
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-13988) Ios 11.2 request again permission is crashing

2018-03-19 Thread Geoffrey MUSELLI (JIRA)
Geoffrey MUSELLI created CB-13988:
-

 Summary: Ios 11.2 request again permission is crashing
 Key: CB-13988
 URL: https://issues.apache.org/jira/browse/CB-13988
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-camera
Affects Versions: 4.0.1
Reporter: Geoffrey MUSELLI


IMPORTANT: 4.0.2 is not available in choice. Affected version is not 4.0.1 but 
4.0.2

 

### Expected Behaviour
If user request to use this feature again. Permission should be requested again 
(and should work)

### Actual Behaviour
When permission request is prompted (the second time) if user click on "Accept" 
plugin crash with "has no access to camera"

### Reproduce Scenario (including but not limited to)

 Steps to Reproduce
Create a simple app with this plugin (ie: ionic app)
Launch it on ios 11.2 (reproduced on 6s, 6s+, 7 and X)
Launch plugin
Give permission
Close app
Go to settings
Change app permission for camera
Reopen app
Launch plugin

 Platform and Version (eg. Android 5.0 or iOS 9.2.1)
ios 11.2
Plugin 4.0.2

 (Android) What device vendor (e.g. Samsung, HTC, Sony...)
N/A

 Cordova CLI version and cordova platform version

@ionic/cli-utils : 1.19.1
 ionic (Ionic CLI) : 3.19.1

global packages:

cordova (Cordova CLI) : 7.0.1

local packages:

@ionic/app-scripts : 3.1.2
 Cordova Platforms : ios 4.5.1
 Ionic Framework : ionic-angular 3.9.2

System:

ios-deploy : 1.9.2 
 ios-sim : 6.0.0 
 Node : v6.11.2
 npm : 5.3.0 
 OS : macOS High Sierra
 Xcode : Xcode 9.2 Build version 9C40b


 Plugin version

4.0.2

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Reopened] (CB-13964) 'Make' command to build cordova website dont work in windows

2018-03-19 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) reopened CB-13964:
-

> 'Make' command to build cordova website dont work in windows
> 
>
> Key: CB-13964
> URL: https://issues.apache.org/jira/browse/CB-13964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-docs
>Reporter: Gandhirajan
>Priority: Critical
>
> Make commands for cordova website devleopment dont work in windows OS



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-13964) 'Make' command to build cordova website dont work in windows

2018-03-19 Thread Jan Piotrowski (Sujan) (JIRA)

 [ 
https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Piotrowski (Sujan) resolved CB-13964.
-
Resolution: Fixed

Both PRs are merged.

> 'Make' command to build cordova website dont work in windows
> 
>
> Key: CB-13964
> URL: https://issues.apache.org/jira/browse/CB-13964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-docs
>Reporter: Gandhirajan
>Priority: Critical
>
> Make commands for cordova website devleopment dont work in windows OS



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13964) 'Make' command to build cordova website dont work in windows

2018-03-19 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405117#comment-16405117
 ] 

ASF GitHub Bot commented on CB-13964:
-

janpio closed pull request #806: CB-13964: Fixed make clean for windows
URL: https://github.com/apache/cordova-docs/pull/806
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/Makefile b/Makefile
index 8d8482928..43e95a229 100644
--- a/Makefile
+++ b/Makefile
@@ -50,6 +50,14 @@ else
 printfile = cat $(1)
 endif
 
+ifdef WINDOWS
+RM = cmd /C del /Q /F $(subst /,\,$(1))
+RMDIR  = cmd /C rmdir /S /Q $(subst /,\,$(1))
+else
+RM = rm -f $(1)
+RMDIR = rm -rf $(1)
+endif
+
 # constants
 EMPTY =
 SPACE = $(EMPTY) $(EMPTY)
@@ -152,7 +160,7 @@ NEXT_DOCS_TOCS = $(addprefix $(TOC_DIR)/,$(addsuffix 
_$(NEXT_DOCS_VERSION_SLUG)-
 JEKYLL_CONFIGS = $(MAIN_CONFIG) $(DEFAULTS_CONFIG) $(VERSION_CONFIG)
 JEKYLL_FLAGS   =
 
-BUILD_DATA = $(DOCS_VERSION_DATA) $(DOCS_PAGE_LIST) $(TOC_FILES)
+BUILD_DATA = $(TOC_FILES) $(DOCS_VERSION_DATA) $(DOCS_PAGE_LIST)
 
 # convenience targets
 help usage default:
@@ -288,18 +296,19 @@ $(CSS_DEST_DIR)/%.css: $(CSS_SRC_DIR)/%.css
 
 # maintenance
 clean:
-   $(RM) $(VERSION_CONFIG)
-   $(RM) $(DEFAULTS_CONFIG)
-   $(RM) $(DOCS_PAGE_LIST)
-   $(RM) $(DOCS_VERSION_DATA)
-   $(RM) -r $(PROD_DIR) $(DEV_DIR)
-   $(RM) $(TOC_FILES)
-   $(RM) $(PLUGINS_APP)
-   $(RM) -r $(CSS_DEST_DIR)
-   $(RM) $(FETCHED_FILES)
+   $(call RM, $(VERSION_CONFIG))
+   $(call RM, $(DEFAULTS_CONFIG))
+   $(call RM, $(DOCS_PAGE_LIST))
+   $(call RM, $(DOCS_VERSION_DATA))
+   $(call RM, $(TOC_FILES))
+   $(call RM, $(PLUGINS_APP))
+   $(call RM, $(FETCHED_FILES))
+   -$(call RMDIR, $(CSS_DEST_DIR))
+   -$(call RMDIR, $(PROD_DIR))
+   -$(call RMDIR, $(DEV_DIR))
 
 nuke: clean
-   $(RM) -r node_modules
-   $(RM) Gemfile.lock
+   $(call RMDIR, node_modules)
+   $(call RM, Gemfile.lock)
 
-.PHONY: clean usage help default build fetch $(DEV_DOCS)
+.PHONY: clean usage help default build fetch $(DEV_DOCS)
\ No newline at end of file


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> 'Make' command to build cordova website dont work in windows
> 
>
> Key: CB-13964
> URL: https://issues.apache.org/jira/browse/CB-13964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-docs
>Reporter: Gandhirajan
>Priority: Critical
>
> Make commands for cordova website devleopment dont work in windows OS



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13964) 'Make' command to build cordova website dont work in windows

2018-03-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405118#comment-16405118
 ] 

ASF subversion and git services commented on CB-13964:
--

Commit c3d73c8446397a18afa7b3396febf848e27495dc in cordova-docs's branch 
refs/heads/master from [~Gandhirajan]
[ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=c3d73c8 ]

CB-13964: Fixed make clean for windows (#806)

* fixed make clean for windows

* fixed make clean for windows

* implemented review comments

* implemented rm and rmdir changes in all occurences


> 'Make' command to build cordova website dont work in windows
> 
>
> Key: CB-13964
> URL: https://issues.apache.org/jira/browse/CB-13964
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-docs
>Reporter: Gandhirajan
>Priority: Critical
>
> Make commands for cordova website devleopment dont work in windows OS



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13800) Drop pre-KitKat specific code

2018-03-19 Thread Shashwat Tripathi (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-13800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404425#comment-16404425
 ] 

Shashwat Tripathi commented on CB-13800:


Does this mean that value of android-minSdkVersion should be 19 instead of 16 
from cordova-android 7.1.0?



 
I am getting an error since I updated to cordova-android to 7.1.0. On changing 
minSdk to 19 it works.


Manifest merger failed : uses-sdk:minSdkVersion 16 cannot be smaller than 
version 19 declared in library [:CordovaLib] 
/Users/shashwat/projects/bnforecast-ui/dist-phonegap-android/platforms/android/CordovaLib/build/intermediates/manifests/full/debug/AndroidManifest.xml
 as the library might be using APIs not available in 16
 Suggestion: use a compatible library with a minSdk of at most 16,
 or increase this project's minSdk version to at least 19,
 or use tools:overrideLibrary="org.apache.cordova" to force usage (may lead to 
runtime failures)

> Drop pre-KitKat specific code
> -
>
> Key: CB-13800
> URL: https://issues.apache.org/jira/browse/CB-13800
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-android
>Affects Versions: 7.0.0
>Reporter: Bas Bosman
>Assignee: Bas Bosman
>Priority: Minor
>
> With the release of cordova-android 7.0.0 the minimum API-Level was set to 19.
>  
> There are a couple of places in the codebase where we have specific logic for 
> older API-levels, which are now no longer needed and therefore can be removed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org