[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410810#comment-16410810 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176639084 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. +1. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. Review comment: @dblotsky I feel its too short and abstract. Any elaborations? @janpio Your thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410809#comment-16410809 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176638959 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation Review comment: @dblotsky Its a kind of heads up to the developer about what he/she is gonna install for this environment and why it is required. Jan and Myself have agreed that it will give more insight for the developer as to why he/she is doing it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410806#comment-16410806 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176638758 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. +1. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. +1. Make - Can to be installed in order to build cordova website using Makefile. This installation is optional. +1. Python - Can to be installed in order to invoke simple HTTP server from Makefile. This installation is optional. Review comment: Taken care This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410805#comment-16410805 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176638740 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: Review comment: Taken care This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410808#comment-16410808 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176638775 ## File path: doc/installing-a-development-environment.md ## @@ -87,6 +90,10 @@ Follow the instructions on [this site][linux_node]. Make is installed by default on Linux. + Python + +The latest version of CentOS, Fedora, Redhat Enterprise (RHEL) and Ubuntu come with Python 2.7 pre-installed. Else, follow the steps from [this site][python_linux]. + Review comment: Taken care This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410804#comment-16410804 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176638728 ## File path: doc/installing-a-development-environment.md ## @@ -121,6 +118,16 @@ Verify your make installation by running: make --version + Verify Python + +Python 2.7 is also required to build the docs. NOTE: *The docs will not build with Python 3.0 or greater.* + +Verify your Python installation by running: + +python --version + +The version must be 2.7.x. + Review comment: Taken care This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410807#comment-16410807 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176638768 ## File path: doc/installing-a-development-environment.md ## @@ -25,6 +27,13 @@ Make comes with the Xcode Command Line Tools. To install them, run: xcode-select --install + Python (optional) + +Mac OS X comes with Python 2.7 pre-installed. Else, follow these steps: + +1. Download [this installer][python_installer_mac] from [this page][python_downloads]. +2. Run the downloaded file. + Review comment: Taken care This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410802#comment-16410802 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176638436 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. Review comment: @dblotsky sounds good to me. Will make this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410501#comment-16410501
]
ASF GitHub Bot commented on CB-13830:
-
jcesarmobile commented on issue #434: CB-13830: Add handlers for plugins that
use non-Java source files
URL: https://github.com/apache/cordova-android/pull/434#issuecomment-375477852
Yeah, sorry, looks good, but I wanted to test it this weekend
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Major
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
> Path: platforms/android
> Package: io.cordova.hellocordova
> Name: HelloCordova
> Activity: MainActivity
> Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than
> 4.0. If you have a previous platform version, you do *not* need this plugin
> since the whitelist will be built in.
>
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
> at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
> at _fulfilled
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
> at self.promiseDispatch.done
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
> at Promise.promise.promiseDispatch
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
> at
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
>
[jira] [Commented] (CB-13830) Cordova-Android@7.0.0 fails to add a plugin previously removed
[
https://issues.apache.org/jira/browse/CB-13830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410489#comment-16410489
]
ASF GitHub Bot commented on CB-13830:
-
infil00p commented on issue #434: CB-13830: Add handlers for plugins that use
non-Java source files
URL: https://github.com/apache/cordova-android/pull/434#issuecomment-375476239
@jcesarmobile But back to the PR, is this cool to add?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Cordova-Android@7.0.0 fails to add a plugin previously removed
> --
>
> Key: CB-13830
> URL: https://issues.apache.org/jira/browse/CB-13830
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-android
>Affects Versions: cordova-android-7.0.0
> Environment: macOS 10.12.6
> node 9.4.0
> Cordova CLI 8.0.0
>
>Reporter: Enrico Giordani
>Assignee: Joe Bowser
>Priority: Major
>
> Removing a plugin and than adding it again, causes an error:
> {code}
> $ cordova create testapp
> $ cd testapp
> $ cordova platform add android
> Using cordova-fetch for cordova-android@~7.0.0
> Adding android project...
> Creating Cordova project for the Android platform:
> Path: platforms/android
> Package: io.cordova.hellocordova
> Name: HelloCordova
> Activity: MainActivity
> Android target: android-26
> Subproject Path: CordovaLib
> Subproject Path: app
> Android project created with cordova-android@7.0.0
> Android Studio project detected
> Android Studio project detected
> Discovered plugin "cordova-plugin-whitelist" in config.xml. Adding it to the
> project
> Installing "cordova-plugin-whitelist" for android
> This plugin is only applicable for versions of cordova-android greater than
> 4.0. If you have a previous platform version, you do *not* need this plugin
> since the whitelist will be built in.
>
> Adding cordova-plugin-whitelist to package.json
> Saved plugin info for "cordova-plugin-whitelist" to config.xml
> --save flag or autosave detected
> Saving android@~7.0.0 into config.xml file ...
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Adding cordova-plugin-camera to package.json
> Saved plugin info for "cordova-plugin-camera" to config.xml
> {code}
> {code}
> $ cordova plugin remove cordova-plugin-camera
> Uninstalling cordova-plugin-camera from android
> Android Studio project detected
> Subproject Path: CordovaLib
> Subproject Path: app
> Removing "cordova-plugin-camera"
> Removing plugin cordova-plugin-camera from config.xml file...
> Removing cordova-plugin-camera from package.json
> {code}
> {code}
> $ cordova plugin add cordova-plugin-camera
> Installing "cordova-plugin-camera" for android
> Android Studio project detected
> Error during processing of action! Attempting to revert...
> Failed to install 'cordova-plugin-camera': CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:51:17)
> at ActionStack.process
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/ActionStack.js:56:25)
> at PluginManager.doOperation
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:114:20)
> at PluginManager.addPlugin
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/cordova-common/src/PluginManager.js:144:17)
> at /Users/enrico/tmp/testapp/platforms/android/cordova/Api.js:247:74
> at _fulfilled
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:854:54)
> at self.promiseDispatch.done
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:883:30)
> at Promise.promise.promiseDispatch
> (/Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:816:13)
> at
> /Users/enrico/tmp/testapp/platforms/android/cordova/node_modules/q/q.js:570:49
> (node:5722) UnhandledPromiseRejectionWarning: CordovaError: Uh oh!
> "/Users/enrico/tmp/testapp/platforms/android/app/src/main/res/xml/provider_paths.xml"
> already exists!
> at copyNewFile
> (/Users/enrico/tmp/testapp/platforms/android/cordova/lib/pluginHandlers.js:261:45)
> at install
>
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410266#comment-16410266 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176566470 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation Review comment: @gandhirajan what is the purpose of this section? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410268#comment-16410268 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176565690 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: Review comment: Grammar: "of following softwares" -> "of the following software". This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410273#comment-16410273 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176566425 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. +1. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. +1. Make - Can to be installed in order to build cordova website using Makefile. This installation is optional. +1. Python - Can to be installed in order to invoke simple HTTP server from Makefile. This installation is optional. Review comment: Grammar: "Can to be" -> "Can be". This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410271#comment-16410271 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176566246 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. +1. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. Review comment: How about: "Needed by the build tools." This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410272#comment-16410272 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176566692 ## File path: doc/installing-a-development-environment.md ## @@ -87,6 +90,10 @@ Follow the instructions on [this site][linux_node]. Make is installed by default on Linux. + Python + +The latest version of CentOS, Fedora, Redhat Enterprise (RHEL) and Ubuntu come with Python 2.7 pre-installed. Else, follow the steps from [this site][python_linux]. + Review comment: Nitpick: extra line. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410270#comment-16410270 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176566579 ## File path: doc/installing-a-development-environment.md ## @@ -25,6 +27,13 @@ Make comes with the Xcode Command Line Tools. To install them, run: xcode-select --install + Python (optional) + +Mac OS X comes with Python 2.7 pre-installed. Else, follow these steps: + +1. Download [this installer][python_installer_mac] from [this page][python_downloads]. +2. Run the downloaded file. + Review comment: Nitpick: extra empty line. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410267#comment-16410267 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176564891 ## File path: doc/installing-a-development-environment.md ## @@ -121,6 +118,16 @@ Verify your make installation by running: make --version + Verify Python + +Python 2.7 is also required to build the docs. NOTE: *The docs will not build with Python 3.0 or greater.* + +Verify your Python installation by running: + +python --version + +The version must be 2.7.x. + Review comment: Nitpick: extra empty line. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410269#comment-16410269 ] ASF GitHub Bot commented on CB-13400: - dblotsky commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176566070 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,14 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. Review comment: How about: "Needed by Jekyll. Jekyll is the static site generator that generates the website and docs." This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410150#comment-16410150 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on issue #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#issuecomment-375426563 @janpio Sure Jan. Will check out. Thanks for your time and support This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410147#comment-16410147 ] ASF GitHub Bot commented on CB-13400: - janpio commented on issue #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#issuecomment-375426094 From someone else. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410133#comment-16410133 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on issue #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#issuecomment-375423596 @janpio You mean from someone else other than you? or you wanna recheck once more? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410093#comment-16410093 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176530766 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + +2. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. + +3. Make - Can to be installed in order to build cordova website using Makefile. This installation is optional. + +4. Python - Can to be installed in order to invoke simple HTTP server from Makefile. This installation is optional. Review comment: @janpio agree with you Jan. Implemented and checked in. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410087#comment-16410087 ] ASF GitHub Bot commented on CB-13400: - janpio commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176530457 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + +2. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. + +3. Make - Can to be installed in order to build cordova website using Makefile. This installation is optional. + +4. Python - Can to be installed in order to invoke simple HTTP server from Makefile. This installation is optional. Review comment: would make sense to match the order of "software" to the order here, right? especially if it is optional, it should not really be listed before a really required one, right? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410020#comment-16410020 ] ASF GitHub Bot commented on CB-13400: - gandhirajan commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176520424 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + +2. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. + +3. Make - Can to be installed in order to build cordova website using Makefile. This installation is optional. + +4. Python - Can to be installed in order to invoke simple HTTP server from Makefile. This installation is optional. Review comment: @janpio you mean in OS specific installations, python should be last? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410014#comment-16410014 ] ASF GitHub Bot commented on CB-13400: - janpio commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176518975 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + +2. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. + +3. Make - Can to be installed in order to build cordova website using Makefile. This installation is optional. + +4. Python - Can to be installed in order to invoke simple HTTP server from Makefile. This installation is optional. Review comment: python should probably also be sorted last in all the instructions below then, correct? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410003#comment-16410003 ] ASF GitHub Bot commented on CB-13400: - janpio commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176518756 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + +2. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. Review comment: you can put `1.` in all lines, numbering will done automatically This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16410002#comment-16410002 ] ASF GitHub Bot commented on CB-13400: - janpio commented on a change in pull request #809: CB-13400: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176518683 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + Review comment: get rid of the empty lines between list items This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-13400) Restructure and test "Installing" instructions
[ https://issues.apache.org/jira/browse/CB-13400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gandhirajan reassigned CB-13400: Assignee: Gandhirajan > Restructure and test "Installing" instructions > -- > > Key: CB-13400 > URL: https://issues.apache.org/jira/browse/CB-13400 > Project: Apache Cordova > Issue Type: Sub-task > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Assignee: Gandhirajan >Priority: Major > > When https://github.com/apache/cordova-docs/pull/745 is merged, the resulting > "installing-a-development-environment.md" should be a) tested for correctness > and b) restructure by platform instead of by tech. Makes much more sense, as > one will only work through the list for one platform. c) might be to add some > explanation which tech is used for which reason and part of the site. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13997) npm should always be used with NO_UPDATE_NOTIFIER setted
Nicolas HENRY created CB-13997: -- Summary: npm should always be used with NO_UPDATE_NOTIFIER setted Key: CB-13997 URL: https://issues.apache.org/jira/browse/CB-13997 Project: Apache Cordova Issue Type: Bug Components: cordova-lib Reporter: Nicolas HENRY Since cordova-lib is using npm commands, when I am behind a corporate proxy npm is trying to check if npm has new versions available and get stuck for some time each time npm command is spawned. As a workaround, I set NO_UPDATE_NOTIFIER environment variable manually to disable the check done by the "update-notifier" module which is used by npm. I think that cordova-lib should set this variable itself when it spawn npm commands since this check is probably unnecessary. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13275) Improve documentation on cordova-docs
[ https://issues.apache.org/jira/browse/CB-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409749#comment-16409749 ] ASF GitHub Bot commented on CB-13275: - janpio commented on a change in pull request #809: CB-13275: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176471045 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + +2. Python - Needs to be installed in order to invoke simple HTTP server from Makefile. Review comment: If this is only needed for the "simple HTTP server from Makefile" then this is also optional (and should be moved down, after "Make") This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve documentation on cordova-docs > - > > Key: CB-13275 > URL: https://issues.apache.org/jira/browse/CB-13275 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > > The documentation (README, other .md files) on `cordova-docs` could use some > improvement. > See the subtasks for actual problems and things to be fixed, changed or > improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13275) Improve documentation on cordova-docs
[ https://issues.apache.org/jira/browse/CB-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409748#comment-16409748 ] ASF GitHub Bot commented on CB-13275: - janpio commented on a change in pull request #809: CB-13275: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809#discussion_r176470774 ## File path: doc/installing-a-development-environment.md ## @@ -1,5 +1,17 @@ ## Installing +### Introduction to Installation + +The development environment setup requires installation of following softwares: + +1. Ruby - Needs to be installed in order to install and use Jekyll. Jekyll helps in tranforming plain texts into static websites. + +2. Python - Needs to be installed in order to invoke simple HTTP server from Makefile. + +3. Node.js - Needs to be installed in order to install all the required development and javascript dependencies. + +4. Make - Needs to be installed in order to build cordova website using Makefile. This installation is optional. Review comment: If it is optional it is not "needed". This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve documentation on cordova-docs > - > > Key: CB-13275 > URL: https://issues.apache.org/jira/browse/CB-13275 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > > The documentation (README, other .md files) on `cordova-docs` could use some > improvement. > See the subtasks for actual problems and things to be fixed, changed or > improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13275) Improve documentation on cordova-docs
[ https://issues.apache.org/jira/browse/CB-13275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409638#comment-16409638 ] ASF GitHub Bot commented on CB-13275: - gandhirajan opened a new pull request #809: CB-13275: Added introduction to installation section URL: https://github.com/apache/cordova-docs/pull/809 This PR adds basic 'Introduction to Installation" section in 'Installing a development environment' page. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve documentation on cordova-docs > - > > Key: CB-13275 > URL: https://issues.apache.org/jira/browse/CB-13275 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-docs >Reporter: Jan Piotrowski (Sujan) >Priority: Minor > > The documentation (README, other .md files) on `cordova-docs` could use some > improvement. > See the subtasks for actual problems and things to be fixed, changed or > improved. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13900) Splashscreen get resized on iOS at startup
[ https://issues.apache.org/jira/browse/CB-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409639#comment-16409639 ] jcesarmobile commented on CB-13900: --- Pull requests are welcome ;) > Splashscreen get resized on iOS at startup > -- > > Key: CB-13900 > URL: https://issues.apache.org/jira/browse/CB-13900 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Reporter: Thomas Fétiveau >Priority: Major > > I'm using the following setting in my config.xml for iOS : > > > > > > > At startup, the splashscreen get displayed once with a given size and then > right after with a unzoomed size. The effect is not nice. > > Why is this happening ? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13900) Splashscreen get resized on iOS at startup
[ https://issues.apache.org/jira/browse/CB-13900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409636#comment-16409636 ] Thomas Fétiveau commented on CB-13900: -- still nothing ? > Splashscreen get resized on iOS at startup > -- > > Key: CB-13900 > URL: https://issues.apache.org/jira/browse/CB-13900 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-splashscreen >Reporter: Thomas Fétiveau >Priority: Major > > I'm using the following setting in my config.xml for iOS : > > > > > > > At startup, the splashscreen get displayed once with a given size and then > right after with a unzoomed size. The effect is not nice. > > Why is this happening ? -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409341#comment-16409341 ] ASF GitHub Bot commented on CB-13415: - alpesh12 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-375246040 @jcesarmobile i am really sorry. i didn’t mean to disturb you. Just wanted to follow up with you regarding merge. But i understand your work load so please take care of it when you get a time. Again sorry for bugging you. Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409331#comment-16409331 ] ASF GitHub Bot commented on CB-13415: - alpesh12 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-375246040 @jcesarmobile Ok i'll wait Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409327#comment-16409327 ] ASF GitHub Bot commented on CB-13415: - jcesarmobile commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-375244323 So, you didn't read my comment or you didn't care and pinged me again trying to rush me, so I just removed it from my list. I understand that you need this and you want this merged as soon as possible, but there are hundreds of PRs at this moment, most of them are older than yours. We don't have enough resources to review and merge everything, we have to prioritize. And after you comment, this PR is no longer a priority for me. I'm unsubscribing from the notifications, please, don't ping me again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409309#comment-16409309 ] ASF GitHub Bot commented on CB-13415: - alpesh12 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-375239314 @jcesarmobile when you are available to check this PR and merge? i am waiting from last 30 days. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409305#comment-16409305 ] ASF GitHub Bot commented on CB-13415: - jcesarmobile commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-375238012 I have a long list of things to review/merge, and every time somebody pings me or comment with +1 on the PR trying to rush it, I move it to the bottom of my list. For people commenting with +1, please, stop doing it. GitHub added the reactions long time ago, if you reaction with +1 on the PR instead of a +1 comment, then we can sort the PRs by the reactions and know which one has more +1, while a comment just spams everybody subscribed and piss off collaborators like me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13415) Importing corrupt images using the Camera plugin crashes the app
[ https://issues.apache.org/jira/browse/CB-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16409281#comment-16409281 ] ASF GitHub Bot commented on CB-13415: - alpesh12 commented on issue #310: CB-13415 (iOS) Importing corrupt images using the Camera plugin crashes the app URL: https://github.com/apache/cordova-plugin-camera/pull/310#issuecomment-375232683 @jcesarmobile @shazron Can you please help me to merge this code to the master, i am waiting from last one month. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Importing corrupt images using the Camera plugin crashes the app > > > Key: CB-13415 > URL: https://issues.apache.org/jira/browse/CB-13415 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-plugin-camera > Environment: Android: OS 7.0, Phone Model: Moto G5 Plus > iOS: OS 10.1.1 (14B150) >Reporter: Shemrick Flannigan >Priority: Critical > Labels: android, camera, cameraui, ios > > ISSUE > Importing corrupt images using the Camera plugin crashes the app > Current Behavior > # Importing a corrupt image using the Cordova Camera plugin crashes the > Cordova app which uses the plugin > Expected Behavior > # Importing a corrupt image using the Cordova Camera plugin: > #* Throws an exception which can be caught by the Cordova app which uses the > plugin > #* Does not crash the Cordova app which uses the plugin > #* Allows the Cordova app which uses the plugin to render a Toast error > message relaying the error > # # Platforms affected > #* Android > #* iOS > REFERENCES > # [Sample corrupt image which crashes the app | > https://www.dropbox.com/s/e7dz007svtvscbc/Corrupt_Image_4.7MB_13500x13500.D2.jpg?dl=0] > # [Technique used to wrap the call in a Try/Catch block in a callable inner > class to prevent an app crash | > https://stackoverflow.com/questions/19183174/phonegap-video-capture-crashes] > ADDITIONAL INFORMATION > # Importing corrupt images does not crash apps which do not use the Camera > plugin, such as: > #* Yelp mobile app > #* Slack mobile app -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-13996) The Splash Page doesn't hide when iOS devices connect to WiFi
Aggie Chen created CB-13996:
---
Summary: The Splash Page doesn't hide when iOS devices connect to
WiFi
Key: CB-13996
URL: https://issues.apache.org/jira/browse/CB-13996
Project: Apache Cordova
Issue Type: Bug
Components: cordova-plugin-splashscreen
Affects Versions: cordova-ios@4.3.1, cordova@7.1.0
Reporter: Aggie Chen
as title, I have done some search about .splashscreen.hide().
Andriod is fine. IOS is fine when it does not connect to WiFi. But some
end-users open App by public WiFi. They connect, and click the app icon,
Splash show up and stuck here.
The problem is a little like https://issues.apache.org/jira/browse/CB-10562.
Is there other ways to help solve this condition?
environment：
splashscreen 4.0.1, iphone 11.1.2. 10.3.2
config.xml
and js:
setTimeout(function () {
navigator.splashscreen.hide();
}, 2000);
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
