[jira] [Updated] (CB-14212) Invalid action should be added to the header of the queue
[ https://issues.apache.org/jira/browse/CB-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles updated CB-14212: - Attachment: (was: TIM图片20180719104111.png) > Invalid action should be added to the header of the queue > - > > Key: CB-14212 > URL: https://issues.apache.org/jira/browse/CB-14212 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 >Reporter: Charles >Priority: Major > Attachments: Attempted to send a second callback.png > > > [callbackContext.sendPluginResult(cr);|https://github.com/apache/cordova-android/blob/b6e4598e7c35dba433a5309c3c633485585dc692/framework/src/org/apache/cordova/PluginManager.java#L140],If > the exe() method returns false, but the callbackContext.success() or > callbackContext.error() method is executed before this, the js side will not > receive the "invalid action" message.So, I think we should put "invalid > action" at the top of the queue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14212) Invalid action should be added to the header of the queue
[ https://issues.apache.org/jira/browse/CB-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles updated CB-14212: - Attachment: Attempted to send a second callback.png > Invalid action should be added to the header of the queue > - > > Key: CB-14212 > URL: https://issues.apache.org/jira/browse/CB-14212 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 >Reporter: Charles >Priority: Major > Attachments: Attempted to send a second callback.png > > > [callbackContext.sendPluginResult(cr);|https://github.com/apache/cordova-android/blob/b6e4598e7c35dba433a5309c3c633485585dc692/framework/src/org/apache/cordova/PluginManager.java#L140],If > the exe() method returns false, but the callbackContext.success() or > callbackContext.error() method is executed before this, the js side will not > receive the "invalid action" message.So, I think we should put "invalid > action" at the top of the queue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14212) Invalid action should be added to the header of the queue
[ https://issues.apache.org/jira/browse/CB-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles updated CB-14212: - Attachment: TIM图片20180719104111.png > Invalid action should be added to the header of the queue > - > > Key: CB-14212 > URL: https://issues.apache.org/jira/browse/CB-14212 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 >Reporter: Charles >Priority: Major > Attachments: TIM图片20180719104111.png > > > [callbackContext.sendPluginResult(cr);|https://github.com/apache/cordova-android/blob/b6e4598e7c35dba433a5309c3c633485585dc692/framework/src/org/apache/cordova/PluginManager.java#L140],If > the exe() method returns false, but the callbackContext.success() or > callbackContext.error() method is executed before this, the js side will not > receive the "invalid action" message.So, I think we should put "invalid > action" at the top of the queue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS
[ https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548667#comment-16548667 ] ASF GitHub Bot commented on CB-14187: - brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-406127713 Thanks @wvengen. Unfortunately I had some real trouble getting a test demo to work on iOS. A quick demo project that shows this functionality working the same way on both Android and iOS (as closely as possible) would be really helpful. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-inappbrowser AllowedSchemes for iOS > -- > > Key: CB-14187 > URL: https://issues.apache.org/jira/browse/CB-14187 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > CB-14013 add support for custom url schemes with the AllowedSchemes > preference. This only works on Android, however. It would be very useful to > have this on iOS (and other platforms) as well. > A pull request for iOS will follow. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14212) Invalid action should be added to the header of the queue
[ https://issues.apache.org/jira/browse/CB-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles updated CB-14212: - Affects Version/s: cordova-android-7.0.0 > Invalid action should be added to the header of the queue > - > > Key: CB-14212 > URL: https://issues.apache.org/jira/browse/CB-14212 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Affects Versions: cordova-android-7.0.0 >Reporter: Charles >Priority: Major > > [callbackContext.sendPluginResult(cr);|https://github.com/apache/cordova-android/blob/b6e4598e7c35dba433a5309c3c633485585dc692/framework/src/org/apache/cordova/PluginManager.java#L140],If > the exe() method returns false, but the callbackContext.success() or > callbackContext.error() method is executed before this, the js side will not > receive the "invalid action" message.So, I think we should put "invalid > action" at the top of the queue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547957#comment-16547957 ] ASF GitHub Bot commented on CB-14188: - wvengen edited a comment on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-405965660 Thanks a lot for your review and comments, @brodybits. I agree that the current approach is not ideal, and have struggled with how to add the callback. Indeed, a synchronous callback would be the best option, that would first need some research to whether Android's and iOS's WebView implementation allow this to take a little time (because it involves a Javascript invocation). If this is not possible (or if this is ported to a platform requiring near-immediate return from its do-I-need-to-load-this-URL-function), for Cordova users it can still be a synchronous function, with the help of a workaround similar to what happens now, but without the concurrency issue you mentioned (I have an idea to do this using a custom URL scheme). Interesting you mention the `beforeunload` event, that would be familiar to many. For inAppBrowser, the confirm dialog would not be shown. It also makes sense to skip the callback on first page load, as that is controlled by the inAppBrowser-invoking code already. I'll delve into this. Since I'll be on holiday for about two weeks, it may take a little time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547956#comment-16547956 ] ASF GitHub Bot commented on CB-14188: - wvengen edited a comment on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-405965660 Thanks a lot for your review and comments, @brodybits. I agree that the current approach is not ideal, and have struggled with how to add the callback. Indeed, a synchronous callback would be the best option, that would first need some research to whether Android's and iOS's WebView implementation allow this to take a little time (because it involves a Javascript invocation). If this is not possible (or if this is ported to a platform requiring near-immediate return from its do-I-need-to-load-this-URL-function), for Cordova users it can still be a synchronous function, with the help of a workaround similar to what happens now, but without the concurrency issue you mentioned (I have an idea to do this using a custom URL scheme). Interesting you mention the `beforeunload` event, that would be familiar to many. In our case, the confirm dialog would not be shown. It also makes sense to skip this on first page load, as that is always controlled by the inAppBrowser-invoking code. I'll delve into this. Since I'll be on holiday for about two weeks, it may take a little time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14188) Callback to decide whether to open link or not.
[ https://issues.apache.org/jira/browse/CB-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547946#comment-16547946 ] ASF GitHub Bot commented on CB-14188: - wvengen commented on issue #276: CB-14188: add beforeload event, catching navigation before it happens URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/276#issuecomment-405965660 Thanks a lot for your review, @brodybits. I agree that the current approach is not ideal, and have struggled with how to add the callback. Indeed, a synchronous callback would be the best option, that would first need some research to whether Android's and iOS's WebView implementation allow this to take a little time (because it involves a Javascript invocation). If this is not possible (or if this is ported to a platform requiring near-immediate return from its do-I-need-to-load-this-URL-function), for Cordova users it can still be a synchronous function, with the help of a workaround similar to what happens now, but without the concurrency issue you mentioned (I have an idea to do this using a custom URL scheme). Interesting you mention the `beforeunload` event, that would be familiar to many. In our case, the confirm dialog would not be shown. It also makes sense to skip this on first page load, as that is always controlled by the inAppBrowser-invoking code. I'll delve into this. Since I'll be on holiday for about two weeks, it may take a little time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Callback to decide whether to open link or not. > --- > > Key: CB-14188 > URL: https://issues.apache.org/jira/browse/CB-14188 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > Several times I've found myself wanting to tell inAppBrowser whether it can > open a link in the embedded webview or using the system web browser. It would > be great if there's a callback _before_ loading a page (loadstart is too late > there), where I can tell inAppBrowser to load the page or not. > CB-14013 introduced AllowedSchemes, but excluded the use of http and https. > -It would be useful to allow intercepting http and https links, e.g. to > decide whether to open the link in the system web browser or not.- At first I > thought this mechanism could be used, but because of the asynchronous nature > of Cordova callbacks, this didn't work out, and I added a beforeload > callback. See comment for an example. > I've submitted a PR -(my approach would be to generate a regexp based on > AllowedSchemes and match the URL on that, instead of the current if logic)-. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS
[ https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547933#comment-16547933 ] ASF GitHub Bot commented on CB-14187: - wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to allow custom schemes URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-405962280 Thanks for your review, @brodybits! I've added a test and some documentation. I opted for a manual test only, since this needs a `config.xml` preference (even though I added that to the CONTRIBUTING document). It might be useful to add the preference to the regular Cordova documentation at some point in the future (not sure if that is desirable or not). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > cordova-plugin-inappbrowser AllowedSchemes for iOS > -- > > Key: CB-14187 > URL: https://issues.apache.org/jira/browse/CB-14187 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-inappbrowser >Affects Versions: 3.0.0 >Reporter: wvengen >Priority: Major > > CB-14013 add support for custom url schemes with the AllowedSchemes > preference. This only works on Android, however. It would be very useful to > have this on iOS (and other platforms) as well. > A pull request for iOS will follow. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14026) Android installation requirements are out of date
[ https://issues.apache.org/jira/browse/CB-14026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547663#comment-16547663 ] ASF GitHub Bot commented on CB-14026: - janpio closed pull request #836: CB-14026 (android): Update Android SDK instructions URL: https://github.com/apache/cordova-docs/pull/836 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/www/docs/en/dev/guide/platforms/android/index.md b/www/docs/en/dev/guide/platforms/android/index.md index 18c321b75..4436d5a4e 100644 --- a/www/docs/en/dev/guide/platforms/android/index.md +++ b/www/docs/en/dev/guide/platforms/android/index.md @@ -37,8 +37,8 @@ the CLI, see [Cordova CLI Reference][cli_reference]. Cordova for Android requires the Android SDK which can be installed on OS X, Linux or Windows. See the Android SDK's [System Requirements](http://developer.android.com/sdk/index.html#Requirements). -Cordova's latest Android package supports up to Android [API Level](http://developer.android.com/guide/topics/manifest/uses-sdk-element.html#ApiLevels) 25. -The supported Android API Levels and Android Versions for the past +Cordova's latest Android package supports up to Android [API Level](http://developer.android.com/guide/topics/manifest/uses-sdk-element.html#ApiLevels) 27. +The supported Android API Levels and Android Versions for the past few cordova-android releases can be found in this table: cordova-android Version | Supported Android API-Levels | Equivalent Android Version @@ -75,10 +75,10 @@ As of Cordova-Android 6.4.0, [Gradle](https://gradle.org/install/) is now requir When installing on Windows, you need to add Gradle to your path, (see [Setting Environment Variables](#setting-environment-variables)) - Android SDK +### Android SDK -Install [Android Studio][android_studio]. -Detailed installation instructions are on Android's developer site. +Install [Android Studio][android_studio]. Follow the instructions at the linked Android Developer site to get started. +Opening Android Studio for the first time will guide you through the process of installing the Android SDK. Adding SDK Packages @@ -87,14 +87,14 @@ whatever [API level](http://developer.android.com/guide/topics/manifest/uses-sdk you wish to target. It is recommended that you install the highest SDK version that your version of cordova-android supports (see [Requirements and Support](#requirements-and-support)). -Open the Android SDK Manager (run `sdkmanager` from the terminal) +Open the Android SDK Manager (`Tools > SDK Manager` in Android Studio, or `sdkmanager` on the command line), and make sure the following are installed: 1. Android Platform SDK for your targeted version of Android 1. Android SDK build-tools version 19.1.0 or higher -1. Android Support Repository (found under "Extras") +1. Android Support Repository (found under the "SDK Tools" tab) -See Android's documentation on [Installing SDK Packages](https://developer.android.com/studio/intro/update.html) +See Android's documentation on [Installing SDK Packages](https://developer.android.com/studio/intro/update) for more details. ### Setting environment variables This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Android installation requirements are out of date > - > > Key: CB-14026 > URL: https://issues.apache.org/jira/browse/CB-14026 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Simon MacDonald >Priority: Major > > In this section of the docs: > [http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing-the-requirements] > we talk about running the sdkmanager from the command line but it is no > longer available. > We should instead tell the users to run the sdkmanager from Android Studio. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14026) Android installation requirements are out of date
[ https://issues.apache.org/jira/browse/CB-14026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547664#comment-16547664 ] ASF subversion and git services commented on CB-14026: -- Commit 3f9471533ff3d1e3adf38abbc818add32ce98b5f in cordova-docs's branch refs/heads/master from Gearóid [ https://gitbox.apache.org/repos/asf?p=cordova-docs.git;h=3f94715 ] CB-14026 (android): Update Android SDK instructions (#836) > Android installation requirements are out of date > - > > Key: CB-14026 > URL: https://issues.apache.org/jira/browse/CB-14026 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-docs >Reporter: Simon MacDonald >Priority: Major > > In this section of the docs: > [http://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing-the-requirements] > we talk about running the sdkmanager from the command line but it is no > longer available. > We should instead tell the users to run the sdkmanager from Android Studio. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14212) Invalid action should be added to the header of the queue
[ https://issues.apache.org/jira/browse/CB-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles updated CB-14212: - Description: [callbackContext.sendPluginResult(cr);|https://github.com/apache/cordova-android/blob/b6e4598e7c35dba433a5309c3c633485585dc692/framework/src/org/apache/cordova/PluginManager.java#L140],If the exe() method returns false, but the callbackContext.success() or callbackContext.error() method is executed before this, the js side will not receive the "invalid action" message.So, I think we should put "invalid action" at the top of the queue (was: [callbackContext.sendPluginResult(cr);|https://github.com/react-native-community/react-native-camera],If the exe() method returns false, but the callbackContext.success() or callbackContext.error() method is executed before this, the js side will not receive the "invalid action" message.So, I think we should put "invalid action" at the top of the queue) > Invalid action should be added to the header of the queue > - > > Key: CB-14212 > URL: https://issues.apache.org/jira/browse/CB-14212 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Charles >Priority: Major > > [callbackContext.sendPluginResult(cr);|https://github.com/apache/cordova-android/blob/b6e4598e7c35dba433a5309c3c633485585dc692/framework/src/org/apache/cordova/PluginManager.java#L140],If > the exe() method returns false, but the callbackContext.success() or > callbackContext.error() method is executed before this, the js side will not > receive the "invalid action" message.So, I think we should put "invalid > action" at the top of the queue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-14212) Invalid action should be added to the header of the queue
[ https://issues.apache.org/jira/browse/CB-14212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Charles updated CB-14212: - Description: [callbackContext.sendPluginResult(cr);|https://github.com/react-native-community/react-native-camera],If the exe() method returns false, but the callbackContext.success() or callbackContext.error() method is executed before this, the js side will not receive the "invalid action" message.So, I think we should put "invalid action" at the top of the queue (was: [ callbackContext.sendPluginResult(cr);|https://github.com/react-native-community/react-native-camera],If the exe() method returns false, but the callbackContext.success() or callbackContext.error() method is executed before this, the js side will not receive the "invalid action" message.So, I think we should put "invalid action" at the top of the queue) > Invalid action should be added to the header of the queue > - > > Key: CB-14212 > URL: https://issues.apache.org/jira/browse/CB-14212 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-android >Reporter: Charles >Priority: Major > > [callbackContext.sendPluginResult(cr);|https://github.com/react-native-community/react-native-camera],If > the exe() method returns false, but the callbackContext.success() or > callbackContext.error() method is executed before this, the js side will not > receive the "invalid action" message.So, I think we should put "invalid > action" at the top of the queue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-14212) Invalid action should be added to the header of the queue
Charles created CB-14212: Summary: Invalid action should be added to the header of the queue Key: CB-14212 URL: https://issues.apache.org/jira/browse/CB-14212 Project: Apache Cordova Issue Type: Bug Components: cordova-android Reporter: Charles [ callbackContext.sendPluginResult(cr);|https://github.com/react-native-community/react-native-camera],If the exe() method returns false, but the callbackContext.success() or callbackContext.error() method is executed before this, the js side will not receive the "invalid action" message.So, I think we should put "invalid action" at the top of the queue -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
[ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547620#comment-16547620 ] ASF GitHub Bot commented on CB-14211: - oliversalzburg commented on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405874702 @raphinesse Yeah, well observed. I was looking at that output earlier and could not quite figure out what exactly the failure was. > PowerShell fails with NativeCommandError when a process writes to StdErr. Caused by this line: https://github.com/stevenvachon/nopter/blob/master/appveyor.yml#L37 From: https://help.appveyor.com/discussions/problems/10014-false-build-fail-status Now that's a bit annoying. The `appveyor.yml` that he links to runs the tests in succession in both shells btw. Maybe that would be an option too. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Windows/AppVeyor test suite in both PowerShell and Command Prompt > - > > Key: CB-14211 > URL: https://issues.apache.org/jira/browse/CB-14211 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Oliver Salzburg >Priority: Major > > I thought it could be useful to run the test suite in both shells, just to be > safe. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
[ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547605#comment-16547605 ] ASF GitHub Bot commented on CB-14211: - janpio commented on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405870443 So we have CI specific bugs as well? Yay! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Windows/AppVeyor test suite in both PowerShell and Command Prompt > - > > Key: CB-14211 > URL: https://issues.apache.org/jira/browse/CB-14211 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Oliver Salzburg >Priority: Major > > I thought it could be useful to run the test suite in both shells, just to be > safe. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12024) Add Browser platform support to cordova-plugin-statusbar
[ https://issues.apache.org/jira/browse/CB-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547598#comment-16547598 ] ASF GitHub Bot commented on CB-12024: - janpio commented on issue #67: CB-12024: Browser platform support URL: https://github.com/apache/cordova-plugin-statusbar/pull/67#issuecomment-405869122 Looking pretty good @dudeofawesome. I left a question, could you also maybe _again_ rebase on master to get rid of the README conflict? Also, what are the easiest steps to try this out? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Browser platform support to cordova-plugin-statusbar > > > Key: CB-12024 > URL: https://issues.apache.org/jira/browse/CB-12024 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-statusbar >Reporter: Louis Orleans >Priority: Minor > Labels: browser > > The StatusBar plugin can support the Browser platform at least on Chrome for > Android, and potentially on other browsers as well. I'm forking the repo and > implementing this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-12024) Add Browser platform support to cordova-plugin-statusbar
[ https://issues.apache.org/jira/browse/CB-12024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547597#comment-16547597 ] ASF GitHub Bot commented on CB-12024: - janpio commented on a change in pull request #67: CB-12024: Browser platform support URL: https://github.com/apache/cordova-plugin-statusbar/pull/67#discussion_r203309656 ## File path: README.md ## @@ -30,7 +30,7 @@ description: Control the device status bar. StatusBar == -> The `StatusBar` object provides some functions to customize the iOS and Android StatusBar. +> The `StatusBar` object provides some functions to customize the iOS and Android StatusBar, as well as some browser chrome. Review comment: What does "some browser chrome" exactly mean here? "browser window on some (mobile OS system) browsers"? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Browser platform support to cordova-plugin-statusbar > > > Key: CB-12024 > URL: https://issues.apache.org/jira/browse/CB-12024 > Project: Apache Cordova > Issue Type: New Feature > Components: cordova-plugin-statusbar >Reporter: Louis Orleans >Priority: Minor > Labels: browser > > The StatusBar plugin can support the Browser platform at least on Chrome for > Android, and potentially on other browsers as well. I'm forking the repo and > implementing this. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9841) Allow iOS status bar to animate hide/show
[ https://issues.apache.org/jira/browse/CB-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547594#comment-16547594 ] ASF GitHub Bot commented on CB-9841: janpio edited a comment on issue #37: CB-9841 - Allow iOS statusbar to animate hide/show URL: https://github.com/apache/cordova-plugin-statusbar/pull/37#issuecomment-405867454 Yes, someone could create a new PR where the merged conflict is resolved please, then someone could take a look @InternetExplorer8 @timbru31 In general: Is this an iOS only feature or is this also possible on other platforms? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow iOS status bar to animate hide/show > - > > Key: CB-9841 > URL: https://issues.apache.org/jira/browse/CB-9841 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar > Environment: iOS >Reporter: Andrei Stanica >Priority: Minor > Labels: features > Original Estimate: 3h > Remaining Estimate: 3h > > At the moment all the updates done to the status bar from cordova do not have > animation, be it hiding, showing or changing colour. > It is suggested to modify the CDVStatusBar file to allow animation on > refreshStatusBarAppearance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-9841) Allow iOS status bar to animate hide/show
[ https://issues.apache.org/jira/browse/CB-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547592#comment-16547592 ] ASF GitHub Bot commented on CB-9841: janpio commented on issue #37: CB-9841 - Allow iOS statusbar to animate hide/show URL: https://github.com/apache/cordova-plugin-statusbar/pull/37#issuecomment-405867454 Yes, someone could create a new PR where the merged conflict is resolved please, then someone could take a look. In general: Is this an iOS only feature or is this also possible on other platforms? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow iOS status bar to animate hide/show > - > > Key: CB-9841 > URL: https://issues.apache.org/jira/browse/CB-9841 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-statusbar > Environment: iOS >Reporter: Andrei Stanica >Priority: Minor > Labels: features > Original Estimate: 3h > Remaining Estimate: 3h > > At the moment all the updates done to the status bar from cordova do not have > animation, be it hiding, showing or changing colour. > It is suggested to modify the CDVStatusBar file to allow animation on > refreshStatusBarAppearance. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
[ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547590#comment-16547590 ] ASF GitHub Bot commented on CB-14211: - raphinesse edited a comment on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405865819 @oliversalzburg > So right after we decide that it's probably not worth running all NodeJS versions on both shells, we see failures with one specific version in one specific shell. It sure looks that way. I *think* that I saw the Buffer deprecation warning while working on some other Cordova stuff before this PR. But I couldn't say if it was the same code that failed. :man_shrugging: **Edit**: Yeah, it also occurs with cmd: https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-lib/build/1.0.1366/job/b2ver32qyy1cqqm5#L80 Maybe it prints to stderr and AppVeyor/Powershell sees that as an error and fails the build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Windows/AppVeyor test suite in both PowerShell and Command Prompt > - > > Key: CB-14211 > URL: https://issues.apache.org/jira/browse/CB-14211 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Oliver Salzburg >Priority: Major > > I thought it could be useful to run the test suite in both shells, just to be > safe. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
[ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547588#comment-16547588 ] ASF GitHub Bot commented on CB-14211: - raphinesse edited a comment on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405865819 > So right after we decide that it's probably not worth running all NodeJS versions on both shells, we see failures with one specific version in one specific shell. It sure looks that way. I *think* that I saw the Buffer deprecation warning while working on some other Cordova stuff before this PR. But I couldn't say if it was the same code that failed. :man_shrugging: **Edit**: Yeah, it also occurs with cmd: https://ci.appveyor.com/project/ApacheSoftwareFoundation/cordova-lib/build/1.0.1366/job/b2ver32qyy1cqqm5#L80 Maybe it prints to stderr and AppVeyor/Powershell sees that as an error and fails the build. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Windows/AppVeyor test suite in both PowerShell and Command Prompt > - > > Key: CB-14211 > URL: https://issues.apache.org/jira/browse/CB-14211 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Oliver Salzburg >Priority: Major > > I thought it could be useful to run the test suite in both shells, just to be > safe. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
[ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547584#comment-16547584 ] ASF GitHub Bot commented on CB-14211: - raphinesse commented on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405865819 > So right after we decide that it's probably not worth running all NodeJS versions on both shells, we see failures with one specific version in one specific shell. It sure looks that way. I *think* that I saw the Buffer deprecation warning while working on some other Cordova stuff before this PR. But I couldn't say if it was the same code that failed. :man_shrugging: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Windows/AppVeyor test suite in both PowerShell and Command Prompt > - > > Key: CB-14211 > URL: https://issues.apache.org/jira/browse/CB-14211 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Oliver Salzburg >Priority: Major > > I thought it could be useful to run the test suite in both shells, just to be > safe. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-14211) Run Windows/AppVeyor test suite in both PowerShell and Command Prompt
[ https://issues.apache.org/jira/browse/CB-14211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547580#comment-16547580 ] ASF GitHub Bot commented on CB-14211: - oliversalzburg commented on issue #627: CB-14211: Run test suite in PowerShell and cmd.exe URL: https://github.com/apache/cordova-lib/pull/627#issuecomment-405864248 @brodybits Nice find. So right after we decide that it's probably not worth running all NodeJS versions on both shells, we see failures with one specific version in one specific shell. That somewhat contradicts the decision to scale down the test matrix, doesn't it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Windows/AppVeyor test suite in both PowerShell and Command Prompt > - > > Key: CB-14211 > URL: https://issues.apache.org/jira/browse/CB-14211 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-lib >Reporter: Oliver Salzburg >Priority: Major > > I thought it could be useful to run the test suite in both shells, just to be > safe. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
