[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564723#comment-16564723
 ] 

ASF GitHub Bot commented on CB-14238:
-

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409447930
 
 
   I do not know why travis build failed for safari browser.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564710#comment-16564710
 ] 

ASF GitHub Bot commented on CB-14238:
-

brodybits commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409443946
 
 
   A couple minor points FYI:
   - First line should generally be within 50 characters. If you need more then 
you should add a blank line then keep remaining lines within 70 characters. 
This is very well documented, for example: 
. AFAICT we generally take care of 
this formatting issue if needed.
   - Unless there is good reason to keep multiple original commits we will very 
likely do a "squash merge", which means that the master branch would actually 
diverge from your proposed `android-persistent-transparency` branch.
   
   Thanks for the contribution, I am sure it will help others in the future.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564704#comment-16564704
 ] 

ASF GitHub Bot commented on CB-14238:
-

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409442707
 
 
   @brodybits thanks. I've pushed clean one commit with name changed.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564700#comment-16564700
 ] 

ASF GitHub Bot commented on CB-14238:
-

brodybits commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409441677
 
 
   @aszmyd it should be fine to update by force push (we do this kind of thing 
all the time). Alternative solution which I think is not necessary is to simply 
open a new PR. Even fancier is to open a new PR with text like "resolves #99" 
or "closes #99" in the description 
().
   
   As an aside you may want to maintain your own special fork version until we 
get a chance to deal with this one. Maybe something like 
"cordova-plugin-statusbar-transparent" or "cordova-plugin-persistent-statusbar"?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564690#comment-16564690
 ] 

ASF GitHub Bot commented on CB-14238:
-

aszmyd commented on issue #99: CB-14238: Make transparency of statusbar 
persistent when hiding and showing statusbar
URL: 
https://github.com/apache/cordova-plugin-statusbar/pull/99#issuecomment-409440198
 
 
   @janpio I've created JIRA issue: 
https://issues.apache.org/jira/browse/CB-14238 and renamed PR name and 
description. Not sure if i should also rename commit name and force git push? 
It could confuse others that already pulled this branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Statusbar transparency does not persist when hiding and showing the statusbar
> -
>
> Key: CB-14238
> URL: https://issues.apache.org/jira/browse/CB-14238
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-statusbar
> Environment: Android
>Reporter: Adam Szmyd
>Priority: Minor
>  Labels: android, easyfix, transparency
>
> When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
> {{show()}} the status bar gets shown without transparency and pushes webview 
> to bottom. And because at start statusbar gets transparent (overlaysWebView) 
> from this point the show/hide should toggle the statusbar visibility and it 
> should always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14224) template/Properties/Default.rd.xml needs license header

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564688#comment-16564688
 ] 

ASF GitHub Bot commented on CB-14224:
-

brodybits closed pull request #284: CB-14224 Default.rd.xml header fixes
URL: https://github.com/apache/cordova-windows/pull/284
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/template/Properties/Default.rd.xml 
b/template/Properties/Default.rd.xml
index 7c40ffeb..3b46199c 100644
--- a/template/Properties/Default.rd.xml
+++ b/template/Properties/Default.rd.xml
@@ -13,6 +13,31 @@
 
 Using the Namespace directive to apply reflection policy to all the types 
in a particular namespace
 
+
+The MIT License (MIT)
+
+Copyright (c) Microsoft Corporation
+
+Permission is hereby granted, free of charge, to any person obtaining a 
copy
+of this software and associated documentation files (the "Software"), to 
deal
+in the Software without restriction, including without limitation the 
rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING 
FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+
+Source:
+
https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml
 -->
 
 http://schemas.microsoft.com/netfx/2013/01/metadata;>


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> template/Properties/Default.rd.xml needs license header
> ---
>
> Key: CB-14224
> URL: https://issues.apache.org/jira/browse/CB-14224
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Minor
>
> Running {{coho audit-license-headers -r windows}} gives a message that 
> {{template/Properties/Default.rd.xml}} is missing the license header. From a 
> quick search I found {{Default.rd.xml}} in [Microsoft / 
> Windows-universal-samples / SharedContent / cs / Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
>  which is exactly the same except for a {{http}} link that was updated to 
> {{https}} _(update: old {{http}} link in GitHub, no need to update this 
> one)_. I would like to propose the following changes:
>  * -Updated {{https}} link from [Microsoft / Windows-universal-samples / 
> SharedContent / cs / Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]-
>  * Include license text from [Microsoft / Windows-universal-samples / LICENSE 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
>  (with left alignment fixed)
>  * Link to [Microsoft / Windows-universal-samples / SharedContent / cs / 
> Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
>  in {{template/Properties/Default.rd.xml}}
> _Additional notes:_
> - _{{template/Properties/Default.rd.xml}} was introduced in CB-12499._
> - _I raised 
> [Microsoft/Windows-universal-samples#949|https://github.com/Microsoft/Windows-universal-samples/pull/949]
>  to cleanup (and rename) its LICENSE file. This may influence the exact 
> LICENSE text we should include in {{template/Properties/Default.rd.xml}}._
> - _Another fix to {{template/Properties/Default.rd.xml}} is proposed in 
> CB-14225_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: 

[jira] [Commented] (CB-14224) template/Properties/Default.rd.xml needs license header

2018-07-31 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564689#comment-16564689
 ] 

ASF subversion and git services commented on CB-14224:
--

Commit 6572801c0f8cc4b0dcb474f1fdf406a8267ca9d6 in cordova-windows's branch 
refs/heads/master from [~brodybits]
[ https://gitbox.apache.org/repos/asf?p=cordova-windows.git;h=6572801 ]

CB-14224 Default.rd.xml header fixes (#284)

* add license text
* add GitHub link


> template/Properties/Default.rd.xml needs license header
> ---
>
> Key: CB-14224
> URL: https://issues.apache.org/jira/browse/CB-14224
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Minor
>
> Running {{coho audit-license-headers -r windows}} gives a message that 
> {{template/Properties/Default.rd.xml}} is missing the license header. From a 
> quick search I found {{Default.rd.xml}} in [Microsoft / 
> Windows-universal-samples / SharedContent / cs / Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
>  which is exactly the same except for a {{http}} link that was updated to 
> {{https}} _(update: old {{http}} link in GitHub, no need to update this 
> one)_. I would like to propose the following changes:
>  * -Updated {{https}} link from [Microsoft / Windows-universal-samples / 
> SharedContent / cs / Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]-
>  * Include license text from [Microsoft / Windows-universal-samples / LICENSE 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
>  (with left alignment fixed)
>  * Link to [Microsoft / Windows-universal-samples / SharedContent / cs / 
> Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
>  in {{template/Properties/Default.rd.xml}}
> _Additional notes:_
> - _{{template/Properties/Default.rd.xml}} was introduced in CB-12499._
> - _I raised 
> [Microsoft/Windows-universal-samples#949|https://github.com/Microsoft/Windows-universal-samples/pull/949]
>  to cleanup (and rename) its LICENSE file. This may influence the exact 
> LICENSE text we should include in {{template/Properties/Default.rd.xml}}._
> - _Another fix to {{template/Properties/Default.rd.xml}} is proposed in 
> CB-14225_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14224) template/Properties/Default.rd.xml needs license header

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564687#comment-16564687
 ] 

ASF GitHub Bot commented on CB-14224:
-

brodybits commented on issue #284: CB-14224 Default.rd.xml header fixes
URL: https://github.com/apache/cordova-windows/pull/284#issuecomment-409439861
 
 
   As this change is already part of 6.0.x (GH-285) it should now be in master. 
Title and description have been updated.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> template/Properties/Default.rd.xml needs license header
> ---
>
> Key: CB-14224
> URL: https://issues.apache.org/jira/browse/CB-14224
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-windows
>Reporter: Chris Brody
>Assignee: Chris Brody
>Priority: Minor
>
> Running {{coho audit-license-headers -r windows}} gives a message that 
> {{template/Properties/Default.rd.xml}} is missing the license header. From a 
> quick search I found {{Default.rd.xml}} in [Microsoft / 
> Windows-universal-samples / SharedContent / cs / Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
>  which is exactly the same except for a {{http}} link that was updated to 
> {{https}} _(update: old {{http}} link in GitHub, no need to update this 
> one)_. I would like to propose the following changes:
>  * -Updated {{https}} link from [Microsoft / Windows-universal-samples / 
> SharedContent / cs / Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]-
>  * Include license text from [Microsoft / Windows-universal-samples / LICENSE 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/LICENSE]
>  (with left alignment fixed)
>  * Link to [Microsoft / Windows-universal-samples / SharedContent / cs / 
> Default.rd.xml 
> (github)|https://github.com/Microsoft/Windows-universal-samples/blob/master/SharedContent/cs/Default.rd.xml]
>  in {{template/Properties/Default.rd.xml}}
> _Additional notes:_
> - _{{template/Properties/Default.rd.xml}} was introduced in CB-12499._
> - _I raised 
> [Microsoft/Windows-universal-samples#949|https://github.com/Microsoft/Windows-universal-samples/pull/949]
>  to cleanup (and rename) its LICENSE file. This may influence the exact 
> LICENSE text we should include in {{template/Properties/Default.rd.xml}}._
> - _Another fix to {{template/Properties/Default.rd.xml}} is proposed in 
> CB-14225_



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564682#comment-16564682
 ] 

ASF GitHub Bot commented on CB-14192:
-

dpogue commented on issue #378: CB-14192: (ios) Add project settings to 
explicitly use legacy build s…
URL: https://github.com/apache/cordova-ios/pull/378#issuecomment-409438779
 
 
   @shazron @sebastiangrail Do we have any idea what would be involved in 
making it compatible with the new build system? Is it likely that the new build 
system would cause problems for plugins or CocoaPods?
   
   Generally I'm in favour of keeping working configurations working, but this 
is Apple and they like to deprecate things and add new requirements to App 
Store submissions and I have little trust in them to not drop the legacy build 
system in a point release of Xcode. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova iOS doesn't build with Xcode 10
> ---
>
> Key: CB-14192
> URL: https://issues.apache.org/jira/browse/CB-14192
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Sebastian Grail
>Priority: Minor
>
> Xcode 10 uses the new build system by default. Any project not explicitly 
> choosing the legacy build system will build with new system. Currently, 
> Cordova iOS fails to build with the new system. The simplest solution is to 
> explicitly use the legacy build system.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-14238) Statusbar transparency does not persist when hiding and showing the statusbar

2018-07-31 Thread Adam Szmyd (JIRA)
Adam Szmyd created CB-14238:
---

 Summary: Statusbar transparency does not persist when hiding and 
showing the statusbar
 Key: CB-14238
 URL: https://issues.apache.org/jira/browse/CB-14238
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-statusbar
 Environment: Android
Reporter: Adam Szmyd


When you call methods in this order: {{overlaysWebView(true)}} , {{hide()}} , 
{{show()}} the status bar gets shown without transparency and pushes webview to 
bottom. And because at start statusbar gets transparent (overlaysWebView) from 
this point the show/hide should toggle the statusbar visibility and it should 
always show transparent.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14192) Cordova iOS doesn't build with Xcode 10

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564678#comment-16564678
 ] 

ASF GitHub Bot commented on CB-14192:
-

brodybits opened a new pull request #862: [CB-14192] Xcode 10 issue notice
URL: https://github.com/apache/cordova-docs/pull/862
 
 
   
   
   ### Platforms affected
   
   iOS
   
   ### What does this PR do?
   
   Add notice about problem with Xcode 10 ref:
   - apache/cordova-ios#378
   - 
   
   I have not yet confirmed this myself, review is requested.
   
   ### What testing has been done on this change?
   
   TODO
   
   ### Checklist
   
   - [ ] TODO: Commit message follows the format: "GH-3232: (android) Fix bug 
with resolving file paths", where GH- is the GitHub issue ID & "android" is 
the platform affected.
   - ~~Added automated test coverage as appropriate for this change.~~


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cordova iOS doesn't build with Xcode 10
> ---
>
> Key: CB-14192
> URL: https://issues.apache.org/jira/browse/CB-14192
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Sebastian Grail
>Priority: Minor
>
> Xcode 10 uses the new build system by default. Any project not explicitly 
> choosing the legacy build system will build with new system. Currently, 
> Cordova iOS fails to build with the new system. The simplest solution is to 
> explicitly use the legacy build system.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564520#comment-16564520
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409405089
 
 
   I pulled the changes from 

 (master branch) into my master branch, doesn't seem to help on either Android 
or iOS. Gotta say I am getting ready to give up on this one. I just pushed one 
more change to 
 to use your 
`q-m:feature/allowedschemes-ios` branch for now, it would be great if you could 
fix the sample for the sake of the user community.
   
   If you want another expert to take a look I suggest you send a request to: 



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564358#comment-16564358
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on a change in pull request #274: CB-14187: (ios) Change 
the InAppBrowser to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#discussion_r206679000
 
 

 ##
 File path: tests/tests.js
 ##
 @@ -693,4 +698,29 @@ exports.defineManualTests = function (contentEl, 
createActionButton) {
 });
 });
 }, 'openHardwareBackDefaultAfterNo');
+
+// Customscheme
+createActionButton('customscheme', function () {
+var ref = cordova.InAppBrowser.open('about:blank', '_blank', 
'hidden=yes');
+var openedCustomscheme = false;
+ref.addEventListener('loadstop', function (e) {
+// Avoid showing the alert twice on iOS, since loadstop is also 
being called after the customscheme event.
+if (!openedCustomscheme) {
+openedCustomscheme = true;
+ref.executeScript({ code: 
'window.location.replace("custom://test");' });
+}
+});
+ref.addEventListener('customscheme', function (e) {
+if (e && e.url === "custom://test") {
 
 Review comment:
   I just discovered today that `npm run eslint` has a few failures:
   
   ```
   /Users/brodybits/Documents/cordova/cordova-plugin-inappbrowser/tests/tests.js
 714:32  error  Strings must use singlequotequotes
 715:1   error  Expected indentation of 16 spaces but found 14  indent
 715:15  error  'alert' is not defined  no-undef
 717:1   error  Expected indentation of 16 spaces but found 14  indent
 717:15  error  'alert' is not defined  no-undef
 722:13  error  'alert' is not defined  no-undef
   
   ✖ 6 problems (6 errors, 0 warnings)
 3 errors, 0 warnings potentially fixable with the `--fix` option.
   ```
   
   I can think of 2 possible solutions for `'alert' is not defined`:
   - use `// eslint-disable-line no-undef`
   - preferred: use `window.alert` (less ugly, more likely to work on Windows 
platform)
   
   A nice bonus would be to fix `alert` --> `window.alert` throughout 
`tests.js`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Reopened] (CB-13254) node 4 with cordova-cli causes platform add issues

2018-07-31 Thread Chris Brody (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody reopened CB-13254:
--
  Assignee: Chris Brody

I will check this when I make upcoming Cordova CLI patch for CB-14145

> node 4 with cordova-cli causes platform add issues
> --
>
> Key: CB-13254
> URL: https://issues.apache.org/jira/browse/CB-13254
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-cli
>Reporter: Shazron Abdullah
>Assignee: Chris Brody
>Priority: Major
>  Labels: tools-next
>
> From [~jcesarmobile] in dev@:
> {code}
> I'm trying to do cordova platform add
> https://github.com/apache/cordova-ios#4.5.0 and getting this error
> Using CLI 7.0.1:
> cordova platform add https://github.com/apache/cordova-ios#4.5.0
> Using cordova-fetch for https://github.com/apache/cordova-ios#4.5.0
> Adding ios project...
>  Using this version of Cordova with older version of cordova-ios is
> deprecated. Upgrade to cordova-ios@4.0.0 or newer.
> Error: Your ios platform does not have Api.js
> Using nightly CLI:
> cordova platform add https://github.com/apache/cordova-ios#4.5.0
> Warning: using prerelease version 7.0.2-nightly.2017.9.7.596da5df
> (cordova-lib@7.0.2-nightly.2017.9.7.6f5be6a7)
> Using cordova-fetch for https://github.com/apache/cordova-ios#4.5.0
> Adding ios project...
> Unable to load PlatformApi from platform. Error: Cannot find module 'unorm'
> Error: Uncaught, unspecified "error" event. (The platform "ios" does not
> appear to be a valid cordova platform. It is missing API.js. ios not
> supported.)
> node -v
> v4.4.7
> npm -v
> 2.15.8
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Resolved] (CB-14126) cordova-ios does not build with node 10.4.0

2018-07-31 Thread Chris Brody (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody resolved CB-14126.
--
   Resolution: Fixed
Fix Version/s: 4.5.5

This issue should be solved on very recent cordova-ios@4.5.5 release. Since 
this is not yet part of Cordova CLI it should be possible to obtain the right 
version as follows:

{code}
cordova platform rm ios
# and verify that no artifacts of ios platform remain
cordova platform add ios@4
 {code}

> cordova-ios does not build with node 10.4.0
> ---
>
> Key: CB-14126
> URL: https://issues.apache.org/jira/browse/CB-14126
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: 8.0.0, 7.1.0
> Environment: macOS 10.13.5
> Xcode 9.4
> Homebrew 1.6.7-72
> Node 10.4.0
>Reporter: Ronald Ligteringen
>Assignee: Chris Brody
>Priority: Blocker
>  Labels: PhaseScriptExecution, cordova, cordova-ios, ios, node
> Fix For: 4.5.5
>
>
> The latest version of Node hangs the building process of cordova-ios during 
> the PhaseScriptExecution. Furthermore with this version of Node in Cordova 
> 8.0 the command
> cordova requirements
> fails during execution
> FIX: These problems do not arise when using Node 8.11.2 (LTS) instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Assigned] (CB-14126) cordova-ios does not build with node 10.4.0

2018-07-31 Thread Chris Brody (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Brody reassigned CB-14126:


Assignee: Chris Brody

> cordova-ios does not build with node 10.4.0
> ---
>
> Key: CB-14126
> URL: https://issues.apache.org/jira/browse/CB-14126
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: 8.0.0, 7.1.0
> Environment: macOS 10.13.5
> Xcode 9.4
> Homebrew 1.6.7-72
> Node 10.4.0
>Reporter: Ronald Ligteringen
>Assignee: Chris Brody
>Priority: Blocker
>  Labels: PhaseScriptExecution, cordova, cordova-ios, ios, node
>
> The latest version of Node hangs the building process of cordova-ios during 
> the PhaseScriptExecution. Furthermore with this version of Node in Cordova 
> 8.0 the command
> cordova requirements
> fails during execution
> FIX: These problems do not arise when using Node 8.11.2 (LTS) instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-14227) cordova build ios does not create ipa file

2018-07-31 Thread Alexey (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alexey closed CB-14227.
---
Resolution: Fixed

> cordova build ios does not create ipa file
> --
>
> Key: CB-14227
> URL: https://issues.apache.org/jira/browse/CB-14227
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Alexey
>Priority: Major
>
> $ npm run cordova platform add ios
>  $ cat Build.json
> {code}
> {
>   "ios": {
>        "debug":{      
>         "codeSignIdentity": "iPhone Developer",      
> "developmentTeam": "**",      
> "packageType": "development",      
> "automaticProvisioning": true,      
>         "buildFlag": [        
>              "EMBEDDED_CONTENT_CONTAINS_SWIFT = YES",          
>  "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO"      
>         ]    
>  },
>     "release" {      
>         "codeSignIdentity": "iPhone Developer",      
>         "developmentTeam": "",      
>         "packageType": "app-store",      
>         "automaticProvisioning": true,        
>         "buildFlag": [            
>             "EMBEDDED_CONTENT_CONTAINS_SWIFT = YES",            
> "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO"        
>       ]    
>     }
>      }
>  }
> {code}
> $ npm run cordova build ios --release --device
> Build log looks good for me - 
> [https://gist.github.com/melezhik/62c652f2b6736d13182b6c8d6981251d]
> However there is no ips files:
> $ find . type f -name "*.ipa" | wc -l
>  0
> Xcode version is 9.4
> cordova-ios@^4.5.4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14227) cordova build ios does not create ipa file

2018-07-31 Thread Alexey (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564140#comment-16564140
 ] 

Alexey commented on CB-14227:
-

the answer is here - 
https://stackoverflow.com/questions/51564372/cordova-build-ios-does-not-create-ipa-file#51619875

> cordova build ios does not create ipa file
> --
>
> Key: CB-14227
> URL: https://issues.apache.org/jira/browse/CB-14227
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Reporter: Alexey
>Priority: Major
>
> $ npm run cordova platform add ios
>  $ cat Build.json
> {code}
> {
>   "ios": {
>        "debug":{      
>         "codeSignIdentity": "iPhone Developer",      
> "developmentTeam": "**",      
> "packageType": "development",      
> "automaticProvisioning": true,      
>         "buildFlag": [        
>              "EMBEDDED_CONTENT_CONTAINS_SWIFT = YES",          
>  "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO"      
>         ]    
>  },
>     "release" {      
>         "codeSignIdentity": "iPhone Developer",      
>         "developmentTeam": "",      
>         "packageType": "app-store",      
>         "automaticProvisioning": true,        
>         "buildFlag": [            
>             "EMBEDDED_CONTENT_CONTAINS_SWIFT = YES",            
> "ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES=NO"        
>       ]    
>     }
>      }
>  }
> {code}
> $ npm run cordova build ios --release --device
> Build log looks good for me - 
> [https://gist.github.com/melezhik/62c652f2b6736d13182b6c8d6981251d]
> However there is no ips files:
> $ find . type f -name "*.ipa" | wc -l
>  0
> Xcode version is 9.4
> cordova-ios@^4.5.4



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14074) Remove Node 4 from CI - cordova-ios

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564083#comment-16564083
 ] 

ASF GitHub Bot commented on CB-14074:
-

brodybits commented on issue #375: CB-14074 ios: Remove Node 4 from CI
URL: https://github.com/apache/cordova-ios/pull/375#issuecomment-409314306
 
 
   I like this in general. As I said elsewhere 
() I 
would favor dropping Node.js 4, removing the committed node_modules, and 
increasing the package version to 5.0.0-dev all at the same time, will ask for 
agreement on the mailing list.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Remove Node 4 from CI - cordova-ios
> ---
>
> Key: CB-14074
> URL: https://issues.apache.org/jira/browse/CB-14074
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-ios
>Reporter: Darryl Pogue
>Assignee: Darryl Pogue
>Priority: Minor
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14234) InAppBrowser iOS calls handleOpenURL in same app for _system URLs

2018-07-31 Thread Dan Polivy (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563833#comment-16563833
 ] 

Dan Polivy commented on CB-14234:
-

[~jcesarmobile]: I can't differentiate the URL in handleOpenURL, because it 
*could* be a legitimate URL the app can handle, but in *this case* I want it to 
open in the system browser, not the app. It's weird to me that the syntax of 
window.open(url, "_system") would even attempt to open in the app – by 
specifying the target as "_system" that's a pretty explicit statement you want 
it to open in the system browser.

For my purposes, not sending handleOpenURL for http/https should address this, 
as we do check the incoming URL to validate it before handling it. Other 
schemes (aside from our custom scheme which launches the app) should be ignored.

I'm curious, though, under what scenario is it expected to call handleOpenURL 
on the app when trying to open a URL (http/https or otherwise) in the system?

> InAppBrowser iOS calls handleOpenURL in same app for _system URLs
> -
>
> Key: CB-14234
> URL: https://issues.apache.org/jira/browse/CB-14234
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: Dan Polivy
>Priority: Minor
>
> The change to fix CB-11178 has caused some undesirable behavior with 
> InAppBrowser on iOS. Now, whenever you try to open a URL in the system 
> browser, by calling `cordova.InAppBrowser.open(url, "_system")`, it opens the 
> system browser AND calls `handleOpenURL` _in your app_ with the same URL.
> In my case, my app is a URL handler for a corresponding web domain (app 
> links). I am trying to open a page on this web domain in the system browser 
> from within my app. If my app's handleOpenURL is called with a URL also on 
> the domain, then my handler thinks it is handling an app link and it causes 
> the app to navigate to another URL, which in this case is not desired or 
> expected.
> Prior to the fix for CB-11178, this worked perfectly. Is there any other way 
> to address the fix for CB-11178 without inheriting this incorrect and 
> undesirable behavior?
> [~jcesarmobile]: FYI as you committed the fix in question.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14237) 10.4.6 405 Method Not Allowed in the InApp Browser plugin

2018-07-31 Thread Clark Light (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563765#comment-16563765
 ] 

Clark Light commented on CB-14237:
--

Whenever i hit that endpoint, it works for the first request, then if i call 
that endpoint again, it gives that error again.

> 10.4.6 405 Method Not Allowed in the InApp Browser plugin
> -
>
> Key: CB-14237
> URL: https://issues.apache.org/jira/browse/CB-14237
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 6.3.0, 6.4.0, 6.5.0
> Environment: I am using Phonegap 6.5, Android 7.1.1 Latest version of 
> In App Browser from NPM.
> Samsung C8 phone.
>Reporter: Clark Light
>Priority: Major
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> I just used the In App browser latest version in NPM to open some websites 
> and it returned me this error, and can not proceed to open the site.
> I am testing on UPS website, and i am simply clicking on a button to link me 
> to another page, and it showed that error, i am having a feeling maybe its 
> shouldnt be using POST or GET something along those line. But i am not sure 
> how to test it out.
>  
> Hypertext Transfer Protocol -- HTTP/1.1
> 10.4.6 405 Method Not Allowed
> The method specified in the Request-Line is not allowed for the resource 
> identified by the Request-URI. The response MUST include an Allow header 
> containing a list of valid methods for the requested resource.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Reopened] (CB-14237) 10.4.6 405 Method Not Allowed in the InApp Browser plugin

2018-07-31 Thread Clark Light (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clark Light reopened CB-14237:
--

> 10.4.6 405 Method Not Allowed in the InApp Browser plugin
> -
>
> Key: CB-14237
> URL: https://issues.apache.org/jira/browse/CB-14237
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 6.3.0, 6.4.0, 6.5.0
> Environment: I am using Phonegap 6.5, Android 7.1.1 Latest version of 
> In App Browser from NPM.
> Samsung C8 phone.
>Reporter: Clark Light
>Priority: Major
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> I just used the In App browser latest version in NPM to open some websites 
> and it returned me this error, and can not proceed to open the site.
> I am testing on UPS website, and i am simply clicking on a button to link me 
> to another page, and it showed that error, i am having a feeling maybe its 
> shouldnt be using POST or GET something along those line. But i am not sure 
> how to test it out.
>  
> Hypertext Transfer Protocol -- HTTP/1.1
> 10.4.6 405 Method Not Allowed
> The method specified in the Request-Line is not allowed for the resource 
> identified by the Request-URI. The response MUST include an Allow header 
> containing a list of valid methods for the requested resource.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-14237) 10.4.6 405 Method Not Allowed in the InApp Browser plugin

2018-07-31 Thread Clark Light (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clark Light closed CB-14237.

Resolution: REMIND

The issues seems to have disappeared for the time being.

> 10.4.6 405 Method Not Allowed in the InApp Browser plugin
> -
>
> Key: CB-14237
> URL: https://issues.apache.org/jira/browse/CB-14237
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 6.3.0, 6.4.0, 6.5.0
> Environment: I am using Phonegap 6.5, Android 7.1.1 Latest version of 
> In App Browser from NPM.
> Samsung C8 phone.
>Reporter: Clark Light
>Priority: Major
>   Original Estimate: 3h
>  Remaining Estimate: 3h
>
> I just used the In App browser latest version in NPM to open some websites 
> and it returned me this error, and can not proceed to open the site.
> I am testing on UPS website, and i am simply clicking on a button to link me 
> to another page, and it showed that error, i am having a feeling maybe its 
> shouldnt be using POST or GET something along those line. But i am not sure 
> how to test it out.
>  
> Hypertext Transfer Protocol -- HTTP/1.1
> 10.4.6 405 Method Not Allowed
> The method specified in the Request-Line is not allowed for the resource 
> identified by the Request-URI. The response MUST include an Allow header 
> containing a list of valid methods for the requested resource.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14236) navigator.languages only returns a single language on iOS

2018-07-31 Thread jcesarmobile (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563760#comment-16563760
 ] 

jcesarmobile commented on CB-14236:
---

Ah, sorry, as the issue was about cordova-ios I didn't know what Chrome had to 
do with it.

Cordova just uses the WebView component, that it's sort of the rendering 
engine. In Android 4.4-6 it's based in Chromium, in Android 7+ is a component 
provided by Chrome app, but it's not the whole Chrome app. It doesn't have 
access to the settings or any other feature Chrome has. So if Chrome as app 
allows to set languages and override the OS ones, it's only available for the 
Chrome app, not for the apps using the WebView. They share a part of the code, 
but not all of it.



> navigator.languages only returns a single language on iOS 
> --
>
> Key: CB-14236
> URL: https://issues.apache.org/jira/browse/CB-14236
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0, cordova-ios 4.5.0
>Reporter: Daniel Wolf
>Priority: Major
>
> Most operating systems allow the user to specify not only a single OS locale, 
> but a list of prefered locales. On both Android and Windows UWP, 
> `navigator.languages` returns the full list of prefered languages. On iOS, 
> however, only the first language of the list is returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14236) navigator.languages only returns a single language on iOS

2018-07-31 Thread Daniel Wolf (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563731#comment-16563731
 ] 

Daniel Wolf commented on CB-14236:
--

There's probably some misconception on my side.

I understand that on Android, Cordova uses Chrome as its webview. That is, the 
same code that functions as a standalone browser (Chrome) is also used as an 
embedded browser within Cordova.

When I run Chrome as a standalone app, JavaScript code within that app that 
accesses `navigator.languages` gets the list of preferred languages the user 
configured in the Chrome settings, not the list the user configured in the 
Android settings.

When I run Cordova on Android, it is my understanding that this JavaScript code 
is also executed within Chrome. But this time, code that accesses 
`navigator.languages` gets the list of preferred languages the user configured 
in the Android settings, not the list the user configured in the Chrome 
settings.

So my question is: If the standalone Chrome browser and the embedded webview 
share the same code, how does that code know which languages to use?

> navigator.languages only returns a single language on iOS 
> --
>
> Key: CB-14236
> URL: https://issues.apache.org/jira/browse/CB-14236
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0, cordova-ios 4.5.0
>Reporter: Daniel Wolf
>Priority: Major
>
> Most operating systems allow the user to specify not only a single OS locale, 
> but a list of prefered locales. On both Android and Windows UWP, 
> `navigator.languages` returns the full list of prefered languages. On iOS, 
> however, only the first language of the list is returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-14237) 10.4.6 405 Method Not Allowed in the InApp Browser plugin

2018-07-31 Thread Clark Light (JIRA)
Clark Light created CB-14237:


 Summary: 10.4.6 405 Method Not Allowed in the InApp Browser plugin
 Key: CB-14237
 URL: https://issues.apache.org/jira/browse/CB-14237
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-plugin-inappbrowser
Affects Versions: 6.3.0, 6.4.0, 6.5.0
 Environment: I am using Phonegap 6.5, Android 7.1.1 Latest version of 
In App Browser from NPM.

Samsung C8 phone.
Reporter: Clark Light


I just used the In App browser latest version in NPM to open some websites and 
it returned me this error, and can not proceed to open the site.

I am testing on UPS website, and i am simply clicking on a button to link me to 
another page, and it showed that error, i am having a feeling maybe its 
shouldnt be using POST or GET something along those line. But i am not sure how 
to test it out.

 
Hypertext Transfer Protocol -- HTTP/1.1
10.4.6 405 Method Not Allowed
The method specified in the Request-Line is not allowed for the resource 
identified by the Request-URI. The response MUST include an Allow header 
containing a list of valid methods for the requested resource.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14236) navigator.languages only returns a single language on iOS

2018-07-31 Thread jcesarmobile (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563675#comment-16563675
 ] 

jcesarmobile commented on CB-14236:
---

I don't really understand what you mean by "But when used as a webview within 
Cordova, Chrome returns the OS settings instead of the browser settings."

> navigator.languages only returns a single language on iOS 
> --
>
> Key: CB-14236
> URL: https://issues.apache.org/jira/browse/CB-14236
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0, cordova-ios 4.5.0
>Reporter: Daniel Wolf
>Priority: Major
>
> Most operating systems allow the user to specify not only a single OS locale, 
> but a list of prefered locales. On both Android and Windows UWP, 
> `navigator.languages` returns the full list of prefered languages. On iOS, 
> however, only the first language of the list is returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563676#comment-16563676
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser 
to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992
 
 
   It took me some experimentation to find the cause, but the page you load in 
the whitelist (local page), it is loaded in the Cordova WebView instead of 
InAppBrowser. Make it `cordova.InAppBrowser.open('iabpage.html', '_blank')` and 
the example should work.
   
   Some small corrections in: 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/5917542781efd220745dca3172489ff38f0b95a7
 (should work without) and 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/821652d41c22347eb50cb61ff97dba5a2b5abc0e
 (makes link work).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563673#comment-16563673
 ] 

ASF GitHub Bot commented on CB-14187:
-

brodybits commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409222786
 
 
   Thanks @wvengen I will take another look today.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563668#comment-16563668
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen edited a comment on issue #274: CB-14187: (ios) Change the InAppBrowser 
to allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992
 
 
   It took me some experimentation to find the cause, but since the page you 
load in the whitelist (local page), it is loaded in the Cordova WebView instead 
of InAppBrowser. Make it `cordova.InAppBrowser.open('iabpage.html', '_blank')` 
and the example should work.
   
   Some small corrections in: 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/5917542781efd220745dca3172489ff38f0b95a7
 (should work without) and 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/821652d41c22347eb50cb61ff97dba5a2b5abc0e
 (makes link work).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14236) navigator.languages only returns a single language on iOS

2018-07-31 Thread Daniel Wolf (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563670#comment-16563670
 ] 

Daniel Wolf commented on CB-14236:
--

Thanks for the information, [~jcesarmobile]. There's one thing I don't 
understand, though: Most browsers (inclusing Chrome) have their own language 
options, where the user can set preferred languages independently from the OS 
settings. Normally, reading `navigator.languages` on these browsers returns the 
browser settings, _not_ the OS settings. But when used as a webview within 
Cordova, Chrome returns the OS settings instead of the browser settings.

So how do these browsers know whether to return the browser settings or the OS 
settings? Does Cordova tell them?

> navigator.languages only returns a single language on iOS 
> --
>
> Key: CB-14236
> URL: https://issues.apache.org/jira/browse/CB-14236
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0, cordova-ios 4.5.0
>Reporter: Daniel Wolf
>Priority: Major
>
> Most operating systems allow the user to specify not only a single OS locale, 
> but a list of prefered locales. On both Android and Windows UWP, 
> `navigator.languages` returns the full list of prefered languages. On iOS, 
> however, only the first language of the list is returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14187) cordova-plugin-inappbrowser AllowedSchemes for iOS

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563667#comment-16563667
 ] 

ASF GitHub Bot commented on CB-14187:
-

wvengen commented on issue #274: CB-14187: (ios) Change the InAppBrowser to 
allow custom schemes
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/274#issuecomment-409220992
 
 
   It took me some experimentation to find the cause, but since the page you 
load is local, it is loaded in the Cordova WebView instead of InAppBrowser. 
Make it `cordova.InAppBrowser.open('iabpage.html', '_blank')` and the example 
should work.
   
   Some small corrections in: 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/5917542781efd220745dca3172489ff38f0b95a7
 (should work without) and 
https://github.com/wvengen/cordova-iab-custom-scheme-test-wip/commit/821652d41c22347eb50cb61ff97dba5a2b5abc0e
 (makes link work).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-plugin-inappbrowser AllowedSchemes for iOS
> --
>
> Key: CB-14187
> URL: https://issues.apache.org/jira/browse/CB-14187
> Project: Apache Cordova
>  Issue Type: New Feature
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: wvengen
>Priority: Major
>
> CB-14013 add support for custom url schemes with the AllowedSchemes 
> preference. This only works on Android, however. It would be very useful to 
> have this on iOS (and other platforms) as well.
> A pull request for iOS will follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-13580) cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true

2018-07-31 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-13580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563565#comment-16563565
 ] 

ASF GitHub Bot commented on CB-13580:
-

349989153 commented on issue #417: CB-13580: (android) fix build for multiple 
apks (different product flavors)
URL: https://github.com/apache/cordova-android/pull/417#issuecomment-409200904
 
 
   @Ankoul Maybe you wanna try this:
   
https://stackoverflow.com/questions/47413647/ionic-android-build-error-all-flavors-must-now-belong-to-a-named-flavor-dimen


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> cordova-android 6.4.0 broke build if cdvBuildMultipleApks is set to true
> 
>
> Key: CB-13580
> URL: https://issues.apache.org/jira/browse/CB-13580
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-android
>Affects Versions: 6.4.0
>Reporter: David Strauß
>Assignee: Joe Bowser
>Priority: Major
>  Labels: build
>
> With the latest cordova-android (6.4.0) builds for different product flavors 
> (arm, x86) do not work anymore (error e.g.: "No flavor is associated with 
> flavor dimension ...")  because of the changes introduced with gradle 3.0.0. 
> With the new gradle plugin a flavorDimenson must be specified to build 
> different product flavors (mentioned 
> [here|https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration.html?utm_source=android-studio#flavor_dimensions]
>  in the upgrade guide. This can be fixed by adding `flavorDimensions 
> "default"` to build.gradle if cdvBuildMultipleApks is set to true.
> Another change that was introduced with the new gradle version is that builds 
> for different architectures are put into their own directory 
> (build/outputs/apk//) which results in APK files not 
> being found (mentioned in the upgrade guide under the point "Modifying 
> variant outputs at build time may not work").
> This can be fixed by adapting the findOutputApksHelper method in 
> GenericBuilder.js.
> An unfortunate side effect of these issues is that projects leveraging 
> crosswalk do not work anymore.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-14234) InAppBrowser iOS calls handleOpenURL in same app for _system URLs

2018-07-31 Thread jcesarmobile (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563523#comment-16563523
 ] 

jcesarmobile commented on CB-14234:
---

Sorry, but Critical for you doesn't mean Critical for the project.

You can probably check on handleOpenURL if the url is internal or not.

The plugin can probably be changed to only send the handleOpenURL event when 
it's not http or https url, would that help to your project?

> InAppBrowser iOS calls handleOpenURL in same app for _system URLs
> -
>
> Key: CB-14234
> URL: https://issues.apache.org/jira/browse/CB-14234
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: Dan Polivy
>Priority: Minor
>
> The change to fix CB-11178 has caused some undesirable behavior with 
> InAppBrowser on iOS. Now, whenever you try to open a URL in the system 
> browser, by calling `cordova.InAppBrowser.open(url, "_system")`, it opens the 
> system browser AND calls `handleOpenURL` _in your app_ with the same URL.
> In my case, my app is a URL handler for a corresponding web domain (app 
> links). I am trying to open a page on this web domain in the system browser 
> from within my app. If my app's handleOpenURL is called with a URL also on 
> the domain, then my handler thinks it is handling an app link and it causes 
> the app to navigate to another URL, which in this case is not desired or 
> expected.
> Prior to the fix for CB-11178, this worked perfectly. Is there any other way 
> to address the fix for CB-11178 without inheriting this incorrect and 
> undesirable behavior?
> [~jcesarmobile]: FYI as you committed the fix in question.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Updated] (CB-14234) InAppBrowser iOS calls handleOpenURL in same app for _system URLs

2018-07-31 Thread jcesarmobile (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile updated CB-14234:
--
Priority: Minor  (was: Critical)

> InAppBrowser iOS calls handleOpenURL in same app for _system URLs
> -
>
> Key: CB-14234
> URL: https://issues.apache.org/jira/browse/CB-14234
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-inappbrowser
>Affects Versions: 3.0.0
>Reporter: Dan Polivy
>Priority: Minor
>
> The change to fix CB-11178 has caused some undesirable behavior with 
> InAppBrowser on iOS. Now, whenever you try to open a URL in the system 
> browser, by calling `cordova.InAppBrowser.open(url, "_system")`, it opens the 
> system browser AND calls `handleOpenURL` _in your app_ with the same URL.
> In my case, my app is a URL handler for a corresponding web domain (app 
> links). I am trying to open a page on this web domain in the system browser 
> from within my app. If my app's handleOpenURL is called with a URL also on 
> the domain, then my handler thinks it is handling an app link and it causes 
> the app to navigate to another URL, which in this case is not desired or 
> expected.
> Prior to the fix for CB-11178, this worked perfectly. Is there any other way 
> to address the fix for CB-11178 without inheriting this incorrect and 
> undesirable behavior?
> [~jcesarmobile]: FYI as you committed the fix in question.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-14236) navigator.languages only returns a single language on iOS

2018-07-31 Thread jcesarmobile (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-14236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-14236.
-
Resolution: Not A Problem

navigator.languages is handled by the webview, not by Cordova.
Try reporting it to Apple.

> navigator.languages only returns a single language on iOS 
> --
>
> Key: CB-14236
> URL: https://issues.apache.org/jira/browse/CB-14236
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-ios
>Affects Versions: cordova@7.0.0, cordova-ios 4.5.0
>Reporter: Daniel Wolf
>Priority: Major
>
> Most operating systems allow the user to specify not only a single OS locale, 
> but a list of prefered locales. On both Android and Windows UWP, 
> `navigator.languages` returns the full list of prefered languages. On iOS, 
> however, only the first language of the list is returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-12959) Conflict between camera and media capture plugin

2018-07-31 Thread jcesarmobile (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-12959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-12959.
-
Resolution: Fixed

The plugins were updated to not add any value, and they can be added with the 
edit-config tag in the config.xml, closing

> Conflict between camera and media capture plugin
> 
>
> Key: CB-12959
> URL: https://issues.apache.org/jira/browse/CB-12959
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera, cordova-plugin-media-capture
>Reporter: Connor Pearson
>Priority: Minor
>
> We recently had a build fail the itunes upload due to 
> NSCameraUsageDescription not being set. It was caused by the newer version of 
> the media-capture plugin defining NSCameraUsageDescription and 
> NSPhotoLibraryUsageDescriptionentry with an empty string and blowing away the 
> value set by the camera plugin variables.
> The workaround is pretty simple: just set the same variables for both 
> plugins, but I would expect core plugins to work nicely with each other. Is 
> it necessary for the plugins to control these parameters? Could one define 
> these values in config.xml instead of relying on the plugins?
> Also, if an empty string is no longer valid for app submission should it be 
> added by default?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-12971) Iphone 6s images not getting clicked

2018-07-31 Thread jcesarmobile (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-12971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-12971.
-
Resolution: Cannot Reproduce

I can't reproduce this.

Feel free to reopen if you can still reproduce with latest version of the 
plugin, but make sure you provide more information, like the code used, cordova 
version, etc

> Iphone 6s images not getting clicked
> 
>
> Key: CB-12971
> URL: https://issues.apache.org/jira/browse/CB-12971
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: ameya shukla
>Priority: Major
>
>  The images are not getting clicked and showing random behavior.Sometimes it 
> will click and sometimes it won't click i.e. sometimes the imageData will 
> come sometimes it won't come. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-13255) Android Camera photo Crop bug

2018-07-31 Thread jcesarmobile (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13255.
-
Resolution: Won't Fix

allowEdit is buggy on Android, it's mentioned on the docs and we recommend not 
using it as it's unpredictable how the other app is going to handle the editing.
Closing as won't fix as we can't really do anything about it.

> Android Camera photo  Crop bug
> --
>
> Key: CB-13255
> URL: https://issues.apache.org/jira/browse/CB-13255
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera
>Reporter: Yash Rad
>Priority: Major
> Attachments: Screen Shot 2017-09-08 at 15.34.18.png
>
>
> I'm experiencing this on Android devices after taking a photo:
> Preview of the photo is shown correctly,[^attachment-name.zip]
> When you are asked to pick a program for cropping "only once", the image is 
> lost.
> Only after choosing "always" for the default cropping app , from the next 
> time you take the photos it works.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Closed] (CB-13450) Cordova camera plugin not supported for Android Nougat

2018-07-31 Thread jcesarmobile (JIRA)


 [ 
https://issues.apache.org/jira/browse/CB-13450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jcesarmobile closed CB-13450.
-
Resolution: Cannot Reproduce

This is probably fixed, old versions of the plugin didn't support Android N, 
but current version supports it, so make sure you are using latest version. I 
couldn't reproduce.

> Cordova camera plugin not supported for Android Nougat 
> ---
>
> Key: CB-13450
> URL: https://issues.apache.org/jira/browse/CB-13450
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: cordova-plugin-camera, Ionic
>Affects Versions: cordova@7.0.0
>Reporter: Kavish Peiris
>Priority: Critical
>
> Ionic app crashes when an image is captured using camera plugin in Android 
> Nougat



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-14236) navigator.languages only returns a single language on iOS

2018-07-31 Thread Daniel Wolf (JIRA)
Daniel Wolf created CB-14236:


 Summary: navigator.languages only returns a single language on iOS 
 Key: CB-14236
 URL: https://issues.apache.org/jira/browse/CB-14236
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-ios
Affects Versions: cordova-ios 4.5.0, cordova@7.0.0
Reporter: Daniel Wolf


Most operating systems allow the user to specify not only a single OS locale, 
but a list of prefered locales. On both Android and Windows UWP, 
`navigator.languages` returns the full list of prefered languages. On iOS, 
however, only the first language of the list is returned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Created] (CB-14235) [iOS] Focus styles stops applying on text-input element after clicking 'done' on keyboard

2018-07-31 Thread Andrey Mazurevich (JIRA)
Andrey Mazurevich created CB-14235:
--

 Summary: [iOS] Focus styles stops applying on text-input element 
after clicking 'done' on keyboard
 Key: CB-14235
 URL: https://issues.apache.org/jira/browse/CB-14235
 Project: Apache Cordova
  Issue Type: Bug
  Components: cordova-ios
Affects Versions: 8.0.0
Reporter: Andrey Mazurevich


I've just created hello-world test app and added a bunch of text inputs with

```:focus \{ border: 1px solid red } ``` style. Styles works fine until I press 
'done' button on the keyboard. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org