[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653117#comment-16653117
 ] 

ASF GitHub Bot commented on CB-7179:


knight commented on a change in pull request #271: CB-7179 (iOS): Add 
WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#discussion_r225806705
 
 

 ##
 File path: tests/plugin.xml
 ##
 @@ -29,5 +29,12 @@
 
 
 
+
+  
+  
+  https://github.com/knight/cordova-plugin-wkwebview-engine-allowfileaccess.git;
 />
 
 Review comment:
   I have published my plugin 
https://www.npmjs.com/package/cordova-plugin-wkwebview-engine-allowfileaccess . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653063#comment-16653063
 ] 

ASF GitHub Bot commented on CB-7179:


dpa99c commented on issue #271: CB-7179 (iOS): Add WKWebView support for iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-430508737
 
 
   @purplecabbage great, thanks for unblocking this. I will be on standby to 
help resolve any issues with the new implementation. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653016#comment-16653016
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 10a06691f94a5ccc76957c48887469aedd4c2e13 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=10a0669 
]

Merge pull request #271 from dpa99c/CB-7179

CB-7179 (iOS): Add WKWebView support for iOS

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653013#comment-16653013
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 3927b8f2fee8e168bb19de93031b2f930b542b24 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3927b8f 
]

Merge branch 'CB-7179' of 
https://github.com/dpa99c/cordova-plugin-themeablebrowser into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653011#comment-16653011
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 5d2df218d83bdaae79ca953799ad8d30cf9f2ce9 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5d2df21 
]

Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser 
into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653017#comment-16653017
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 10a06691f94a5ccc76957c48887469aedd4c2e13 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~purplecabbage]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=10a0669 
]

Merge pull request #271 from dpa99c/CB-7179

CB-7179 (iOS): Add WKWebView support for iOS

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653010#comment-16653010
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 5d2df218d83bdaae79ca953799ad8d30cf9f2ce9 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=5d2df21 
]

Merge branch 'CB-7179' of https://github.com/dpa99c/cordova-plugin-inappbrowser 
into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653015#comment-16653015
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 3927b8f2fee8e168bb19de93031b2f930b542b24 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=3927b8f 
]

Merge branch 'CB-7179' of 
https://github.com/dpa99c/cordova-plugin-themeablebrowser into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653007#comment-16653007
 ] 

ASF GitHub Bot commented on CB-7179:


purplecabbage commented on issue #271: CB-7179 (iOS): Add WKWebView support for 
iOS
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/271#issuecomment-430501417
 
 
   Every other way of doing this is messy and involves crazy git rebasing, so I 
am gonna just merge this as is, and see if I can address my concern about the 
test dependency in another pr.
   Thanks for all you work on this @dpa99c !!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653012#comment-16653012
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit 19c6dfe1971818789a4b3e83f6f4b0793e401597 in 
cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c]
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=19c6dfe 
]

Merge branch 'master' into CB-7179


> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org



[jira] [Commented] (CB-7179) [InAppBrowser][iOS 8] Update to support WKWebView

2018-10-17 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/CB-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653009#comment-16653009
 ] 

ASF subversion and git services commented on CB-7179:
-

Commit cbfa195f7da3b8307a468c3f50f38de25f38bd8e in 
cordova-plugin-inappbrowser's branch refs/heads/master from Jan Piotrowski
[ 
https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=cbfa195 
]

Merge branch 'master' into CB-7179

> [InAppBrowser][iOS 8] Update to support WKWebView
> -
>
> Key: CB-7179
> URL: https://issues.apache.org/jira/browse/CB-7179
> Project: Apache Cordova
>  Issue Type: Sub-task
>  Components: cordova-plugin-inappbrowser
> Environment: iOS 8
>Reporter: Shazron Abdullah
>Priority: Major
>
> support dual use with UIWebView



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org