[jira] [Closed] (CB-8722) Android should move icons to res/mipmap-* rather than drawable
[ https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Nennker closed CB-8722. Resolution: Fixed does not work with cordova-android@6.0.0 Works with master > Android should move icons to res/mipmap-* rather than drawable > -- > > Key: CB-8722 > URL: https://issues.apache.org/jira/browse/CB-8722 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Andrew Grieve >Priority: Minor > > Refer to: http://developer.android.com/tools/projects/index.html#mipmap -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8722) Android should move icons to res/mipmap-* rather than drawable
[ https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15646947#comment-15646947 ] Axel Nennker commented on CB-8722: -- Retried with cordova platform add https://github.com/apache/cordoave-android That works > Android should move icons to res/mipmap-* rather than drawable > -- > > Key: CB-8722 > URL: https://issues.apache.org/jira/browse/CB-8722 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Andrew Grieve >Priority: Minor > > Refer to: http://developer.android.com/tools/projects/index.html#mipmap -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Reopened] (CB-8722) Android should move icons to res/mipmap-* rather than drawable
[ https://issues.apache.org/jira/browse/CB-8722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Nennker reopened CB-8722: -- Does not work with a single default icon on Android. Steps to reproduce: - create hello project - copy some icon.png next to config.xml - add to config.xml - cordova build android - cordova run android What's wrong: launcher icon is default cordova icon Expected: launcher icon is icon.png The icon handling code in cordova-android@6.0.0 prepare.js should delete all the default icons. ps: There is icon handling code in cordova-lib android_parser.js too - remove that? > Android should move icons to res/mipmap-* rather than drawable > -- > > Key: CB-8722 > URL: https://issues.apache.org/jira/browse/CB-8722 > Project: Apache Cordova > Issue Type: Bug > Components: Android, CordovaLib >Reporter: Andrew Grieve >Priority: Minor > > Refer to: http://developer.android.com/tools/projects/index.html#mipmap -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7482) Add browser support for camera plugin
[ https://issues.apache.org/jira/browse/CB-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14369279#comment-14369279 ] Axel Nennker commented on CB-7482: -- plugin.xml now has a platform=browser section. https://github.com/apache/cordova-plugin-camera/blob/master/plugin.xml It seems that this bug could have been closed since August 30, 2014 https://github.com/apache/cordova-plugin-camera/commit/b2403c607652d2db21d778b39102e57652f813a8 But maybe this is still WIP? In my app the video element opens somewhere in the current page and is partially hidden by the footer. I think the video element or its parent should have a very high z-index and be centered on the page. Axel Add browser support for camera plugin - Key: CB-7482 URL: https://issues.apache.org/jira/browse/CB-7482 Project: Apache Cordova Issue Type: New Feature Components: Plugin Camera Reporter: Suraj Pindoria Assignee: Suraj Pindoria -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8448) Add support for activities field in FirefoxOS manifest.webapp
[
https://issues.apache.org/jira/browse/CB-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14348404#comment-14348404
]
Axel Nennker commented on CB-8448:
--
Although PR #172 was merged I would like to keep this issue open because #172
was only a first step.
#172 implements what I need in one project but does not add full support for
activities in a Cordoba app's manifest.webapp.
Add support for activities field in FirefoxOS manifest.webapp
---
Key: CB-8448
URL: https://issues.apache.org/jira/browse/CB-8448
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
FirefoxOS manifest files allow a richer set of fields than currently
supported by firefoxos_parser.js
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js
E.g.: activities
https://developer.mozilla.org/de/Apps/Manifest#activities
This is needed to e.g. open files of a defined mime type.
Extend syntax of plugin.xml like e.g.:
platform name=firefoxos
config-file target=config.xml parent=/*
activities
activity name=open href=./import.html
disposition=inline
filter type=application/wallet-import /
/activity
/activities
/config-file
/platform
This results e.g. in
activities: {
open: {
href: ./import.html,
disposition: inline,
filters: {
type: application/wallet-import
}
}
},
Lines needed for this in firefoxos_parser.js:
var activitiesNodes = config.doc.findall('activities');
activitiesNodes.forEach(function(activitiesNode) {
var activityNodes = activitiesNode.findall('activity');
if (activityNodes.length) {
var activities = {};
activityNodes.forEach(function (node) {
var name = node.attrib.name;
var href = node.attrib.href;
if (name href) {
events.emit('verbose', 'activity name='+name+'
href='+href);
activities[name] = {};
activities[name].href = href;
var disposition = node.attrib.disposition;
if (disposition) {
activities[name].disposition = disposition;
}
activities[name].filters = {};
var filterNodes = node.findall('filter');
filterNodes.forEach(function(filter) {
var type = filter.attrib.type;
if (type) {
activities[name].filters.type = type;
}
});
} else {
events.emit('warn', 'activity without name='+name+'or
href='+href);
}
});
manifest.activities = activities;
}
});
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8448) Add support for activities field in FirefoxOS manifest.webapp
[
https://issues.apache.org/jira/browse/CB-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333582#comment-14333582
]
Axel Nennker commented on CB-8448:
--
New PR based on today's apache/cordova-lib
https://github.com/apache/cordova-lib/pull/172
Add support for activities field in FirefoxOS manifest.webapp
---
Key: CB-8448
URL: https://issues.apache.org/jira/browse/CB-8448
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
FirefoxOS manifest files allow a richer set of fields than currently
supported by firefoxos_parser.js
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js
E.g.: activities
https://developer.mozilla.org/de/Apps/Manifest#activities
This is needed to e.g. open files of a defined mime type.
Extend syntax of plugin.xml like e.g.:
platform name=firefoxos
config-file target=config.xml parent=/*
activities
activity name=open href=./import.html
disposition=inline
filter type=application/wallet-import /
/activity
/activities
/config-file
/platform
This results e.g. in
activities: {
open: {
href: ./import.html,
disposition: inline,
filters: {
type: application/wallet-import
}
}
},
Lines needed for this in firefoxos_parser.js:
var activitiesNodes = config.doc.findall('activities');
activitiesNodes.forEach(function(activitiesNode) {
var activityNodes = activitiesNode.findall('activity');
if (activityNodes.length) {
var activities = {};
activityNodes.forEach(function (node) {
var name = node.attrib.name;
var href = node.attrib.href;
if (name href) {
events.emit('verbose', 'activity name='+name+'
href='+href);
activities[name] = {};
activities[name].href = href;
var disposition = node.attrib.disposition;
if (disposition) {
activities[name].disposition = disposition;
}
activities[name].filters = {};
var filterNodes = node.findall('filter');
filterNodes.forEach(function(filter) {
var type = filter.attrib.type;
if (type) {
activities[name].filters.type = type;
}
});
} else {
events.emit('warn', 'activity without name='+name+'or
href='+href);
}
});
manifest.activities = activities;
}
});
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8448) Add support for activities field in FirefoxOS manifest.webapp
[
https://issues.apache.org/jira/browse/CB-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14333581#comment-14333581
]
Axel Nennker commented on CB-8448:
--
New PR based on today's apache/cordova-lib
https://github.com/apache/cordova-lib/pull/172
Add support for activities field in FirefoxOS manifest.webapp
---
Key: CB-8448
URL: https://issues.apache.org/jira/browse/CB-8448
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
FirefoxOS manifest files allow a richer set of fields than currently
supported by firefoxos_parser.js
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js
E.g.: activities
https://developer.mozilla.org/de/Apps/Manifest#activities
This is needed to e.g. open files of a defined mime type.
Extend syntax of plugin.xml like e.g.:
platform name=firefoxos
config-file target=config.xml parent=/*
activities
activity name=open href=./import.html
disposition=inline
filter type=application/wallet-import /
/activity
/activities
/config-file
/platform
This results e.g. in
activities: {
open: {
href: ./import.html,
disposition: inline,
filters: {
type: application/wallet-import
}
}
},
Lines needed for this in firefoxos_parser.js:
var activitiesNodes = config.doc.findall('activities');
activitiesNodes.forEach(function(activitiesNode) {
var activityNodes = activitiesNode.findall('activity');
if (activityNodes.length) {
var activities = {};
activityNodes.forEach(function (node) {
var name = node.attrib.name;
var href = node.attrib.href;
if (name href) {
events.emit('verbose', 'activity name='+name+'
href='+href);
activities[name] = {};
activities[name].href = href;
var disposition = node.attrib.disposition;
if (disposition) {
activities[name].disposition = disposition;
}
activities[name].filters = {};
var filterNodes = node.findall('filter');
filterNodes.forEach(function(filter) {
var type = filter.attrib.type;
if (type) {
activities[name].filters.type = type;
}
});
} else {
events.emit('warn', 'activity without name='+name+'or
href='+href);
}
});
manifest.activities = activities;
}
});
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8461) Help Cordova app detect a plugin's support for a platform
Axel Nennker created CB-8461: Summary: Help Cordova app detect a plugin's support for a platform Key: CB-8461 URL: https://issues.apache.org/jira/browse/CB-8461 Project: Apache Cordova Issue Type: Improvement Components: CLI, Plugman Reporter: Axel Nennker As per this email exchange implement Andrew Grieve's strawman: http://mail-archives.apache.org/mod_mbox/cordova-dev/201502.mbox/%3CCAHcDwFxL%3DoxntHXET4m5RZi62J1J9K6oayg_BL9pgJ-%2BK-BKFw%40mail.gmail.com%3E Strawman: If plugin.xml has *any* platforms, then only apply global tags to those platforms. If plugin.xml has *no* platforms, then apply global tags to all platforms. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8448) Add support for activities field in FirefoxOS manifest.webapp
Axel Nennker created CB-8448:
Summary: Add support for activities field in FirefoxOS
manifest.webapp
Key: CB-8448
URL: https://issues.apache.org/jira/browse/CB-8448
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Axel Nennker
FirefoxOS manifest files allow a richer set of fields than currently supported
by firefoxos_parser.js
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/firefoxos_parser.js
E.g.: activities
https://developer.mozilla.org/de/Apps/Manifest#activities
This is needed to e.g. open files of a defined mime type.
Extend syntax of plugin.xml like e.g.:
platform name=firefoxos
config-file target=config.xml parent=/*
activities
activity name=open href=./import.html disposition=inline
filter type=application/wallet-import /
/activity
/activities
/config-file
/platform
This results e.g. in
activities: {
open: {
href: ./import.html,
disposition: inline,
filters: {
type: application/wallet-import
}
}
},
Lines needed for this in firefoxos_parser.js:
var activitiesNodes = config.doc.findall('activities');
activitiesNodes.forEach(function(activitiesNode) {
var activityNodes = activitiesNode.findall('activity');
if (activityNodes.length) {
var activities = {};
activityNodes.forEach(function (node) {
var name = node.attrib.name;
var href = node.attrib.href;
if (name href) {
events.emit('verbose', 'activity name='+name+'
href='+href);
activities[name] = {};
activities[name].href = href;
var disposition = node.attrib.disposition;
if (disposition) {
activities[name].disposition = disposition;
}
activities[name].filters = {};
var filterNodes = node.findall('filter');
filterNodes.forEach(function(filter) {
var type = filter.attrib.type;
if (type) {
activities[name].filters.type = type;
}
});
} else {
events.emit('warn', 'activity without name='+name+'or
href='+href);
}
});
manifest.activities = activities;
}
});
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8364) InAppBrowser reports two errors in the console.
[
https://issues.apache.org/jira/browse/CB-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293200#comment-14293200
]
Axel Nennker commented on CB-8364:
--
I get the same warnings and no errors.
Nevertheless when I add if (!lastName) continue; to cordova.js my app works
again.
The difference between works and not-working is that not-working means:
The app does not react to any touch event. So it is unusable.
-Axel
W/HSV@MWC ( 2098): [JavaScript Warning: Empty string passed to
getElementById(). {file: app://twe.gaiamobile.org/cordova.js line: 1175}]
W/HSV@MWC ( 2098): [JavaScript Warning: Empty string passed to
getElementById(). {file: app://twe.gaiamobile.org/cordova.js line: 466}]
I can't work on this today.
InAppBrowser reports two errors in the console.
---
Key: CB-8364
URL: https://issues.apache.org/jira/browse/CB-8364
Project: Apache Cordova
Issue Type: Bug
Components: FirefoxOS
Reporter: Piotr Zalewa
Assignee: Piotr Zalewa
From Axel Nennker's (telekom.de) email:
The firefoxos version of the app reports two errors in the console log.
Cordova.js:466 getElementByID called with empty id (or similar)
Cordova.js:1171 - -
In line 1171 this is cause by lastName being null.
https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L1171
The value of moduleName at that time is InAppBrowserProxy.
I fixed this by inserting in line 1172:
If (!lastName) continue;
In line 466 key is null or undefined.
https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L466
I have no idea why this happens on FirefoxOS but not on the other platforms.
My current guess is that
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L203
does not get digested on FirefoxOS as on the other platforms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-8364) InAppBrowser reports two errors in the console.
[ https://issues.apache.org/jira/browse/CB-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14293235#comment-14293235 ] Axel Nennker commented on CB-8364: -- My app has several buttons button with attached event listeners. document.getElementById(button1).addEventListener(click, startInAppBrowser, false); These buttons stopped working when I added the inappbrowser plugin. InAppBrowser reports two errors in the console. --- Key: CB-8364 URL: https://issues.apache.org/jira/browse/CB-8364 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Piotr Zalewa Assignee: Piotr Zalewa From Axel Nennker's (telekom.de) email: The firefoxos version of the app reports two errors in the console log. Cordova.js:466 getElementByID called with empty id (or similar) Cordova.js:1171 - - In line 1171 this is cause by lastName being null. https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L1171 The value of moduleName at that time is InAppBrowserProxy. I fixed this by inserting in line 1172: If (!lastName) continue; In line 466 key is null or undefined. https://github.com/apache/cordova-firefoxos/blob/master/cordova-lib/cordova.js#L466 I have no idea why this happens on FirefoxOS but not on the other platforms. My current guess is that https://github.com/apache/cordova-plugin-inappbrowser/blob/master/plugin.xml#L203 does not get digested on FirefoxOS as on the other platforms. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-8184) inappbrowser on firefoxos uses deprecated commandproxy
Axel Nennker created CB-8184: Summary: inappbrowser on firefoxos uses deprecated commandproxy Key: CB-8184 URL: https://issues.apache.org/jira/browse/CB-8184 Project: Apache Cordova Issue Type: Improvement Components: FirefoxOS, Plugin InAppBrowser Reporter: Axel Nennker This line https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/firefoxos/InAppBrowserProxy.js#L191 requires 'cordova/exec/proxy' which leads to a warning in the console log: Please require 'cordova/exec/proxy' instead. The file firefoxos/InAppBrowserProxy.js should be changed to get rid of the warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-8184) inappbrowser on firefoxos uses deprecated commandproxy
[ https://issues.apache.org/jira/browse/CB-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Nennker closed CB-8184. Resolution: Fixed Oops. I looked at an older version of the plugin. The issue is already fixed. Sorry. inappbrowser on firefoxos uses deprecated commandproxy -- Key: CB-8184 URL: https://issues.apache.org/jira/browse/CB-8184 Project: Apache Cordova Issue Type: Improvement Components: FirefoxOS, Plugin InAppBrowser Reporter: Axel Nennker Labels: easyfix This line https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/firefoxos/InAppBrowserProxy.js#L191 requires 'cordova/exec/proxy' which leads to a warning in the console log: Please require 'cordova/exec/proxy' instead. The file firefoxos/InAppBrowserProxy.js should be changed to get rid of the warning. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-7310) Add Promises Polyfill to cordova.js
[ https://issues.apache.org/jira/browse/CB-7310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099916#comment-14099916 ] Axel Nennker commented on CB-7310: -- (i) Already some Cordova plugins create a dependency on e.g. jquery to use jquery's Deferred type to get Promises-like behavior. https://github.com/oauth-io/oauth-phonegap/blob/master/www/dist/oauth.js Those plugins could get rid of this dependency if Cordova provides Promises in cordova.js Add Promises Polyfill to cordova.js --- Key: CB-7310 URL: https://issues.apache.org/jira/browse/CB-7310 Project: Apache Cordova Issue Type: New Feature Components: CordovaJS Environment: core Reporter: Axel Nennker Newer W3C standards use Promises and by providing Promises in core Cordova would help implementers of these standards in Cordova a lot. http://www.html5rocks.com/en/tutorials/es6/promises/ This feature does not mean that Cordova advocates for or against Promises. By providing Promises on platforms that do not provide them natively Cordova just helps to implement standards cross platform. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (CB-7310) Add Promises Polyfill to cordova.js
Axel Nennker created CB-7310: Summary: Add Promises Polyfill to cordova.js Key: CB-7310 URL: https://issues.apache.org/jira/browse/CB-7310 Project: Apache Cordova Issue Type: New Feature Components: CordovaJS Environment: core Reporter: Axel Nennker Newer W3C standards use Promises and by providing Promises in core Cordova would help implementers of these standards in Cordova a lot. http://www.html5rocks.com/en/tutorials/es6/promises/ This feature does not mean that Cordova advocates for or against Promises. By providing Promises on platforms that do not provide them natively Cordova just helps to implement standards cross platform. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-3571) Add support for splash elements in config.xml
[
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061208#comment-14061208
]
Axel Nennker commented on CB-3571:
--
New version of PR is here:
https://github.com/AxelNennker/cordova-docs/commit/b7683a79fa3658125f42b234508de68924b25175
Add support for splash elements in config.xml
---
Key: CB-3571
URL: https://issues.apache.org/jira/browse/CB-3571
Project: Apache Cordova
Issue Type: Wish
Components: CLI
Affects Versions: Master
Reporter: Michael Brooks
Assignee: Lorin Beer
Similar to adding support for the {{icon}} element, we should add support
for the splash screen.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Assigned] (CB-7132) Single default icon overridden by Cordova icon on Android
[ https://issues.apache.org/jira/browse/CB-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Nennker reassigned CB-7132: Assignee: Axel Nennker Single default icon overridden by Cordova icon on Android -- Key: CB-7132 URL: https://issues.apache.org/jira/browse/CB-7132 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Affects Versions: 3.5.0 Reporter: Bryan Higgins Assignee: Axel Nennker Behaviour has changed between 3.5.0-0.2.4 and 3.5.0-0.2.6 resulting in the single default icon [1] not being displayed on device. In 3.5.0-0.2.4 the icon was copied into drawable-* In 3.5.0-0.2.6 the icon is copied to drawable/ The template [2] already contains default icons for drawable-*, thus the single default icon is never used. [1] http://cordova.apache.org/docs/en/3.5.0/config_ref_images.md.html [2] https://github.com/apache/cordova-android/tree/master/bin/templates/project/res -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-7132) Single default icon overridden by Cordova icon on Android
[ https://issues.apache.org/jira/browse/CB-7132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061299#comment-14061299 ] Axel Nennker commented on CB-7132: -- This should fix it. https://github.com/apache/cordova-lib/pull/58 -Axel Single default icon overridden by Cordova icon on Android -- Key: CB-7132 URL: https://issues.apache.org/jira/browse/CB-7132 Project: Apache Cordova Issue Type: Bug Components: Android, CLI Affects Versions: 3.5.0 Reporter: Bryan Higgins Assignee: Axel Nennker Behaviour has changed between 3.5.0-0.2.4 and 3.5.0-0.2.6 resulting in the single default icon [1] not being displayed on device. In 3.5.0-0.2.4 the icon was copied into drawable-* In 3.5.0-0.2.6 the icon is copied to drawable/ The template [2] already contains default icons for drawable-*, thus the single default icon is never used. [1] http://cordova.apache.org/docs/en/3.5.0/config_ref_images.md.html [2] https://github.com/apache/cordova-android/tree/master/bin/templates/project/res -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-2606) Add support for icon elements in config.xml
[
https://issues.apache.org/jira/browse/CB-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14054637#comment-14054637
]
Axel Nennker commented on CB-2606:
--
Could you please add icon related output from cordova platform add
blackberry10 -d as a comment here?
There should be some output from this line:
https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cordova/metadata/blackberry10_parser.js#L86
Does the version of blackberry10_parser.js on your machine look like the one in
the link above?
I am wondering where the /tmp/qqr/img comes from; or is this /tmp/qqr ==
new_directory?
-Axel
Looking at your config.xml:
This looks like you have two default icons which are the same, right? Because
rim:hover is ignored by cordova
blackberry10_parser.js could be improved here to prevent the double copying.
Add support for icon elements in config.xml
-
Key: CB-2606
URL: https://issues.apache.org/jira/browse/CB-2606
Project: Apache Cordova
Issue Type: Wish
Components: Docs
Reporter: Filip Maj
Assignee: Mark Koudritsky
This feature would add support for specifying the application icon by
changing values inside the {{config.xml}} document.
Relevant details for Cordova:
- {{icon}} elements _may_ have {{width}} and {{height}} attributes
representing the preferred size of the icon in CSS pixels.
- {{icon}} elements _must_ have a {{src}} attribute, which contains a path
string relative to the {{www/}} folder (or equivalent) in the platform.
See [the Widget Spec's section on
icons|http://www.w3.org/TR/widgets/#the-icon-element-and-its-attributes] for
specifics.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-3571) Add support for splash elements in config.xml
[
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037159#comment-14037159
]
Axel Nennker commented on CB-3571:
--
Is it true that the tests for ConfigParser are never run?
I added a test for getIcons to ConfigParser.spec.js that is never called.
Axel
ignisvulpis@ubuntu:/host/Cordova/cordova-lib$ find . -name ConfigP\*
./cordova-lib/src/configparser/ConfigParser.js
./cordova-lib/src/configparser/ConfigParser.spec.js
ignisvulpis@ubuntu:/host/Cordova/cordova-lib$
Add support for splash elements in config.xml
---
Key: CB-3571
URL: https://issues.apache.org/jira/browse/CB-3571
Project: Apache Cordova
Issue Type: Wish
Components: CLI
Affects Versions: Master
Reporter: Michael Brooks
Assignee: Mark Koudritsky
Similar to adding support for the {{icon}} element, we should add support
for the splash screen.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-3571) Add support for splash elements in config.xml
[
https://issues.apache.org/jira/browse/CB-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037933#comment-14037933
]
Axel Nennker commented on CB-3571:
--
Changed the indentation from 2 to 4 spaces although I prefer Mozilla's 2 space
guideline.
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#Indentation
Where would a shared function live or would the fireos_parser do a:
require('./android_parser').handleLauncherIcons(config);
Add support for splash elements in config.xml
---
Key: CB-3571
URL: https://issues.apache.org/jira/browse/CB-3571
Project: Apache Cordova
Issue Type: Wish
Components: CLI
Affects Versions: Master
Reporter: Michael Brooks
Assignee: Lorin Beer
Similar to adding support for the {{icon}} element, we should add support
for the splash screen.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (CB-2606) Add support for icon elements in config.xml
[
https://issues.apache.org/jira/browse/CB-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032224#comment-14032224
]
Axel Nennker commented on CB-2606:
--
Why is this issue reopened or still open? It is resolved in 3.5.
Add support for icon elements in config.xml
-
Key: CB-2606
URL: https://issues.apache.org/jira/browse/CB-2606
Project: Apache Cordova
Issue Type: Wish
Components: Docs
Reporter: Filip Maj
Assignee: Mark Koudritsky
This feature would add support for specifying the application icon by
changing values inside the {{config.xml}} document.
Relevant details for Cordova:
- {{icon}} elements _may_ have {{width}} and {{height}} attributes
representing the preferred size of the icon in CSS pixels.
- {{icon}} elements _must_ have a {{src}} attribute, which contains a path
string relative to the {{www/}} folder (or equivalent) in the platform.
See [the Widget Spec's section on
icons|http://www.w3.org/TR/widgets/#the-icon-element-and-its-attributes] for
specifics.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-6777) window.requestFileSystem(LocalFileSystem.TEMPORARY returns /
Axel Nennker created CB-6777:
Summary: window.requestFileSystem(LocalFileSystem.TEMPORARY
returns /
Key: CB-6777
URL: https://issues.apache.org/jira/browse/CB-6777
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 3.5.0
Reporter: Axel Nennker
In the code below I get a
java.io.FileNotFoundException: /tmpfile.tmp: open failed: EROFS (Read-only file
system)
because the request for a temporary filesystem returns /.
60 window.requestFileSystem(LocalFileSystem.TEMPORARY, 0,
function(fs){
61 for (var p in fs.root) {
62 Framework.util.LogUtil.i(this.$className, 'getImport() fs.root['+p+'] ='
+ fs.root[p]);-
63 }
64 fs.root.getFile(tmpfile.tmp, {create: true, exclusive:
false},
65 function(entry){
66 var fileTransfer = new FileTransfer();
67 fileTransfer.download(
68 aFile,
69 entry.fullPath,
70 function(entry) {
71 console.log(download complete: +
entry.fullPath);
72 aSuccess(entry);
73 },
74 function(error) {
75 console.log(error source + error.source);
76 console.log(error target + error.target);
77 console.log(error code + error.code);
78 aFail(error);
79 },
80 false,
81 {
82 headers: {
83 'Content-Type': 'application/json'
84 }
85 }
86 );
87 }, function(error){
88 Framework.util.LogUtil.e(this.$className, 'getImport()
download error =' + error);-
89 aFail(error);
90 });
91 }, null);
92
93 },
I/Web Console(22297): [I] :: getImport() fs.root[isFile] =false:37
I/Web Console(22297): [I] :: getImport() fs.root[isDirectory] =true:37
I/Web Console(22297): [I] :: getImport() fs.root[name] =:37
I/Web Console(22297): [I] :: getImport() fs.root[fullPath] =/:37
I/Web Console(22297): [I] :: getImport() fs.root[filesystem] =[object
Object]:37
I/Web Console(22297): [I] :: getImport() fs.root[nativeURL] =null:37
This happened after I updated the file and the file-transfer plugins in my
project. It worked with the old versions (about one year older).
Not sure what the temporary filesystem should be on Android but / is wrong.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (CB-6777) window.requestFileSystem(LocalFileSystem.TEMPORARY returns /
[
https://issues.apache.org/jira/browse/CB-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Axel Nennker updated CB-6777:
-
Description:
In the code below I get a
java.io.FileNotFoundException: /tmpfile.tmp: open failed: EROFS (Read-only file
system)
because the request for a temporary filesystem returns /.
{code}
60 window.requestFileSystem(LocalFileSystem.TEMPORARY, 0,
function(fs){
61 for (var p in fs.root) {
62 Framework.util.LogUtil.i(this.$className, 'getImport() fs.root['+p+'] =' +
fs.root[p]);-
63 }
64 fs.root.getFile(tmpfile.tmp, {create: true, exclusive:
false},
65 function(entry){
66 var fileTransfer = new FileTransfer();
67 fileTransfer.download(
68 aFile,
69 entry.fullPath,
70 function(entry) {
71 console.log(download complete: +
entry.fullPath);
72 aSuccess(entry);
73 },
74 function(error) {
75 console.log(error source + error.source);
76 console.log(error target + error.target);
77 console.log(error code + error.code);
78 aFail(error);
79 },
80 false,
81 {
82 headers: {
83 'Content-Type': 'application/json'
84 }
85 }
86 );
87 }, function(error){
88 Framework.util.LogUtil.e(this.$className, 'getImport()
download error =' + error);-
89 aFail(error);
90 });
91 }, null);
92
93 },
{code}
I/Web Console(22297): [I] :: getImport() fs.root[isFile] =false:37
I/Web Console(22297): [I] :: getImport() fs.root[isDirectory] =true:37
I/Web Console(22297): [I] :: getImport() fs.root[name] =:37
I/Web Console(22297): [I] :: getImport() fs.root[fullPath] =/:37
I/Web Console(22297): [I] :: getImport() fs.root[filesystem] =[object
Object]:37
I/Web Console(22297): [I] :: getImport() fs.root[nativeURL] =null:37
This happened after I updated the file and the file-transfer plugins in my
project. It worked with the old versions (about one year older).
Not sure what the temporary filesystem should be on Android but / is wrong.
was:
In the code below I get a
java.io.FileNotFoundException: /tmpfile.tmp: open failed: EROFS (Read-only file
system)
because the request for a temporary filesystem returns /.
60 window.requestFileSystem(LocalFileSystem.TEMPORARY, 0,
function(fs){
61 for (var p in fs.root) {
62 Framework.util.LogUtil.i(this.$className, 'getImport() fs.root['+p+'] ='
+ fs.root[p]);-
63 }
64 fs.root.getFile(tmpfile.tmp, {create: true, exclusive:
false},
65 function(entry){
66 var fileTransfer = new FileTransfer();
67 fileTransfer.download(
68 aFile,
69 entry.fullPath,
70 function(entry) {
71 console.log(download complete: +
entry.fullPath);
72 aSuccess(entry);
73 },
74 function(error) {
75 console.log(error source + error.source);
76 console.log(error target + error.target);
77 console.log(error code + error.code);
78 aFail(error);
79 },
80 false,
81 {
82 headers: {
83 'Content-Type': 'application/json'
84 }
85 }
86 );
87 }, function(error){
88 Framework.util.LogUtil.e(this.$className, 'getImport()
download error =' + error);-
89 aFail(error);
90 });
91 }, null);
92
93 },
I/Web Console(22297): [I] :: getImport() fs.root[isFile] =false:37
I/Web Console(22297): [I] :: getImport() fs.root[isDirectory] =true:37
I/Web Console(22297): [I] :: getImport() fs.root[name] =:37
I/Web Console(22297): [I] :: getImport() fs.root[fullPath] =/:37
I/Web Console(22297): [I] :: getImport() fs.root[filesystem] =[object
Object]:37
I/Web Console(22297): [I] :: getImport() fs.root[nativeURL] =null:37
This happened after I updated the file and the file-transfer plugins in my
project. It worked with the old versions (about one year older).
Not sure what the
[jira] [Commented] (CB-6777) window.requestFileSystem(LocalFileSystem.TEMPORARY returns /
[
https://issues.apache.org/jira/browse/CB-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012391#comment-14012391
]
Axel Nennker commented on CB-6777:
--
This code is taken from the examples floating around in the web. It does not
work.
Maybe it is more to the spec.
I do not want a url. I need one for FileTransfer.download
Is this not the right way to get a temorary filesystem, then create a file in
it and pass that to download?
I am not saving an cdvfile url to some permanent storage or other things that
were discussed during the release of the new version of file and file-transfer.
I think this code should work but it doesn't due to what I think is a bug in
cordova.
Please reopen.
window.requestFileSystem(LocalFileSystem.TEMPORARY returns /
--
Key: CB-6777
URL: https://issues.apache.org/jira/browse/CB-6777
Project: Apache Cordova
Issue Type: Bug
Components: Android
Affects Versions: 3.5.0
Reporter: Axel Nennker
In the code below I get a
java.io.FileNotFoundException: /tmpfile.tmp: open failed: EROFS (Read-only
file system)
because the request for a temporary filesystem returns /.
{code}
60 window.requestFileSystem(LocalFileSystem.TEMPORARY, 0,
function(fs){
61 for (var p in fs.root) {
62 Framework.util.LogUtil.i(this.$className, 'getImport() fs.root['+p+'] ='
+ fs.root[p]);-
63 }
64 fs.root.getFile(tmpfile.tmp, {create: true, exclusive:
false},
65 function(entry){
66 var fileTransfer = new FileTransfer();
67 fileTransfer.download(
68 aFile,
69 entry.fullPath,
70 function(entry) {
71 console.log(download complete: +
entry.fullPath);
72 aSuccess(entry);
73 },
74 function(error) {
75 console.log(error source + error.source);
76 console.log(error target + error.target);
77 console.log(error code + error.code);
78 aFail(error);
79 },
80 false,
81 {
82 headers: {
83 'Content-Type': 'application/json'
84 }
85 }
86 );
87 }, function(error){
88 Framework.util.LogUtil.e(this.$className, 'getImport()
download error =' + error);-
89 aFail(error);
90 });
91 }, null);
92
93 },
{code}
I/Web Console(22297): [I] :: getImport() fs.root[isFile] =false:37
I/Web Console(22297): [I] :: getImport() fs.root[isDirectory] =true:37
I/Web Console(22297): [I] :: getImport() fs.root[name] =:37
I/Web Console(22297): [I] :: getImport() fs.root[fullPath] =/:37
I/Web Console(22297): [I] :: getImport() fs.root[filesystem] =[object
Object]:37
I/Web Console(22297): [I] :: getImport() fs.root[nativeURL] =null:37
This happened after I updated the file and the file-transfer plugins in my
project. It worked with the old versions (about one year older).
Not sure what the temporary filesystem should be on Android but / is wrong.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Created] (CB-6781) plugin file-transfer: add exception info to error object
Axel Nennker created CB-6781: Summary: plugin file-transfer: add exception info to error object Key: CB-6781 URL: https://issues.apache.org/jira/browse/CB-6781 Project: Apache Cordova Issue Type: Improvement Components: Android Affects Versions: 3.5.0 Reporter: Axel Nennker Assignee: Axel Nennker Priority: Minor When something goes wrong during FileTransfer.download or upload the actual information from the exception thrown is lost. Add a field exception to the error object that holds the string of either exception.getMessage() or exception.toString(). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-6781) plugin file-transfer: add exception info to error object
[ https://issues.apache.org/jira/browse/CB-6781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14012682#comment-14012682 ] Axel Nennker commented on CB-6781: -- https://github.com/apache/cordova-plugin-file-transfer/pull/30 Axel plugin file-transfer: add exception info to error object Key: CB-6781 URL: https://issues.apache.org/jira/browse/CB-6781 Project: Apache Cordova Issue Type: Improvement Components: Android Affects Versions: 3.5.0 Reporter: Axel Nennker Assignee: Axel Nennker Priority: Minor When something goes wrong during FileTransfer.download or upload the actual information from the exception thrown is lost. Add a field exception to the error object that holds the string of either exception.getMessage() or exception.toString(). -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (CB-5675) Can't get rid of nameHello Cordova/name from config.xml
[ https://issues.apache.org/jira/browse/CB-5675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13997274#comment-13997274 ] Axel Nennker commented on CB-5675: -- Adding name and description to SINGLETONS is not in 3.5.0-0.2.3 yet. I think this is a good fix although it misses the mark http://www.w3.org/TR/widgets/#the-name-element-and-its-attributes E.g. name is only a singleton for same xml:lang values... So name xml:lang=deHallo Welt/name and name xml:lang=enHello World/name are allowed in one config.xml Can't get rid of nameHello Cordova/name from config.xml - Key: CB-5675 URL: https://issues.apache.org/jira/browse/CB-5675 Project: Apache Cordova Issue Type: Bug Components: CLI Affects Versions: 3.2.0 Environment: OSX/IOS Reporter: Michael Stanford Fix For: Master config_parser.js merges your www/config.xml in on top of cordova/defaults.xml to produce your platform/project/config.xml. I don't like seeing Hello Cordova in there as the name of the project in addition to the one that I gave it. Same with the description. I am concerned that it confuses Xcode as well. So I changed the SINGLETONS array in config_parser.merge_with() from: [content, author] to: [content, author,description,name] Which seems to have fixed my problem. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (CB-6088) platform add firefoxos fails if config.xml in project but not in www
[ https://issues.apache.org/jira/browse/CB-6088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Nennker updated CB-6088: - Assignee: Axel Nennker platform add firefoxos fails if config.xml in project but not in www Key: CB-6088 URL: https://issues.apache.org/jira/browse/CB-6088 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Affects Versions: 3.4.0 Reporter: Axel Nennker Assignee: Axel Nennker config.xml is expected to be in www but it moved to project_dir in 3.4 cordova should check both locations for a while. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Closed] (CB-6082) Installing plugins fails when Firefox platform is present
[ https://issues.apache.org/jira/browse/CB-6082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Axel Nennker closed CB-6082. Resolution: Fixed Assignee: Axel Nennker This a duplicate of CB-6088 which has a fix. Installing plugins fails when Firefox platform is present - Key: CB-6082 URL: https://issues.apache.org/jira/browse/CB-6082 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS, Plugman Affects Versions: 3.4.0 Reporter: Sébastien Blanc Assignee: Axel Nennker Once the firefoxos platform is added it fails to install new plugins using : cordova plugin add xx I tested with Contacts, Device and my own plugin. This is the output : Error: ENOENT, no such file or directory '/home/sebastien/aerogear/ffos/ffsupport/platforms/firefoxos/www/config.xml' at Object.fs.openSync (fs.js:427:18) at Object.fs.readFileSync (fs.js:284:15) at Object.module.exports.parseElementtreeSync (/home/sebastien/nvm/v0.10.23/lib/node_modules/cordova/node_modules/plugman/src/util/xml-helpers.js:119:27) at Object.module.exports.package_name (/home/sebastien/nvm/v0.10.23/lib/node_modules/cordova/node_modules/plugman/src/platforms/firefoxos.js:10:38) at Object.module.exports.generate_plugin_config_munge (/home/sebastien/nvm/v0.10.23/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:100:53) at Object.module.exports.add_plugin_changes (/home/sebastien/nvm/v0.10.23/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:300:43) at /home/sebastien/nvm/v0.10.23/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:440:28 at Array.forEach (native) at Object.module.exports.process (/home/sebastien/nvm/v0.10.23/lib/node_modules/cordova/node_modules/plugman/src/util/config-changes.js:439:49) at Object.handlePrepare (/home/sebastien/nvm/v0.10.23/lib/node_modules/cordova/node_modules/plugman/src/prepare.js:69:20) So it's seems to look for the config.xml at the wrong place. The problem seems to be in plugman here : https://github.com/apache/cordova-plugman/blob/master/src/platforms/firefoxos.js#L9 When changing config.xml to ../config.xml I am able to install the plugins. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-2606) Add support for icon elements in config.xml
[
https://issues.apache.org/jira/browse/CB-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895508#comment-13895508
]
Axel Nennker commented on CB-2606:
--
I removed the restriction that icons live in specific directories.
https://github.com/apache/cordova-cli/pull/126
The src in the icon element in config.xml is taken as is.
-Axel
icon src=/res/android/icons/icon.png cdv:platform=android /
icon src=/res/android/icons/icon-ldpi.png cdv:platform=android
cdv:density=ldpi /
icon src=/res/android/icons/icon-mdpi.png cdv:platform=android
cdv:density=mdpi /
icon src=/res/android/icons/icon-hdpi.png cdv:platform=android
cdv:density=hdpi /
icon src=/res/android/icons/icon-xhdpi.png cdv:platform=android
cdv:density=xhdpi /
Add support for icon elements in config.xml
-
Key: CB-2606
URL: https://issues.apache.org/jira/browse/CB-2606
Project: Apache Cordova
Issue Type: Wish
Components: Docs
Reporter: Filip Maj
Assignee: Mark Koudritsky
This feature would add support for specifying the application icon by
changing values inside the {{config.xml}} document.
Relevant details for Cordova:
- {{icon}} elements _may_ have {{width}} and {{height}} attributes
representing the preferred size of the icon in CSS pixels.
- {{icon}} elements _must_ have a {{src}} attribute, which contains a path
string relative to the {{www/}} folder (or equivalent) in the platform.
See [the Widget Spec's section on
icons|http://www.w3.org/TR/widgets/#the-icon-element-and-its-attributes] for
specifics.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Created] (CB-5816) FirefoxOS - add build script
Axel Nennker created CB-5816: Summary: FirefoxOS - add build script Key: CB-5816 URL: https://issues.apache.org/jira/browse/CB-5816 Project: Apache Cordova Issue Type: Bug Components: FirefoxOS Reporter: Axel Nennker run: cordova build firefoxos output: Generating config.xml from defaults for platform firefoxos Preparing firefoxos project Compiling app on platform firefoxos via command /project/platforms/firefoxos/cordova/build events.js:72 throw er; // Unhandled 'error' event ^ Error: spawn ENOENT at errnoException (child_process.js:980:11) at Process.ChildProcess._handle.onexit (child_process.js:771:34) project$ expected output: nothing - platforms/firefoxos/cordova/build does not exist so the cordova build firefoxos command fails. Please add a build script (although it does nothing) -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5720) Add resource-file element to plugin.xml
[ https://issues.apache.org/jira/browse/CB-5720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13865704#comment-13865704 ] Axel Nennker commented on CB-5720: -- pull request is here: https://github.com/apache/cordova-plugman/pull/41 The code now emits a warning if resouce-file is not supported on the platform. res is now not prepended to the target anymore; so an example element in plugin.xml would be: resource-file src=glass.xml target=res/xml/glass.xml / Which would move the file from plugin_dir/glass.xml to project_dir/res/xml/glass.xml (project_dir is e.g. platforms/android/ -Axel Add resource-file element to plugin.xml --- Key: CB-5720 URL: https://issues.apache.org/jira/browse/CB-5720 Project: Apache Cordova Issue Type: Improvement Reporter: Axel Nennker Add support for resource-file src=glass.xml target=xml/glass.xml / to a plugin's plugin.xml The above example would copy the file glass.xml from the plugin's directory to the platforms/android/res/xml/glass.xml This is for the use case when a plugin in needs additional file e.g. in res/xml or other directories. An example for Android would be an authenticator that is specified in AndroidManifest.xml -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (CB-5707) Add new platforms to Plugin Developement Guide
[ https://issues.apache.org/jira/browse/CB-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860793#comment-13860793 ] Axel Nennker commented on CB-5707: -- ubuntu uses resource-file to add file to qml. This is not documented, I think, but should be on a page linked from https://cordova.apache.org/docs/en/3.3.0/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide Add new platforms to Plugin Developement Guide -- Key: CB-5707 URL: https://issues.apache.org/jira/browse/CB-5707 Project: Apache Cordova Issue Type: Bug Components: Docs Reporter: Axel Nennker The Plugin Development Guide https://cordova.apache.org/docs/en/3.3.0/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide list some platforms but not all. Add the missing platforms' documentation e.g. resource-file src= target= / -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (CB-5707) Add new platforms to Plugin Developement Guide
[ https://issues.apache.org/jira/browse/CB-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860793#comment-13860793 ] Axel Nennker edited comment on CB-5707 at 1/2/14 9:36 PM: -- ubuntu uses resource-file to add file to qml. This is not documented, I think, but should be on a page linked from https://cordova.apache.org/docs/en/3.3.0/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide I think that it is not good that developers have to guess which elements of plugin.xml are supported on their plattform and what the effect of that element is on their platform. was (Author: ignisvulpis): ubuntu uses resource-file to add file to qml. This is not documented, I think, but should be on a page linked from https://cordova.apache.org/docs/en/3.3.0/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide Add new platforms to Plugin Developement Guide -- Key: CB-5707 URL: https://issues.apache.org/jira/browse/CB-5707 Project: Apache Cordova Issue Type: Bug Components: Docs Reporter: Axel Nennker The Plugin Development Guide https://cordova.apache.org/docs/en/3.3.0/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide list some platforms but not all. Add the missing platforms' documentation e.g. resource-file src= target= / -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5707) Add new platforms to Plugin Developement Guide
Axel Nennker created CB-5707: Summary: Add new platforms to Plugin Developement Guide Key: CB-5707 URL: https://issues.apache.org/jira/browse/CB-5707 Project: Apache Cordova Issue Type: Bug Reporter: Axel Nennker The Plugin Development Guide https://cordova.apache.org/docs/en/3.3.0/guide_hybrid_plugins_index.md.html#Plugin%20Development%20Guide list some platforms but not all. Add the missing platforms' documentation e.g. resource-file src= target= / -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (CB-5692) Add icon to firefoxos
Axel Nennker created CB-5692:
Summary: Add icon to firefoxos
Key: CB-5692
URL: https://issues.apache.org/jira/browse/CB-5692
Project: Apache Cordova
Issue Type: Bug
Reporter: Axel Nennker
Add icons to firefoxos and add icons field to manifest.webapp
https://developer.mozilla.org/en-US/Apps/Developing/Manifest
icons: {
30: icon-30.png,
60: icon-60.png,
128: icon-128.png
}
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (CB-2606) Add support for icon elements in config.xml
[
https://issues.apache.org/jira/browse/CB-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13852164#comment-13852164
]
Axel Nennker commented on CB-2606:
--
I started to implement this here:
https://github.com/AxelNennker/cordova-cli
This
https://github.com/AxelNennker/cordova-cli/blob/master/src/config_parser.js
changes the config_parser to support the icon element.
On Android using this config_parser might be used like this:
https://github.com/AxelNennker/cordova-cli/blob/master/src/metadata/android_parser.js
Currently the src attribute from the icon element in config.xml is relative to
www.
It is easy to change this to be relative to project_root which allows for
simple support for /res/icon.
Add support for icon elements in config.xml
-
Key: CB-2606
URL: https://issues.apache.org/jira/browse/CB-2606
Project: Apache Cordova
Issue Type: Wish
Components: Docs
Reporter: Filip Maj
Assignee: Mark Koudritsky
This feature would add support for specifying the application icon by
changing values inside the {{config.xml}} document.
Relevant details for Cordova:
- {{icon}} elements _may_ have {{width}} and {{height}} attributes
representing the preferred size of the icon in CSS pixels.
- {{icon}} elements _must_ have a {{src}} attribute, which contains a path
string relative to the {{www/}} folder (or equivalent) in the platform.
See [the Widget Spec's section on
icons|http://www.w3.org/TR/widgets/#the-icon-element-and-its-attributes] for
specifics.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Created] (CB-5633) PluginManager.java regression cordova-3.2 ERROR: config.xml is missing. Add res/xml/config.xml to your project
Axel Nennker created CB-5633: Summary: PluginManager.java regression cordova-3.2 ERROR: config.xml is missing. Add res/xml/config.xml to your project Key: CB-5633 URL: https://issues.apache.org/jira/browse/CB-5633 Project: Apache Cordova Issue Type: Bug Environment: cordova version 3.1.0 Android Reporter: Axel Nennker PluginManager loadPlugins fails when cordova app is started through an intent filter and the activity started by Android is in a different package than the main activity. Please see the dev mailing list for details. The subject of the emails is the same as the summary of this issue. Axel -- This message was sent by Atlassian JIRA (v6.1.4#6159)
[jira] [Created] (CB-5605) plugman install.js:68 crashes
Axel Nennker created CB-5605:
Summary: plugman install.js:68 crashes
Key: CB-5605
URL: https://issues.apache.org/jira/browse/CB-5605
Project: Apache Cordova
Issue Type: Bug
Reporter: Axel Nennker
My app uses two custom plugins.
I want to add firefoxos as a platform.
When I issue a
cordova platform add firefoxos
install.js:68 fails with the message
Cannot access currentVersion of null
I guess my custom plugins' plugin.xml are wrong...
Anyway I think that install.js should not crash here.
I have no idea why engines[i] is null for some i.
-Axel
Maybe this code is a fix:
function checkEngines(engines) {
for(var i = 0; i engines.length; i++) {
var engine = engines[i];
if(engine===null) {
return Q.reject(new Error('Plugin doesn\'t support this project'));
} else {
if(semver.satisfies(engine.currentVersion, engine.minVersion) ||
engine.currentVersion == null){
// engine ok!
}else{
return Q.reject(new Error('Plugin doesn\'t support this project\'s
'+engine.name+' version. '+engine.name+': ' + engine.currentVersion + ', failed
version requirement: ' + engine.minVersion));
}
}
}
return Q(true);
}
Although I never see the no-support output
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)
[jira] [Created] (CB-5537) ClassNotFound in PluginEntry for empty string
Axel Nennker created CB-5537: Summary: ClassNotFound in PluginEntry for empty string Key: CB-5537 URL: https://issues.apache.org/jira/browse/CB-5537 Project: Apache Cordova Issue Type: Bug Environment: Android https://github.com/apache/cordova-android/ Reporter: Axel Nennker PluginEntry.getClassByName is called with an argument of (not null). The method getClassByName checks for null but not for and so it throws ClassNotFound. This happens for the service http://api.phonegap.com/1.0/device I am using cordova-3.1.0-0.2.0 but this seems to be in the latest code too. A screenshot of the debugging window is attached to my email to dev-cordova. A simple fix seems to be to never to set this.pluginClass in PluginEntry.java to but to null. PluginManager.java contains the assignment: pluginClass = Or to check not only for null but for too. -Axel https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/PluginEntry.java#L116 https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/PluginManager.java#L121 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5537) ClassNotFound in PluginEntry for empty string
[ https://issues.apache.org/jira/browse/CB-5537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838285#comment-13838285 ] Axel Nennker commented on CB-5537: -- A pull request is here: https://github.com/apache/cordova-android/pull/87 -Axel ClassNotFound in PluginEntry for empty string - Key: CB-5537 URL: https://issues.apache.org/jira/browse/CB-5537 Project: Apache Cordova Issue Type: Bug Environment: Android https://github.com/apache/cordova-android/ Reporter: Axel Nennker PluginEntry.getClassByName is called with an argument of (not null). The method getClassByName checks for null but not for and so it throws ClassNotFound. This happens for the service http://api.phonegap.com/1.0/device I am using cordova-3.1.0-0.2.0 but this seems to be in the latest code too. A screenshot of the debugging window is attached to my email to dev-cordova. A simple fix seems to be to never to set this.pluginClass in PluginEntry.java to but to null. PluginManager.java contains the assignment: pluginClass = Or to check not only for null but for too. -Axel https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/PluginEntry.java#L116 https://github.com/apache/cordova-android/blob/master/framework/src/org/apache/cordova/PluginManager.java#L121 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-5419) feature param name=onload not documented on Android
[ https://issues.apache.org/jira/browse/CB-5419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13824433#comment-13824433 ] Axel Nennker commented on CB-5419: -- A pull request for this is now here: https://github.com/apache/cordova-docs/pull/154 feature param name=onload not documented on Android - Key: CB-5419 URL: https://issues.apache.org/jira/browse/CB-5419 Project: Apache Cordova Issue Type: Bug Components: Android Affects Versions: 3.1.0 Reporter: Axel Nennker Plugins are only instanciated when the cordava app's JS code first call them. If the plugin needs to be notified of a e.g. a hardware event or some other intent filter its onNewIntent method is never called unless onload = true. feature ... ... param name=onload value=true / /feature is a neded for all plugins that react to operating system events. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4624) Allow apps to specify plugin dependencies within their config.xml
[ https://issues.apache.org/jira/browse/CB-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801578#comment-13801578 ] Axel Nennker commented on CB-4624: -- Michal Mocny suggested on the dev mailing list: Maybe we do just go the npm style route. cordova plugin add (without ID) - reads deps from config and installs them. cordova plugin add --save-deps ID - adds plugin and adds to config cordova plugin add --save-deps (without ID)- takes installed plugins and adds to deps I am not sure whether www/config.xml should ever be touched by cli commands. Let us start with the first suggestion cordova plugin add (without ID). Allow apps to specify plugin dependencies within their config.xml - Key: CB-4624 URL: https://issues.apache.org/jira/browse/CB-4624 Project: Apache Cordova Issue Type: New Feature Components: CLI Reporter: Andrew Grieve Assignee: Mark Koudritsky Use-case: Be able to have plugins/ and platforms/ in your .gitignore Be able to specify what plugins an app depends on within config.xml. The list should be updated whenever you perform a cordova plugin add, just like npm install --save does for node. If no commit is specified, then the latest is downloaded and the hash is extracted saved into the config.xml. The syntax should match that of dependency tags within the plugin spec: http://cordova.apache.org/docs/en/3.0.0/plugin_ref_spec.md.html#Plugin%20Specification. Note that there's an open issue to fold the commit/subdir into the URI (CB-4622). We'll need a new command for installing dependencies. Maybe: cordova install? cordova plugin install? cordova project init? -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (CB-4430) lib-file should be usable on platforms other than BB10 (wherever it makes sense)
[
https://issues.apache.org/jira/browse/CB-4430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13744936#comment-13744936
]
Axel Nennker commented on CB-4430:
--
Here is a new android.js file that adds support for lib-file to android.
I could not figure out what the best way to contribute is... Commenting on this
issue is probably not optimal.
Axel
/*
*
* Copyright 2013 Anis Kadri
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*
*/
var fs = require('fs') // use existsSync in 0.6.x
, path = require('path')
, common = require('./common')
, xml_helpers = require(path.join(__dirname, '..', 'util', 'xml-helpers'));
module.exports = {
www_dir:function(project_dir) {
return path.join(project_dir, 'assets', 'www');
},
// reads the package name out of the Android Manifest file
// @param string project_dir the absolute path to the directory containing
the project
// @return string the name of the package
package_name:function (project_dir) {
var mDoc = xml_helpers.parseElementtreeSync(path.join(project_dir,
'AndroidManifest.xml'));
return mDoc._root.attrib['package'];
},
source-file:{
install:function(source_el, plugin_dir, project_dir, plugin_id) {
var dest = path.join(source_el.attrib['target-dir'],
path.basename(source_el.attrib['src']));
common.copyFile(plugin_dir, source_el.attrib['src'], project_dir,
dest);
},
uninstall:function(source_el, project_dir, plugin_id) {
var dest = path.join(source_el.attrib['target-dir'],
path.basename(source_el.attrib['src']));
common.deleteJava(project_dir, dest);
}
},
lib-file:{
install:function(lib_el, plugin_dir, project_dir) {
var src = lib_el.attrib.src;
var dest = path.join(libs, path.basename(src));
common.copyFile(plugin_dir, src, project_dir, dest);
},
uninstall:function(lib_el, project_dir) {
var src = lib_el.attrib.src;
var dest = path.join(libs, path.basename(src));
common.removeFile(project_dir, dest);
}
}
};
lib-file should be usable on platforms other than BB10 (wherever it makes
sense)
--
Key: CB-4430
URL: https://issues.apache.org/jira/browse/CB-4430
Project: Apache Cordova
Issue Type: Bug
Components: Plugman
Affects Versions: 3.0.0
Reporter: Filip Maj
Assignee: Filip Maj
https://groups.google.com/forum/#!topic/phonegap/dAXi8p_vjOE
Currently lib-file is only supported on BB10. Someone had an issue where
they tried using it for Android .jars. Are there any other platforms where
lib-file should be supported / an analogue to another element?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
