[jira] [Closed] (CB-11713) no CLI feedback on plugin version installed during plugin install
[ https://issues.apache.org/jira/browse/CB-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd closed CB-11713. --- Resolution: Won't Fix > no CLI feedback on plugin version installed during plugin install > - > > Key: CB-11713 > URL: https://issues.apache.org/jira/browse/CB-11713 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Trivial > Labels: cordova-8.0.0 > > During plugin install no feedback is given to the user as to what version > (from npm etc.) is installed or what exact sha (git repos) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Closed] (CB-11961) do a shallow clone if git_ref is a remote ref
[ https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd closed CB-11961. --- Resolution: Won't Fix gitclone replaced by npm install > do a shallow clone if git_ref is a remote ref > - > > Key: CB-11961 > URL: https://issues.apache.org/jira/browse/CB-11961 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Minor > > Currently when cloning with a reference the entire repo is cloned then is > checked out. > If the reference is a valid remote reference then it should be shallow cloned > so as to save time / lower bandwidth. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11713) no CLI feedback on plugin version installed during plugin install
[ https://issues.apache.org/jira/browse/CB-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd updated CB-11713: External issue URL: https://github.com/apache/cordova-lib/pull/563 > no CLI feedback on plugin version installed during plugin install > - > > Key: CB-11713 > URL: https://issues.apache.org/jira/browse/CB-11713 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Trivial > > During plugin install no feedback is given to the user as to what version > (from npm etc.) is installed or what exact sha (git repos) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11713) no CLI feedback on plugin version installed during plugin install
[ https://issues.apache.org/jira/browse/CB-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd updated CB-11713: External issue URL: (was: https://github.com/apache/cordova-lib/pull/563) > no CLI feedback on plugin version installed during plugin install > - > > Key: CB-11713 > URL: https://issues.apache.org/jira/browse/CB-11713 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Trivial > > During plugin install no feedback is given to the user as to what version > (from npm etc.) is installed or what exact sha (git repos) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11713) no CLI feedback on plugin version installed during plugin install
[ https://issues.apache.org/jira/browse/CB-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd updated CB-11713: Summary: no CLI feedback on plugin version installed during plugin install (was: no CLI feedback on plugin version installed during plugin instal) > no CLI feedback on plugin version installed during plugin install > - > > Key: CB-11713 > URL: https://issues.apache.org/jira/browse/CB-11713 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-cli >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Trivial > > During plugin install no feedback is given to the user as to what version > (from npm etc.) is installed or what exact sha (git repos) -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-11961) do a shallow clone if git_ref is a remote ref
[ https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15553287#comment-15553287 ] Brett Rudd commented on CB-11961: - needGitCheckout is true if git_ref is present depth=1 is used when needGitCheckout is false we had to patch this for build as some clones were taking 90s for a branch. > do a shallow clone if git_ref is a remote ref > - > > Key: CB-11961 > URL: https://issues.apache.org/jira/browse/CB-11961 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Minor > > Currently when cloning with a reference the entire repo is cloned then is > checked out. > If the reference is a valid remote reference then it should be shallow cloned > so as to save time / lower bandwidth. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11961) do a shallow clone if git_ref is a remote ref
[ https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd updated CB-11961: Description: Currently when cloning with a reference the entire repo is cloned then is checked out. If the reference is a valid remote reference then it should be shallow cloned so as to save time / lower bandwidth. was: Currently when cloning with a reference the entire repo is cloned then is checked out. If the reference is a valid remote reference then it should be shallow cloned so as to save time and bandwidth. > do a shallow clone if git_ref is a remote ref > - > > Key: CB-11961 > URL: https://issues.apache.org/jira/browse/CB-11961 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Minor > > Currently when cloning with a reference the entire repo is cloned then is > checked out. > If the reference is a valid remote reference then it should be shallow cloned > so as to save time / lower bandwidth. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Updated] (CB-11961) do a shallow clone if git_ref is a remote ref
[ https://issues.apache.org/jira/browse/CB-11961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd updated CB-11961: Component/s: CLI > do a shallow clone if git_ref is a remote ref > - > > Key: CB-11961 > URL: https://issues.apache.org/jira/browse/CB-11961 > Project: Apache Cordova > Issue Type: Improvement > Components: CLI >Reporter: Brett Rudd >Assignee: Brett Rudd >Priority: Minor > > Currently when cloning with a reference the entire repo is cloned then is > checked out. > If the reference is a valid remote reference then it should be shallow cloned > so as to save time and bandwidth. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11961) do a shallow clone if git_ref is a remote ref
Brett Rudd created CB-11961: --- Summary: do a shallow clone if git_ref is a remote ref Key: CB-11961 URL: https://issues.apache.org/jira/browse/CB-11961 Project: Apache Cordova Issue Type: Improvement Reporter: Brett Rudd Assignee: Brett Rudd Priority: Minor Currently when cloning with a reference the entire repo is cloned then is checked out. If the reference is a valid remote reference then it should be shallow cloned so as to save time and bandwidth. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Created] (CB-11713) no CLI feedback on plugin version installed during plugin instal
Brett Rudd created CB-11713: --- Summary: no CLI feedback on plugin version installed during plugin instal Key: CB-11713 URL: https://issues.apache.org/jira/browse/CB-11713 Project: Apache Cordova Issue Type: Improvement Components: CLI Reporter: Brett Rudd Assignee: Brett Rudd Priority: Trivial During plugin install no feedback is given to the user as to what version (from npm etc.) is installed or what exact sha (git repos) -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Resolved] (CB-8007) Two cordova plugins modifying “*-Info.plist” CFBundleURLTypes
[
https://issues.apache.org/jira/browse/CB-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brett Rudd resolved CB-8007.
Resolution: Fixed
fixed in dff78b0779444d06e259140694e07d5e8c5f5308
Two cordova plugins modifying “*-Info.plist” CFBundleURLTypes
-
Key: CB-8007
URL: https://issues.apache.org/jira/browse/CB-8007
Project: Apache Cordova
Issue Type: Bug
Components: CLI, CordovaLib
Affects Versions: 3.5.0
Reporter: Miquel
Assignee: Brett Rudd
Labels: cordova-lib, ios, plist, plugins
When 2 cordova plugins are modifying the same property, only the first added
plugin is getting the changes applied:
I.e.:
https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin.git
https://github.com/Wizcorp/phonegap-facebook-plugin
The first one:
{code:xml}
config-file target=*-Info.plist parent=CFBundleURLTypes
array
dict
keyCFBundleURLSchemes/key
array
string$URL_SCHEME/string
/array
/dict
/array
/config-file
{code}
The second one:
{code:xml}
config-file target=*-Info.plist parent=CFBundleURLTypes
array
dict
keyCFBundleURLSchemes/key
array
stringfb$APP_ID/string
/array
/dict
/array
/config-file
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-8007) Two cordova plugins modifying “*-Info.plist” CFBundleURLTypes
[
https://issues.apache.org/jira/browse/CB-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brett Rudd reassigned CB-8007:
--
Assignee: Brett Rudd
Two cordova plugins modifying “*-Info.plist” CFBundleURLTypes
-
Key: CB-8007
URL: https://issues.apache.org/jira/browse/CB-8007
Project: Apache Cordova
Issue Type: Bug
Components: CLI, CordovaLib
Affects Versions: 3.5.0
Reporter: Miquel
Assignee: Brett Rudd
Labels: cordova-lib, ios, plist, plugins
When 2 cordova plugins are modifying the same property, only the first added
plugin is getting the changes applied:
I.e.:
https://github.com/EddyVerbruggen/LaunchMyApp-PhoneGap-Plugin.git
https://github.com/Wizcorp/phonegap-facebook-plugin
The first one:
{code:xml}
config-file target=*-Info.plist parent=CFBundleURLTypes
array
dict
keyCFBundleURLSchemes/key
array
string$URL_SCHEME/string
/array
/dict
/array
/config-file
{code}
The second one:
{code:xml}
config-file target=*-Info.plist parent=CFBundleURLTypes
array
dict
keyCFBundleURLSchemes/key
array
stringfb$APP_ID/string
/array
/dict
/array
/config-file
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Assigned] (CB-5535) bin/create can't support both --shared and --arc at the same time
[ https://issues.apache.org/jira/browse/CB-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd reassigned CB-5535: -- Assignee: Brett Rudd bin/create can't support both --shared and --arc at the same time - Key: CB-5535 URL: https://issues.apache.org/jira/browse/CB-5535 Project: Apache Cordova Issue Type: Bug Components: iOS Reporter: Shazron Abdullah Assignee: Brett Rudd Priority: Minor See: https://github.com/apache/cordova-ios/blob/dfc52c5d77798766529035754cc9d9c825056c99/bin/create#L46-L53 To fix, see how it is done here: https://github.com/apache/cordova-ios/blob/5a194a96bedf4470856eac6c1913c7c406ca64ae/bin/templates/scripts/cordova/run#L51-L72 -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (CB-5012) Crash occurs because plugman adds extra information in iOS Info.plist when installing a plugin
[ https://issues.apache.org/jira/browse/CB-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd resolved CB-5012. Resolution: Fixed Crash occurs because plugman adds extra information in iOS Info.plist when installing a plugin -- Key: CB-5012 URL: https://issues.apache.org/jira/browse/CB-5012 Project: Apache Cordova Issue Type: Bug Components: Plugman Affects Versions: Master Reporter: Shazron Abdullah Assignee: Brett Rudd Priority: Critical Fix For: 3.2.0 Attachments: KeyboardTest-Info.after-plugman.plist, KeyboardTest-Info.original.plist See attached .original.plist and .after-plugman.plist. The plugin.xml used is: https://github.com/apache/cordova-labs/blob/86fb3afef5aaaba8e82e5bf0719b74b4a07582e0/statusbar/plugin.xml (note the value it tries to add in the iOS Info.plist). What plugman does is, it adds extra info (newlines, spaces) as the string value for the keys NSMainNibFile and NSMainNibFile~ipad in Info.plist. They had no values before. At runtime, iOS will search for these values and not finding the .nib files to load, then crash. This is critical for plugins that need to modify the Info.plist, like the Facebook PhoneGap plugin. There was a pull request for this, but I don't know why it was closed exactly: https://github.com/apache/cordova-plugman/pull/21 Expected: plugman should not modify plist keys that have empty string values. Actual: plugman adds a newline, 6 spaces, and another newline for keys that have empty string values. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Assigned] (CB-5012) Crash occurs because plugman adds extra information in iOS Info.plist when installing a plugin
[ https://issues.apache.org/jira/browse/CB-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brett Rudd reassigned CB-5012: -- Assignee: Brett Rudd Crash occurs because plugman adds extra information in iOS Info.plist when installing a plugin -- Key: CB-5012 URL: https://issues.apache.org/jira/browse/CB-5012 Project: Apache Cordova Issue Type: Bug Components: Plugman Affects Versions: Master Reporter: Shazron Abdullah Assignee: Brett Rudd Priority: Critical Fix For: 3.2.0 Attachments: KeyboardTest-Info.after-plugman.plist, KeyboardTest-Info.original.plist See attached .original.plist and .after-plugman.plist. The plugin.xml used is: https://github.com/apache/cordova-labs/blob/86fb3afef5aaaba8e82e5bf0719b74b4a07582e0/statusbar/plugin.xml (note the value it tries to add in the iOS Info.plist). What plugman does is, it adds extra info (newlines, spaces) as the string value for the keys NSMainNibFile and NSMainNibFile~ipad in Info.plist. They had no values before. At runtime, iOS will search for these values and not finding the .nib files to load, then crash. This is critical for plugins that need to modify the Info.plist, like the Facebook PhoneGap plugin. There was a pull request for this, but I don't know why it was closed exactly: https://github.com/apache/cordova-plugman/pull/21 Expected: plugman should not modify plist keys that have empty string values. Actual: plugman adds a newline, 6 spaces, and another newline for keys that have empty string values. -- This message was sent by Atlassian JIRA (v6.1#6144)
