[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329349#comment-16329349
 ] 

ASF GitHub Bot commented on CB-13309:
-

infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/242#issuecomment-358425257
 
 
   Actually, I'll keep it open as a reference, but I don't have any time to 
work on this right now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make InAppBrowser a Library Module for easier maintenance
> -
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Joe Bowser
>Priority: Major
>
> We currently just copy in Java files directly in a project, but that has some 
> major problems with layouts and resources.  Now that Android allows Library 
> Projects, we can now add modules as plugins and allow for certain plugins 
> which require layouts (like the InAppBrowser) to define them in XML instead 
> of programmatically, which will allow for a lot of code to be deleted from 
> the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso 
> Integration Tests to plugins so that we can actually test plugin changes the 
> same way we run native tests on Android with the Android Test Project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329346#comment-16329346
 ] 

ASF GitHub Bot commented on CB-13309:
-

infil00p closed pull request #242: CB-13309: InAppBrowser as a Library Project
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/plugin.xml b/plugin.xml
index 5329fdfd..7031c239 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -45,25 +45,7 @@
 
 
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
+
 
 
 
diff --git a/src/android/InAppBrowser/.gitignore 
b/src/android/InAppBrowser/.gitignore
new file mode 100644
index ..796b96d1
--- /dev/null
+++ b/src/android/InAppBrowser/.gitignore
@@ -0,0 +1 @@
+/build
diff --git a/src/android/InAppBrowser/InAppBrowser.iml 
b/src/android/InAppBrowser/InAppBrowser.iml
new file mode 100644
index ..d545ea40
--- /dev/null
+++ b/src/android/InAppBrowser/InAppBrowser.iml
@@ -0,0 +1,101 @@
+
+
+  
+
+  
+
+  
+
+
+  
+
+
+
+
+
+  generateDebugSources
+
+
+
+
+
+
+
+  
+
+  
+  
+
+
+
+
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+  
+
+
+
+
+
+
+  
+
\ No newline at end of file
diff --git a/src/android/InAppBrowser/build.gradle 
b/src/android/InAppBrowser/build.gradle
new file mode 100644
index ..6fc1a36f
--- /dev/null
+++ b/src/android/InAppBrowser/build.gradle
@@ -0,0 +1,40 @@
+buildscript {
+repositories {
+mavenCentral()
+}
+dependencies {
+classpath 'com.android.tools.build:gradle:2.1.0'
+}
+}
+
+apply plugin: 'com.android.library'
+
+android {
+compileSdkVersion 23
+buildToolsVersion "23.0.2"
+
+defaultConfig {
+minSdkVersion 14
+targetSdkVersion 23
+versionCode 1
+versionName "1.0"
+}
+
+
+buildTypes {
+release {
+minifyEnabled false
+proguardFiles getDefaultProguardFile('proguard-android.txt'), 
'proguard-rules.pro'
+}
+}
+
+// This is required once you specify debug and non-debug builds
+publishNonDefault true
+
+}
+
+dependencies {
+compile fileTree(include: ['*.jar'], dir: 'libs')
+testCompile 'junit:junit:4.12'
+compile project(':CordovaLib')
+}
diff --git a/src/android/InAppBrowser/proguard-rules.pro 
b/src/android/InAppBrowser/proguard-rules.pro
new file mode 100644
index ..73631aff
--- /dev/null
+++ b/src/android/InAppBrowser/proguard-rules.pro
@@ -0,0 +1,17 @@
+# Add project specific ProGuard rules here.
+# By default, the flags in this file are appended to flags specified
+# in /Users/jbowser/Library/Android/sdk/tools/proguard/proguard-android.txt
+# You can edit the include path and order by changing the proguardFiles
+# directive in build.gradle.
+#
+# For more details, see
+#   http://developer.android.com/guide/developing/tools/proguard.html
+
+# Add any project specific keep options here:
+
+# If your project uses WebView with JS, uncomment the following
+# and specify the fully qualified class name to the JavaScript interface
+# class:
+#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
+#   public *;
+#}
diff --git 
a/src/android/InAppBrowser/src/androidTest/java/org/apache/cordova/inappbrowser/ApplicationTest.java
 
b/src/android/InAppBrowser/src/androidTest/java/org/apache/cordova/inappbrowser/ApplicationTest.java
new file mode 100644
index ..5e52219a
--- /dev/null
+++ 
b/src/android/InAppBrowser/src/androidTest/java/org/apache/cordova/inappbrowser/ApplicationTest.java
@@ -0,0 +1,13 @@
+package org.apache.cordova.inappbrowser;
+
+import android.app.Application;
+import android.test.ApplicationTestCase;
+
+/**
+ * http://d.android.com/tools/testing/testing_android.html;>Testing 
Fundamentals
+ */
+public class ApplicationTest extends ApplicationTestCase {
+public ApplicationTest() {
+super(Application.class);
+}
+}
\ No newline at end of file

[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329347#comment-16329347
 ] 

ASF GitHub Bot commented on CB-13309:
-

infil00p opened a new pull request #242: CB-13309: InAppBrowser as a Library 
Project
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/242
 
 
   
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   This changes the Android code so that the plugin is installed as a Library 
Project, and the Assets, Code and Layout are managed in their own project 
instead of copied into the generated project.
   
   ### What testing has been done on this change?
   * Tested against mobilespec
   * Tested against CI
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
   - [ ] Added automated test coverage as appropriate for this change.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make InAppBrowser a Library Module for easier maintenance
> -
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Joe Bowser
>Priority: Major
>
> We currently just copy in Java files directly in a project, but that has some 
> major problems with layouts and resources.  Now that Android allows Library 
> Projects, we can now add modules as plugins and allow for certain plugins 
> which require layouts (like the InAppBrowser) to define them in XML instead 
> of programmatically, which will allow for a lot of code to be deleted from 
> the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso 
> Integration Tests to plugins so that we can actually test plugin changes the 
> same way we run native tests on Android with the Android Test Project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329345#comment-16329345
 ] 

ASF GitHub Bot commented on CB-13309:
-

infil00p commented on issue #242: CB-13309: InAppBrowser as a Library Project
URL: 
https://github.com/apache/cordova-plugin-inappbrowser/pull/242#issuecomment-358424993
 
 
   Sadly, this conflicts hard with the programmatic approach that people want 
to adopt, so I'm going to close this for now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Make InAppBrowser a Library Module for easier maintenance
> -
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Joe Bowser
>Priority: Major
>
> We currently just copy in Java files directly in a project, but that has some 
> major problems with layouts and resources.  Now that Android allows Library 
> Projects, we can now add modules as plugins and allow for certain plugins 
> which require layouts (like the InAppBrowser) to define them in XML instead 
> of programmatically, which will allow for a lot of code to be deleted from 
> the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso 
> Integration Tests to plugins so that we can actually test plugin changes the 
> same way we run native tests on Android with the Android Test Project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance

[Jan Piotrowski (Sujan) (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16191015#comment-16191015
 ] 

Jan Piotrowski (Sujan) commented on CB-13309:
-

I looked at the PR and I have to say, this is _so_ much better than the current 
state. Nice!

> Make InAppBrowser a Library Module for easier maintenance
> -
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Joe Bowser
>
> We currently just copy in Java files directly in a project, but that has some 
> major problems with layouts and resources.  Now that Android allows Library 
> Projects, we can now add modules as plugins and allow for certain plugins 
> which require layouts (like the InAppBrowser) to define them in XML instead 
> of programmatically, which will allow for a lot of code to be deleted from 
> the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso 
> Integration Tests to plugins so that we can actually test plugin changes the 
> same way we run native tests on Android with the Android Test Project.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-13309) Make InAppBrowser a Library Module for easier maintenance

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/CB-13309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16175196#comment-16175196
 ] 

ASF GitHub Bot commented on CB-13309:
-

GitHub user infil00p opened a pull request:

https://github.com/apache/cordova-plugin-inappbrowser/pull/242

CB-13309: InAppBrowser as a Library Project



### Platforms affected
Android

### What does this PR do?
This changes the Android code so that the plugin is installed as a Library 
Project, and the Assets, Code and Layout are managed in their own project 
instead of copied into the generated project.

### What testing has been done on this change?
* Tested against mobilespec
* Tested against CI

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/infil00p/cordova-plugin-inappbrowser 
modulework

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-inappbrowser/pull/242.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #242


commit 796761029a2fad587c6ade5b2d67109b9095a2ac
Author: Joe Bowser 
Date:   2016-04-07T17:09:49Z

Adding the Library Project

commit 899fe80c43ac2c20e05ef9ad9679e2855bf38ddd
Author: Joe Bowser 
Date:   2016-06-06T22:44:00Z

Tweaking to get framework install kinda working

commit 8e2acd7066bafb09fe112d565ded6d1be247140c
Author: Joe Bowser 
Date:   2016-06-07T23:05:32Z

Got a gradle that makes submodules work.  This took a long time to figure 
out.

commit a4dea54087ce922551bd13410ce6901d2edbb1dd
Author: Joe Bowser 
Date:   2016-06-08T18:01:40Z

Adding publishNonDefault for debug and non-debug builds, because Cordova 
will add seperate rules for both

commit 4b61238598a2c644f996354e100c482a2154eab6
Author: Joe Bowser 
Date:   2016-06-29T18:22:00Z

Attempting to make Cordova standalone so we can query dependencies

commit a84a51b401a96b9c9fc868c18d1b935ed464c521
Author: Joe Bowser 
Date:   2017-09-21T16:48:36Z

Merge branch 'master' into modulework

Necessary Merge Commit to bring this old POC into modern usage




> Make InAppBrowser a Library Module for easier maintenance
> -
>
> Key: CB-13309
> URL: https://issues.apache.org/jira/browse/CB-13309
> Project: Apache Cordova
>  Issue Type: Improvement
>  Components: cordova-plugin-inappbrowser
>Reporter: Joe Bowser
>
> We currently just copy in Java files directly in a project, but that has some 
> major problems with layouts and resources.  Now that Android allows Library 
> Projects, we can now add modules as plugins and allow for certain plugins 
> which require layouts (like the InAppBrowser) to define them in XML instead 
> of programmatically, which will allow for a lot of code to be deleted from 
> the project, and for the project to be easier to maintain for Android.
> Another upshot of this change is that we can then add JUnit and Espresso 
> Integration Tests to plugins so that we can actually test plugin changes the 
> same way we run native tests on Android with the Android Test Project.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org