[jira] [Commented] (CB-5487) Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome based WebView

2013-11-29 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13835570#comment-13835570
 ] 

ASF subversion and git services commented on CB-5487:
-

Commit ea1f041e1167de9add5346a7d4fe6afec095d910 in branch refs/heads/master 
from [~bowserj]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=ea1f041 ]

CB-5487: Remote Debugging is on when your Android app is debuggable.


 Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome 
 based WebView
 

 Key: CB-5487
 URL: https://issues.apache.org/jira/browse/CB-5487
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: 3.2.0
Reporter: Michal Mocny
Assignee: Joe Bowser

 You have to explicitly enable remote debugging for kitkat chrome-based 
 webview:
 https://developers.google.com/chrome-developer-tools/docs/remote-debugging#debugging-webviews
 As far as I am aware there are no performance implication to leaving this 
 flag on at all time (i.e. when releasing your app) -- however, the feature 
 was implemented as an opt-in so that users cannot inspect your webview based 
 application without your (the developer) explicit consent.  I think cordova 
 should respect that decision and leave the preference off by default.
 CB-3494 is related.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5487) Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome based WebView

2013-11-28 Thread Dirk-Jan Hoek (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834667#comment-13834667
 ] 

Dirk-Jan Hoek commented on CB-5487:
---

[~agrieve], linking the setting to the 'debuggable' parameter means you can't 
leave it on when releasing the app (Play Store won't allow 'debuggable'=true). 
I'd like to be sure of what it implicated in the description: there is no 
performance implication to leaving this flag on at all time. Is there anyone 
who can confirm/refute this?

Jamie Starke's plugin works great by the way :)

 Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome 
 based WebView
 

 Key: CB-5487
 URL: https://issues.apache.org/jira/browse/CB-5487
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: 3.2.0
Reporter: Michal Mocny

 You have to explicitly enable remote debugging for kitkat chrome-based 
 webview:
 https://developers.google.com/chrome-developer-tools/docs/remote-debugging#debugging-webviews
 As far as I am aware there are no performance implication to leaving this 
 flag on at all time (i.e. when releasing your app) -- however, the feature 
 was implemented as an opt-in so that users cannot inspect your webview based 
 application without your (the developer) explicit consent.  I think cordova 
 should respect that decision and leave the preference off by default.
 CB-3494 is related.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5487) Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome based WebView

2013-11-28 Thread Michal Mocny (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834960#comment-13834960
 ] 

Michal Mocny commented on CB-5487:
--

I now think that we should ship this the way andrew suggests, so that you get 
debugging out of the box for local dev and disabled by default when you ship 
your app with release build.

If you want to leave debugging on with your released app, just install the 
plugin or override the platform code.

 Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome 
 based WebView
 

 Key: CB-5487
 URL: https://issues.apache.org/jira/browse/CB-5487
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: 3.2.0
Reporter: Michal Mocny

 You have to explicitly enable remote debugging for kitkat chrome-based 
 webview:
 https://developers.google.com/chrome-developer-tools/docs/remote-debugging#debugging-webviews
 As far as I am aware there are no performance implication to leaving this 
 flag on at all time (i.e. when releasing your app) -- however, the feature 
 was implemented as an opt-in so that users cannot inspect your webview based 
 application without your (the developer) explicit consent.  I think cordova 
 should respect that decision and leave the preference off by default.
 CB-3494 is related.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5487) Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome based WebView

2013-11-27 Thread Andrew Grieve (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834510#comment-13834510
 ] 

Andrew Grieve commented on CB-5487:
---

Instead of a preference, how about just linking it with the debuggable 
AndroidManifest parameter. This is shown in the example code from the linked 
page.

{code}
if(Build.VERSION.SDK_INT = Build.VERSION_CODES.KITKAT) {
if ( 0 != ( getApplcationInfo().flags = ApplicationInfo.FLAG_DEBUGGABLE ) 
) {
WebView.setWebContentsDebuggingEnabled(true);
}
}
{code}

 Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome 
 based WebView
 

 Key: CB-5487
 URL: https://issues.apache.org/jira/browse/CB-5487
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: 3.2.0
Reporter: Michal Mocny

 You have to explicitly enable remote debugging for kitkat chrome-based 
 webview:
 https://developers.google.com/chrome-developer-tools/docs/remote-debugging#debugging-webviews
 As far as I am aware there are no performance implication to leaving this 
 flag on at all time (i.e. when releasing your app) -- however, the feature 
 was implemented as an opt-in so that users cannot inspect your webview based 
 application without your (the developer) explicit consent.  I think cordova 
 should respect that decision and leave the preference off by default.
 CB-3494 is related.



--
This message was sent by Atlassian JIRA
(v6.1#6144)


[jira] [Commented] (CB-5487) Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome based WebView

2013-11-27 Thread Michal Mocny (JIRA)

[ 
https://issues.apache.org/jira/browse/CB-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834512#comment-13834512
 ] 

Michal Mocny commented on CB-5487:
--

Also, a community member has already written a nice plugin for this, with a 
great guide to boot:
http://plugins.cordova.io/#/com.jamiestarke.webviewdebug

 Add preference to enable Remote Debugging for Android 4.4+ (KitKat) Chrome 
 based WebView
 

 Key: CB-5487
 URL: https://issues.apache.org/jira/browse/CB-5487
 Project: Apache Cordova
  Issue Type: Bug
  Components: Android
Affects Versions: 3.2.0
Reporter: Michal Mocny

 You have to explicitly enable remote debugging for kitkat chrome-based 
 webview:
 https://developers.google.com/chrome-developer-tools/docs/remote-debugging#debugging-webviews
 As far as I am aware there are no performance implication to leaving this 
 flag on at all time (i.e. when releasing your app) -- however, the feature 
 was implemented as an opt-in so that users cannot inspect your webview based 
 application without your (the developer) explicit consent.  I think cordova 
 should respect that decision and leave the preference off by default.
 CB-3494 is related.



--
This message was sent by Atlassian JIRA
(v6.1#6144)