[jira] [Commented] (CB-12112) moveFolder function in UWP fails for folder trees with depth greater than 1

2016-12-07 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730579#comment-15730579
 ] 

ASF subversion and git services commented on CB-12112:
--

Commit a1cfabdce07cabd44694097fac6730b7317d4607 in cordova-plugin-file's branch 
refs/heads/4.3.x from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=a1cfabd ]

CB-12112 windows: Make available to move folder trees

There was a mistake in the logic of recursive function for moving operation. As 
for destination folder, it was always used start folder.

 This closes #198


> moveFolder function in UWP fails for folder trees with depth greater than 1
> ---
>
> Key: CB-12112
> URL: https://issues.apache.org/jira/browse/CB-12112
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, Windows
>Affects Versions: 3.5.0
> Environment: Universal windows
>Reporter: Chris Redhead
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: reproduced, triaged
>
> The moveFolder function works incorrectly in UWP for folder trees with depth 
> greater than 1. 
> The recursion does not work as expected so all files and folders end up in 
> the new directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12112) moveFolder function in UWP fails for folder trees with depth greater than 1

2016-11-24 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693469#comment-15693469
 ] 

ASF GitHub Bot commented on CB-12112:
-

Github user asfgit closed the pull request at:

https://github.com/apache/cordova-plugin-file/pull/198


> moveFolder function in UWP fails for folder trees with depth greater than 1
> ---
>
> Key: CB-12112
> URL: https://issues.apache.org/jira/browse/CB-12112
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, Windows
>Affects Versions: 3.5.0
> Environment: Universal windows
>Reporter: Chris Redhead
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: reproduced, triaged
>
> The moveFolder function works incorrectly in UWP for folder trees with depth 
> greater than 1. 
> The recursion does not work as expected so all files and folders end up in 
> the new directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12112) moveFolder function in UWP fails for folder trees with depth greater than 1

2016-11-24 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15693467#comment-15693467
 ] 

ASF subversion and git services commented on CB-12112:
--

Commit a1cfabdce07cabd44694097fac6730b7317d4607 in cordova-plugin-file's branch 
refs/heads/master from [~Nikita Matrosov]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file.git;h=a1cfabd ]

CB-12112 windows: Make available to move folder trees

There was a mistake in the logic of recursive function for moving operation. As 
for destination folder, it was always used start folder.

 This closes #198


> moveFolder function in UWP fails for folder trees with depth greater than 1
> ---
>
> Key: CB-12112
> URL: https://issues.apache.org/jira/browse/CB-12112
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, Windows
>Affects Versions: 3.5.0
> Environment: Universal windows
>Reporter: Chris Redhead
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: reproduced, triaged
>
> The moveFolder function works incorrectly in UWP for folder trees with depth 
> greater than 1. 
> The recursion does not work as expected so all files and folders end up in 
> the new directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12112) moveFolder function in UWP fails for folder trees with depth greater than 1

2016-11-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676382#comment-15676382
 ] 

ASF GitHub Bot commented on CB-12112:
-

Github user cordova-qa commented on the issue:

https://github.com/apache/cordova-plugin-file/pull/198
  
Cordova CI Build has completed successfully.

**Commit** - 
[Link](https://github.com/apache/cordova-plugin-file/pull/198/commits/1bbd7997fea0bbffce989bcb6b12d96cf66c993d)
**Dashboard** - 
[Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48/)

| Builder Name  | Console Output | Test Report | Device Logs  |
| :---: | :---:  |   :---: | :---:|
| [Windows 8.1 Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-store/artifact/)
 |
| [Windows 10  Store]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-10-store/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-10-store/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-10-store/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-10-store/artifact/)
 |
| [Windows 8.1 Phone]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-phone/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-phone/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-phone/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=windows-8.1-phone/artifact/)
 |
| [iOS]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=ios/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=ios/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=ios/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=ios/artifact/)
 |
| [Android]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=android/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=android/console)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=android/testReport/)
 | [Link]( 
http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-pr/48//PLATFORM=android/artifact/)
 |
 



> moveFolder function in UWP fails for folder trees with depth greater than 1
> ---
>
> Key: CB-12112
> URL: https://issues.apache.org/jira/browse/CB-12112
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, Windows
>Affects Versions: 3.5.0
> Environment: Universal windows
>Reporter: Chris Redhead
>Assignee: Nikita Matrosov
>Priority: Minor
>  Labels: reproduced, triaged
>
> The moveFolder function works incorrectly in UWP for folder trees with depth 
> greater than 1. 
> The recursion does not work as expected so all files and folders end up in 
> the new directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

[jira] [Commented] (CB-12112) moveFolder function in UWP fails for folder trees with depth greater than 1

2016-11-18 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/CB-12112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15676195#comment-15676195
 ] 

ASF GitHub Bot commented on CB-12112:
-

GitHub user matrosov-nikita opened a pull request:

https://github.com/apache/cordova-plugin-file/pull/198

CB-12112 windows: Make available to move folder trees



### Platforms affected
Windows

### What does this PR do?
There was a mistake in the logic of recursive function for moving 
operation. As for destination folder, it was always used start folder.

### What testing has been done on this change?
Auto-test

### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) 
in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with 
resolving file paths", where CB- is the JIRA ID & "android" is the platform 
affected.
- [x] Added automated test coverage as appropriate for this change.



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/matrosov-nikita/cordova-plugin-file CB-12112

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/cordova-plugin-file/pull/198.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #198


commit 1bbd7997fea0bbffce989bcb6b12d96cf66c993d
Author: Nikita Matrosov 
Date:   2016-11-18T08:50:20Z

CB-12112 windows: Make available to move folder trees

There was a mistake in the logic of recursive function for moving 
operation. As for destination folder, it was always used start folder.




> moveFolder function in UWP fails for folder trees with depth greater than 1
> ---
>
> Key: CB-12112
> URL: https://issues.apache.org/jira/browse/CB-12112
> Project: Apache Cordova
>  Issue Type: Bug
>  Components: Plugin File, Windows
>Affects Versions: 3.5.0
> Environment: Universal windows
>Reporter: Chris Redhead
>Priority: Minor
>
> The moveFolder function works incorrectly in UWP for folder trees with depth 
> greater than 1. 
> The recursion does not work as expected so all files and folders end up in 
> the new directory



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org