[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339763#comment-16339763 ] ASF subversion and git services commented on CB-13791: -- Commit 98ee2e148cd98a6e0b627b9b92f2e03efd9e00c5 in cordova-plugin-inappbrowser's branch refs/heads/2.0.x from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=98ee2e1 ] Merge pull request #258 from dpa99c/CB-13791 CB-13791: (android) Add Android support for a footer close button > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339762#comment-16339762 ] ASF subversion and git services commented on CB-13791: -- Commit 98ee2e148cd98a6e0b627b9b92f2e03efd9e00c5 in cordova-plugin-inappbrowser's branch refs/heads/2.0.x from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=98ee2e1 ] Merge pull request #258 from dpa99c/CB-13791 CB-13791: (android) Add Android support for a footer close button > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339761#comment-16339761 ] ASF subversion and git services commented on CB-13791: -- Commit b73ba93884dcaa88429aae6e4ea6d117effae7d2 in cordova-plugin-inappbrowser's branch refs/heads/2.0.x from [~dpa99c] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=b73ba93 ] CB-13791: Add Android support for a footer close button > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337969#comment-16337969 ] ASF subversion and git services commented on CB-13791: -- Commit b73ba93884dcaa88429aae6e4ea6d117effae7d2 in cordova-plugin-inappbrowser's branch refs/heads/master from [~dpa99c] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=b73ba93 ] CB-13791: Add Android support for a footer close button > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337970#comment-16337970 ] ASF subversion and git services commented on CB-13791: -- Commit 98ee2e148cd98a6e0b627b9b92f2e03efd9e00c5 in cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=98ee2e1 ] Merge pull request #258 from dpa99c/CB-13791 CB-13791: (android) Add Android support for a footer close button > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[
https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337968#comment-16337968
]
ASF GitHub Bot commented on CB-13791:
-
infil00p closed pull request #258: CB-13791: (android) Add Android support for
a footer close button
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/258
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/README.md b/README.md
index 7a2ec96a..936f1dce 100644
--- a/README.md
+++ b/README.md
@@ -112,9 +112,13 @@ instance, or the system browser.
- __hidden__: set to `yes` to create the browser and load the page, but
not show it. The loadstop event fires when loading is complete. Omit or set to
`no` (default) to have the browser open and load normally.
- __clearcache__: set to `yes` to have the browser's cookie cache cleared
before the new window is opened
- __clearsessioncache__: set to `yes` to have the session cookie cache
cleared before the new window is opened
-- __closebuttoncaption__: set to a string to use as the close buttons
caption instead of a X. Note that you need to localize this value yourself.
+- __closebuttoncaption__: set to a string to use as the close button's
caption instead of a X. Note that you need to localize this value yourself.
- __closebuttoncolor__: set to a valid hex color string, for example:
`#00ff00`, and it will change the
close button color from default, regardless of being a text or default X.
Only has effect if user has location set to `yes`.
+- __footer__: set to `yes` to show a close button in the footer similar to
the iOS __Done__ button.
+The close button will appear the same as for the header hence use
__closebuttoncaption__ and __closebuttoncolor__ to set its properties.
+- __footercolor__: set to a valid hex color string, for example `#00ff00`
or `#CC00ff00` (`#aarrggbb`) , and it will change the footer color from default.
+Only has effect if user has __footer__ set to `yes`.
- __hardwareback__: set to `yes` to use the hardware back button to
navigate backwards through the `InAppBrowser`'s history. If there is no
previous page, the `InAppBrowser` will close. The default value is `yes`, so
you must set it to `no` if you want the back button to simply close the
InAppBrowser.
- __hidenavigationbuttons__: set to `yes` to hide the navigation buttons
on the location toolbar, only has effect if user has location set to `yes`. The
default value is `no`.
- __hideurlbar__: set to `yes` to hide the url bar on the location
toolbar, only has effect if user has location set to `yes`. The default value
is `no`.
diff --git a/src/android/InAppBrowser.java b/src/android/InAppBrowser.java
index 8f937fb7..2b0dbe0f 100644
--- a/src/android/InAppBrowser.java
+++ b/src/android/InAppBrowser.java
@@ -103,8 +103,10 @@ Licensed to the Apache Software Foundation (ASF) under one
private static final String HIDE_NAVIGATION = "hidenavigationbuttons";
private static final String NAVIGATION_COLOR = "navigationbuttoncolor";
private static final String HIDE_URL = "hideurlbar";
+private static final String FOOTER = "footer";
+private static final String FOOTER_COLOR = "footercolor";
-private static final List customizableOptions =
Arrays.asList(CLOSE_BUTTON_CAPTION, TOOLBAR_COLOR, NAVIGATION_COLOR,
CLOSE_BUTTON_COLOR);
+private static final List customizableOptions =
Arrays.asList(CLOSE_BUTTON_CAPTION, TOOLBAR_COLOR, NAVIGATION_COLOR,
CLOSE_BUTTON_COLOR, FOOTER_COLOR);
private InAppBrowserDialog dialog;
private WebView inAppWebView;
@@ -129,6 +131,8 @@ Licensed to the Apache Software Foundation (ASF) under one
private boolean hideNavigationButtons = false;
private String navigationButtonColor = "";
private boolean hideUrlBar = false;
+private boolean showFooter = false;
+private String footerColor = "";
/**
* Executes the request and returns PluginResult.
@@ -397,11 +401,9 @@ public void run() {
option = new StringTokenizer(features.nextToken(), "=");
if (option.hasMoreElements()) {
String key = option.nextToken();
-String value = null;
-if (customizableOptions.contains(key)) value =
option.nextToken();
-else {
- String token = option.nextToken();
- value = token.equals("yes") || token.equals("no") ?
token : "yes";
+String value = option.nextToken();
+if (!customizableOptions.contains(key)){
+value = value.equals("yes") ||
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337971#comment-16337971 ] ASF subversion and git services commented on CB-13791: -- Commit 98ee2e148cd98a6e0b627b9b92f2e03efd9e00c5 in cordova-plugin-inappbrowser's branch refs/heads/master from [~bowserj] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-inappbrowser.git;h=98ee2e1 ] Merge pull request #258 from dpa99c/CB-13791 CB-13791: (android) Add Android support for a footer close button > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331070#comment-16331070 ] Dave Alden commented on CB-13791: - [~bowserj] How is this Fixed/Resolved if the PR is still open and not merged? [https://github.com/apache/cordova-plugin-inappbrowser/pull/258] > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! > _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300! > _location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00_ > > !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300! -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13791) Add Android support for a footer close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16329465#comment-16329465 ] ASF GitHub Bot commented on CB-13791: - dpa99c opened a new pull request #258: CB-13791: (android) Add Android support for a footer close button URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/258 ### Platforms affected Android ### What does this PR do? Adds support to Android for a footer close button similar to the "Done" button on iOS. ### What testing has been done on this change? Manual testing as there's no currently no automated tests for platform-specific options. I've tested all the possible combinations of the new `footer` and `footercolor` options with the related `closebuttoncaption` and `closebuttoncolor` options. The screenshots below illustrate the results: `location=yes,footer=yes` https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png"/> `location=no,footer=yes` https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png"/> `location=yes,footer=yes,closebuttoncaption=Done` https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png"/> `location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff` https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png"/> `location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done` https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png"/> `location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#ff` https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png"/> `location=no,footer=yes,footercolor=#CC00,closebuttoncaption=Done,closebuttoncolor=#00` https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png"/> ### Checklist - [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [x] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add Android support for a footer close button. > -- > > Key: CB-13791 > URL: https://issues.apache.org/jira/browse/CB-13791 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-plugin-inappbrowser > Environment: Android >Reporter: Dave Alden >Priority: Minor > Labels: features, newbie > > Extending the work done in [PR > #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under > CB-13409, this adds support to Android for a footer close button similar to > the "Done" button on iOS. > The following options are added for Android: > * *footer* - set to "yes" to show a close button in the footer similar to > the iOS "Done" button. > The close button will appear the same as for the header hence use > _closebuttoncaption_ and _closebuttoncolor_ to set its properties. > * *footercolor* - set to a valid hex color string, for example #00ff00 or > #CC00ff00 (#aarrggbb) , and it will change the footer color from default. > Only has effect if user has _footer_ set to "yes". > Here are some example screenshots with the relevant options: > _location=yes,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300! > _location=no,footer=yes_ > > !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300! > _location=yes,footer=yes,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300! > _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#ff_ > > !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300! > _location=no,footer=yes,footercolor=#ff,closebuttoncaption=Done_ > > !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300! >
