[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379814#comment-16379814 ] ASF subversion and git services commented on CB-13921: -- Commit 7397337c932e072c0d68e6d1c61e6a5056d4f376 in cordova-ios's branch refs/heads/master from [~shazron] [ https://gitbox.apache.org/repos/asf?p=cordova-ios.git;h=7397337 ] CB-13921 - Update Xcode requirement to Xcode 9 (#360) Updated Travis osx_image to Xcode 9.2, updated node versions Node 4 and 6 testing updated to latest versions > Update Xcode requirement to Xcode 9 > --- > > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[
https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379813#comment-16379813
]
ASF GitHub Bot commented on CB-13921:
-
shazron closed pull request #360: CB-13921 - Update Xcode requirement to Xcode 9
URL: https://github.com/apache/cordova-ios/pull/360
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 2866f3527..013df38b7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,10 +1,10 @@
language: objective-c
-osx_image: xcode8.3
+osx_image: xcode9.2
sudo: false
env:
matrix:
- - TRAVIS_NODE_VERSION: '4.2'
- - TRAVIS_NODE_VERSION: '6.11'
+ - TRAVIS_NODE_VERSION: '4.8.7'
+ - TRAVIS_NODE_VERSION: '6.13'
before_install:
- npm cache clean -f
- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm &&
(cd ~/.nvm
diff --git a/bin/templates/scripts/cordova/lib/check_reqs.js
b/bin/templates/scripts/cordova/lib/check_reqs.js
index 21a220814..0af8ed33f 100644
--- a/bin/templates/scripts/cordova/lib/check_reqs.js
+++ b/bin/templates/scripts/cordova/lib/check_reqs.js
@@ -26,7 +26,7 @@ const versions = require('./versions');
const SUPPORTED_OS_PLATFORMS = [ 'darwin' ];
-const XCODEBUILD_MIN_VERSION = '7.0.0';
+const XCODEBUILD_MIN_VERSION = '9.0.0';
const XCODEBUILD_NOT_FOUND_MESSAGE =
'Please install version ' + XCODEBUILD_MIN_VERSION + ' or greater from App
Store';
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Xcode requirement to Xcode 9
> ---
>
> Key: CB-13921
> URL: https://issues.apache.org/jira/browse/CB-13921
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>Priority: Major
>
> Right now it is Xcode 7.
>
> Update check_reqs.js
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379812#comment-16379812 ] ASF GitHub Bot commented on CB-13921: - codecov-io commented on issue #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360#issuecomment-369129824 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=h1) Report > Merging [#360](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/e75c38f65d05b8bbca1178d6ace309a2df7844da?src=pr=desc) will **not change** coverage. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #360 +/- ## === Coverage 63.99% 63.99% === Files 14 14 Lines1697 1697 Branches 286 286 === Hits 1086 1086 Misses611 611 ``` | [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=tree) | Coverage Δ | | |---|---|---| | [bin/templates/scripts/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-ios/pull/360/diff?src=pr=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL2NoZWNrX3JlcXMuanM=) | `42.04% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=footer). Last update [e75c38f...ec8d451](https://codecov.io/gh/apache/cordova-ios/pull/360?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Xcode requirement to Xcode 9 > --- > > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379811#comment-16379811 ] ASF GitHub Bot commented on CB-13921: - shazron commented on issue #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360#issuecomment-369128535 Testing this locally, and also Travis testing the same commits on my fork worked. Chalking this up to a one-off, closing and re-opening the PR so Travis builds this again. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update Xcode requirement to Xcode 9 > --- > > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[
https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379808#comment-16379808
]
ASF GitHub Bot commented on CB-13921:
-
shazron closed pull request #360: CB-13921 - Update Xcode requirement to Xcode 9
URL: https://github.com/apache/cordova-ios/pull/360
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.travis.yml b/.travis.yml
index 2866f3527..013df38b7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,10 +1,10 @@
language: objective-c
-osx_image: xcode8.3
+osx_image: xcode9.2
sudo: false
env:
matrix:
- - TRAVIS_NODE_VERSION: '4.2'
- - TRAVIS_NODE_VERSION: '6.11'
+ - TRAVIS_NODE_VERSION: '4.8.7'
+ - TRAVIS_NODE_VERSION: '6.13'
before_install:
- npm cache clean -f
- rm -rf ~/.nvm && git clone https://github.com/creationix/nvm.git ~/.nvm &&
(cd ~/.nvm
diff --git a/bin/templates/scripts/cordova/lib/check_reqs.js
b/bin/templates/scripts/cordova/lib/check_reqs.js
index 21a220814..0af8ed33f 100644
--- a/bin/templates/scripts/cordova/lib/check_reqs.js
+++ b/bin/templates/scripts/cordova/lib/check_reqs.js
@@ -26,7 +26,7 @@ const versions = require('./versions');
const SUPPORTED_OS_PLATFORMS = [ 'darwin' ];
-const XCODEBUILD_MIN_VERSION = '7.0.0';
+const XCODEBUILD_MIN_VERSION = '9.0.0';
const XCODEBUILD_NOT_FOUND_MESSAGE =
'Please install version ' + XCODEBUILD_MIN_VERSION + ' or greater from App
Store';
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update Xcode requirement to Xcode 9
> ---
>
> Key: CB-13921
> URL: https://issues.apache.org/jira/browse/CB-13921
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-ios
>Reporter: Shazron Abdullah
>Assignee: Shazron Abdullah
>Priority: Major
>
> Right now it is Xcode 7.
>
> Update check_reqs.js
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379809#comment-16379809 ] ASF GitHub Bot commented on CB-13921: - shazron opened a new pull request #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360 > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13921) Update Xcode requirement to Xcode 9
[ https://issues.apache.org/jira/browse/CB-13921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379797#comment-16379797 ] ASF GitHub Bot commented on CB-13921: - shazron opened a new pull request #360: CB-13921 - Update Xcode requirement to Xcode 9 URL: https://github.com/apache/cordova-ios/pull/360 > Key: CB-13921 > URL: https://issues.apache.org/jira/browse/CB-13921 > Project: Apache Cordova > Issue Type: Improvement > Components: cordova-ios >Reporter: Shazron Abdullah >Assignee: Shazron Abdullah >Priority: Major > > Right now it is Xcode 7. > > Update check_reqs.js -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
