[jira] [Commented] (DRILL-4286) Have an ability to put server in quiescent mode of operation

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268518#comment-16268518
 ] 

ASF GitHub Bot commented on DRILL-4286:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/921
  
Since we don't want to hold the release any more. @paul-rogers should we 
address this issue in the next release or move this PR to the next release? I 
am in the favor of the second.


> Have an ability to put server in quiescent mode of operation
> 
>
> Key: DRILL-4286
> URL: https://issues.apache.org/jira/browse/DRILL-4286
> Project: Apache Drill
>  Issue Type: New Feature
>  Components: Execution - Flow
>Affects Versions: 1.11.0
>Reporter: Victoria Markman
>Assignee: Venkata Jyothsna Donapati
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
> Attachments: consoleText.txt, consoleText_after.txt, 
> consoleText_before.txt
>
>
> I think drill will benefit from mode of operation that is called "quiescent" 
> in some databases. 
> From IBM Informix server documentation:
> {code}
> Change gracefully from online to quiescent mode
> Take the database server gracefully from online mode to quiescent mode to 
> restrict access to the database server without interrupting current 
> processing. After you perform this task, the database server sets a flag that 
> prevents new sessions from gaining access to the database server. The current 
> sessions are allowed to finish processing. After you initiate the mode 
> change, it cannot be canceled. During the mode change from online to 
> quiescent, the database server is considered to be in Shutdown mode.
> {code}
> This is different from shutdown, when processes are terminated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5964) Do not allow queries to access paths outside the current workspace root

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268450#comment-16268450
 ] 

ASF GitHub Bot commented on DRILL-5964:
---

Github user arina-ielchiieva commented on a diff in the pull request:

https://github.com/apache/drill/pull/1050#discussion_r153436976
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceConfig.java
 ---
@@ -30,18 +30,24 @@
 public class WorkspaceConfig {
 
   /** Default workspace is a root directory which supports read, but not 
write. */
-  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", 
false, null);
+  public static final WorkspaceConfig DEFAULT = new WorkspaceConfig("/", 
false, null, false);
 
   private final String location;
   private final boolean writable;
   private final String defaultInputFormat;
-
+  private final Boolean allowAccessOutsideWorkspace; // allow access 
outside the workspace by default. This
--- End diff --

1. Can we adjust the variable to be false by default, i.e. rename it to 
`disallowAccessOutsideWorkspace`? Thus we'll be able to use primitive, right?
2. In the below code you always set `this.allowAccessOutsideWorkspace = 
true;`, block with `this.allowAccessOutsideWorkspace = 
allowAccessOutsideWorkspace != null ? allowAccessOutsideWorkspace : false ;` is 
commented. I guess this is a mistake.


> Do not allow queries to access paths outside the current workspace root
> ---
>
> Key: DRILL-5964
> URL: https://issues.apache.org/jira/browse/DRILL-5964
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Parth Chandra
>Assignee: Parth Chandra
>  Labels: doc-impacting
>
> Workspace definitions in the dfs plugin are intended to provide a convenient 
> shortcut to long directory paths. However, some users may wish to disallow 
> access to paths outside the root of the workspace, possibly to prevent 
> accidental access. Note that this is a convenience option and not a 
> substitute for permissions on the file system.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-4779) Kafka storage plugin support

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268510#comment-16268510
 ] 

ASF GitHub Bot commented on DRILL-4779:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1052


> Kafka storage plugin support
> 
>
> Key: DRILL-4779
> URL: https://issues.apache.org/jira/browse/DRILL-4779
> Project: Apache Drill
>  Issue Type: New Feature
>  Components: Storage - Other
>Affects Versions: 1.11.0
>Reporter: B Anil Kumar
>Assignee: B Anil Kumar
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Implement Kafka storage plugin will enable the strong SQL support for Kafka.
> Initially implementation can target for supporting json and avro message types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-3993) Rebase Drill on Calcite master branch

2017-11-28 Thread Roman Kulyk (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268669#comment-16268669
 ] 

Roman Kulyk commented on DRILL-3993:


Working on Functional/Advanced test suits. Need to fix the last failed cases. 
The list of failed tests you can see below:

{noformat}
/root/drillAutomation/drill-test-framework/framework/resources/Functional/schema_change_empty_batch/hbase/emptyHbase_5480_1.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/schema_change_empty_batch/hbase/emptyHbase_5480_2.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/hive/hive_storage/nulls/text23.q
/root/drillAutomation/drill-test-framework/framework/resources/Functional/tpcds/variants/hive/q8_1.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/tpcds/variants/json/q8_1.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/tpcds/variants/parquet/q8_1.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/tpcds/variants/text/q8_1.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/subqueries/not_in/q11.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/subqueries/not_in/q12.sql
/root/drillAutomation/drill-test-framework/framework/resources/Functional/ctas/ctas_auto_partition/general/plan/q3.q
/root/drillAutomation/drill-test-framework/framework/resources/Functional/hbase/hbase_pushdown/plan/pushdown_p7.q
/root/drillAutomation/drill-test-framework/framework/resources/Functional/ctas/ctas_auto_partition/general/plan/drill3947_5.q
/root/drillAutomation/drill-test-framework/framework/resources/Functional/ctas/ctas_auto_partition/general/plan/drill3947_6.q
/root/drillAutomation/drill-test-framework/framework/resources/Functional/filter/pushdown/plan/q4.sql
/root/drillAutomation/drill-test-framework/framework/resources/Advanced/tpcds/tpcds_sf1/original/parquet/query95.sql
{noformat}

> Rebase Drill on Calcite master branch
> -
>
> Key: DRILL-3993
> URL: https://issues.apache.org/jira/browse/DRILL-3993
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning & Optimization
>Affects Versions: 1.2.0
>Reporter: Sudheesh Katkam
>Assignee: Roman Kulyk
>
> Calcite keeps moving, and now we need to catch up to Calcite 1.5, and ensure 
> there are no regressions.
> Also, how do we resolve this 'catching up' issue in the long term?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-4779) Kafka storage plugin support

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268439#comment-16268439
 ] 

ASF GitHub Bot commented on DRILL-4779:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1027
  
Please close the pull request.


> Kafka storage plugin support
> 
>
> Key: DRILL-4779
> URL: https://issues.apache.org/jira/browse/DRILL-4779
> Project: Apache Drill
>  Issue Type: New Feature
>  Components: Storage - Other
>Affects Versions: 1.11.0
>Reporter: B Anil Kumar
>Assignee: B Anil Kumar
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Implement Kafka storage plugin will enable the strong SQL support for Kafka.
> Initially implementation can target for supporting json and avro message types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (DRILL-5994) Cannot start web server on a machine with more than 200 cores

2017-11-28 Thread Mitchel Labonte (JIRA) 
Mitchel Labonte created DRILL-5994:
--

 Summary: Cannot start web server on a machine with more than 200 
cores
 Key: DRILL-5994
 URL: https://issues.apache.org/jira/browse/DRILL-5994
 Project: Apache Drill
  Issue Type: Bug
Reporter: Mitchel Labonte
Priority: Minor


If the WebServer is launched on a machine that has more than 200 cores, you get 
the following stack trace:

{noformat}
Exception in thread "main" 
org.apache.drill.exec.exception.DrillStartupException: Failure during initial 
startup of Drillbit:
at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:313)
at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:289)
at org.apache.drill.exec.server.Drillbit.start(Drillbit.java:285)
Caused by: java.lang.IllegalStateException: Insufficient max threads in 
ThreadPool: max=200 < needed=206
at org.eclipse.jetty.server.Server.doStart(Server.java:321)
at 
org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68)
at org.eclipse.drill.exec.server.rest.WebServer.start(WebServer.java:197)
at org.eclipse.drill.exec.server.Drillbit.run(Drillbit.java:140)
at org.eclipse.drill.exec.server.Drillbit.start(Drillbit.java:309)
... 2 more
{noformat}

The cause of this is that in the WebServer start method, a Server instance is 
created with the default constructor, which initializes a QueuedThreadPool with 
a default maxThreads value of 200, and there is no way to configure this value.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (DRILL-5995) ArangoDB storage engine

2017-11-28 Thread Pinco Palla (JIRA) 
Pinco Palla created DRILL-5995:
--

 Summary: ArangoDB storage engine
 Key: DRILL-5995
 URL: https://issues.apache.org/jira/browse/DRILL-5995
 Project: Apache Drill
  Issue Type: New Feature
Reporter: Pinco Palla


Any timeline on ArangoDB storage engine availability in Drill? 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-4779) Kafka storage plugin support

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268831#comment-16268831
 ] 

ASF GitHub Bot commented on DRILL-4779:
---

Github user akumarb2010 closed the pull request at:

https://github.com/apache/drill/pull/1027


> Kafka storage plugin support
> 
>
> Key: DRILL-4779
> URL: https://issues.apache.org/jira/browse/DRILL-4779
> Project: Apache Drill
>  Issue Type: New Feature
>  Components: Storage - Other
>Affects Versions: 1.11.0
>Reporter: B Anil Kumar
>Assignee: B Anil Kumar
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Implement Kafka storage plugin will enable the strong SQL support for Kafka.
> Initially implementation can target for supporting json and avro message types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-4779) Kafka storage plugin support

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268830#comment-16268830
 ] 

ASF GitHub Bot commented on DRILL-4779:
---

Github user akumarb2010 commented on the issue:

https://github.com/apache/drill/pull/1027
  
Closing this PR, as this is taken care as part of 
https://github.com/apache/drill/pull/1052


> Kafka storage plugin support
> 
>
> Key: DRILL-4779
> URL: https://issues.apache.org/jira/browse/DRILL-4779
> Project: Apache Drill
>  Issue Type: New Feature
>  Components: Storage - Other
>Affects Versions: 1.11.0
>Reporter: B Anil Kumar
>Assignee: B Anil Kumar
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Implement Kafka storage plugin will enable the strong SQL support for Kafka.
> Initially implementation can target for supporting json and avro message types



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5993) Allow Copier to Copy a Record to an Arbitrary Index

2017-11-28 Thread Paul Rogers (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269305#comment-16269305
 ] 

Paul Rogers commented on DRILL-5993:


Although you cannot write to random location is non-fixed-width vectors, there 
is a work around.

Write to the vectors in sequential order. But, use a selection vector (SV2) to 
provide a logical ordering. Pass the SV2 through the Selection Vector Remover 
(SVR) to rewrite the vector in the desired order.

Still, what is the problem being solved here?

> Allow Copier to Copy a Record to an Arbitrary Index
> ---
>
> Key: DRILL-5993
> URL: https://issues.apache.org/jira/browse/DRILL-5993
> Project: Apache Drill
>  Issue Type: New Feature
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the copier can only copy record from an incoming batch to the 
> beginning of an outgoing batch. We need to be able to copy a record to any 
> index in the outgoing batch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (DRILL-5996) Unable to re-run queries from Profiles tab with impersonation and without authentication

2017-11-28 Thread Krystal (JIRA) 
Krystal created DRILL-5996:
--

 Summary: Unable to re-run queries from Profiles tab with 
impersonation and without authentication 
 Key: DRILL-5996
 URL: https://issues.apache.org/jira/browse/DRILL-5996
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - CLI
Affects Versions: 1.12.0
Reporter: Krystal


On drillbit, enable impersonation without authentication.  From WebUI, click on 
a query from Profiles link -> click on the "Edit Query" tab -> click on the 
"Re-Run Query" button.  The query would fail with the following error:

"HTTP ERROR 412

Problem accessing /query. Reason:

User-Name header is not set"

We should also provide a username dialog box for this tab.

 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-4286) Have an ability to put server in quiescent mode of operation

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269404#comment-16269404
 ] 

ASF GitHub Bot commented on DRILL-4286:
---

Github user paul-rogers commented on the issue:

https://github.com/apache/drill/pull/921
  
My suggestion is to go ahead and commit this PR with Jyothsna's change to 
disable the "graceful" part of the graceful shutdown. The feature will be in 
the product and people can turn it on to play with it. Then, @dvjyothsna should 
file a JIRA for the improvements we discussed (enabling by default for true 
servers, disabling for embedded.)


> Have an ability to put server in quiescent mode of operation
> 
>
> Key: DRILL-4286
> URL: https://issues.apache.org/jira/browse/DRILL-4286
> Project: Apache Drill
>  Issue Type: New Feature
>  Components: Execution - Flow
>Affects Versions: 1.11.0
>Reporter: Victoria Markman
>Assignee: Venkata Jyothsna Donapati
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
> Attachments: consoleText.txt, consoleText_after.txt, 
> consoleText_before.txt
>
>
> I think drill will benefit from mode of operation that is called "quiescent" 
> in some databases. 
> From IBM Informix server documentation:
> {code}
> Change gracefully from online to quiescent mode
> Take the database server gracefully from online mode to quiescent mode to 
> restrict access to the database server without interrupting current 
> processing. After you perform this task, the database server sets a flag that 
> prevents new sessions from gaining access to the database server. The current 
> sessions are allowed to finish processing. After you initiate the mode 
> change, it cannot be canceled. During the mode change from online to 
> quiescent, the database server is considered to be in Shutdown mode.
> {code}
> This is different from shutdown, when processes are terminated. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (DRILL-5997) TestLargeFileCompilation tests are borken

2017-11-28 Thread Timothy Farkas (JIRA) 
Timothy Farkas created DRILL-5997:
-

 Summary: TestLargeFileCompilation tests are borken
 Key: DRILL-5997
 URL: https://issues.apache.org/jira/browse/DRILL-5997
 Project: Apache Drill
  Issue Type: Bug
Reporter: Timothy Farkas
Assignee: Timothy Farkas


Codegen fails in the following tests. Nobody noticed because these tests are 
excluded by default

TestLargeFileCompilation#testFILTER
TestLargeFileCompilation#testTEXT_WRITER
TestLargeFileCompilation#testGROUP_BY





--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5998) Queue information of queries which fail due to queue time out not shown

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270257#comment-16270257
 ] 

ASF GitHub Bot commented on DRILL-5998:
---

GitHub user prasadns14 opened a pull request:

https://github.com/apache/drill/pull/1054

DRILL-5998: Set queue name even when exception occurs

@paul-rogers, please review

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prasadns14/drill DRILL-5998

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1054.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1054


commit 4e22cd3c90a028604aacd59f09cf90a72d44f538
Author: Prasad Nagaraj Subramanya 
Date:   2017-11-29T06:44:47Z

DRILL-5998: Set queue name even when exception occurs




> Queue information of queries which fail due to queue time out not shown
> ---
>
> Key: DRILL-5998
> URL: https://issues.apache.org/jira/browse/DRILL-5998
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - HTTP
>Affects Versions: 1.11.0
>Reporter: Prasad Nagaraj Subramanya
>Assignee: Prasad Nagaraj Subramanya
>
> When a query fails because of queue time out, the queue information is not 
> shown in the web UI



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5972) Slow performance for query on INFORMATION_SCHEMA.TABLE

2017-11-28 Thread Padma Penumarthy (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Padma Penumarthy updated DRILL-5972:

Labels: ready-to-commit  (was: )

> Slow performance for query on INFORMATION_SCHEMA.TABLE
> --
>
> Key: DRILL-5972
> URL: https://issues.apache.org/jira/browse/DRILL-5972
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Storage - Information Schema
>Affects Versions: 1.11.0
>Reporter: Padma Penumarthy
>Assignee: Padma Penumarthy
>  Labels: ready-to-commit
> Fix For: 1.13.0
>
>
> A query like the following on INFORMATION_SCHEMA takes a long time to 
> execute. 
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE TABLE_NAME LIKE '%' AND ( TABLE_SCHEMA = 
> 'hive.default' ) ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> Reason being we fetch table information for all schemas instead of just 
> 'hive.default' schema.
> If we  change the predicate like this, it executes very fast.
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE  ( TABLE_SCHEMA = 'hive.default' ) AND 
> TABLE_NAME LIKE '%'  ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> The difference is in the order in which we evaluate the expressions in the 
> predicate.
> In the first case,  we first evaluate TABLE_NAME LIKE '%' and decide that it 
> is inconclusive (since we do not know the schema). So, we go get all tables 
> for all the schemas.
> In the second case, we first evaluate  TABLE_SCHEMA = 'hive.default' and 
> decide that we need to fetch only tables for that schema.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5989) Run Smoke Tests On Travis

2017-11-28 Thread Arina Ielchiieva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-5989:

Affects Version/s: 1.11.0

> Run Smoke Tests On Travis
> -
>
> Key: DRILL-5989
> URL: https://issues.apache.org/jira/browse/DRILL-5989
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the smoke tests don't run on travis. We should update the 
> travis.yml to cache maven dependencies and run the smoke tets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5989) Run Smoke Tests On Travis

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270316#comment-16270316
 ] 

ASF GitHub Bot commented on DRILL-5989:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1053
  
+1, LGTM.


> Run Smoke Tests On Travis
> -
>
> Key: DRILL-5989
> URL: https://issues.apache.org/jira/browse/DRILL-5989
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the smoke tests don't run on travis. We should update the 
> travis.yml to cache maven dependencies and run the smoke tets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5989) Run Smoke Tests On Travis

2017-11-28 Thread Arina Ielchiieva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-5989:

Fix Version/s: 1.12.0

> Run Smoke Tests On Travis
> -
>
> Key: DRILL-5989
> URL: https://issues.apache.org/jira/browse/DRILL-5989
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
> Fix For: 1.12.0
>
>
> Currently the smoke tests don't run on travis. We should update the 
> travis.yml to cache maven dependencies and run the smoke tets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5964) Do not allow queries to access paths outside the current workspace root

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270318#comment-16270318
 ] 

ASF GitHub Bot commented on DRILL-5964:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1050
  
+1, LGTM.


> Do not allow queries to access paths outside the current workspace root
> ---
>
> Key: DRILL-5964
> URL: https://issues.apache.org/jira/browse/DRILL-5964
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Parth Chandra
>Assignee: Parth Chandra
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Workspace definitions in the dfs plugin are intended to provide a convenient 
> shortcut to long directory paths. However, some users may wish to disallow 
> access to paths outside the root of the workspace, possibly to prevent 
> accidental access. Note that this is a convenience option and not a 
> substitute for permissions on the file system.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5989) Run Smoke Tests On Travis

2017-11-28 Thread Arina Ielchiieva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-5989:

Labels: ready-to-commit  (was: )

> Run Smoke Tests On Travis
> -
>
> Key: DRILL-5989
> URL: https://issues.apache.org/jira/browse/DRILL-5989
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>  Labels: ready-to-commit
> Fix For: 1.12.0
>
>
> Currently the smoke tests don't run on travis. We should update the 
> travis.yml to cache maven dependencies and run the smoke tets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5964) Do not allow queries to access paths outside the current workspace root

2017-11-28 Thread Arina Ielchiieva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-5964:

Fix Version/s: 1.12.0

> Do not allow queries to access paths outside the current workspace root
> ---
>
> Key: DRILL-5964
> URL: https://issues.apache.org/jira/browse/DRILL-5964
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Parth Chandra
>Assignee: Parth Chandra
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Workspace definitions in the dfs plugin are intended to provide a convenient 
> shortcut to long directory paths. However, some users may wish to disallow 
> access to paths outside the root of the workspace, possibly to prevent 
> accidental access. Note that this is a convenience option and not a 
> substitute for permissions on the file system.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5964) Do not allow queries to access paths outside the current workspace root

2017-11-28 Thread Arina Ielchiieva (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-5964:

Labels: doc-impacting ready-to-commit  (was: doc-impacting)

> Do not allow queries to access paths outside the current workspace root
> ---
>
> Key: DRILL-5964
> URL: https://issues.apache.org/jira/browse/DRILL-5964
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Parth Chandra
>Assignee: Parth Chandra
>  Labels: doc-impacting, ready-to-commit
> Fix For: 1.12.0
>
>
> Workspace definitions in the dfs plugin are intended to provide a convenient 
> shortcut to long directory paths. However, some users may wish to disallow 
> access to paths outside the root of the workspace, possibly to prevent 
> accidental access. Note that this is a convenience option and not a 
> substitute for permissions on the file system.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (DRILL-5998) Queue information of queries which fail due to queue time out not shown

2017-11-28 Thread Prasad Nagaraj Subramanya (JIRA) 
Prasad Nagaraj Subramanya created DRILL-5998:


 Summary: Queue information of queries which fail due to queue time 
out not shown
 Key: DRILL-5998
 URL: https://issues.apache.org/jira/browse/DRILL-5998
 Project: Apache Drill
  Issue Type: Bug
  Components: Client - HTTP
Affects Versions: 1.11.0
Reporter: Prasad Nagaraj Subramanya
Assignee: Prasad Nagaraj Subramanya


When a query fails because of queue time out, the queue information is not 
shown in the web UI



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5972) Slow performance for query on INFORMATION_SCHEMA.TABLE

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269965#comment-16269965
 ] 

ASF GitHub Bot commented on DRILL-5972:
---

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1038
  
+1. LGTM


> Slow performance for query on INFORMATION_SCHEMA.TABLE
> --
>
> Key: DRILL-5972
> URL: https://issues.apache.org/jira/browse/DRILL-5972
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Storage - Information Schema
>Affects Versions: 1.11.0
>Reporter: Padma Penumarthy
>Assignee: Padma Penumarthy
> Fix For: 1.13.0
>
>
> A query like the following on INFORMATION_SCHEMA takes a long time to 
> execute. 
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE TABLE_NAME LIKE '%' AND ( TABLE_SCHEMA = 
> 'hive.default' ) ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> Reason being we fetch table information for all schemas instead of just 
> 'hive.default' schema.
> If we  change the predicate like this, it executes very fast.
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE  ( TABLE_SCHEMA = 'hive.default' ) AND 
> TABLE_NAME LIKE '%'  ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> The difference is in the order in which we evaluate the expressions in the 
> predicate.
> In the first case,  we first evaluate TABLE_NAME LIKE '%' and decide that it 
> is inconclusive (since we do not know the schema). So, we go get all tables 
> for all the schemas.
> In the second case, we first evaluate  TABLE_SCHEMA = 'hive.default' and 
> decide that we need to fetch only tables for that schema.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5964) Do not allow queries to access paths outside the current workspace root

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269961#comment-16269961
 ] 

ASF GitHub Bot commented on DRILL-5964:
---

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1050
  
Changed the type of allowAccessOutsideWorkspace to boolean. This changes 
behavior. All existing dfs workspaces will also disallow access outside the 
workspace. Ideally, we should deprecate this parameter in a future release, but 
for the moment it allows existing users to access paths outside the workspace 
if they want to.


> Do not allow queries to access paths outside the current workspace root
> ---
>
> Key: DRILL-5964
> URL: https://issues.apache.org/jira/browse/DRILL-5964
> Project: Apache Drill
>  Issue Type: Improvement
>Affects Versions: 1.11.0
>Reporter: Parth Chandra
>Assignee: Parth Chandra
>  Labels: doc-impacting
>
> Workspace definitions in the dfs plugin are intended to provide a convenient 
> shortcut to long directory paths. However, some users may wish to disallow 
> access to paths outside the root of the workspace, possibly to prevent 
> accidental access. Note that this is a convenience option and not a 
> substitute for permissions on the file system.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5971) Fix INT64, INT32 logical types in complex parquet reader

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269970#comment-16269970
 ] 

ASF GitHub Bot commented on DRILL-5971:
---

Github user parthchandra commented on the issue:

https://github.com/apache/drill/pull/1049
  
Updated the PR to include all the remaining logical int types. While 
generating the test file for the unit test, found that some of the types were 
missing from the fast parquet reader so added those as well.


> Fix INT64, INT32 logical types in complex parquet reader
> 
>
> Key: DRILL-5971
> URL: https://issues.apache.org/jira/browse/DRILL-5971
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.11.0
>Reporter: Parth Chandra
>Assignee: Parth Chandra
> Fix For: 1.13.0
>
>
> The 'complex' Parquet reader does not recognize the Parquet logical types 
> INT64, and INT32. 
> Should be a simple change to add these logical types.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5989) Run Smoke Tests On Travis

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269817#comment-16269817
 ] 

ASF GitHub Bot commented on DRILL-5989:
---

Github user ilooner commented on the issue:

https://github.com/apache/drill/pull/1053
  
@arina-ielchiieva 


> Run Smoke Tests On Travis
> -
>
> Key: DRILL-5989
> URL: https://issues.apache.org/jira/browse/DRILL-5989
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the smoke tests don't run on travis. We should update the 
> travis.yml to cache maven dependencies and run the smoke tets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5989) Run Smoke Tests On Travis

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269816#comment-16269816
 ] 

ASF GitHub Bot commented on DRILL-5989:
---

GitHub user ilooner opened a pull request:

https://github.com/apache/drill/pull/1053

DRILL-5989 Travis Finally Runs Smoke Tests!!!

## DRILL-5989

Previously Travis would only do a build for each pull request. Now Travis 
will also run all the smoke tests every time a PR is opened or updated. Smoke 
Tests are defined as tests which do not belong to one of these categories:

- **org.apache.drill.categories.SlowTest**
- **org.apache.drill.categories.SecurityTest**
- **org.apache.drill.categories.UnlikelyTest**

In order to get the smoke tests to run on Travis I had to make the 
following fixes:

- Categorized Kafka storage plugin tests
- Categorized more long running tests as slow tests in order to avoid 
timing out on travis
- Fixed a bug with jdbc-all tests which would cause jdbc-all to fail when 
categories were excluded
- Fixed usage of surefire plugin in java-exec, and fixed a bug which caused 
**excludedGroups** not to be propagated to the java-exec project.
- Made the heap size of the forked test process configurable via a 
property. This was necessary because running the whole build requires about 4gb 
of memory for the test process, but 4gb is too large for the Travis container 
and the smoke tests only require 3.5gb
- Cached maven dependencies for the Travis build so that it runs faster


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ilooner/drill DRILL-5989

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1053.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1053


commit c5274ed3890c9bf116a79043e7610f9d9a968bd6
Author: Timothy Farkas 
Date:   2017-11-22T23:02:07Z

 - Categories some tests to speed up smoke tests
 - Made travis run tests

commit f565e64f7c8f7cf95d6747a2d651979bf4d868bc
Author: Timothy Farkas 
Date:   2017-11-22T23:06:47Z

 - Cache maven artifacts

commit a65e1c1124408b53b376b6a7d4419b38b91a80b2
Author: Timothy Farkas 
Date:   2017-11-23T00:43:44Z

 - Fixed missing class exception

commit f608992b66c2a9347582e5724d11f8bf0e434dda
Author: Timothy Farkas 
Date:   2017-11-27T18:16:46Z

 - Added drill common test classes

commit 6b05a1d2d455e17f78f568f49035e4227ec46686
Author: Timothy Farkas 
Date:   2017-11-28T00:20:20Z

 - Fixed bug where excluded tests are run anyways
 - Reduced runtime of smoke tests by categorizing more long running, 
unlikely, and security tests.
 - Deleted commented out code
 - Fixed class not found exception in the jdbc-all tests

commit 53c70ca598f9821faba2773ff1a743c901a76eb6
Author: Timothy Farkas 
Date:   2017-11-28T01:30:55Z

 - Fixed classpath for tests

commit f87882693b9f9cc571e7335542d831fbe3d79d00
Author: Timothy Farkas 
Date:   2017-11-28T20:02:05Z

 - Categorized kafka tests
 - Increased memory size

commit c594b1164834f5d24e324a227a72edee953e585b
Author: Timothy Farkas 
Date:   2017-11-28T20:02:52Z

 - Added missing file

commit 6e0cb95a492d4802a5c85818455274b8525459e5
Author: Timothy Farkas 
Date:   2017-11-28T20:11:58Z

 - Fixed memory settings again

commit 474cba2915a883ac559c8071a3016cd854e42e63
Author: Timothy Farkas 
Date:   2017-11-28T21:15:26Z

 - Increased memory for travis

commit b59a274511c9d125ee242285c3dee7035577fd4f
Author: Timothy Farkas 
Date:   2017-11-28T22:18:41Z

 - Ignore broken tests

commit fd7ae8f378e9a87cad1f46cfc269709fb1431426
Author: Timothy Farkas 
Date:   2017-11-28T22:37:07Z

 - Fixed yml syntax error

commit ee57dd7c08f3ca7169885bc1993003e05e385610
Author: Timothy Farkas 
Date:   2017-11-28T23:20:47Z

 - More memory config fixes

commit 365f2b58b36748753a42fb6d85792e1f5d5a9552
Author: Timothy Farkas 
Date:   2017-11-29T00:22:53Z

 - Minor code cleanup




> Run Smoke Tests On Travis
> -
>
> Key: DRILL-5989
> URL: https://issues.apache.org/jira/browse/DRILL-5989
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the smoke tests don't run on travis. We should update the 
> travis.yml to

[jira] [Commented] (DRILL-5993) Allow Copier to Copy a Record to an Arbitrary Index

2017-11-28 Thread Timothy Farkas (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269827#comment-16269827
 ] 

Timothy Farkas commented on DRILL-5993:
---

[~Paul.Rogers] You are correct, I should have said append a record to the end 
of an outgoing batch.

> Allow Copier to Copy a Record to an Arbitrary Index
> ---
>
> Key: DRILL-5993
> URL: https://issues.apache.org/jira/browse/DRILL-5993
> Project: Apache Drill
>  Issue Type: New Feature
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the copier can only copy record from an incoming batch to the 
> beginning of an outgoing batch. We need to be able to copy a record to any 
> index in the outgoing batch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (DRILL-5993) Allow Copier to Copy a Record to an Arbitrary Index

2017-11-28 Thread Timothy Farkas (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269827#comment-16269827
 ] 

Timothy Farkas edited comment on DRILL-5993 at 11/29/17 12:43 AM:
--

[~Paul.Rogers] You are correct, I should have said append a record to the end 
of an outgoing batch. The purpose of this is for the HashJoin operator work.


was (Author: timothyfarkas):
[~Paul.Rogers] You are correct, I should have said append a record to the end 
of an outgoing batch.

> Allow Copier to Copy a Record to an Arbitrary Index
> ---
>
> Key: DRILL-5993
> URL: https://issues.apache.org/jira/browse/DRILL-5993
> Project: Apache Drill
>  Issue Type: New Feature
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the copier can only copy record from an incoming batch to the 
> beginning of an outgoing batch. We need to be able to copy a record to any 
> index in the outgoing batch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5993) Allow Copier to Copy a Record and Append to the End of an Outgoing Batch

2017-11-28 Thread Timothy Farkas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Farkas updated DRILL-5993:
--
Summary: Allow Copier to Copy a Record and Append to the End of an Outgoing 
Batch  (was: Allow Copier to Copy a Record to an Arbitrary Index)

> Allow Copier to Copy a Record and Append to the End of an Outgoing Batch
> 
>
> Key: DRILL-5993
> URL: https://issues.apache.org/jira/browse/DRILL-5993
> Project: Apache Drill
>  Issue Type: New Feature
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the copier can only copy record from an incoming batch to the 
> beginning of an outgoing batch. We need to be able to copy a record to any 
> index in the outgoing batch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5972) Slow performance for query on INFORMATION_SCHEMA.TABLE

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269745#comment-16269745
 ] 

ASF GitHub Bot commented on DRILL-5972:
---

Github user parthchandra commented on a diff in the pull request:

https://github.com/apache/drill/pull/1038#discussion_r153658073
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilter.java
 ---
@@ -202,14 +202,19 @@ private Result evaluateHelperFunction(Map recordValues, Function
 // If at least one arg returns FALSE, then the AND function value 
is FALSE
 // If at least one arg returns INCONCLUSIVE, then the AND function 
value is INCONCLUSIVE
 // If all args return TRUE, then the AND function value is TRUE
+Result result = Result.TRUE;
+
 for(ExprNode arg : exprNode.args) {
   Result exprResult = evaluateHelper(recordValues, arg);
-  if (exprResult != Result.TRUE) {
+  if (exprResult == Result.FALSE) {
 return exprResult;
   }
+  if (exprResult == Result.INCONCLUSIVE) {
--- End diff --

Just to be clear. You want to return `Result.INCONCLUSIVE` if any one of 
the expressions is inconclusive  *and* there is no expression that is false.  
Correct ?


> Slow performance for query on INFORMATION_SCHEMA.TABLE
> --
>
> Key: DRILL-5972
> URL: https://issues.apache.org/jira/browse/DRILL-5972
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Storage - Information Schema
>Affects Versions: 1.11.0
>Reporter: Padma Penumarthy
>Assignee: Padma Penumarthy
> Fix For: 1.13.0
>
>
> A query like the following on INFORMATION_SCHEMA takes a long time to 
> execute. 
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE TABLE_NAME LIKE '%' AND ( TABLE_SCHEMA = 
> 'hive.default' ) ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> Reason being we fetch table information for all schemas instead of just 
> 'hive.default' schema.
> If we  change the predicate like this, it executes very fast.
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE  ( TABLE_SCHEMA = 'hive.default' ) AND 
> TABLE_NAME LIKE '%'  ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> The difference is in the order in which we evaluate the expressions in the 
> predicate.
> In the first case,  we first evaluate TABLE_NAME LIKE '%' and decide that it 
> is inconclusive (since we do not know the schema). So, we go get all tables 
> for all the schemas.
> In the second case, we first evaluate  TABLE_SCHEMA = 'hive.default' and 
> decide that we need to fetch only tables for that schema.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (DRILL-5972) Slow performance for query on INFORMATION_SCHEMA.TABLE

2017-11-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/DRILL-5972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16269783#comment-16269783
 ] 

ASF GitHub Bot commented on DRILL-5972:
---

Github user ppadma commented on a diff in the pull request:

https://github.com/apache/drill/pull/1038#discussion_r153661820
  
--- Diff: 
exec/java-exec/src/main/java/org/apache/drill/exec/store/ischema/InfoSchemaFilter.java
 ---
@@ -202,14 +202,19 @@ private Result evaluateHelperFunction(Map recordValues, Function
 // If at least one arg returns FALSE, then the AND function value 
is FALSE
 // If at least one arg returns INCONCLUSIVE, then the AND function 
value is INCONCLUSIVE
 // If all args return TRUE, then the AND function value is TRUE
+Result result = Result.TRUE;
+
 for(ExprNode arg : exprNode.args) {
   Result exprResult = evaluateHelper(recordValues, arg);
-  if (exprResult != Result.TRUE) {
+  if (exprResult == Result.FALSE) {
 return exprResult;
   }
+  if (exprResult == Result.INCONCLUSIVE) {
--- End diff --

@parthchandra yes, that is correct. 


> Slow performance for query on INFORMATION_SCHEMA.TABLE
> --
>
> Key: DRILL-5972
> URL: https://issues.apache.org/jira/browse/DRILL-5972
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Storage - Information Schema
>Affects Versions: 1.11.0
>Reporter: Padma Penumarthy
>Assignee: Padma Penumarthy
> Fix For: 1.13.0
>
>
> A query like the following on INFORMATION_SCHEMA takes a long time to 
> execute. 
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE TABLE_NAME LIKE '%' AND ( TABLE_SCHEMA = 
> 'hive.default' ) ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> Reason being we fetch table information for all schemas instead of just 
> 'hive.default' schema.
> If we  change the predicate like this, it executes very fast.
> select TABLE_CATALOG, TABLE_SCHEMA, TABLE_NAME, TABLE_TYPE from 
> INFORMATION_SCHEMA.`TABLES` WHERE  ( TABLE_SCHEMA = 'hive.default' ) AND 
> TABLE_NAME LIKE '%'  ORDER BY TABLE_TYPE, TABLE_CATALOG, TABLE_SCHEMA, 
> TABLE_NAME; 
> The difference is in the order in which we evaluate the expressions in the 
> predicate.
> In the first case,  we first evaluate TABLE_NAME LIKE '%' and decide that it 
> is inconclusive (since we do not know the schema). So, we go get all tables 
> for all the schemas.
> In the second case, we first evaluate  TABLE_SCHEMA = 'hive.default' and 
> decide that we need to fetch only tables for that schema.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5989) Run Smoke Tests On Travis

2017-11-28 Thread Timothy Farkas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Farkas updated DRILL-5989:
--
Reviewer: Arina Ielchiieva

> Run Smoke Tests On Travis
> -
>
> Key: DRILL-5989
> URL: https://issues.apache.org/jira/browse/DRILL-5989
> Project: Apache Drill
>  Issue Type: Improvement
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the smoke tests don't run on travis. We should update the 
> travis.yml to cache maven dependencies and run the smoke tets.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (DRILL-5993) Allow Copier to Copy a Record and Append to the End of an Outgoing Batch

2017-11-28 Thread Timothy Farkas (JIRA) 

 [ 
https://issues.apache.org/jira/browse/DRILL-5993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Timothy Farkas updated DRILL-5993:
--
Description: Currently the copier can only copy record from an incoming 
batch to the beginning of an outgoing batch. We need to be able to copy a 
record and append it to the end of the outgoing batch.  (was: Currently the 
copier can only copy record from an incoming batch to the beginning of an 
outgoing batch. We need to be able to copy a record to any index in the 
outgoing batch.)

> Allow Copier to Copy a Record and Append to the End of an Outgoing Batch
> 
>
> Key: DRILL-5993
> URL: https://issues.apache.org/jira/browse/DRILL-5993
> Project: Apache Drill
>  Issue Type: New Feature
>Reporter: Timothy Farkas
>Assignee: Timothy Farkas
>
> Currently the copier can only copy record from an incoming batch to the 
> beginning of an outgoing batch. We need to be able to copy a record and 
> append it to the end of the outgoing batch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)