[jira] [Assigned] (DRILL-7460) Exclude classes which cannot be loaded from JDBC Driver

2019-12-19 Thread Vova Vysotskyi (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vova Vysotskyi reassigned DRILL-7460:
-

Assignee: (was: Vova Vysotskyi)

> Exclude classes which cannot be loaded from JDBC Driver 
> 
>
> Key: DRILL-7460
> URL: https://issues.apache.org/jira/browse/DRILL-7460
> Project: Apache Drill
>  Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Vova Vysotskyi
>Priority: Minor
> Fix For: 1.18.0
>
>
> When using drill-jdbc-driver with SQuirreLSQL, it logs the following errors:
> {noformat}
> 2019-11-28 15:22:53,406 [Thread-0] DEBUG 
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - 
> getFileFromUrl: 
> fileUri.getPath()=/Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
> 2019-11-28 15:22:53,431 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load oadd.org.apache.drill.common.util.RepeatTestRule in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: org/junit/rules/TestRule
> 2019-11-28 15:22:53,432 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load oadd.org.apache.drill.common.util.RepeatTestRule$RepeatStatement in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: org/junit/runners/model/Statement
> 2019-11-28 15:22:53,458 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load 
> oadd.org.apache.drill.exec.proto.SchemaGeneralRPCProtos$CompleteRpcMessage$BuilderSchema
>  in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: oadd/io/protostuff/Schema
> 2019-11-28 15:22:53,458 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load 
> oadd.org.apache.drill.exec.proto.SchemaBitControl$BitControlHandshake$BuilderSchema
>  in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: oadd/io/protostuff/Schema
> 2019-11-28 15:22:53,468 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load 
> oadd.org.apache.drill.exec.proto.SchemaUserBitShared$ExceptionWrapper$MessageSchema
>  in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: oadd/io/protostuff/Schema
> 2019-11-28 15:22:53,468 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load 
> oadd.org.apache.drill.exec.proto.SchemaUserProtos$CreatePreparedStatementReq$MessageSchema
>  in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: oadd/io/protostuff/Schema
> 2019-11-28 15:22:53,470 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load 
> oadd.org.apache.drill.exec.proto.SchemaUserBitShared$MetricValue$MessageSchema
>  in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: oadd/io/protostuff/Schema
> 2019-11-28 15:22:53,471 [Thread-0] INFO  
> net.sourceforge.squirrel_sql.client.gui.db.DriverInternalFrame  - Failed to 
> load 
> oadd.org.apache.drill.exec.proto.SchemaGeneralRPCProtos$Ack$MessageSchema in 
> /Users/vova/work/drill/distribution/target/apache-drill-1.17.0-SNAPSHOT/apache-drill-1.17.0-SNAPSHOT/jars/jdbc-driver/drill-jdbc-all-1.17.0-SNAPSHOT.jar
>  to check if it is assignable to java.sql.Driver. Reason: 
> java.lang.NoClassDefFoundError: oadd/io/protostuff/Schema

[jira] [Commented] (DRILL-7230) Add README.md with instructions for release

2019-12-19 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-7230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000113#comment-17000113
 ] 

ASF GitHub Bot commented on DRILL-7230:
---

vvysotskyi commented on pull request #1937: DRILL-7230: Add README.md with 
instructions for release and release scripts
URL: https://github.com/apache/drill/pull/1937
 
 
   Jira - [DRILL-7230](https://issues.apache.org/jira/browse/DRILL-7230).
   
   Release instruction and scripts are based on the 
https://github.com/parthchandra/drill/wiki/Drill-Release-Process, 
https://github.com/parthchandra/stuff/blob/master/scripts/drill-release.sh, and 
https://github.com/parthchandra/stuff/blob/master/scripts/checksum.sh.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add README.md with instructions for release
> ---
>
> Key: DRILL-7230
> URL: https://issues.apache.org/jira/browse/DRILL-7230
> Project: Apache Drill
>  Issue Type: Sub-task
>  Components: Tools, Build  Test
>Reporter: Sorabh Hamirwasia
>Assignee: Vova Vysotskyi
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7490) limit is not pushed to JDBC storage plugin

2019-12-19 Thread Vova Vysotskyi (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vova Vysotskyi updated DRILL-7490:
--
Component/s: Query Planning & Optimization

> limit is not pushed to JDBC storage plugin
> --
>
> Key: DRILL-7490
> URL: https://issues.apache.org/jira/browse/DRILL-7490
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - JDBC, Query Planning  Optimization
>Affects Versions: 1.11.0
>Reporter: Vova Vysotskyi
>Assignee: Vova Vysotskyi
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.18.0
>
>
> The limit is not pushed to JDBC storage plugin. 
> The following query:
> {code:sql}
> select person_id from mysql.`drill_mysql_test`.person limit 10
> {code}
> Returns plan:
> {noformat}
> 00-00Screen
> 00-01  Project(person_id=[$0])
> 00-02SelectionVectorRemover
> 00-03  Limit(fetch=[10])
> 00-04Limit(fetch=[10])
> 00-05  Jdbc(sql=[SELECT `person_id` FROM 
> `drill_mysql_test`.`person` ])
> {noformat}
> This issue happens since incorrect row count is calculated for {{JdbcSort}}.
> Drill enforces to use {{RelNode.estimateRowCount(mq)}} for calculating row 
> count for all inheritants of {{Sort}} rel node (see {{DrillRelMdRowCount}}), 
> but {{JdbcSort}} doesn't override this method and uses parent one which 
> returns row count of input. So planner choses {{DrillLimitRel}} since it has 
> less row count.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7490) limit is not pushed to JDBC storage plugin

2019-12-19 Thread Vova Vysotskyi (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vova Vysotskyi updated DRILL-7490:
--
Component/s: (was: Client - JDBC)
 Storage - JDBC

> limit is not pushed to JDBC storage plugin
> --
>
> Key: DRILL-7490
> URL: https://issues.apache.org/jira/browse/DRILL-7490
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Query Planning  Optimization, Storage - JDBC
>Affects Versions: 1.11.0
>Reporter: Vova Vysotskyi
>Assignee: Vova Vysotskyi
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.18.0
>
>
> The limit is not pushed to JDBC storage plugin. 
> The following query:
> {code:sql}
> select person_id from mysql.`drill_mysql_test`.person limit 10
> {code}
> Returns plan:
> {noformat}
> 00-00Screen
> 00-01  Project(person_id=[$0])
> 00-02SelectionVectorRemover
> 00-03  Limit(fetch=[10])
> 00-04Limit(fetch=[10])
> 00-05  Jdbc(sql=[SELECT `person_id` FROM 
> `drill_mysql_test`.`person` ])
> {noformat}
> This issue happens since incorrect row count is calculated for {{JdbcSort}}.
> Drill enforces to use {{RelNode.estimateRowCount(mq)}} for calculating row 
> count for all inheritants of {{Sort}} rel node (see {{DrillRelMdRowCount}}), 
> but {{JdbcSort}} doesn't override this method and uses parent one which 
> returns row count of input. So planner choses {{DrillLimitRel}} since it has 
> less row count.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Igor Guzenko (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Guzenko updated DRILL-7491:

Description: 
To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
parquet file generated by Hive) and try count on columns *c13 - c15.*  For 
example, 
{code:sql}
SELECT count(c13) FROM dfs.tmp.`hive_alltypes.parquet`
{code}

*Expected result:* {color:green}3 {color}
*Actual result:* {color:red}0{color}

  was:
To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
parquet file generated by Hive) and try count on columns *c13 - c15.*  For 
example, 

{code:sql}

SELECT count(c13) FROM dfs.tmp.``

{code}


> Incorrect COUNT(column) returned for complex types in parquet
> -
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
> Attachments: hive_alltypes.parquet
>
>
> To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
> parquet file generated by Hive) and try count on columns *c13 - c15.*  For 
> example, 
> {code:sql}
> SELECT count(c13) FROM dfs.tmp.`hive_alltypes.parquet`
> {code}
> *Expected result:* {color:green}3 {color}
> *Actual result:* {color:red}0{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Igor Guzenko (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Guzenko updated DRILL-7491:

Description: 
To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
parquet file generated by Hive) and try count on columns *c13 - c15.*  For 
example, 

{code:sql}

SELECT count(c13) FROM dfs.tmp.``

{code}

  was:To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
parquet file generated by Hive) and try count on columns *c13 - c15.* 


> Incorrect COUNT(column) returned for complex types in parquet
> -
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
> Attachments: hive_alltypes.parquet
>
>
> To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
> parquet file generated by Hive) and try count on columns *c13 - c15.*  For 
> example, 
> {code:sql}
> SELECT count(c13) FROM dfs.tmp.``
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Arina Ielchiieva (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-7491:

Description: To reproduce use the attached file for 
{{hive_alltypes.parquet}} (this is parquet file generated by Hive) and try 
count on columns *c13 - c15.*   (was: To reproduce use the attached file for 
{{hive_alltypes.parquet}} and try count on columns *c13 - c15.* )

> Incorrect COUNT(column) returned for complex types in parquet
> -
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
> Attachments: hive_alltypes.parquet
>
>
> To reproduce use the attached file for {{hive_alltypes.parquet}} (this is 
> parquet file generated by Hive) and try count on columns *c13 - c15.* 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Arina Ielchiieva (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-7491:

Description: To reproduce use the attached file for 
{{hive_alltypes.parquet}} and try count on columns *c13 - c15.*   (was: To 
reproduce download the attached file for DRILL-7473 and try count on columns 
*c13 - c15.* )

> Incorrect COUNT(column) returned for complex types in parquet
> -
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
> Attachments: hive_alltypes.parquet
>
>
> To reproduce use the attached file for {{hive_alltypes.parquet}} and try 
> count on columns *c13 - c15.* 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Arina Ielchiieva (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-7491:

Attachment: hive_alltypes.parquet

> Incorrect COUNT(column) returned for complex types in parquet
> -
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
> Attachments: hive_alltypes.parquet
>
>
> To reproduce download the attached file for DRILL-7473 and try count on 
> columns *c13 - c15.* 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Arina Ielchiieva (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1702#comment-1702
 ] 

Arina Ielchiieva commented on DRILL-7491:
-

[~IhorHuzenko] please provide query example :)

> Incorrect COUNT(column) returned for complex types in parquet
> -
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
>
> To reproduce download the attached file for DRILL-7473 and try count on 
> columns *c13 - c15.* 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (DRILL-7492) Do not display Failure node entry if it is not set

2019-12-19 Thread Arina Ielchiieva (Jira)
Arina Ielchiieva created DRILL-7492:
---

 Summary: Do not display Failure node entry if it is not set
 Key: DRILL-7492
 URL: https://issues.apache.org/jira/browse/DRILL-7492
 Project: Apache Drill
  Issue Type: Task
Affects Versions: 1.16.0
Reporter: Arina Ielchiieva


https://github.com/apache/drill/blob/master/exec/java-exec/src/main/resources/rest/profile/profile.ftl#L223

{{errorNode}} is not set in most the times, we should not display {{Failure 
node}} entry is its value is null. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Vova Vysotskyi (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1681#comment-1681
 ] 

Vova Vysotskyi commented on DRILL-7491:
---

Good catch!

> Incorrect COUNT(column) returned for complex types in parquet
> -
>
> Key: DRILL-7491
> URL: https://issues.apache.org/jira/browse/DRILL-7491
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Functions - Drill, Functions - Hive, Storage - Parquet
>Affects Versions: 1.16.0, 1.17.0
>Reporter: Igor Guzenko
>Assignee: Igor Guzenko
>Priority: Major
>
> To reproduce download the attached file for DRILL-7473 and try count on 
> columns *c13 - c15.* 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (DRILL-7491) Incorrect COUNT(column) returned for complex types in parquet

2019-12-19 Thread Igor Guzenko (Jira)
Igor Guzenko created DRILL-7491:
---

 Summary: Incorrect COUNT(column) returned for complex types in 
parquet
 Key: DRILL-7491
 URL: https://issues.apache.org/jira/browse/DRILL-7491
 Project: Apache Drill
  Issue Type: Bug
  Components: Functions - Drill, Functions - Hive, Storage - Parquet
Affects Versions: 1.16.0, 1.17.0
Reporter: Igor Guzenko
Assignee: Igor Guzenko


To reproduce download the attached file for DRILL-7473 and try count on columns 
*c13 - c15.* 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7490) limit is not pushed to JDBC storage plugin

2019-12-19 Thread Arina Ielchiieva (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-7490:

Labels: ready-to-commit  (was: )

> limit is not pushed to JDBC storage plugin
> --
>
> Key: DRILL-7490
> URL: https://issues.apache.org/jira/browse/DRILL-7490
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - JDBC
>Affects Versions: 1.11.0
>Reporter: Vova Vysotskyi
>Assignee: Vova Vysotskyi
>Priority: Major
>  Labels: ready-to-commit
> Fix For: 1.18.0
>
>
> The limit is not pushed to JDBC storage plugin. 
> The following query:
> {code:sql}
> select person_id from mysql.`drill_mysql_test`.person limit 10
> {code}
> Returns plan:
> {noformat}
> 00-00Screen
> 00-01  Project(person_id=[$0])
> 00-02SelectionVectorRemover
> 00-03  Limit(fetch=[10])
> 00-04Limit(fetch=[10])
> 00-05  Jdbc(sql=[SELECT `person_id` FROM 
> `drill_mysql_test`.`person` ])
> {noformat}
> This issue happens since incorrect row count is calculated for {{JdbcSort}}.
> Drill enforces to use {{RelNode.estimateRowCount(mq)}} for calculating row 
> count for all inheritants of {{Sort}} rel node (see {{DrillRelMdRowCount}}), 
> but {{JdbcSort}} doesn't override this method and uses parent one which 
> returns row count of input. So planner choses {{DrillLimitRel}} since it has 
> less row count.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (DRILL-7490) limit is not pushed to JDBC storage plugin

2019-12-19 Thread Arina Ielchiieva (Jira)


 [ 
https://issues.apache.org/jira/browse/DRILL-7490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arina Ielchiieva updated DRILL-7490:

Reviewer: Arina Ielchiieva

> limit is not pushed to JDBC storage plugin
> --
>
> Key: DRILL-7490
> URL: https://issues.apache.org/jira/browse/DRILL-7490
> Project: Apache Drill
>  Issue Type: Bug
>  Components: Client - JDBC
>Affects Versions: 1.11.0
>Reporter: Vova Vysotskyi
>Assignee: Vova Vysotskyi
>Priority: Major
> Fix For: 1.18.0
>
>
> The limit is not pushed to JDBC storage plugin. 
> The following query:
> {code:sql}
> select person_id from mysql.`drill_mysql_test`.person limit 10
> {code}
> Returns plan:
> {noformat}
> 00-00Screen
> 00-01  Project(person_id=[$0])
> 00-02SelectionVectorRemover
> 00-03  Limit(fetch=[10])
> 00-04Limit(fetch=[10])
> 00-05  Jdbc(sql=[SELECT `person_id` FROM 
> `drill_mysql_test`.`person` ])
> {noformat}
> This issue happens since incorrect row count is calculated for {{JdbcSort}}.
> Drill enforces to use {{RelNode.estimateRowCount(mq)}} for calculating row 
> count for all inheritants of {{Sort}} rel node (see {{DrillRelMdRowCount}}), 
> but {{JdbcSort}} doesn't override this method and uses parent one which 
> returns row count of input. So planner choses {{DrillLimitRel}} since it has 
> less row count.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)