[jira] [Commented] (DRILL-8454) Disable unsupported MapR profile and plugin

2023-08-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759606#comment-17759606
 ] 

ASF GitHub Bot commented on DRILL-8454:
---

jnturton commented on PR #2825:
URL: https://github.com/apache/drill/pull/2825#issuecomment-1695823466

   A note to the reviewers. Git's default diff algorithm makes it very hard to 
see that the changes this PR makes to pom.xml are simply whole sections moving 
into comment blocks. GitHub does not allow selection diff algorithm at this 
time so, to ease review, I have therefore [uploaded the diff of pom.xml 
generated using `git diff --diff-algorithm=patience` 
separately](https://gist.github.com/jnturton/f7a623046da2861bad93419529ff78b3). 
It is of course also possible to run this locally after pulling down my branch.




> Disable unsupported MapR profile and plugin
> ---
>
> Key: DRILL-8454
> URL: https://issues.apache.org/jira/browse/DRILL-8454
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Tools, Build  Test
>Affects Versions: 1.21.1
>Reporter: James Turton
>Assignee: James Turton
>Priority: Minor
> Fix For: 1.22.0
>
>
> The MapR build profile and format plugin, which fell out of support in the 
> open source Drill codebase years ago, are disabled. Drill users needing 
> support for these components should contact HPE.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8453) Add XSD Support to XML Reader (Part 1)

2023-08-28 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17759554#comment-17759554
 ] 

ASF GitHub Bot commented on DRILL-8453:
---

cgivre commented on code in PR #2824:
URL: https://github.com/apache/drill/pull/2824#discussion_r1307318742


##
pom.xml:
##
@@ -689,6 +690,34 @@
   **/*.accdb
   **/*.access_log
   **/.asf.yaml
+  **/*.woff2

Review Comment:
   Done!





> Add XSD Support to XML Reader (Part 1)
> --
>
> Key: DRILL-8453
> URL: https://issues.apache.org/jira/browse/DRILL-8453
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Format - XML
>Affects Versions: 1.21.1
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Major
> Fix For: 1.21.2
>
>
> This PR is a part of a series to add better support for reading XML data to 
> Drill.  One of the main challenges is that XML data does not have a way of 
> inferring data types, nor does it have a way of detecting arrays.  
> The only way to do this really well is to have a schema.  Some XML files link 
> a schema definition file to the data.  This PR adds the capability for Drill 
> to map XSD schema files into Drill schemas.  
> The current plan is as follows: Part 1 of this PR simply adds the reader but 
> adds no new user detectable functionality.  Part 2 will include the actual 
> integration with the XML reader.  Part 3 will include the ability to read 
> arrays.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)