[jira] [Commented] (DRILL-8420) Remove Guava shading and patching
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758981#comment-17758981 ] ASF GitHub Bot commented on DRILL-8420: --- jnturton opened a new pull request, #2827: URL: https://github.com/apache/drill/pull/2827 # [DRILL-8420](https://issues.apache.org/jira/browse/DRILL-8420): Remove shaded Guava upgrade stock Guava 32.1.2-jre ## Description - Remove shaded Guava. - Upgrade stock Guava 30.1.1-jre → 32.1.2-jre ## Documentation N/A ## Testing All unit tests pass. Manual testing of Drill JDBC driver. > Remove Guava shading and patching > - > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8420) Remove Guava shading and patching
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758979#comment-17758979 ] ASF GitHub Bot commented on DRILL-8420: --- jnturton closed pull request #2786: DRILL-8420: Remove Guava shading and patching URL: https://github.com/apache/drill/pull/2786 > Remove Guava shading and patching > - > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8420) Remove Guava shading and patching
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758577#comment-17758577 ] ASF GitHub Bot commented on DRILL-8420: --- jnturton commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1691627763 > @jnturton Is this PR still relevant? Yes, I'm going to resurrect it after all the other clean up and upgrade PRs are in. > Remove Guava shading and patching > - > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8420) Remove Guava shading and patching
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17758546#comment-17758546 ] ASF GitHub Bot commented on DRILL-8420: --- cgivre commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1691559682 @jnturton Is this PR still relevant? > Remove Guava shading and patching > - > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8420) Remove Guava shading and patching
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709249#comment-17709249 ] ASF GitHub Bot commented on DRILL-8420: --- jnturton commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1498616790 @cgivre > Thanks for this. Aside from imports, which files were actually modified and I'll do a review? Yes, I'll split the import statement changes into a separate commit. > Do we want to add this to back port to stable? I don't think so. It's not a fix and it definitely carries a risk of breakage with it. Currently the Hadoop 2 build is broken because Drill's Guava patches (but not shading) are still needed in that case so I'll set the PR to draft for the moment. > Remove Guava shading and patching > - > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8420) Remove Guava shading and patching
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709074#comment-17709074 ] ASF GitHub Bot commented on DRILL-8420: --- cgivre commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1497991025 Do we want to add this to back port to stable? > Remove Guava shading and patching > - > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8420) Remove Guava shading and patching
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17709072#comment-17709072 ] ASF GitHub Bot commented on DRILL-8420: --- cgivre commented on PR #2786: URL: https://github.com/apache/drill/pull/2786#issuecomment-1497990433 @jnturton Thanks for this. Aside from imports, which files were actually modified and I'll do a review? > Remove Guava shading and patching > - > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.22.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DRILL-8420) Remove Guava shading and patching, and the conjars repo
[ https://issues.apache.org/jira/browse/DRILL-8420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17707995#comment-17707995 ] ASF GitHub Bot commented on DRILL-8420: --- jnturton opened a new pull request, #2786: URL: https://github.com/apache/drill/pull/2786 # [DRILL-8420](https://issues.apache.org/jira/browse/DRILL-8420): Remove Guava shading and patching, and the conjars repo ## Description - Remove shaded Guava. - Drop conjars repository. - Drop Guava patches. - Upgrade guava to 31.1-jre. - Upgrade parquet to 1.12.3 and parquet-format to 2.9.0. - Move Splunk Maven repository declaration to contrib/storage-splunk/pom.xml. ## Documentation N/A ## Testing Existing unit tests. > Remove Guava shading and patching, and the conjars repo > --- > > Key: DRILL-8420 > URL: https://issues.apache.org/jira/browse/DRILL-8420 > Project: Apache Drill > Issue Type: Improvement > Components: Tools, Build Test >Affects Versions: 1.21.0 >Reporter: James Turton >Assignee: James Turton >Priority: Major > Fix For: 1.21.1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
