[jira] [Commented] (DRILL-6290) Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413725#comment-16413725
 ] 

ASF GitHub Bot commented on DRILL-6290:
---

Github user asfgit closed the pull request at:

https://github.com/apache/drill/pull/1186


> Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility 
> methods
> ---
>
> Key: DRILL-6290
> URL: https://issues.apache.org/jira/browse/DRILL-6290
> Project: Apache Drill
>  Issue Type: Task
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
>Priority: Minor
>  Labels: ready-to-commit
> Fix For: 1.14.0
>
>
> PlanTestBase has useful utility methods to match query plans.
> It would be useful to TestInfoSchemaFilterPushDown to use such utility 
> methods plus loosen expected pattern to match exactly what is needed rather 
> then the whole string.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6290) Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16412232#comment-16412232
 ] 

ASF GitHub Bot commented on DRILL-6290:
---

Github user vdiravka commented on the issue:

https://github.com/apache/drill/pull/1186
  
+1
Thank you for improving the old code


> Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility 
> methods
> ---
>
> Key: DRILL-6290
> URL: https://issues.apache.org/jira/browse/DRILL-6290
> Project: Apache Drill
>  Issue Type: Task
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
>Priority: Minor
> Fix For: 1.14.0
>
>
> PlanTestBase has useful utility methods to match query plans.
> It would be useful to TestInfoSchemaFilterPushDown to use such utility 
> methods plus loosen expected pattern to match exactly what is needed rather 
> then the whole string.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6290) Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411309#comment-16411309
 ] 

ASF GitHub Bot commented on DRILL-6290:
---

GitHub user arina-ielchiieva opened a pull request:

https://github.com/apache/drill/pull/1186

DRILL-6290: Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase 
utility methods

Details in [DRILL-6290](https://issues.apache.org/jira/browse/DRILL-6290).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/arina-ielchiieva/drill DRILL-6290

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/drill/pull/1186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1186


commit c08ba0f36028c5e4c23bd3029033b734495295bc
Author: Arina Ielchiieva 
Date:   2018-03-23T11:33:40Z

DRILL-6290: Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase 
utility methods




> Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility 
> methods
> ---
>
> Key: DRILL-6290
> URL: https://issues.apache.org/jira/browse/DRILL-6290
> Project: Apache Drill
>  Issue Type: Task
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
>Priority: Minor
> Fix For: 1.14.0
>
>
> PlanTestBase has useful utility methods to match query plans.
> It would be useful to TestInfoSchemaFilterPushDown to use such utility 
> methods plus loosen expected pattern to match exactly what is needed rather 
> then the whole string.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DRILL-6290) Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility methods

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/DRILL-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16411310#comment-16411310
 ] 

ASF GitHub Bot commented on DRILL-6290:
---

Github user arina-ielchiieva commented on the issue:

https://github.com/apache/drill/pull/1186
  
@vdiravka please review.


> Refactor TestInfoSchemaFilterPushDown tests to use PlanTestBase utility 
> methods
> ---
>
> Key: DRILL-6290
> URL: https://issues.apache.org/jira/browse/DRILL-6290
> Project: Apache Drill
>  Issue Type: Task
>Reporter: Arina Ielchiieva
>Assignee: Arina Ielchiieva
>Priority: Minor
> Fix For: 1.14.0
>
>
> PlanTestBase has useful utility methods to match query plans.
> It would be useful to TestInfoSchemaFilterPushDown to use such utility 
> methods plus loosen expected pattern to match exactly what is needed rather 
> then the whole string.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)