[jira] [Commented] (DRILL-8437) Add Header Index Pagination

2023-05-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724713#comment-17724713
 ] 

ASF GitHub Bot commented on DRILL-8437:
---

cgivre merged PR #2806:
URL: https://github.com/apache/drill/pull/2806




> Add Header Index Pagination
> ---
>
> Key: DRILL-8437
> URL: https://issues.apache.org/jira/browse/DRILL-8437
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - HTTP
>Affects Versions: 1.21.1
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Major
> Fix For: 1.22.0
>
>
> Some APIs include pagination fields in the HTTP response headers.  This PR 
> adds a new pagination method called Header Index which supports that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (DRILL-8437) Add Header Index Pagination

2023-05-21 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/DRILL-8437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17724647#comment-17724647
 ] 

ASF GitHub Bot commented on DRILL-8437:
---

cgivre opened a new pull request, #2806:
URL: https://github.com/apache/drill/pull/2806

   # [DRILL-8437](https://issues.apache.org/jira/browse/DRILL-8437): Add Header 
Index Pagination
   
   (Please replace `PR Title` with actual PR Title)
   
   ## Description
   See below
   
   
   ## Documentation
   Updated README.
   
   ## Header Index Pagination
   Header index pagination is used when the API in question returns a link to 
the next page in the response header.  Shopify is one such example of an API 
that does this. 
   
   The only configuration option is the `nextPageParam` which is the parameter 
that Drill should look for in the response header.
   
   ```json
"paginator": {
   "nextPageParam": "page",
   "method": "HEADER_INDEX"
 }
   ```
   
   
   ## Testing
   Added UT and manually tested with Shopify API.




> Add Header Index Pagination
> ---
>
> Key: DRILL-8437
> URL: https://issues.apache.org/jira/browse/DRILL-8437
> Project: Apache Drill
>  Issue Type: Improvement
>  Components: Storage - HTTP
>Affects Versions: 1.21.1
>Reporter: Charles Givre
>Assignee: Charles Givre
>Priority: Major
> Fix For: 1.22.0
>
>
> Some APIs include pagination fields in the HTTP response headers.  This PR 
> adds a new pagination method called Header Index which supports that.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)