[GitHub] eagle issue #920: [EAGLE-1009] Fix losing exception issues

2017-04-18 Thread asdf2014
Github user asdf2014 commented on the issue: https://github.com/apache/eagle/pull/920 @qingwen220 Hi, qingwen220. You are right. This situation will not lose any exception because all exception from `try` statement will be catched in `catch` block and it just print the exception

[GitHub] eagle issue #920: [EAGLE-1009] Fix losing exception issues

2017-04-18 Thread qingwen220
Github user qingwen220 commented on the issue: https://github.com/apache/eagle/pull/920 I don't think there are exceptions lost in the code you modified. All these try statements are followed by catch statement which doesn't throw a new exception anymore. I agree with your