[GitHub] incubator-eagle pull request #686: [MINOR] add retry when read jmx timeout

2016-11-28 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/686#discussion_r89955056 --- Diff: eagle-external/hadoop_jmx_collector/metric_collector.py --- @@ -93,21 +93,26 @@ def http_get(host, port, https=False, path=None

[GitHub] incubator-eagle pull request #692: [EAGLE-806] Integrate Metric Process and ...

2016-11-28 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/692 [EAGLE-806] Integrate Metric Process and Persistence with Application Framework Integrate Stream Source and Metric Persistence with Application Framework - Provide API to easily

[GitHub] incubator-eagle issue #671: [EAGLE-787] add healthy check for hadoop-queue/t...

2016-11-21 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/671 LGTM Pls. merge after jenkins building pass. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-eagle issue #667: EAGLE-788 Add unit test for eagle-client-base mo...

2016-11-20 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/667 LGTM Thanks very much for the contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-eagle pull request #670: [EAGLE-791] Refactor eagle module names t...

2016-11-20 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/670 [EAGLE-791] Refactor eagle module names to be more meaningful Refactor eagle module names to be more meaningful for developer to learn about eagle's code structure. https

[GitHub] incubator-eagle pull request #670: [EAGLE-791] Refactor eagle module names t...

2016-11-20 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/670#discussion_r88824965 --- Diff: eagle-core/eagle-query/eagle-query-base/pom.xml --- @@ -28,6 +28,8 @@ eagle-query-base +Eagle::Core::Query::Base

[GitHub] incubator-eagle pull request #725: [EAGLE-833] Add MetricSchemaGenerator and...

2016-12-08 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/725 [EAGLE-833] Add MetricSchemaGenerator and MetricSchemaService * Add MetricSchemaService to store metric schema aside GenericMetric * Add MetricSchemaGenerator to automatically generate

[GitHub] incubator-eagle pull request #750: [EAGLE-843] Refactor application shared s...

2016-12-16 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/750#discussion_r92778513 --- Diff: eagle-core/eagle-app/eagle-app-base/src/main/java/org/apache/eagle/app/spi/ApplicationProvider.java --- @@ -72,7 +75,20

[GitHub] incubator-eagle pull request #750: [EAGLE-843] Refactor application shared s...

2016-12-16 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/750#discussion_r92778778 --- Diff: eagle-server/src/main/java/org/apache/eagle/server/ServerApplication.java --- @@ -107,18 +111,31 @@ public void run(ServerConfig

[GitHub] incubator-eagle pull request #750: [EAGLE-843] Refactor application shared s...

2016-12-16 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/750 [EAGLE-843] Refactor application shared service registry framework Refactor application shared service registry framework https://issues.apache.org/jira/browse/EAGLE-843 You can

[GitHub] incubator-eagle issue #736: Eagle-836 Add JMX start up page

2016-12-13 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/736 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-eagle issue #735: [EAGLE-839] add job diagnostics

2016-12-13 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/735 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-eagle pull request #733: [MINOR] Resolve defunct process in hadoop...

2016-12-12 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/733 [MINOR] Resolve defunct process in hadoop jmx script by kill -9 - Resolve defunct process in hadoop jmx script by kill -9 - Support configurable log file path - Improve JMX reader

[GitHub] incubator-eagle pull request #721: [MINOR] Refactor alert list and detail pa...

2016-12-07 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/721 [MINOR] Refactor alert list and detail pages # Changes * Refactor alert list and detail pages * Add "storage.hbase.autoCreateTable" (boolean) config to improve serve

[GitHub] incubator-eagle issue #742: EAGLE-834 Add Daily Job Summery Report

2016-12-14 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/742 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] incubator-eagle pull request #746: [EAGLE-834] Improve jpm report template b...

2016-12-15 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/746 [EAGLE-834] Improve jpm report template by fixing font-size and notes * Improve jpm report template by fixing font-size and notes http://issues.apache.org/jira/browse/EAGLE-834 You

[GitHub] incubator-eagle issue #686: [MINOR] add retry when read jmx timeout

2016-12-03 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/686 LGTM, please merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] incubator-eagle pull request #711: [EAGLE-815] Add eagle alert template, sev...

2016-12-02 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/711 [EAGLE-815] Add eagle alert template, severity and category support Support alert template to generate human readable message * Support to define alert template in PolicyDefinition

[GitHub] incubator-eagle pull request #701: [EAGLE-816] Fix host problem in jmx colle...

2016-11-30 Thread haoch
GitHub user haoch opened a pull request: https://github.com/apache/incubator-eagle/pull/701 [EAGLE-816] Fix host problem in jmx collector script [EAGLE-816] Fix host problem in jmx collector script Fix host name bug in jmx collector scripts, which current always only use

[GitHub] incubator-eagle pull request #708: [MINOR] support group by in siddhi patter...

2016-12-04 Thread haoch
Github user haoch commented on a diff in the pull request: https://github.com/apache/incubator-eagle/pull/708#discussion_r90795623 --- Diff: eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/interpreter/PolicyExecutionPlan.java

[GitHub] incubator-eagle issue #716: [MINOR]Fix initial sql syntax problem

2016-12-06 Thread haoch
Github user haoch commented on the issue: https://github.com/apache/incubator-eagle/pull/716 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so