Adam Saghy created FINERACT-1672: ------------------------------------ Summary: Fix inconsistent Date and Date time handling Key: FINERACT-1672 URL: https://issues.apache.org/jira/browse/FINERACT-1672 Project: Apache Fineract Issue Type: Improvement Reporter: Adam Saghy
In the DB some of the fields are DATE when it should be DATETIME and vice versa. Also in JPA some of the fields are mapped wrongly: * TemporalType is wrong * TemporalType is missing |m_client_non_person|incorp_validity_till|Date.from(incorpValidityTill.atStartOfDay(ZoneId.systemDefault()).toInstant())|System|Should be changed to DATE| |m_floating_rates_periods|from_date|Date.from(date).atStartOfDay(ZoneId.systemDefault()).toInstant())|System|Should be changed to DATE| |m_holiday|from_date|Date.from(newValue.atStartOfDay(ZoneId.systemDefault()).toInstant())|System|Should be changed to DATE| |m_holiday|to_date|Date.from(newValue.atStartOfDay(ZoneId.systemDefault()).toInstant())|System|Should be changed to DATE| |m_holiday|repayments_rescheduled_to|Date.from(newValue.atStartOfDay(ZoneId.systemDefault()).toInstant())|System|Should be changed to DATE| |m_loan_disbursement_detail|expected_disburse_date|User-defined: Date.from(actualDisbursementDate.atStartOfDay(ZoneId.systemDefault()).toInstant())|System|Should be changed to DATE| |m_loan_disbursement_detail|disbursedon_date|Date.from(actualDisbursementDate.atStartOfDay(ZoneId.systemDefault()).toInstant()))|System|Should be changed to DATE| |m_share_product|start_date|DateUtils.getDateOfTenant();|Tenant|Should be changed to DATE| |m_share_product|end_date|DateUtils.getDateOfTenant();|Tenant|Should be changed to DATE| |m_surveys|valid_from|Date.from(DateUtils.getLocalDateOfTenant().atStartOfDay(ZoneId.systemDefault()).toInstant())|System|Should be changed to DATE| |m_surveys|valid_to|cal.getTime() + 100 years|System|Should be changed to DATE| *Acceptance criteria* * All places the proper DATE or DATETIME type is used -- This message was sent by Atlassian Jira (v8.20.10#820010)