[GitHub] fineract pull request #401: Extend-mifos-data-import-tool-office populate & ...

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/401#discussion_r132179421 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/office/OfficeImportHandler.java --- @@ -0,0

[GitHub] fineract pull request #401: Extend-mifos-data-import-tool-office populate & ...

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/401#discussion_r132178962 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/office/OfficeWorkbookPopulator.java --- @@ -0,0

[GitHub] fineract pull request #401: Extend-mifos-data-import-tool-office populate & ...

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/401#discussion_r132178051 --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/office/data/OfficeData.java --- @@ -40,6 +41,34 @@

[GitHub] fineract pull request #401: Extend-mifos-data-import-tool-office populate & ...

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/401#discussion_r132177471 --- Diff: fineract-provider/src/main/java/org/apache/fineract/organisation/office/api/OfficesApiResource.java --- @@ -165,4 +177,21 @@ public

[GitHub] fineract pull request #401: Extend-mifos-data-import-tool-office populate & ...

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/401#discussion_r132170296 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/ImportHandler.java --- @@ -0,0 +1,26 @@

[GitHub] fineract pull request #401: Extend-mifos-data-import-tool-office populate & ...

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/401#discussion_r132169308 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/AbstractImportHandler.java --- @@ -0,0 +1,143

[GitHub] fineract pull request #401: Extend-mifos-data-import-tool-office populate & ...

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/401#discussion_r132167595 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/ImportFormatType.java --- @@ -0,0 +1,49 @@ +/**

[GitHub] fineract pull request #404: Self user role and report access

2017-08-09 Thread nazeer1100126
GitHub user nazeer1100126 opened a pull request: https://github.com/apache/fineract/pull/404 Self user role and report access You can merge this pull request into a Git repository by running: $ git pull https://github.com/nazeer1100126/incubator-fineract

[GitHub] fineract pull request #397: Integrated TOIF into apache-fineract

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/fineract/pull/397#discussion_r132120780 --- Diff: fineract-provider/toif/housekeeping/housekeeping.txt --- @@ -0,0 +1,36 @@ +### +#Facts

[GitHub] fineract issue #283: Notification Module

2017-08-09 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/fineract/pull/283 @ad-os as discussed over slack, You have added a library which is having dependency on BSD licensed third party library. Can you check the current binary licensing please. --- If your