Github user avikganguly01 commented on a diff in the pull request:

    https://github.com/apache/fineract/pull/401#discussion_r135389025
  
    --- Diff: 
fineract-provider/src/main/java/org/apache/fineract/organisation/office/data/OfficeData.java
 ---
    @@ -40,6 +42,34 @@
         @SuppressWarnings("unused")
         private final Collection<OfficeData> allowedParents;
     
    +    //import fields
    +    private transient Integer rowIndex;
    +    private String locale;
    +    private String dateFormat;
    +
    +    public OfficeData(String name, Long parentId,LocalDate 
openingDate,String externalId,Integer rowIndex) {
    +
    --- End diff --
    
    @wkk91193 Hey, please follow convention here. All instantiator functions 
are static methods which should in turn call the private constructor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to