GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/411
FINERACT-494 Issue when selecting savings account on client creation â¦
â¦page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/410
sms notification
1)to register client
method - post
url- /device/registration
body
{
"clientId" : 3
"registrationId" : "
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/374#discussion_r134218439
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/service/TwoFactorServiceImpl.java
---
@@ -0,0 +1,221
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/396
@Anh3h please send PR after rebasing to latest code. Your PR shouldn't have
Adhyan changes
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/374#discussion_r133724939
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/data/TwoFactorConfigurationValidator.java
---
@@ -0,0 +1,120
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/374#discussion_r133724306
--- Diff:
fineract-provider/src/main/resources/META-INF/spring/securityContext.xml ---
@@ -42,19 +42,26 @@
method
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/374#discussion_r133721774
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/service/TwoFactorServiceImpl.java
---
@@ -0,0 +1,221
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/374#discussion_r133719473
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/service/TwoFactorConfigurationServiceImpl.java
---
@@ -0,0
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/374#discussion_r133673728
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/domain/TFAccessToken.java
---
@@ -0,0 +1,137
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/374#discussion_r133669923
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/PlatformEmailService.java
---
@@ -26,5 +26,4 @@ void
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/402
follow the common comments from other pull request related to import tool
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/403
create a utility class for file related functionality which should contain
1)getNumberOfRows
2)all read as methods
readAsInt,readAsLong,readAsDouble,readAsString,readAsDate etc.
3
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/403#discussion_r133640875
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/codes/data/CodeValueData.java
---
@@ -37,6 +37,15 @@
private
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/403#discussion_r133640512
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/service/BulkImportWorkbookPopulatorServiceImpl.java
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/403#discussion_r133639899
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/chartofaccounts/ChartOfAccountsWorkbook.java
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/403#discussion_r133638020
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/chartofaccounts/ChartOfAccountsWorkbook.java
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/403#discussion_r133634512
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/chartofaccounts/ChartOfAccountsImportHandler.java
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/403#discussion_r133631616
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/service/GLAccountReadPlatformServiceImpl.java
---
@@ -123,11
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/403#discussion_r133630362
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/accounting/glaccount/api/GLAccountsApiResource.java
---
@@ -219,4 +231,21 @@ private
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/399
@nikpawar89 Please follow
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/283
@ad-os Please refer LICENSE_RELEASE file. You need to add an entry about
this BSD library.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/401#discussion_r132179421
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/office/OfficeImportHandler.java
---
@@ -0,0
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/401#discussion_r132178962
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/office/OfficeWorkbookPopulator.java
---
@@ -0,0
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/401#discussion_r132178051
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/organisation/office/data/OfficeData.java
---
@@ -40,6 +41,34
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/401#discussion_r132177471
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/organisation/office/api/OfficesApiResource.java
---
@@ -165,4 +177,21 @@ public
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/401#discussion_r132170296
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/ImportHandler.java
---
@@ -0,0 +1,26
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/401#discussion_r132169308
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/importhandler/AbstractImportHandler.java
---
@@ -0,0 +1,143
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/401#discussion_r132167595
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/ImportFormatType.java
---
@@ -0,0 +1,49
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/404
Self user role and report access
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/397#discussion_r132120780
--- Diff: fineract-provider/toif/housekeeping/housekeeping.txt ---
@@ -0,0 +1,36 @@
+###
+#Facts
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/283
@ad-os as discussed over slack, You have added a library which is having
dependency on BSD licensed third party library. Can you check the current
binary licensing please.
---
If your
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/283
@ad-os Changes looks ok. Can you resent PR with single commit please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/400
self service registration role
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/283#discussion_r130303691
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationMapperReadPlatformServiceImpl.java
---
@@ -0,0 +1,53
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/394
To create request-
https://localhost:8443/fineract-provider/api/v1/self/registration
{
"username" : "user1",
"firstName" : &
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/394
self service registration
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract
self_service_registration
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/388
FINERACT-498
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract FINERACT-498
Alternatively you can
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/387
holiday partial
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract holiday
Alternatively you can review
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/386
FINERACT-439
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract
develop_mirror
Alternatively you can
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/380#discussion_r127177143
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountWritePlatformServiceJpaRepositoryImpl.java
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/380#discussion_r127179728
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionDataValidator.java
---
@@ -94,6 +95,9
Github user nazeer1100126 closed the pull request at:
https://github.com/apache/fineract/pull/377
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/fineract/pull/377
485 make payment with flat interest calculation(Null Pointer)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/359
@Ippezrobert I believe we need to implement savings transaction note
similar to loan transaction note.
1) Add a new column in m_note table for savings transaction id
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/374
@MegaAlex Send PR with single commit and please resolve the conflicts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/375
@ThisuraThejith I suggest to have separate exception classes or generic
type exceptions (for each sms and journaly entry) which takes errorcode, user
message in the constructor
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/357
@ThisuraThejith thank you. Please make sure to send PR with single commit
from next time :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/369#discussion_r122164855
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/adhocquery/domain/AdHoc.java
---
@@ -0,0 +1,156 @@
+/**
+ * Licensed
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/fineract/pull/365#discussion_r121935605
--- Diff:
fineract-provider/src/main/resources/sql/migrations/core_db/V329__adhocquery_changes.sql
---
@@ -0,0 +1,21 @@
+--
--- End diff
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/362
You need to modify appContext.xml. You need to add this new package to bean
scan and you need to add repository package also. Please include this xml as
part of next PR
---
If your project
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/361
@iamrupok close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/361
@iamrupok Yes, only committers will have push permission. You need to send
PR to this repo.
1) Checkout a local branch from this repo and do the changes. add the
changes and then commit
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/359
@Ippezrobert can we discuss on Skype ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/359
@Ippezrobert in this screen
https://demo.openmf.org/#/viewsavingtrxn/790/trxnId/9212
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/359
@Ippezrobert Don't we require to show this note in the UI when user is
selecting these transactions?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/354
@raj140916 thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/341
@Ippezrobert You need to add that note parameter to
SavingsApiConstants.SAVINGS_ACCOUNT_TRANSACTION_REQUEST_DATA_PARAMETERS
---
If your project is set up for it, you can reply to this email
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/341
ah got it. He didn't add noteParamName in supported parameter list
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/341
@Ippezrobert can you give some more details? What validations should we do
in SavingsAccountTransactionDataValidator ?
---
If your project is set up for it, you can reply to this email
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/341
Changes are OK. But it is having two commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/320
@nikpawar89 Please let me know whether I understood correctly. With this
implementation, I can define credit bureau, credit bureau products and map them
to a loan product. So where is actual
Github user nazeer1100126 commented on the issue:
https://github.com/apache/fineract/pull/320
@nikpawar89 Please follow coding style defined by
https://google.github.io/styleguide/javaguide.html
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/incubator-fineract/pull/353
bug fixed 458,310,453,158,166
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract bug_fixes
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/incubator-fineract/pull/352
Prepayloan 158 166
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract prepayloan
Alternatively
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/incubator-fineract/pull/350
loan integration test case fixes 453
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/incubator-fineract/pull/349
sql injections fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract
Github user nazeer1100126 closed the pull request at:
https://github.com/apache/incubator-fineract/pull/342
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/incubator-fineract/pull/345
issue 205 for jlg change of disbursement date at time of disbursement
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/335
This is merged. Due to sync issue it is not reflecting here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/331#discussion_r112660699
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/security/utils/SQLInjectionValidator.java
---
@@ -0,0 +1,117
Github user nazeer1100126 commented on a diff in the pull request:
https://github.com/apache/incubator-fineract/pull/331#discussion_r112660811
--- Diff:
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientReadPlatformServiceImpl.java
---
@@ -225,6
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/incubator-fineract/pull/338
#261 validation added on disabling gl account
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator
GitHub user nazeer1100126 opened a pull request:
https://github.com/apache/incubator-fineract/pull/336
317 flat installment amount
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nazeer1100126/incubator-fineract
73 matches
Mail list logo
