[GitHub] incubator-fineract issue #248: Fix for resolving scorecards, and replacing d...

2016-11-22 Thread mgeiss
Github user mgeiss commented on the issue: https://github.com/apache/incubator-fineract/pull/248 what is the issue? it works fine on my system ... but I use a MariaDB 10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] incubator-fineract issue #178: Added notification module

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/178 You need to listen to the business events and you can push notifications in your message queue. API resourced should not have this changes. --- If your project is set up for it,

[GitHub] incubator-fineract issue #248: Fix for resolving scorecards, and replacing d...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/248 Migration is failing with V323__spm_replace_dead_fk_with_exisiting_one.sql --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-fineract issue #239: API for Email Campaign feature implementation

2016-11-22 Thread Ippezrobert
Github user Ippezrobert commented on the issue: https://github.com/apache/incubator-fineract/pull/239 Hi @nazeer1100126 , Could you please make the little tweaks with the existing SMS Campaign if you are not so busy or you can delegate @satish-conflux to work on these changes as

[GitHub] incubator-fineract issue #239: API for Email Campaign feature implementation

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on the issue: https://github.com/apache/incubator-fineract/pull/239 I see we can make use of existing SMS Campaign classes with little tweaks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r89067494 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/handler/UpdateEmailCommandHandler.java --- @@

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r88862014 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/api/EmailCampaignApiResource.java --- @@ -0,0

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r89057283 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java --- @@ -0,0 +1,538

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r89057853 --- Diff:

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r88860343 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/api/EmailCampaignApiResource.java --- @@ -0,0

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r89068747 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientRepository.java --- @@ -21,6 +21,6 @@

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r88860871 --- Diff: fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/api/EmailApiResource.java --- @@ -0,0 +1,188

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r88856163 --- Diff: fineract-provider/dependencies.gradle --- @@ -90,7 +90,7 @@ dependencies { // it's useful to have this for

[GitHub] incubator-fineract pull request #239: API for Email Campaign feature impleme...

2016-11-22 Thread nazeer1100126
Github user nazeer1100126 commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/239#discussion_r89056528 --- Diff: fineract-provider/src/main/java/org/apache/fineract/commands/service/CommandWrapperBuilder.java --- @@ -2803,4 +2803,82 @@