[jira] [Commented] (FLINK-1525) Provide utils to pass -D parameters to UDFs

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537616#comment-14537616 ] ASF GitHub Bot commented on FLINK-1525: --- Github user hsaputra commented on the pull

[GitHub] flink pull request: [FLINK-1525][FEEDBACK] Introduction of a small...

2015-05-10 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/664#issuecomment-100775629 This is great idea @rmetzger I am bit confuse about the addition of UserConfig interface. Is the interface added to add abstraction for the ParameterUtil?

[jira] [Commented] (FLINK-1979) Implement Loss Functions

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537342#comment-14537342 ] ASF GitHub Bot commented on FLINK-1979: --- Github user jojo19893 commented on the pull

[GitHub] flink pull request: [FLINK-1979] Lossfunctions

2015-05-10 Thread jojo19893
Github user jojo19893 commented on the pull request: https://github.com/apache/flink/pull/656#issuecomment-100696661 Okay I Changed the implementation of the logistic loss! Thanks for the advice ! --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-1999) TF-IDF transformer

2015-05-10 Thread Alexander Alexandrov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537358#comment-14537358 ] Alexander Alexandrov commented on FLINK-1999: - I agree with [~Felix Neutatz],

[GitHub] flink pull request: [FLINK-1964] Rework TwitterSource to use a Pro...

2015-05-10 Thread carloscurotto
Github user carloscurotto commented on a diff in the pull request: https://github.com/apache/flink/pull/666#discussion_r30009100 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/twitter/PropertiesUtil.java ---

[jira] [Commented] (FLINK-1964) Rework TwitterSource to use a Properties object instead of a file path

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537476#comment-14537476 ] ASF GitHub Bot commented on FLINK-1964: --- Github user carloscurotto commented on a

[jira] [Commented] (FLINK-1999) TF-IDF transformer

2015-05-10 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537143#comment-14537143 ] Felix Neutatz commented on FLINK-1999: -- Hi Ronny, I guess the functionality is

[jira] [Updated] (FLINK-1999) TF-IDF transformer

2015-05-10 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz updated FLINK-1999: - Assignee: Alexander Alexandrov (was: Felix Neutatz) TF-IDF transformer --

[jira] [Assigned] (FLINK-1999) TF-IDF transformer

2015-05-10 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz reassigned FLINK-1999: Assignee: Felix Neutatz TF-IDF transformer -- Key:

[jira] [Updated] (FLINK-1999) TF-IDF transformer

2015-05-10 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz updated FLINK-1999: - Component/s: Machine Learning Library TF-IDF transformer --

[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check

2015-05-10 Thread Mathusuthan Kannan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537082#comment-14537082 ] Mathusuthan Kannan commented on FLINK-1711: --- Robert, I am sorry I could not

[jira] [Commented] (FLINK-1525) Provide utils to pass -D parameters to UDFs

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537086#comment-14537086 ] ASF GitHub Bot commented on FLINK-1525: --- Github user rmetzger commented on the pull

[GitHub] flink pull request: [FLINK-1525][FEEDBACK] Introduction of a small...

2015-05-10 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/664#issuecomment-100605507 Thank you for the feedback so far! @uce In the word count example: is the only point of setting the user config in the execution config only to show the

[GitHub] flink pull request: [FLINK-1525][FEEDBACK] Introduction of a small...

2015-05-10 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/664#issuecomment-100600902 **Feedback w/o code review** I like the idea very much. +1 for the general thing. Exporting it to the web interface is great. Thanks for this. :-) The

[jira] [Commented] (FLINK-1525) Provide utils to pass -D parameters to UDFs

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537076#comment-14537076 ] ASF GitHub Bot commented on FLINK-1525: --- Github user uce commented on the pull

[GitHub] flink pull request: [FLINK-1525][FEEDBACK] Introduction of a small...

2015-05-10 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/664#issuecomment-100601591 Cool tool, Robert. This is definitely useful for users. If this tool also supported positional arguments, then we wouldn't have to change how the

[jira] [Commented] (FLINK-1525) Provide utils to pass -D parameters to UDFs

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537081#comment-14537081 ] ASF GitHub Bot commented on FLINK-1525: --- Github user tillrohrmann commented on the

[jira] [Updated] (FLINK-1711) Replace all usages off commons.Validate with guava.check

2015-05-10 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1711: -- Assignee: (was: Mathusuthan Kannan) Replace all usages off commons.Validate with

[jira] [Updated] (FLINK-1711) Replace all usages off commons.Validate with guava.check

2015-05-10 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-1711: -- Assignee: Lokesh Rajaram Replace all usages off commons.Validate with guava.check

[jira] [Commented] (FLINK-1711) Replace all usages off commons.Validate with guava.check

2015-05-10 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537109#comment-14537109 ] Robert Metzger commented on FLINK-1711: --- Hey, no problem ;) I assigned

[jira] [Created] (FLINK-1999) TF-IDF transformer

2015-05-10 Thread JIRA
Ronny Bräunlich created FLINK-1999: -- Summary: TF-IDF transformer Key: FLINK-1999 URL: https://issues.apache.org/jira/browse/FLINK-1999 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-1964) Rework TwitterSource to use a Properties object instead of a file path

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537300#comment-14537300 ] ASF GitHub Bot commented on FLINK-1964: --- Github user rmetzger commented on a diff in

[jira] [Updated] (FLINK-1999) TF-IDF transformer

2015-05-10 Thread Felix Neutatz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Felix Neutatz updated FLINK-1999: - Labels: ML (was: ) TF-IDF transformer -- Key: FLINK-1999

[GitHub] flink pull request: [FLINK-1964] Rework TwitterSource to use a Pro...

2015-05-10 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/666#discussion_r30004354 --- Diff: flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/twitter/PropertiesUtil.java --- @@

[jira] [Commented] (FLINK-1964) Rework TwitterSource to use a Properties object instead of a file path

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537281#comment-14537281 ] ASF GitHub Bot commented on FLINK-1964: --- GitHub user carloscurotto opened a pull

[GitHub] flink pull request: [FLINK-1964] Rework TwitterSource to use a Pro...

2015-05-10 Thread carloscurotto
GitHub user carloscurotto opened a pull request: https://github.com/apache/flink/pull/666 [FLINK-1964] Rework TwitterSource to use a Properties object I have changed TwitterSource and its related code to use a properties object insted of a file path so we could inject properties

[GitHub] flink pull request: [FLINK-1964] Rework TwitterSource to use a Pro...

2015-05-10 Thread carloscurotto
Github user carloscurotto commented on the pull request: https://github.com/apache/flink/pull/666#issuecomment-100671079 Let me also suggest a few other further improvements: TwitterSource: - put the default value for queueSize attribute in a constant (we could call

[jira] [Commented] (FLINK-1964) Rework TwitterSource to use a Properties object instead of a file path

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537288#comment-14537288 ] ASF GitHub Bot commented on FLINK-1964: --- Github user carloscurotto commented on the

[jira] [Commented] (FLINK-1959) Accumulators BROKEN after Partitioning

2015-05-10 Thread mustafa elbehery (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537312#comment-14537312 ] mustafa elbehery commented on FLINK-1959: - Any updates for this bug ?!!This is

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537318#comment-14537318 ] ASF GitHub Bot commented on FLINK-1735: --- Github user aalexandrov commented on a diff

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

2015-05-10 Thread aalexandrov
Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30004988 --- Diff: flink-staging/flink-ml/src/test/scala/org/apache/flink/ml/feature/extraction/FeatureHasherSuite.scala --- @@ -0,0 +1,245 @@ +/* + *

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

2015-05-10 Thread aalexandrov
Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005062 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537319#comment-14537319 ] ASF GitHub Bot commented on FLINK-1735: --- Github user aalexandrov commented on a diff

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

2015-05-10 Thread aalexandrov
Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005080 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537320#comment-14537320 ] ASF GitHub Bot commented on FLINK-1735: --- Github user aalexandrov commented on a diff

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

2015-05-10 Thread aalexandrov
Github user aalexandrov commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005092 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + * Licensed

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537321#comment-14537321 ] ASF GitHub Bot commented on FLINK-1735: --- Github user aalexandrov commented on a diff

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

2015-05-10 Thread aalexandrov
Github user aalexandrov commented on the pull request: https://github.com/apache/flink/pull/665#issuecomment-100685242 Nice job! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537323#comment-14537323 ] ASF GitHub Bot commented on FLINK-1735: --- Github user aalexandrov commented on the

[GitHub] flink pull request: [FLINK-1735] Feature Hasher

2015-05-10 Thread FelixNeutatz
Github user FelixNeutatz commented on a diff in the pull request: https://github.com/apache/flink/pull/665#discussion_r30005430 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/feature/extraction/FeatureHasher.scala --- @@ -0,0 +1,142 @@ +/* + *

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537332#comment-14537332 ] ASF GitHub Bot commented on FLINK-1735: --- Github user FelixNeutatz commented on a

[GitHub] flink pull request: [FLINK-1735] Feature hasher

2015-05-10 Thread FelixNeutatz
Github user FelixNeutatz closed the pull request at: https://github.com/apache/flink/pull/661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request: [FLINK-1735] Feature hasher

2015-05-10 Thread FelixNeutatz
Github user FelixNeutatz commented on the pull request: https://github.com/apache/flink/pull/661#issuecomment-100690583 This will be further implemented here: https://github.com/apache/flink/pull/665 --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537333#comment-14537333 ] ASF GitHub Bot commented on FLINK-1735: --- Github user FelixNeutatz commented on the

[jira] [Commented] (FLINK-1735) Add FeatureHasher to machine learning library

2015-05-10 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537334#comment-14537334 ] ASF GitHub Bot commented on FLINK-1735: --- Github user FelixNeutatz closed the pull