Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/700#issuecomment-115133956
Thanks, seems like all is fine now. We will start reviewing this in the
next few days.
---
If your project is set up for it, you can reply to this email and have your
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-115207592
You don't do it. I think it's best at the moment to only make the
histograms available within the ml package. Everyone who wants to use them, can
then add
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-115228662
Also, apparently no tests were ever run after these changes. All fail on
the build server on basic checkstyle rules even.
---
If your project is set up for it, you
[
https://issues.apache.org/jira/browse/FLINK-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601093#comment-14601093
]
ASF GitHub Bot commented on FLINK-2230:
---
Github user StephanEwen commented on the
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-115248743
@StephanEwen hinted that the best way to go would be to decuple the
RowTypeInfo completely from the TupleTypeInfo/TupleSerializerBase. This way, we
get null-value
[
https://issues.apache.org/jira/browse/FLINK-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601127#comment-14601127
]
ASF GitHub Bot commented on FLINK-2230:
---
Github user aljoscha commented on the pull
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/747#discussion_r33256890
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601038#comment-14601038
]
ASF GitHub Bot commented on FLINK-2255:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-1956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601037#comment-14601037
]
ASF GitHub Bot commented on FLINK-1956:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/857
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-115210476
Okay. So I guess we can leave adding a createHistogram function to
DataSetUtils for now [It would also require utilizing the FlinkMLTools.block
for an efficient
[
https://issues.apache.org/jira/browse/FLINK-2255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Márton Balassi closed FLINK-2255.
-
Resolution: Fixed
Fix Version/s: 0.10
Fixed via af05b94d0d
In the TopSpeedWindowing
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/867#issuecomment-115227753
We actually had a discussion about this quite a few times. I also raised my
concerns in the discussion of the issue, to which no one reacted.
The
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-115202017
For the moment, I think it's best to place it under
`org.apache.flink.ml.density`, for example.
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/FLINK-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601062#comment-14601062
]
ASF GitHub Bot commented on FLINK-2230:
---
GitHub user Shiti opened a pull request:
GitHub user Shiti opened a pull request:
https://github.com/apache/flink/pull/867
[FLINK-2230] handling null values for TupleSerializer
When serializing, we add a `byte[] (BitSet.toByteArray)` before the fields
which indicates `null` fields.
When deserializing, we fetch
[
https://issues.apache.org/jira/browse/FLINK-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601092#comment-14601092
]
ASF GitHub Bot commented on FLINK-2230:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/747#discussion_r33253164
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java
---
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-115204540
How should I import a class in flink.ml.math from say, flink-java? I tried
adding flink-staging as a dependency to pom.xml of flink-java but to no avail.
I'm not
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/818#issuecomment-115215460
Thank you @shghatge! I'll merge this :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
[
https://issues.apache.org/jira/browse/FLINK-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601137#comment-14601137
]
ASF GitHub Bot commented on FLINK-2271:
---
Github user vasia commented on the pull
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/747#discussion_r33253332
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java
---
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-115262360
Good changes +1
There are some assumptions about the call order of the newly introduced
functions though (like you have to call prepare make_src_release [or be in
[
https://issues.apache.org/jira/browse/FLINK-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601159#comment-14601159
]
Stephan Ewen commented on FLINK-2239:
-
There is pending work to support larger results
[
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601031#comment-14601031
]
ASF GitHub Bot commented on FLINK-2093:
---
Github user vasia commented on the pull
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/868
[tools] Make release script a bit more flexible
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink release_script
Alternatively
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/863#issuecomment-115194215
Thank you @samk3211! This looks good :)
I see that like here, @mjsax has also created a utils class for the new
comparison methods in #866.
Since all migrated
[
https://issues.apache.org/jira/browse/FLINK-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600944#comment-14600944
]
ASF GitHub Bot commented on FLINK-2264:
---
Github user vasia commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600948#comment-14600948
]
Sebastian Kruse commented on FLINK-2239:
I used the
[
https://issues.apache.org/jira/browse/FLINK-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Theodore Vasiloudis reassigned FLINK-2108:
--
Assignee: Theodore Vasiloudis (was: Sachin Goel)
Add score function for
[
https://issues.apache.org/jira/browse/FLINK-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600951#comment-14600951
]
Theodore Vasiloudis commented on FLINK-2108:
OK I will take this then, the
Sachin Goel created FLINK-2276:
--
Summary: Travis build error
Key: FLINK-2276
URL: https://issues.apache.org/jira/browse/FLINK-2276
Project: Flink
Issue Type: Bug
Reporter: Sachin
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/772#issuecomment-115198124
Actually I wouldn't call it predictSomething, because then we're again
quite close to the former problem that we have a method whose semantics depend
on the
[
https://issues.apache.org/jira/browse/FLINK-2116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600958#comment-14600958
]
ASF GitHub Bot commented on FLINK-2116:
---
Github user tillrohrmann commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-115199291
Where should I place the Histogram implementations? Currently, they are in
{{org.apache.flink.ml.math}}, but I can't import them from the flink-core where
the
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/818
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/863
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601972#comment-14601972
]
ASF GitHub Bot commented on FLINK-2264:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-2093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601971#comment-14601971
]
ASF GitHub Bot commented on FLINK-2093:
---
Github user asfgit closed the pull request
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/747#discussion_r33259296
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java
---
@@
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/747#issuecomment-115275285
I think we have no real blocker here. I would prefer the exception issue
could be addressed (message for wrapping exception).
Everything else will probably
[
https://issues.apache.org/jira/browse/FLINK-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601254#comment-14601254
]
Chiwan Park commented on FLINK-2105:
Hi [~r-pogalz],
I think that this issue covers
Github user gyfora commented on a diff in the pull request:
https://github.com/apache/flink/pull/747#discussion_r33259615
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java
---
@@
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/747#issuecomment-115268784
Should we merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/747#issuecomment-115277122
Okay I will fix the exceptions and will merge it afterwards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/747#discussion_r33259429
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/state/PartitionedStreamOperatorState.java
---
[
https://issues.apache.org/jira/browse/FLINK-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved FLINK-2232.
Resolution: Fixed
StormWordCountLocalITCase fails
---
[
https://issues.apache.org/jira/browse/FLINK-2066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14601529#comment-14601529
]
Nuno Miguel Marques dos Santos commented on FLINK-2066:
---
Hi guys.
I
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/868#issuecomment-115366539
HI @rmetzger, could you summarize the intention of the PR here? Like what
is the final goal of the changes?
---
If your project is set up for it, you can reply to this
[
https://issues.apache.org/jira/browse/FLINK-2163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602000#comment-14602000
]
Vasia Kalavri commented on FLINK-2163:
--
This test has now been changed to use
[
https://issues.apache.org/jira/browse/FLINK-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri resolved FLINK-2264.
--
Resolution: Fixed
Fix Version/s: 0.10
Congrats on your first contribution [~Samia]!
[
https://issues.apache.org/jira/browse/FLINK-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri resolved FLINK-1522.
--
Resolution: Fixed
Fix Version/s: 0.10
Add tests for the library methods and examples
[
https://issues.apache.org/jira/browse/FLINK-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vasia Kalavri resolved FLINK-2271.
--
Resolution: Fixed
PageRank gives wrong results with weighted graph input
[
https://issues.apache.org/jira/browse/FLINK-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600798#comment-14600798
]
ASF GitHub Bot commented on FLINK-1731:
---
Github user thvasilo commented on the pull
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/832#issuecomment-115134406
Hey Theo,
Thanks a lot for finding my bug there ^^
PR updated to address the Java issues and to contain a pimped Scala
version of `zipWithIndex` :)
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/865#issuecomment-115167456
Thanks for adding tests. The changes look good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
[
https://issues.apache.org/jira/browse/FLINK-2271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600890#comment-14600890
]
ASF GitHub Bot commented on FLINK-2271:
---
Github user mxm commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600905#comment-14600905
]
ASF GitHub Bot commented on FLINK-2275:
---
Github user mjsax commented on the pull
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/866#issuecomment-115173704
I adapted all tests except for DataSinkITCase and
ExecutionEnvironmentITCase.
- DataSinkITCase - seems to test writing to file explicit; would not make
sense to
Github user nikste commented on the pull request:
https://github.com/apache/flink/pull/805#issuecomment-115180597
This did not work unfortunately, the class was available in the test, but
unfortunately not in the shell which is invoked in the test.
However, if you add the
[
https://issues.apache.org/jira/browse/FLINK-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600917#comment-14600917
]
ASF GitHub Bot commented on FLINK-2161:
---
Github user nikste commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600937#comment-14600937
]
ASF GitHub Bot commented on FLINK-1745:
---
Github user thvasilo commented on the pull
Github user thvasilo commented on the pull request:
https://github.com/apache/flink/pull/696#issuecomment-115189878
Just a correction, the functionality you will need is in #832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/861#issuecomment-115180791
The easiest way is probably to check out her branch or the PR and then
rebase your work on hers.
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/FLINK-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600934#comment-14600934
]
Ricky Pogalz commented on FLINK-2105:
-
Hi,
first of all thanks for your answers
66 matches
Mail list logo
