[GitHub] flink pull request: [Flink-2030][ml]Online Histogram: Discrete and...

Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/861#issuecomment-118775803 Since Till is very busy these days, I would ask @chiwanpark if he can take some time to review this, so that we can merge it if we get +1's. --- If your project is set

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33916738 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user chiwanpark commented on the pull request: https://github.com/apache/flink/pull/696#issuecomment-118792663 @thvasilo Thanks :) I'll update this pull request soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614810#comment-14614810 ] ASF GitHub Bot commented on FLINK-1745: --- Github user chiwanpark commented on the

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33921868 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-2293) Division by Zero Exception

[ https://issues.apache.org/jira/browse/FLINK-2293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614835#comment-14614835 ] Fabian Hueske commented on FLINK-2293: -- The fix changes the logic of the bucket

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614829#comment-14614829 ] ASF GitHub Bot commented on FLINK-1745: --- Github user chiwanpark commented on a diff

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33921518 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614834#comment-14614834 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614857#comment-14614857 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33923303 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614823#comment-14614823 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33921277 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on the pull request: https://github.com/apache/flink/pull/696#issuecomment-118807403 Hello Chiwan, I had some comments on the code. In a more general sense, I have some concerns about the rationale of including an algorithm that by its nature

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614855#comment-14614855 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on the pull

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614876#comment-14614876 ] ASF GitHub Bot commented on FLINK-1745: --- Github user andralungu commented on a diff

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user andralungu commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33924163 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33916817 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614729#comment-14614729 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[jira] [Commented] (FLINK-2299) The slot on which the task maanger was scheduled was killed

[ https://issues.apache.org/jira/browse/FLINK-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614730#comment-14614730 ] Stephan Ewen commented on FLINK-2299: - [~andralungu] Th number you want to increase is

[jira] [Commented] (FLINK-2157) Create evaluation framework for ML library

[ https://issues.apache.org/jira/browse/FLINK-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614704#comment-14614704 ] ASF GitHub Bot commented on FLINK-2157: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-2157] [ml] [WIP] Create evaluation fram...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/871#discussion_r33914602 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/Classifier.scala --- @@ -0,0 +1,43 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614717#comment-14614717 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33916339 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614727#comment-14614727 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614761#comment-14614761 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33916420 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33916484 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614719#comment-14614719 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[jira] [Commented] (FLINK-1967) Introduce (Event)time in Streaming

[ https://issues.apache.org/jira/browse/FLINK-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614710#comment-14614710 ] ASF GitHub Bot commented on FLINK-1967: --- Github user aljoscha commented on the pull

[GitHub] flink pull request: [FLINK-2240] Use BloomFilter to filter probe r...

GitHub user ChengXiangLi opened a pull request: https://github.com/apache/flink/pull/888 [FLINK-2240] Use BloomFilter to filter probe records in Hybrid-Hash-Join In Hybrid-Hash-Join, while small table does not fit into memory, part of the small table data would be spilled to disk,

[GitHub] flink pull request: [FLINK-1967] Introduce (Event)time in Streamin...

Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/879#issuecomment-11844 I thought about how we could change it so that the Watermarks are transmitted in-band with the stream records. This would require the StreamRecordSerializer to handle

[jira] [Commented] (FLINK-2240) Use BloomFilter to minimize probe side records which are spilled to disk in Hybrid-Hash-Join

[ https://issues.apache.org/jira/browse/FLINK-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614711#comment-14614711 ] ASF GitHub Bot commented on FLINK-2240: --- GitHub user ChengXiangLi opened a pull

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614723#comment-14614723 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33916882 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-1745) Add exact k-nearest-neighbours algorithm to machine learning library

[ https://issues.apache.org/jira/browse/FLINK-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614733#comment-14614733 ] ASF GitHub Bot commented on FLINK-1745: --- Github user thvasilo commented on a diff in

[GitHub] flink pull request: [FLINK-1745] [ml] [WIP] Add exact k-nearest-ne...

Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/696#discussion_r33917198 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/classification/KNN.scala --- @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-2240) Use BloomFilter to minimize probe side records which are spilled to disk in Hybrid-Hash-Join

[ https://issues.apache.org/jira/browse/FLINK-2240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614780#comment-14614780 ] ASF GitHub Bot commented on FLINK-2240: --- Github user ChengXiangLi commented on the

[GitHub] flink pull request: [FLINK-2240] Use BloomFilter to filter probe r...

Github user ChengXiangLi commented on the pull request: https://github.com/apache/flink/pull/888#issuecomment-118786914 I did a simple test on single node, here is the related information: 1 task manager, 1 slot, 1G RAM assigned, probe table 5G, build table 1G, half of build table

[jira] [Created] (FLINK-2320) Enable DataSet DataStream Joins

Matthias J. Sax created FLINK-2320: -- Summary: Enable DataSet DataStream Joins Key: FLINK-2320 URL: https://issues.apache.org/jira/browse/FLINK-2320 Project: Flink Issue Type: New Feature

[GitHub] flink pull request: [FLINK-2311] Fixes 'flink-*' dependency scope ...

Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/880#issuecomment-118832384 Okay, I've closed the JIRA. can you close the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Closed] (FLINK-2311) Set flink-* dependencies in flink-contrib as provided

[ https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger closed FLINK-2311. - Resolution: Won't Fix Fix Version/s: (was: 0.9.1) (was: 0.10)

[jira] [Commented] (FLINK-2311) Set flink-* dependencies in flink-contrib as provided

[ https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614936#comment-14614936 ] ASF GitHub Bot commented on FLINK-2311: --- Github user aalexandrov closed the pull

[jira] [Commented] (FLINK-2311) Set flink-* dependencies in flink-contrib as provided

[ https://issues.apache.org/jira/browse/FLINK-2311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14614934#comment-14614934 ] ASF GitHub Bot commented on FLINK-2311: --- Github user rmetzger commented on the pull

[jira] [Created] (FLINK-2321) The seed for the SVM classifier is currently static

Theodore Vasiloudis created FLINK-2321: -- Summary: The seed for the SVM classifier is currently static Key: FLINK-2321 URL: https://issues.apache.org/jira/browse/FLINK-2321 Project: Flink

[jira] [Commented] (FLINK-2321) The seed for the SVM classifier is currently static

[ https://issues.apache.org/jira/browse/FLINK-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615037#comment-14615037 ] ASF GitHub Bot commented on FLINK-2321: --- GitHub user thvasilo opened a pull request:

[GitHub] flink pull request: [FLINK-2321] [ml] The seed for the SVM classif...

GitHub user thvasilo opened a pull request: https://github.com/apache/flink/pull/889 [FLINK-2321] [ml] The seed for the SVM classifier is currently static The seed for the SVM algorithm in FlinkML has a default value of 0, meaning that if it's not set, we always have the same seed

[jira] [Commented] (FLINK-2141) Allow GSA's Gather to perform this operation in more than one direction

[ https://issues.apache.org/jira/browse/FLINK-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615252#comment-14615252 ] ASF GitHub Bot commented on FLINK-2141: --- Github user vasia commented on the pull

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118921231 Updated PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2141) Allow GSA's Gather to perform this operation in more than one direction

[ https://issues.apache.org/jira/browse/FLINK-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615289#comment-14615289 ] ASF GitHub Bot commented on FLINK-2141: --- Github user shghatge commented on the pull

[jira] [Commented] (FLINK-2141) Allow GSA's Gather to perform this operation in more than one direction

[ https://issues.apache.org/jira/browse/FLINK-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615174#comment-14615174 ] ASF GitHub Bot commented on FLINK-2141: --- Github user andralungu commented on the

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

Github user andralungu commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118891421 I see the requirements have been fulfilled here. If no objections, I'd like to merge this by the end of the week :) --- If your project is set up for it, you can

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-11815 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] flink pull request: [FLINK-1520]Read edges and vertices from CSV f...

Github user shghatge commented on the pull request: https://github.com/apache/flink/pull/847#issuecomment-11598 Updated PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-2141) Allow GSA's Gather to perform this operation in more than one direction

[ https://issues.apache.org/jira/browse/FLINK-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615158#comment-14615158 ] ASF GitHub Bot commented on FLINK-2141: --- Github user shghatge commented on the pull

[jira] [Commented] (FLINK-2141) Allow GSA's Gather to perform this operation in more than one direction

[ https://issues.apache.org/jira/browse/FLINK-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14615250#comment-14615250 ] ASF GitHub Bot commented on FLINK-2141: --- Github user vasia commented on a diff in

[GitHub] flink pull request: [FLINK-2141] Allow GSA's Gather to perform thi...

Github user vasia commented on the pull request: https://github.com/apache/flink/pull/877#issuecomment-118912040 Hi @shghatge, @andralungu! I left one comment that I think is quite serious. Apart from that, I had also left a minor comment on the gelly-guide changes in the last