[jira] [Assigned] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-2974: - Assignee: Robert Metzger > Add periodic offset commit to Kafka Consumer if checkpointing

[jira] [Commented] (FLINK-3052) Optimizer does not push properties out of bulk iterations

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015658#comment-15015658 ] ASF GitHub Bot commented on FLINK-3052: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-3052] [optimizer] Fix instantiation of ...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1388#issuecomment-158373108 Good fix! +1 to merge this! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45461902 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java --- @@

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016678#comment-15016678 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016676#comment-15016676 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016685#comment-15016685 ] ASF GitHub Bot commented on FLINK-2974: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016684#comment-15016684 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1341#issuecomment-158377800 Thank you for the review. I'll address the comments and merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45463542 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java --- @@ -290,9

[GitHub] flink pull request: [FLINK-3000]Adds shutdown hook to clean up lin...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1354#issuecomment-158425799 Thank you for looking into the issue. I'll soon try it out on a cluster. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: [FLINK-3045] Properly expose the key of a Kafk...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1385#issuecomment-158401295 I agree. Its a new feature and under normal circumstances we would not add this to a bugfix release. However, I would really like to merge it for 0.10.1 because a

[jira] [Commented] (FLINK-3045) Properly expose the key of a kafka message

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018009#comment-15018009 ] ASF GitHub Bot commented on FLINK-3045: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-2861] Fields grouping on split streams ...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1387#issuecomment-158416101 I ran into that issue a while back. The problem was that you emit elements that have the name/tag of the split stream (to use the split selector) and over that, you

[jira] [Commented] (FLINK-2861) Fields grouping on split streams fails

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018087#comment-15018087 ] ASF GitHub Bot commented on FLINK-2861: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [docs] Fix Documentation formatting for recent...

2015-11-20 Thread smarthi
GitHub user smarthi opened a pull request: https://github.com/apache/flink/pull/1389 [docs] Fix Documentation formatting for recently added ExecutionEnvironment.readSequenceFile() You can merge this pull request into a Git repository by running: $ git pull

[jira] [Created] (FLINK-3054) Remove R (return) type variable from SerializationSchema

2015-11-20 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-3054: - Summary: Remove R (return) type variable from SerializationSchema Key: FLINK-3054 URL: https://issues.apache.org/jira/browse/FLINK-3054 Project: Flink

[GitHub] flink pull request: Out-of-core state backend for JDBC databases

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1305#discussion_r45474858 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateBackend.java --- @@ -64,33 +64,35 @@ /** * Closes the state

[GitHub] flink pull request: [FLINK-3052] [optimizer] Fix instantiation of ...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [docs] Fix Documentation formatting for recent...

2015-11-20 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1389#issuecomment-158427436 LGTM. Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018093#comment-15018093 ] ASF GitHub Bot commented on FLINK-2974: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-3052) Optimizer does not push properties out of bulk iterations

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018053#comment-15018053 ] ASF GitHub Bot commented on FLINK-3052: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1341 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: Out-of-core state backend for JDBC databases

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1305#issuecomment-158423218 Had an offline chat with @gyfora with the following outcome: - A deterministic state identifier is needed - Small change to pass that identifier as a

[jira] [Commented] (FLINK-3000) Add ShutdownHook to YARN CLI to prevent lingering sessions

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018129#comment-15018129 ] ASF GitHub Bot commented on FLINK-3000: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-2488) Expose attemptNumber in RuntimeContext

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018047#comment-15018047 ] ASF GitHub Bot commented on FLINK-2488: --- Github user sachingoel0101 commented on the pull request:

[GitHub] flink pull request: [FLINK-2488] Expose Attempt Number in RuntimeC...

2015-11-20 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1386#issuecomment-158408532 @rmetzger I have added a test case to verify the functionality. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Resolved] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-2974. --- Resolution: Fixed Fix Version/s: 0.10.1 1.0.0 Resolved for 1.0.0 in

[jira] [Created] (FLINK-3052) Optimizer does not push properties out of bulk iterations

2015-11-20 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-3052: Summary: Optimizer does not push properties out of bulk iterations Key: FLINK-3052 URL: https://issues.apache.org/jira/browse/FLINK-3052 Project: Flink

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016683#comment-15016683 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45462208 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java ---

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1341#issuecomment-158377427 Some comments, manly on redundant constructs and style. Otherwise good to merge... --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-3045) Properly expose the key of a kafka message

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015628#comment-15015628 ] ASF GitHub Bot commented on FLINK-3045: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016524#comment-15016524 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45461644 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java --- @@

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45461519 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java --- @@

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015983#comment-15015983 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-3045) Properly expose the key of a kafka message

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016690#comment-15016690 ] ASF GitHub Bot commented on FLINK-3045: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3020][streaming] set number of task slo...

2015-11-20 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1360#issuecomment-158334929 I think we agree that we want to set the number of task slots to the maximum parallelism instead of the default one. I'll merge this later on. --- If your project is set

[jira] [Commented] (FLINK-3020) Local streaming execution: set number of task manager slots to the maximum parallelism

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015478#comment-15015478 ] ASF GitHub Bot commented on FLINK-3020: --- Github user mxm commented on the pull request:

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15017747#comment-15017747 ] ASF GitHub Bot commented on FLINK-2974: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016673#comment-15016673 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45461871 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java --- @@

[GitHub] flink pull request: [FLINK-3045] Properly expose the key of a Kafk...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1385#issuecomment-158378202 Thank you for the review. I'll change the `KeyedSerializationSchema` interface. Do you think we should merge this into 0.10.1 as well? --- If your project

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016714#comment-15016714 ] ASF GitHub Bot commented on FLINK-2974: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-3052) Optimizer does not push properties out of bulk iterations

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15017745#comment-15017745 ] ASF GitHub Bot commented on FLINK-3052: --- Github user tillrohrmann commented on the pull request:

[jira] [Created] (FLINK-3053) SuccessAfterNetworkBuffersFailureITCase.testSuccessfulProgramAfterFailure

2015-11-20 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created FLINK-3053: -- Summary: SuccessAfterNetworkBuffersFailureITCase.testSuccessfulProgramAfterFailure Key: FLINK-3053 URL: https://issues.apache.org/jira/browse/FLINK-3053 Project:

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015517#comment-15015517 ] ASF GitHub Bot commented on FLINK-2017: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-158340342 I'm wondering whether you are trying to run the examples I'm posting here: ```java RequiredParameters rq = new RequiredParameters(); rq.add("input");

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-11-20 Thread mliesenberg
Github user mliesenberg commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-158345168 Oha. that is embarrassing, I thought I had it covered. I'll look into it. Sorry for the mess. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015529#comment-15015529 ] ASF GitHub Bot commented on FLINK-2017: --- Github user mliesenberg commented on the pull request:

[GitHub] flink pull request: [FLINK-3045] Properly expose the key of a Kafk...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1385#issuecomment-158366729 Looks quite good. I was wondering whether the KeyedSerializationSchema should have two methods, one to serialize key, one to serialize the value. That way

[GitHub] flink pull request: [FLINK-3052] [optimizer] Fix instantiation of ...

2015-11-20 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/1388 [FLINK-3052] [optimizer] Fix instantiation of bulk iteration candidates When a candidate for a bulk iteration is instantiated, then the optimizer creates candidates for the step function.

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45461971 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java --- @@

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/1341#discussion_r45462057 --- Diff: flink-streaming-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer.java --- @@

[jira] [Commented] (FLINK-3045) Properly expose the key of a kafka message

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016694#comment-15016694 ] ASF GitHub Bot commented on FLINK-3045: --- Github user StephanEwen commented on the pull request:

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-158335983 Yes, in IntelliJ the button right to the Debug button will generate a test coverage report. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015485#comment-15015485 ] ASF GitHub Bot commented on FLINK-2017: --- Github user rmetzger commented on the pull request:

[jira] [Commented] (FLINK-3052) Optimizer does not push properties out of bulk iterations

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015638#comment-15015638 ] ASF GitHub Bot commented on FLINK-3052: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1341#issuecomment-158373979 You can probably undo most of the docs changes, these are fixed by now... --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015668#comment-15015668 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on the pull request:

[jira] [Commented] (FLINK-2974) Add periodic offset commit to Kafka Consumer if checkpointing is disabled

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15016681#comment-15016681 ] ASF GitHub Bot commented on FLINK-2974: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request: [FLINK-3045] Properly expose the key of a Kafk...

2015-11-20 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1385#issuecomment-158379363 It is a new feature in some sense, but it does not break anything, so probably no harm in adding it to 0.10.1 as well... --- If your project is set up for it, you

[GitHub] flink pull request: [FLINK-2974] Add periodic offset committer for...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1341#issuecomment-158391607 I updated the PR. Once travis is green I'll merge it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink pull request: [docs] Fix Documentation formatting for recent...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1389 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3051) Define a maximum number of concurrent inflight checkpoints

2015-11-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018198#comment-15018198 ] Stephan Ewen commented on FLINK-3051: - As part of this feature, I also started adding a config object

[GitHub] flink pull request: Out-of-core state backend for JDBC databases

2015-11-20 Thread gyfora
Github user gyfora commented on a diff in the pull request: https://github.com/apache/flink/pull/1305#discussion_r45479951 --- Diff: flink-contrib/flink-streaming-contrib/src/main/java/org/apache/flink/contrib/streaming/state/DbStateHandle.java --- @@ -0,0 +1,88 @@ +/* +

[GitHub] flink pull request: Out-of-core state backend for JDBC databases

2015-11-20 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1305#discussion_r45479621 --- Diff: flink-contrib/flink-streaming-contrib/src/main/java/org/apache/flink/contrib/streaming/state/DbStateHandle.java --- @@ -0,0 +1,88 @@ +/*

[jira] [Commented] (FLINK-3054) Remove R (return) type variable from SerializationSchema

2015-11-20 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018194#comment-15018194 ] Stephan Ewen commented on FLINK-3054: - +1 will be API breaking, though... > Remove R (return) type

[jira] [Created] (FLINK-3055) ExecutionVertex has duplicate method getParallelSubtaskIndex and getSubTaskIndex

2015-11-20 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-3055: -- Summary: ExecutionVertex has duplicate method getParallelSubtaskIndex and getSubTaskIndex Key: FLINK-3055 URL: https://issues.apache.org/jira/browse/FLINK-3055 Project:

[jira] [Resolved] (FLINK-2860) The mlr object from the FlinkML Getting Started code example uses an undefined argument

2015-11-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-2860. -- Resolution: Fixed Fixed via 09433032d8ecb13c66204d8912225af919577b4e > The mlr object from the

[jira] [Commented] (FLINK-2860) The mlr object from the FlinkML Getting Started code example uses an undefined argument

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018348#comment-15018348 ] ASF GitHub Bot commented on FLINK-2860: --- Github user tillrohrmann commented on the pull request:

[jira] [Commented] (FLINK-2860) The mlr object from the FlinkML Getting Started code example uses an undefined argument

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018352#comment-15018352 ] ASF GitHub Bot commented on FLINK-2860: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-2860] [ml] [docs] The mlr object from t...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request: [FLINK-2860] [ml] [docs] The mlr object from t...

2015-11-20 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1310#issuecomment-158462775 Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3009) Cannot build docs with Jekyll 3.0.0

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018759#comment-15018759 ] ASF GitHub Bot commented on FLINK-3009: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3009] Add dockerized jekyll environment

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request:

2015-11-20 Thread smarthi
Github user smarthi commented on the pull request: https://github.com/apache/flink/commit/8dc70f2e770ac1c355869f5e0b5e23379b1ed76f#commitcomment-14534466 In flink-optimizer/src/test/java/org/apache/flink/optimizer/IterationsCompilerTest.java: In

[GitHub] flink pull request: [FLINK-2861] Fields grouping on split streams ...

2015-11-20 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1387#issuecomment-158538344 Btw: Travis fails due to a instable test -- I already create a JIRA for it. --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-2861) Fields grouping on split streams fails

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1501#comment-1501 ] ASF GitHub Bot commented on FLINK-2861: --- Github user mjsax commented on the pull request:

[jira] [Commented] (FLINK-2861) Fields grouping on split streams fails

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15018885#comment-15018885 ] ASF GitHub Bot commented on FLINK-2861: --- Github user mjsax commented on the pull request:

[GitHub] flink pull request: [FLINK-2861] Fields grouping on split streams ...

2015-11-20 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1387#issuecomment-158538063 I don't understand you comment? What you describe is exactly how it works (even before this PR). The problem was actually just a missing `TypeInformation` I added here...

[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-20 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1368#issuecomment-158328847 Will merge it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-3021) Job submission times out due to classloading issue on JobManager

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015446#comment-15015446 ] ASF GitHub Bot commented on FLINK-3021: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-11-20 Thread mliesenberg
Github user mliesenberg commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-158329310 Cool. Pushed my latest changes which fix the bug and add more test cases. Btw., is there any way to see a test coverage report? --- If your project is

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015450#comment-15015450 ] ASF GitHub Bot commented on FLINK-2017: --- Github user mliesenberg commented on the pull request:

[GitHub] flink pull request: [FLINK-3021] Fix class loading issue for strea...

2015-11-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1368 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (FLINK-3021) Job submission times out due to classloading issue on JobManager

2015-11-20 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-3021. Resolution: Fixed Fixed via 177df41bf94ba18b0174a5973ee12efc195ec17e > Job submission times out

[GitHub] flink pull request: [FLINK-2017] Add predefined required parameter...

2015-11-20 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1097#issuecomment-158321550 No, I think once that's resolved, the PR is good to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-2017) Add predefined required parameters to ParameterTool

2015-11-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15015412#comment-15015412 ] ASF GitHub Bot commented on FLINK-2017: --- Github user rmetzger commented on the pull request: