[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110455#comment-15110455 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110473#comment-15110473 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on the pull request:

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50391112 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -107,6 +107,11 @@ class

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110472#comment-15110472 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1469#discussion_r50391192 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java --- @@ -486,11 +518,43 @@ protected boolean

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110471#comment-15110471 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110519#comment-15110519 ] ASF GitHub Bot commented on FLINK-2021: --- Github user chiwanpark commented on a diff in the pull

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110520#comment-15110520 ] ASF GitHub Bot commented on FLINK-2021: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50395017 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java --- @@ -291,31 +297,54 @@ public

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50399418 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java --- @@ -291,31 +297,54 @@ public

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110570#comment-15110570 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on a diff in the pull

[jira] [Assigned] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-01-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-3265: - Assignee: Robert Metzger > RabbitMQ Source not threadsafe:

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1469#discussion_r50385614 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/operators/hash/MutableHashTable.java --- @@ -1558,7 +1641,209 @@ public void reset() {

[jira] [Commented] (FLINK-2973) Remove OpenJDK JMH dependency from flink-benchmark

2016-01-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110452#comment-15110452 ] Robert Metzger commented on FLINK-2973: --- [~fhueske]: I think we can close this issue

[jira] [Commented] (FLINK-3065) Can't cancel failing jobs

2016-01-21 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110460#comment-15110460 ] Ufuk Celebi commented on FLINK-3065: I think you've resolved it with the Curator change ;) > Can't

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1469#discussion_r50390858 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java --- @@ -1534,6 +1534,106 @@ public void

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110468#comment-15110468 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110521#comment-15110521 ] ASF GitHub Bot commented on FLINK-2021: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50395062 --- Diff: flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala --- @@ -104,36 +105,52 @@ object

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50401844 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -107,6 +107,11 @@ class

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110624#comment-15110624 ] ASF GitHub Bot commented on FLINK-1994: --- Github user rawkintrevo commented on the pull request:

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50402286 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java --- @@ -291,31 +297,54 @@ public

[GitHub] flink pull request: [FLINK-3256] Fix colocation group re-instantia...

2016-01-21 Thread senorcarbone
Github user senorcarbone commented on the pull request: https://github.com/apache/flink/pull/1526#issuecomment-173575376 I removed the groups from the ExecutionGraph. Hope it's good now. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-3256) Invalid execution graph cleanup for jobs with colocation groups

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110610#comment-15110610 ] ASF GitHub Bot commented on FLINK-3256: --- Github user senorcarbone commented on the pull request:

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110609#comment-15110609 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on a diff in the pull

[jira] [Commented] (FLINK-2168) Add fromHBase() to TableEnvironment

2016-01-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110607#comment-15110607 ] Fabian Hueske commented on FLINK-2168: -- The internals of the Table API are currently heavily

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1469#discussion_r50385880 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildFirstDescriptor.java --- @@ -0,0 +1,66 @@ +/* + *

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1469#discussion_r50385924 --- Diff: flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/HashFullOuterJoinBuildSecondDescriptor.java --- @@ -0,0 +1,65 @@ +/* +

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110416#comment-15110416 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-3065) Can't cancel failing jobs

2016-01-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110453#comment-15110453 ] Robert Metzger commented on FLINK-3065: --- I think this issue is resolved and can be closed? > Can't

[jira] [Commented] (FLINK-3135) Add chainable driver for UNARY_NO_OP strategy

2016-01-21 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110498#comment-15110498 ] ramkrishna.s.vasudevan commented on FLINK-3135: --- Ping for reviews!! > Add chainable driver

[jira] [Commented] (FLINK-2168) Add fromHBase() to TableEnvironment

2016-01-21 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110525#comment-15110525 ] ramkrishna.s.vasudevan commented on FLINK-2168: --- Is there any one working on this? If not

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110574#comment-15110574 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50399628 --- Diff: flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala --- @@ -104,36 +105,52 @@ object

[jira] [Updated] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-01-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-3265: -- Component/s: Streaming Connectors > RabbitMQ Source not threadsafe:

[jira] [Commented] (FLINK-3265) RabbitMQ Source not threadsafe: ConcurrentModificationException

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110450#comment-15110450 ] ASF GitHub Bot commented on FLINK-3265: --- GitHub user rmetzger opened a pull request:

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110476#comment-15110476 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50391309 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -107,6 +107,11 @@ class

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-21 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1469#issuecomment-173547539 Thanks for the update and the regression test @ChengXiangLi! Looks good, only minor changes to do, IMO. --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110534#comment-15110534 ] ASF GitHub Bot commented on FLINK-2021: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50395674 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java --- @@ -291,31 +297,54 @@ public

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50401269 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java --- @@ -291,31 +297,54 @@ public Centroid

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110605#comment-15110605 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110415#comment-15110415 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110418#comment-15110418 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-2972) Remove Twitter Chill dependency from flink-java module

2016-01-21 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110420#comment-15110420 ] Maximilian Michels commented on FLINK-2972: --- Seems like this doesn't work for some test cases,

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50389332 --- Diff: docs/libs/ml/optimization.md --- @@ -256,6 +271,79 @@ The full list of supported prediction functions can be found [here](#prediction-

[jira] [Commented] (FLINK-2972) Remove Twitter Chill dependency from flink-java module

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110458#comment-15110458 ] ASF GitHub Bot commented on FLINK-2972: --- GitHub user mxm opened a pull request:

[GitHub] flink pull request: [FLINK-2972] remove Chill dependency from the ...

2016-01-21 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/1535 [FLINK-2972] remove Chill dependency from the test scope This eliminates the last bit of the Scala dependency of `flink-java`. If the Chill library can't be found it is replaced by one of the default

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110465#comment-15110465 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2871] support outer join for hash join ...

2016-01-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1469#discussion_r50390580 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/operators/hash/HashTableITCase.java --- @@ -1534,6 +1534,106 @@ public void

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50394492 --- Diff: flink-staging/flink-ml/src/main/scala/org/apache/flink/ml/regression/MultipleLinearRegression.scala --- @@ -107,6 +107,11 @@ class

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110507#comment-15110507 ] ASF GitHub Bot commented on FLINK-1994: --- Github user chiwanpark commented on a diff in the pull

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110514#comment-15110514 ] ASF GitHub Bot commented on FLINK-2021: --- Github user chiwanpark commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread rawkintrevo
Github user rawkintrevo commented on the pull request: https://github.com/apache/flink/pull/1397#issuecomment-173578713 For sure, definitely want to close the books on this one, and I appreciate all your help and patience as I have been learning. I will work on this tonight. --- If

[GitHub] flink pull request: [FLINK-3265] Make RabbitMQ source threadsafe

2016-01-21 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1534 [FLINK-3265] Make RabbitMQ source threadsafe You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink3265 Alternatively you can

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110469#comment-15110469 ] ASF GitHub Bot commented on FLINK-2021: --- GitHub user stefanobaghino opened a pull request:

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread stefanobaghino
GitHub user stefanobaghino opened a pull request: https://github.com/apache/flink/pull/1536 [FLINK-2021] Rework examples to use ParameterTool (K-Means) I've reworked the K-Means examples in Java and Scala to get a feeling of what it would mean on the whole examples code base. Just

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50394812 --- Diff: flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala --- @@ -104,36 +105,52 @@ object

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread chiwanpark
Github user chiwanpark commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50394801 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java --- @@ -291,31 +297,54 @@ public

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110516#comment-15110516 ] ASF GitHub Bot commented on FLINK-2021: --- Github user chiwanpark commented on a diff in the pull

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110577#comment-15110577 ] ASF GitHub Bot commented on FLINK-2021: --- Github user stefanobaghino commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2237] [runtime] Add hash-based combiner...

2016-01-21 Thread ggevay
Github user ggevay commented on the pull request: https://github.com/apache/flink/pull/1517#issuecomment-173571311 I've fixed a minor issue related to closing the table, and improved some comments. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-2237) Add hash-based Aggregation

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110576#comment-15110576 ] ASF GitHub Bot commented on FLINK-2237: --- Github user ggevay commented on the pull request:

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread stefanobaghino
Github user stefanobaghino commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50400122 --- Diff: flink-examples/flink-examples-batch/src/main/scala/org/apache/flink/examples/scala/clustering/KMeans.scala --- @@ -104,36 +105,52 @@ object

[jira] [Commented] (FLINK-2021) Rework examples to use ParameterTool

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110599#comment-15110599 ] ASF GitHub Bot commented on FLINK-2021: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request: [FLINK-2021] Rework examples to use ParameterT...

2016-01-21 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/1536#discussion_r50401470 --- Diff: flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/clustering/KMeans.java --- @@ -291,31 +297,54 @@ public Centroid

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110598#comment-15110598 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1397#issuecomment-173573669 I had some minor comments. I also opened a PR against your branch @rawkintrevo which shows how one could solve the problem with the enumerations

[jira] [Commented] (FLINK-3093) Introduce annotations for interface stability

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110320#comment-15110320 ] ASF GitHub Bot commented on FLINK-3093: --- Github user rmetzger commented on the pull request:

[GitHub] flink pull request: [FLINK-3093] Introduce annotations for interfa...

2016-01-21 Thread rmetzger
Github user rmetzger commented on the pull request: https://github.com/apache/flink/pull/1428#issuecomment-173511286 Cool, thank you. I'll rebase the PR, and go over the APIs again as well --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink pull request: Tidied up some docs. Fixed some non-idiomatic ...

2016-01-21 Thread sksamuel
Github user sksamuel commented on a diff in the pull request: https://github.com/apache/flink/pull/1531#discussion_r50376844 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/package.scala --- @@ -71,12 +71,11 @@ package object scala { "supported on

[jira] [Commented] (FLINK-3247) Kafka Connector unusable with quickstarts - shading issue

2016-01-21 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110312#comment-15110312 ] Robert Metzger commented on FLINK-3247: --- I'm not sure, even with Maven 3.0.4, maven will include

[jira] [Created] (FLINK-3270) Add example for reading and writing to Kafka

2016-01-21 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-3270: - Summary: Add example for reading and writing to Kafka Key: FLINK-3270 URL: https://issues.apache.org/jira/browse/FLINK-3270 Project: Flink Issue Type:

[GitHub] flink pull request: [FLINK-3270] Add Kafka example

2016-01-21 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/1533 [FLINK-3270] Add Kafka example You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink3270 Alternatively you can review and

[GitHub] flink pull request: [FLINK-3267] Disable reference tracking in Kry...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1528#issuecomment-173509879 Sure makes sense :-) On Jan 20, 2016 7:23 PM, "Stephan Ewen" wrote: > Trigger was a mail from Theo on the ML where

[GitHub] flink pull request: Tidied up some docs. Fixed some non-idiomatic ...

2016-01-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1531#discussion_r50376595 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/package.scala --- @@ -71,12 +71,11 @@ package object scala { "supported on

[jira] [Commented] (FLINK-3266) LocalFlinkMiniCluster leaks resources when multiple jobs are submitted

2016-01-21 Thread Gabor Gevay (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110349#comment-15110349 ] Gabor Gevay commented on FLINK-3266: They have names like `ForkJoinPool-168-worker-3` and `Timer-13`.

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50382914 --- Diff: docs/libs/ml/optimization.md --- @@ -256,6 +271,79 @@ The full list of supported prediction functions can be found [here](#prediction-

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110389#comment-15110389 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50382898 --- Diff: docs/libs/ml/optimization.md --- @@ -256,6 +271,79 @@ The full list of supported prediction functions can be found [here](#prediction-

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110390#comment-15110390 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50382928 --- Diff: docs/libs/ml/optimization.md --- @@ -256,6 +271,79 @@ The full list of supported prediction functions can be found [here](#prediction-

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110392#comment-15110392 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [refactor] Rename OperatorState to ValueState,...

2016-01-21 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1347#issuecomment-173528182 Closing for now, I have a bigger PR coming up --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110391#comment-15110391 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [refactor] Rename OperatorState to ValueState,...

2016-01-21 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/1347 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3270) Add example for reading and writing to Kafka

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110410#comment-15110410 ] ASF GitHub Bot commented on FLINK-3270: --- GitHub user rmetzger opened a pull request:

[jira] [Commented] (FLINK-2933) Flink scala libraries exposed with maven should carry scala version

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110409#comment-15110409 ] ASF GitHub Bot commented on FLINK-2933: --- Github user mxm commented on the pull request:

[GitHub] flink pull request: [FLINK-2933] Flink scala libraries exposed wit...

2016-01-21 Thread mxm
Github user mxm commented on the pull request: https://github.com/apache/flink/pull/1529#issuecomment-173533784 I agree it would be nice to fix the Scala dependency of `flink-java` before merging. Let's try to find a solution. --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-3267) Disable reference tracking in Kryo fallback serializer

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110317#comment-15110317 ] ASF GitHub Bot commented on FLINK-3267: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: Tidied up some docs. Fixed some non-idiomatic ...

2016-01-21 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1531#issuecomment-173515281 Wow, that was quick! :-) Thanks for the PR and the update. Looks good to merge, IMO --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request: Tidied up some docs. Fixed some non-idiomatic ...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on the pull request: https://github.com/apache/flink/pull/1531#issuecomment-173515454 +1 for merging. Thanks for your contribution @sksamuel :-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110380#comment-15110380 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50382852 --- Diff: docs/libs/ml/optimization.md --- @@ -256,6 +271,79 @@ The full list of supported prediction functions can be found [here](#prediction-

[jira] [Commented] (FLINK-2321) The seed for the SVM classifier is currently static

2016-01-21 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110362#comment-15110362 ] Till Rohrmann commented on FLINK-2321: -- You're right [~tvas]. I'll correct it. > The seed for the

[jira] [Commented] (FLINK-1994) Add different gain calculation schemes to SGD

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110397#comment-15110397 ] ASF GitHub Bot commented on FLINK-1994: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request: [FLINK-1994] [ml] Add different gain calculati...

2016-01-21 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1397#discussion_r50383721 --- Diff: docs/libs/ml/optimization.md --- @@ -256,6 +271,79 @@ The full list of supported prediction functions can be found [here](#prediction-

[GitHub] flink pull request: [hotfix] Fix interaction of Async calls/checkp...

2016-01-21 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/1532 [hotfix] Fix interaction of Async calls/checkpointing/canceling Before, it could happen that a Task is canceled during snapshotting. Some State Backends would silently swallow exceptions

[jira] [Commented] (FLINK-2871) Add OuterJoin strategy with HashTable on outer side

2016-01-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15110405#comment-15110405 ] ASF GitHub Bot commented on FLINK-2871: --- Github user fhueske commented on a diff in the pull

  1   2   >