[GitHub] flink pull request: [FLINK-3541] [Kafka Connector] Clean up workar...

2016-03-31 Thread skyahead
GitHub user skyahead opened a pull request: https://github.com/apache/flink/pull/1846 [FLINK-3541] [Kafka Connector] Clean up workaround in FlinkKafkaConsu… …mer09 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-3541) Clean up workaround in FlinkKafkaConsumer09

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221142#comment-15221142 ] ASF GitHub Bot commented on FLINK-3541: --- GitHub user skyahead opened a pull request:

[jira] [Commented] (FLINK-3635) Potential null deference in TwitterExample#SelectEnglishAndTokenizeFlatMap#flatMap

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221038#comment-15221038 ] ASF GitHub Bot commented on FLINK-3635: --- GitHub user skyahead opened a pull request:

[GitHub] flink pull request: [FLINK-3635] Potential null deference in Twitt...

2016-03-31 Thread skyahead
GitHub user skyahead opened a pull request: https://github.com/apache/flink/pull/1845 [FLINK-3635] Potential null deference in TwitterExample#SelectEnglish… …AndTokenizeFlatMap#flatMap You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-3523) Storm SpoutSplitExample fails with a ClassCastException

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220858#comment-15220858 ] ASF GitHub Bot commented on FLINK-3523: --- GitHub user mjsax opened a pull request:

[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...

2016-03-31 Thread mjsax
GitHub user mjsax opened a pull request: https://github.com/apache/flink/pull/1844 [FLINK-3523] [Storm-Compatibility] Added SplitStreamMapper to program… … to get rid of SplitStreamType wrapper You can merge this pull request into a Git repository by running: $ git pull

[jira] [Assigned] (FLINK-3523) Storm SpoutSplitExample fails with a ClassCastException

2016-03-31 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned FLINK-3523: -- Assignee: Matthias J. Sax > Storm SpoutSplitExample fails with a ClassCastException >

[jira] [Closed] (FLINK-2338) Shut down "Storm Topologies" cleanly

2016-03-31 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax closed FLINK-2338. -- Resolution: Fixed > Shut down "Storm Topologies" cleanly >

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220550#comment-15220550 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on the pull request: https://github.com/apache/flink/pull/1813#issuecomment-204094107 One additional overall comment: please use consistent JavaDoc formatting with respect to whitespaced and emtpy lines (sometime you have empty lines before parameter list;

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220544#comment-15220544 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58114600 --- Diff:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58114545 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/common/config/JedisSentinelConfigTest.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220542#comment-15220542 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220541#comment-15220541 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220543#comment-15220543 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58114513 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/common/config/JedisPoolConfigTest.java ---

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58114500 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfigTest.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220537#comment-15220537 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58113913 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java --- @@ -0,0

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220535#comment-15220535 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58113574 --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java --- @@ -0,0

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220532#comment-15220532 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58113357 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220533#comment-15220533 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220530#comment-15220530 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220528#comment-15220528 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220527#comment-15220527 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220529#comment-15220529 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58113261 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58113229 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataTypeDescription.java

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58113197 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/mapper/RedisDataType.java --- @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220522#comment-15220522 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58113161 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java ---

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112951 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java ---

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112927 --- Diff:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220521#comment-15220521 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220518#comment-15220518 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220520#comment-15220520 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112842 --- Diff:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112760 --- Diff:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220517#comment-15220517 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220515#comment-15220515 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112601 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisCommandsContainer.java

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112656 --- Diff:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112455 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220513#comment-15220513 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112296 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisSentinelConfig.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220512#comment-15220512 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220510#comment-15220510 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220509#comment-15220509 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112229 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisSentinelConfig.java ---

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112099 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisPoolConfig.java --- @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220506#comment-15220506 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58112031 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfig.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220507#comment-15220507 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58111937 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisPoolConfig.java --- @@

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58111680 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisClusterConfig.java ---

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220502#comment-15220502 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220501#comment-15220501 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58111485 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220500#comment-15220500 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58111329 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220494#comment-15220494 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58110997 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220489#comment-15220489 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58110429 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220484#comment-15220484 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58110110 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220476#comment-15220476 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58109874 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220472#comment-15220472 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220471#comment-15220471 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58109328 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58109313 --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java --- @@ -0,0 +1,224 @@

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220454#comment-15220454 ] ASF GitHub Bot commented on FLINK-3034: --- Github user mjsax commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-3034] Redis Sink Connector

2016-03-31 Thread mjsax
Github user mjsax commented on a diff in the pull request: https://github.com/apache/flink/pull/1813#discussion_r58108235 --- Diff: docs/apis/streaming/connectors/redis.md --- @@ -0,0 +1,172 @@ +--- +title: "Redis Connector" + +# Sub-level navigation

[GitHub] flink pull request: [docs] Add first version of "Concepts" documen...

2016-03-31 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/1843 [docs] Add first version of "Concepts" documentation. I think that the Flink docs (linked from the website) need a general introduction of the concepts behind Flink. Such a thing is

[jira] [Commented] (FLINK-2522) Integrate Streaming Api into Flink-scala-shell

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220273#comment-15220273 ] ASF GitHub Bot commented on FLINK-2522: --- Github user nikste commented on a diff in the pull request:

[GitHub] flink pull request: [FLINK-2522] Streaming support for Flink-Scala...

2016-03-31 Thread nikste
Github user nikste commented on a diff in the pull request: https://github.com/apache/flink/pull/1412#discussion_r58094009 --- Diff: flink-scala-shell/src/main/scala/org/apache/flink/api/scala/FlinkILoop.scala --- @@ -124,7 +127,9 @@ class FlinkILoop(

[GitHub] flink pull request: [FLINK-2522] Streaming support for Flink-Scala...

2016-03-31 Thread nikste
Github user nikste commented on the pull request: https://github.com/apache/flink/pull/1412#issuecomment-204038110 So since a lot has changed in the master I basically rewrote the whole thing. Seems to work now. What default imports should be included for the streaming API?

[jira] [Commented] (FLINK-2522) Integrate Streaming Api into Flink-scala-shell

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220268#comment-15220268 ] ASF GitHub Bot commented on FLINK-2522: --- Github user nikste commented on the pull request:

[jira] [Commented] (FLINK-2522) Integrate Streaming Api into Flink-scala-shell

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219900#comment-15219900 ] ASF GitHub Bot commented on FLINK-2522: --- Github user rawkintrevo commented on the pull request:

[GitHub] flink pull request: [FLINK-2522] Streaming support for Flink-Scala...

2016-03-31 Thread rawkintrevo
Github user rawkintrevo commented on the pull request: https://github.com/apache/flink/pull/1412#issuecomment-203953994 @nikste awesome work, any updates? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-3669) WindowOperator registers a lot of timers at StreamTask

2016-03-31 Thread Konstantin Knauf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219865#comment-15219865 ] Konstantin Knauf commented on FLINK-3669: - In my opionen the 1st option is the cleanest, but I can

[jira] [Commented] (FLINK-3669) WindowOperator registers a lot of timers at StreamTask

2016-03-31 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219845#comment-15219845 ] Aljoscha Krettek commented on FLINK-3669: - Yes, you're right that's still a problem. The issue

[GitHub] flink pull request: [FLINK-3614] Remove Non-Keyed Window Operator

2016-03-31 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1805#issuecomment-203875675 Any thoughts on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-3614) Remove Non-Keyed Window Operator

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219732#comment-15219732 ] ASF GitHub Bot commented on FLINK-3614: --- Github user aljoscha commented on the pull request:

[jira] [Created] (FLINK-3685) Logical error in code for DateSerializer deserialize with reuse

2016-03-31 Thread ZhengBowen (JIRA)
ZhengBowen created FLINK-3685: - Summary: Logical error in code for DateSerializer deserialize with reuse Key: FLINK-3685 URL: https://issues.apache.org/jira/browse/FLINK-3685 Project: Flink

[GitHub] flink pull request: FLINK-3579 Improve String concatenation (Ram)

2016-03-31 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/1821#discussion_r58029854 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ExpressionParser.scala --- @@ -59,6 +59,8 @@ object

[jira] [Commented] (FLINK-3579) Improve String concatenation

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219703#comment-15219703 ] ASF GitHub Bot commented on FLINK-3579: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-3684) CEP operator does not forward watermarks properly

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219674#comment-15219674 ] ASF GitHub Bot commented on FLINK-3684: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request: [FLINK-3684] [cep] Add proper watermark emissi...

2016-03-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/1842 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (FLINK-3684) CEP operator does not forward watermarks properly

2016-03-31 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-3684. Resolution: Fixed Fixed via e3759a5e65181040066dbb278266f2c1fa226347 > CEP operator does not

[jira] [Commented] (FLINK-3684) CEP operator does not forward watermarks properly

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219666#comment-15219666 ] ASF GitHub Bot commented on FLINK-3684: --- Github user uce commented on the pull request:

[jira] [Commented] (FLINK-3684) CEP operator does not forward watermarks properly

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219669#comment-15219669 ] ASF GitHub Bot commented on FLINK-3684: --- Github user tillrohrmann commented on the pull request:

[GitHub] flink pull request: [FLINK-3684] [cep] Add proper watermark emissi...

2016-03-31 Thread uce
Github user uce commented on the pull request: https://github.com/apache/flink/pull/1842#issuecomment-203854053 +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-3684) CEP operator does not forward watermarks properly

2016-03-31 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219662#comment-15219662 ] ASF GitHub Bot commented on FLINK-3684: --- GitHub user tillrohrmann opened a pull request:

[jira] [Created] (FLINK-3684) CEP operator does not forward watermarks properly

2016-03-31 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-3684: Summary: CEP operator does not forward watermarks properly Key: FLINK-3684 URL: https://issues.apache.org/jira/browse/FLINK-3684 Project: Flink Issue Type:

[GitHub] flink pull request: [FLINK-3684] [cep] Add proper watermark emissi...

2016-03-31 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/1842 [FLINK-3684] [cep] Add proper watermark emission to CEP operators Adds watermark emission to CEP stream operators. You can merge this pull request into a Git repository by running: $ git

  1   2   >