Github user subhankarb commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68484062
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java
---
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349055#comment-15349055
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user subhankarb commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349044#comment-15349044
]
ASF GitHub Bot commented on FLINK-4103:
---
GitHub user smarthi opened a pull request:
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2162
FLINK-4103: Modify CsvTableSource to implement StreamTableSource
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
Github user smarthi closed the pull request at:
https://github.com/apache/flink/pull/2161
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user smarthi commented on the issue:
https://github.com/apache/flink/pull/2161
Wrong Jira# closing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user smarthi opened a pull request:
https://github.com/apache/flink/pull/2161
FLINK-4301: Modify CsvTableSource to implement StreamTableSource
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
[
https://issues.apache.org/jira/browse/FLINK-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348877#comment-15348877
]
ASF GitHub Bot commented on FLINK-3580:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2150
Hi @twalthr, thanks for the PR. I skimmed the changes and everything looked
fine. I have two suggestions though.
1. Can we add a casts from `Long` to `Timestamp` and back?
2. Can you
[
https://issues.apache.org/jira/browse/FLINK-3580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348866#comment-15348866
]
ASF GitHub Bot commented on FLINK-3580:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2150#discussion_r68476229
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/typeutils/TypeCoercion.scala
---
@@ -85,6 +85,9 @@ object TypeCoercion {
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348836#comment-15348836
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2159
Hi @wuchong, thanks for the PR. I think it is better to use a CoGroup
instead of a Join for `INTERSECT` (even though, I said "Join" in the original
JIRA). For `INTERSECT ALL`, CoGroup is required.
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348829#comment-15348829
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68474570
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -260,10 +260,14 @@ class CodeGenerator(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68474420
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/sql/IntersectITCase.scala
---
@@ -0,0 +1,108 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348828#comment-15348828
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68474131
--- Diff:
flink-libraries/flink-table/src/test/java/org/apache/flink/api/java/batch/table/IntersectITCase.java
---
@@ -0,0 +1,101 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348821#comment-15348821
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348813#comment-15348813
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473826
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -446,6 +446,31 @@ class Table(
}
/**
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348811#comment-15348811
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/table.scala
---
@@ -446,6 +446,31 @@ class Table(
}
/**
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348805#comment-15348805
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473250
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348801#comment-15348801
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348797#comment-15348797
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473118
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68473031
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348785#comment-15348785
]
ASF GitHub Bot commented on FLINK-3942:
---
Github user fhueske commented on a diff in the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/2159#discussion_r68471662
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetIntersect.scala
---
@@ -0,0 +1,153 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348740#comment-15348740
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2128
@zentol I've fixed my PR according to your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348711#comment-15348711
]
ASF GitHub Bot commented on FLINK-3898:
---
GitHub user greghogan opened a pull request:
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2160
[FLINK-3898] [gelly] Adamic-Adar Similarity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3898_adamic_adar_similarity
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348606#comment-15348606
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user mjsax commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-3907.
-
Resolution: Fixed
Implemented in d34bdaf7f1de4dd4f742867e6b9e879c8b631765
> Directed Clustering
Github user mjsax commented on the issue:
https://github.com/apache/flink/pull/1813
@rmetzger Thanks :)
I did not test with a Redis cluster or similar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/1813
@mjsax, did you test the code with a redis installation / on a cluster?
(I'm not expecting those tests from a PR review, but I would not do it again if
you already did ... and I'm not doing it
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455277
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455334
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSentinelClusterTest.java
---
@@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68455103
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java
---
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454693
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisContainer.java
---
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454559
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68454370
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,232 @@
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68453882
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,92 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68453630
--- Diff: flink-streaming-connectors/flink-connector-redis/pom.xml ---
@@ -0,0 +1,92 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
Github user subhankarb commented on the issue:
https://github.com/apache/flink/pull/1813
done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2079
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2137
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348529#comment-15348529
]
Chesnay Schepler commented on FLINK-4098:
-
huh. As far as i can tell, every call to next() in
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348522#comment-15348522
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
Okay, sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2131
@rmetzger Thank you! No problem, I can wait and address the current
comments meanwhile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348516#comment-15348516
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348503#comment-15348503
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348502#comment-15348502
]
ASF GitHub Bot commented on FLINK-4018:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'm not done with the review yet. I hope I find some time over the weekend
to continue with it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2071
Yes, I would suggest to do this PR after the big one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348482#comment-15348482
]
ASF GitHub Bot commented on FLINK-4018:
---
Github user tzulitai commented on the issue:
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2071
Thank you for reviewing this @rmetzger. Should I address your comment after
the rework in https://github.com/apache/flink/pull/2131 is merged, and rebase
this PR on that?
---
If your project is
[
https://issues.apache.org/jira/browse/FLINK-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348477#comment-15348477
]
ASF GitHub Bot commented on FLINK-4018:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2071#discussion_r68420387
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumerThread.java
---
[
https://issues.apache.org/jira/browse/FLINK-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347577#comment-15347577
]
Geoffrey Mon edited comment on FLINK-4098 at 6/24/16 3:34 PM:
--
Thanks for the
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348422#comment-15348422
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user mjsax commented on the issue:
Github user mjsax commented on the issue:
https://github.com/apache/flink/pull/1813
Please address last comment. Otherwise, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68414043
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348419#comment-15348419
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68413466
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348412#comment-15348412
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348407#comment-15348407
]
ASF GitHub Bot commented on FLINK-3034:
---
Github user mjsax commented on a diff in the pull request:
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1813#discussion_r68412669
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/container/RedisClusterContainer.java
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348404#comment-15348404
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68412025
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348395#comment-15348395
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68411242
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348389#comment-15348389
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68410216
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348386#comment-15348386
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409932
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348387#comment-15348387
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409807
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348383#comment-15348383
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68409331
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348376#comment-15348376
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68408986
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java
---
Greg Hogan created FLINK-4117:
-
Summary: Wait for CuratorFramework connection to be established
Key: FLINK-4117
URL: https://issues.apache.org/jira/browse/FLINK-4117
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348364#comment-15348364
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68408173
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348356#comment-15348356
]
Greg Hogan commented on FLINK-4113:
---
I experienced the problem when verifying the
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348354#comment-15348354
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user zentol commented on a diff in the pull request:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2128
I wanted to avoid this bit of duplication, but I have no strong preferences
for that. Will remove this static method.
---
If your project is set up for it, you can reply to this email and have
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2128#discussion_r68406896
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/common/RMQSinkTest.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348353#comment-15348353
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user mushketyk commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348350#comment-15348350
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348349#comment-15348349
]
ASF GitHub Bot commented on FLINK-4053:
---
Github user zentol commented on a diff in the pull request:
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2131#discussion_r68406625
--- Diff:
flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/model/KinesisStreamShard.java
---
1 - 100 of 151 matches
Mail list logo
