[
https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363810#comment-15363810
]
ramkrishna.s.vasudevan commented on FLINK-3397:
---
[~uce]
As per the suggestion I have already
[
https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363794#comment-15363794
]
ASF GitHub Bot commented on FLINK-3397:
---
Github user ramkrish86 closed the pull request at:
Github user ramkrish86 closed the pull request at:
https://github.com/apache/flink/pull/2195
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363793#comment-15363793
]
ASF GitHub Bot commented on FLINK-3397:
---
Github user ramkrish86 commented on the issue:
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/2195
Sure. I can close this. I always had a doubt on the scope of this JIRA. As
per the suggestion I have already started working on a doc. I will try to list
out how things are working now and may be
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2195
Sorry for not responding earlier in the JIRA issue. I've somehow missed
your mentions. I agree with what Stephan said in JIRA. Before trying to fix
something here, we would have to think about the
[
https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363160#comment-15363160
]
ASF GitHub Bot commented on FLINK-3397:
---
Github user uce commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-4020.
---
Resolution: Fixed
Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/17dfd68d
>
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger closed FLINK-3231.
-
Resolution: Fixed
Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/17dfd68d
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362978#comment-15362978
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Gyula Fora created FLINK-4155:
-
Summary: Get Kafka producer partition info in open method instead
of constructor
Key: FLINK-4155
URL: https://issues.apache.org/jira/browse/FLINK-4155
Project: Flink
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2131
I'm going to merge this once travis gives me green light ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362845#comment-15362845
]
ASF GitHub Bot commented on FLINK-3231:
---
Github user rmetzger commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362809#comment-15362809
]
Till Rohrmann commented on FLINK-4137:
--
I think it is not the problem of the web frontend not being
[
https://issues.apache.org/jira/browse/FLINK-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362824#comment-15362824
]
Robert Metzger commented on FLINK-4137:
---
THank you for looking into the problem.
I will try to
[
https://issues.apache.org/jira/browse/FLINK-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362783#comment-15362783
]
Robert Metzger commented on FLINK-4137:
---
Here's the full log:
[
https://issues.apache.org/jira/browse/FLINK-3916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362791#comment-15362791
]
ASF GitHub Bot commented on FLINK-3916:
---
Github user vasia commented on the issue:
Github user vasia commented on the issue:
https://github.com/apache/flink/pull/2197
Thanks for the ping @twalthr! I don't see anything suspicious :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362717#comment-15362717
]
ASF GitHub Bot commented on FLINK-4149:
---
GitHub user aljoscha opened a pull request:
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/2202
[FLINK-4149] Fix Serialization of NFA in AbstractKeyedCEPPatternOperator
NFA is Serializable and has readObject()/writeObject() methods. In
AbstractKeyedCEPPatternOperator a KryoSerializer was
[
https://issues.apache.org/jira/browse/FLINK-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362690#comment-15362690
]
Till Rohrmann edited comment on FLINK-4137 at 7/5/16 4:06 PM:
--
Do you still
[
https://issues.apache.org/jira/browse/FLINK-4137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362690#comment-15362690
]
Till Rohrmann commented on FLINK-4137:
--
Do you still have the complete log for the described problem?
[
https://issues.apache.org/jira/browse/FLINK-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362683#comment-15362683
]
Robert Metzger commented on FLINK-4151:
---
Regarding our 10 slots, we could ask Apache to increase our
[
https://issues.apache.org/jira/browse/FLINK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362673#comment-15362673
]
Greg Hogan commented on FLINK-4154:
---
This is a keen observation. Considering the usage and looking at
[
https://issues.apache.org/jira/browse/FLINK-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362665#comment-15362665
]
ASF GitHub Bot commented on FLINK-4146:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2200
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-4146.
---
Resolution: Fixed
Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/424c0826
>
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-4133.
---
Resolution: Fixed
Fix Version/s: 1.1.0
Resolved in
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362658#comment-15362658
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2198
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362653#comment-15362653
]
Aljoscha Krettek commented on FLINK-4154:
-
I'd vote for 1) i.e. revert the change to murmur hash.
[
https://issues.apache.org/jira/browse/FLINK-4098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362646#comment-15362646
]
Geoffrey Mon commented on FLINK-4098:
-
That would explain the issue I had earlier. I've made a simple
[
https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4149:
Description:
A job that uses CEP fails upon restore with a {{NullPointerException}} in
[
https://issues.apache.org/jira/browse/FLINK-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362623#comment-15362623
]
ASF GitHub Bot commented on FLINK-4017:
---
Github user GEOFBOT commented on the issue:
Github user GEOFBOT commented on the issue:
https://github.com/apache/flink/pull/2115
I've addressed the documentation issue, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek updated FLINK-4149:
Affects Version/s: 1.0.0
1.0.1
1.0.2
[
https://issues.apache.org/jira/browse/FLINK-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-4154:
-
Priority: Blocker (was: Critical)
> Correction of murmur hash breaks backwards compatibility
>
[
https://issues.apache.org/jira/browse/FLINK-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362612#comment-15362612
]
ASF GitHub Bot commented on FLINK-4123:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2183
@tillrohrmann test added.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Till Rohrmann created FLINK-4154:
Summary: Correction of murmur hash breaks backwards compatibility
Key: FLINK-4154
URL: https://issues.apache.org/jira/browse/FLINK-4154
Project: Flink
Issue
Github user uce commented on the issue:
https://github.com/apache/flink/pull/2194
Thanks for the thorough review! I didn't catch that by my manual test. I
would also be in favour of 1) for the same reasons.
---
If your project is set up for it, you can reply to this email and have
[
https://issues.apache.org/jira/browse/FLINK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362605#comment-15362605
]
ASF GitHub Bot commented on FLINK-4067:
---
Github user uce commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362589#comment-15362589
]
ASF GitHub Bot commented on FLINK-4067:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2194
Really good work @uce. The code is well structured and thoroughly tested. I
had only some minor comments.
While testing the code with the streaming state machine job I stumbled
across
[
https://issues.apache.org/jira/browse/FLINK-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362586#comment-15362586
]
ASF GitHub Bot commented on FLINK-4115:
---
Github user joshfg commented on the issue:
Github user joshfg commented on the issue:
https://github.com/apache/flink/pull/2157
Cool, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
[
https://issues.apache.org/jira/browse/FLINK-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-3995.
---
Resolution: Fixed
Resolved in http://git-wip-us.apache.org/repos/asf/flink/commit/8a2c03e1
>
[
https://issues.apache.org/jira/browse/FLINK-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362567#comment-15362567
]
ASF GitHub Bot commented on FLINK-3995:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362566#comment-15362566
]
ASF GitHub Bot commented on FLINK-3395:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362553#comment-15362553
]
ASF GitHub Bot commented on FLINK-3995:
---
Github user rmetzger commented on the issue:
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2148
Thank you for the review ... merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek reassigned FLINK-4149:
---
Assignee: Aljoscha Krettek
> Fix Serialization of NFA in
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2198
Thank you. I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2198
Thanks @rmetzger !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362518#comment-15362518
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user rmetzger commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362514#comment-15362514
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user kl0u commented on the issue:
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2198
@rmetzger I updated the PR.
Please let me know if you have any further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/FLINK-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362504#comment-15362504
]
Greg Hogan commented on FLINK-4151:
---
This change will get Travis back under two hours (and we could
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69562188
--- Diff: docs/apis/streaming/index.md ---
@@ -1357,20 +1364,27 @@ Custom:
-Sources can by created by using
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362488#comment-15362488
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362484#comment-15362484
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user kl0u commented on a diff in the pull request:
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69561987
--- Diff: docs/apis/streaming/index.md ---
@@ -1310,21 +1310,28 @@ Data Sources
-Sources can by created by using
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362482#comment-15362482
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user kl0u commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362483#comment-15362483
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user kl0u commented on a diff in the pull request:
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69561903
--- Diff: docs/apis/streaming/index.md ---
@@ -1310,21 +1310,28 @@ Data Sources
-Sources can by created by using
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69561860
--- Diff: docs/apis/streaming/index.md ---
@@ -1310,21 +1310,28 @@ Data Sources
-Sources can by created by using
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362478#comment-15362478
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user kl0u commented on a diff in the pull request:
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69561347
--- Diff: docs/apis/streaming/index.md ---
@@ -1357,20 +1364,27 @@ Custom:
-Sources can by created by using
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362470#comment-15362470
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69560355
--- Diff: docs/apis/streaming/index.md ---
@@ -1310,21 +1310,28 @@ Data Sources
-Sources can by created by using
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69560211
--- Diff: docs/apis/streaming/index.md ---
@@ -1357,20 +1364,27 @@ Custom:
-Sources can by created by using
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362467#comment-15362467
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user rmetzger commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362464#comment-15362464
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69559804
--- Diff: docs/apis/streaming/index.md ---
@@ -1310,21 +1310,28 @@ Data Sources
-Sources can by created by using
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69559890
--- Diff: docs/apis/streaming/index.md ---
@@ -1310,21 +1310,28 @@ Data Sources
-Sources can by created by using
[
https://issues.apache.org/jira/browse/FLINK-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362461#comment-15362461
]
ASF GitHub Bot commented on FLINK-4133:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2198#discussion_r69559534
--- Diff: docs/apis/streaming/index.md ---
@@ -1310,21 +1310,28 @@ Data Sources
-Sources can by created by using
[
https://issues.apache.org/jira/browse/FLINK-3190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362454#comment-15362454
]
ASF GitHub Bot commented on FLINK-3190:
---
Github user fijolekProjects commented on the issue:
Github user fijolekProjects commented on the issue:
https://github.com/apache/flink/pull/1954
@tillrohrmann I've pushed fixes and commented on your sugesstions. Should I
squash and rebase it onto master as well?
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/FLINK-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362442#comment-15362442
]
ASF GitHub Bot commented on FLINK-3648:
---
Github user kl0u commented on the issue:
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/2199
Thanks for the comments @aljoscha !
I integrated them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-4152:
--
Attachment: logs.tgz
> TaskManager registration exponential backoff doesn't work
>
[
https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362435#comment-15362435
]
ASF GitHub Bot commented on FLINK-4127:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2177
I think it's a good idea to merge `container` and `containerized`.
I think the idea is to introduce some general container parameters, such as
the `heap-cutoff-ratio`, which are valid
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362433#comment-15362433
]
Robert Metzger commented on FLINK-4152:
---
The full aggregated YARN log is more than 300 MB ...
I'm
Aljoscha Krettek created FLINK-4153:
---
Summary: ExecutionGraphRestartTest Fails
Key: FLINK-4153
URL: https://issues.apache.org/jira/browse/FLINK-4153
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-4152:
--
Issue Type: Bug (was: Task)
> TaskManager registration exponential backoff doesn't work
>
Robert Metzger created FLINK-4152:
-
Summary: TaskManager registration exponential backoff doesn't work
Key: FLINK-4152
URL: https://issues.apache.org/jira/browse/FLINK-4152
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362422#comment-15362422
]
ASF GitHub Bot commented on FLINK-4127:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r69553944
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to
[
https://issues.apache.org/jira/browse/FLINK-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362416#comment-15362416
]
ASF GitHub Bot commented on FLINK-4123:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2183
If our components are not testable, then this is good indicator that we can
still improve our design. But actually I think that it should be doable in this
case. Can't we mock the `Session`
[
https://issues.apache.org/jira/browse/FLINK-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362411#comment-15362411
]
ASF GitHub Bot commented on FLINK-3648:
---
Github user aljoscha commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362412#comment-15362412
]
ASF GitHub Bot commented on FLINK-3648:
---
Github user aljoscha commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2199
Looks good! I just had some minor comments. After fixing those it should be
good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2199#discussion_r69552555
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/WindowingTestHarness.java
---
@@ -0,0 +1,217 @@
+/**
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362407#comment-15362407
]
ASF GitHub Bot commented on FLINK-3648:
---
Github user aljoscha commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15362409#comment-15362409
]
ASF GitHub Bot commented on FLINK-3648:
---
Github user aljoscha commented on a diff in the pull
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2199#discussion_r69552396
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/util/WindowingTestHarness.java
---
@@ -0,0 +1,217 @@
+/**
+ * Licensed to
1 - 100 of 149 matches
Mail list logo