[jira] [Commented] (FLINK-4278) Unclosed FSDataOutputStream in multiple files in the project

2016-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405275#comment-15405275 ] Ted Yu commented on FLINK-4278: --- I was out of town. IOUtils.closeQuietly() should be fine. > Unclosed

[jira] [Updated] (FLINK-3801) Upgrade Joda-Time library to 2.9.3

2016-08-02 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-3801: -- Description: Currently yoda-time 2.5 is used which was very old. We should upgrade to 2.9.3 was: Currently

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405206#comment-15405206 ] ASF GitHub Bot commented on FLINK-3940: --- Github user gallenvara commented on a diff in the pull

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread gallenvara
Github user gallenvara commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73272805 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[jira] [Closed] (FLINK-4224) Exception after successful execution os job submitted through the web interface.

2016-08-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4224. --- Resolution: Not A Problem > Exception after successful execution os job submitted through the

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405156#comment-15405156 ] ASF GitHub Bot commented on FLINK-4271: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-02 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2305 I agree with @aljoscha . Can we reduce the checker's sensitivity to pass this change ? How do we do when we need to break compatibility? --- If your project is set up for it, you can reply to this

[jira] [Created] (FLINK-4309) Potential null pointer dereference in DelegatingConfiguration#keySet()

2016-08-02 Thread Ted Yu (JIRA)
Ted Yu created FLINK-4309: - Summary: Potential null pointer dereference in DelegatingConfiguration#keySet() Key: FLINK-4309 URL: https://issues.apache.org/jira/browse/FLINK-4309 Project: Flink

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405073#comment-15405073 ] ASF GitHub Bot commented on FLINK-3929: --- Github user vijikarthi commented on the issue:

[GitHub] flink issue #2275: FLINK-3929 Support for Kerberos Authentication with Keyta...

2016-08-02 Thread vijikarthi
Github user vijikarthi commented on the issue: https://github.com/apache/flink/pull/2275 @mxm - I have addressed most of the feedback and pushed the changes. Please take a look when you get a chance. Regarding the secure test cases, - HDFS and Yarn are handled through

[jira] [Comment Edited] (FLINK-4308) Allow uploaded jar directory to be configurable

2016-08-02 Thread Zhenzhong Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404889#comment-15404889 ] Zhenzhong Xu edited comment on FLINK-4308 at 8/2/16 9:57 PM: - The proposal is

[jira] [Commented] (FLINK-4308) Allow uploaded jar directory to be configurable

2016-08-02 Thread Zhenzhong Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404889#comment-15404889 ] Zhenzhong Xu commented on FLINK-4308: - The proposal is to introduce a new optional config

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404880#comment-15404880 ] ASF GitHub Bot commented on FLINK-3929: --- Github user vijikarthi commented on a diff in the pull

[GitHub] flink pull request #2275: FLINK-3929 Support for Kerberos Authentication wit...

2016-08-02 Thread vijikarthi
Github user vijikarthi commented on a diff in the pull request: https://github.com/apache/flink/pull/2275#discussion_r73245570 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -1016,6 +1016,23 @@ /** The environment variable

[jira] [Commented] (FLINK-4262) Consider null handling during sorting

2016-08-02 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404861#comment-15404861 ] Ivan Mushketyk commented on FLINK-4262: --- I would like to implement this. > Consider null handling

[jira] [Assigned] (FLINK-4262) Consider null handling during sorting

2016-08-02 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mushketyk reassigned FLINK-4262: - Assignee: Ivan Mushketyk > Consider null handling during sorting >

[jira] [Commented] (FLINK-3414) Add Scala API for CEP's pattern definition

2016-08-02 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404852#comment-15404852 ] Ivan Mushketyk commented on FLINK-3414: --- I would like to describe my proposal on the case-by-case

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-02 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404730#comment-15404730 ] Ivan Mushketyk commented on FLINK-3298: --- Hi, Thank you for reviewing my changes. I don't think I

[jira] [Resolved] (FLINK-4307) Broken user-facing API for ListState

2016-08-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4307. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed in - 1.1.0 via

[jira] [Closed] (FLINK-4307) Broken user-facing API for ListState

2016-08-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4307. --- > Broken user-facing API for ListState > > > Key:

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404582#comment-15404582 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-08-02 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2109 @mxm Thank you for your detailed review! I'll update it according to your feedback and revert the breaking changes. --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404579#comment-15404579 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404577#comment-15404577 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73213456 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73213488 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java --- @@ -257,41 +257,22 @@ public void testFileInputSplit() {

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73212835 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -995,8 +993,7 @@ public

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404571#comment-15404571 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mushketyk commented on a diff in the pull

[jira] [Commented] (FLINK-3779) Add support for queryable state

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404491#comment-15404491 ] ASF GitHub Bot commented on FLINK-3779: --- Github user rehevkor5 commented on the issue:

[GitHub] flink issue #2051: [FLINK-3779] Add support for queryable state

2016-08-02 Thread rehevkor5
Github user rehevkor5 commented on the issue: https://github.com/apache/flink/pull/2051 Hi, it's great to see that someone is working on this stuff! I just wanted to put in my two cents, to provide a different perspective that might change how you are thinking about this.

[jira] [Updated] (FLINK-4308) Allow uploaded jar directory to be configurable

2016-08-02 Thread Zhenzhong Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenzhong Xu updated FLINK-4308: Description: I notice sometimes it's preferable to have uploaded jars to be put into a

[jira] [Updated] (FLINK-4308) Allow uploaded jar directory to be configurable

2016-08-02 Thread Zhenzhong Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenzhong Xu updated FLINK-4308: Description: I notice sometimes it's preferable to have uploaded jars to be put into a

[jira] [Created] (FLINK-4308) Allow uploaded jar directory to be configurable

2016-08-02 Thread Zhenzhong Xu (JIRA)
Zhenzhong Xu created FLINK-4308: --- Summary: Allow uploaded jar directory to be configurable Key: FLINK-4308 URL: https://issues.apache.org/jira/browse/FLINK-4308 Project: Flink Issue Type:

[GitHub] flink issue #2324: Bump version to 1.2-SNAPSHOT

2016-08-02 Thread mbalassi
Github user mbalassi commented on the issue: https://github.com/apache/flink/pull/2324 Good catch, looking into that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

2016-08-02 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404384#comment-15404384 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- I can do this Log update and document

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

2016-08-02 Thread ramkrishna.s.vasudevan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404378#comment-15404378 ] ramkrishna.s.vasudevan commented on FLINK-4094: --- bq. We cannot really manually release the

[jira] [Commented] (FLINK-4224) Exception after successful execution os job submitted through the web interface.

2016-08-02 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404370#comment-15404370 ] Kostas Kloudas commented on FLINK-4224: --- No. As I also said to Max, this does not appear any more.

[jira] [Closed] (FLINK-4306) Fix Flink and Storm dependencies in flink-storm and flink-storm-examples

2016-08-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-4306. --- > Fix Flink and Storm dependencies in flink-storm and flink-storm-examples >

[jira] [Resolved] (FLINK-4306) Fix Flink and Storm dependencies in flink-storm and flink-storm-examples

2016-08-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-4306. - Resolution: Fixed Fix Version/s: (was: 1.1.1) Fixed via

[jira] [Created] (FLINK-4307) Broken user-facing API for ListState

2016-08-02 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-4307: --- Summary: Broken user-facing API for ListState Key: FLINK-4307 URL: https://issues.apache.org/jira/browse/FLINK-4307 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

2016-08-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404270#comment-15404270 ] Stephan Ewen commented on FLINK-4094: - True, it is not documented the {{preallocate == false}} returns

[jira] [Commented] (FLINK-4304) Jar names that contain whitespace cause problems in web client

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404230#comment-15404230 ] ASF GitHub Bot commented on FLINK-4304: --- Github user mxm commented on the issue:

[GitHub] flink issue #2327: [FLINK-4304] [runtime-web] Jar names that contain whitesp...

2016-08-02 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2327 +1 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404228#comment-15404228 ] ASF GitHub Bot commented on FLINK-4271: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2305 I think it breaks binary compatibility, not source compatibility. The specific return type is part of the method signature used by the JVM for linking. --- If your project is set up for it,

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73181770 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404225#comment-15404225 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404216#comment-15404216 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73180693 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404196#comment-15404196 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73179240 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404193#comment-15404193 ] ASF GitHub Bot commented on FLINK-4271: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-02 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/2305 @StephanEwen I think technically it doesn't break the API because `SingleOutputStreamOperator` is a subclass of `DataStream`, right? (It might break binary compatibility though, because the

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404188#comment-15404188 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-4275) Generic Folding, Reducing and List states behave differently from other state backends

2016-08-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404186#comment-15404186 ] Aljoscha Krettek commented on FLINK-4275: - This was changed to make it possible in the

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73178324 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404181#comment-15404181 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73177719 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetSort.scala --- @@ -71,11 +78,57 @@ class

[jira] [Commented] (FLINK-4081) FieldParsers should support empty strings

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404167#comment-15404167 ] ASF GitHub Bot commented on FLINK-4081: --- Github user fpompermaier commented on the issue:

[GitHub] flink issue #2297: [FLINK-4081] [core] [table] FieldParsers should support e...

2016-08-02 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/2297 For our use cases it is important to know whether a value of cell is empty or it is 0. The EMPTY_STRING error could be intercepted by the csv parser in order to generate Row objects with

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73172351 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -150,6 +150,47 @@ case class Sort(order:

[jira] [Commented] (FLINK-4224) Exception after successful execution os job submitted through the web interface.

2016-08-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404157#comment-15404157 ] Aljoscha Krettek commented on FLINK-4224: - [~kkl0u] is this still an issue on the new 1.1 RC? >

[jira] [Resolved] (FLINK-4246) Allow Specifying Multiple Metrics Reporters

2016-08-02 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek resolved FLINK-4246. - Resolution: Fixed This was merged a while back > Allow Specifying Multiple Metrics

[jira] [Commented] (FLINK-4271) There is no way to set parallelism of operators produced by CoGroupedStreams

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404149#comment-15404149 ] ASF GitHub Bot commented on FLINK-4271: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2305: [FLINK-4271] [DataStreamAPI] Enable CoGroupedStreams and ...

2016-08-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2305 @wuchong The CI fails because this change breaks backwards compatibility. I understand though that this is a pretty critical change and may actually warrant to break the backwards compatibility.

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73172521 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala --- @@ -150,6 +150,47 @@ case class Sort(order:

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404137#comment-15404137 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404141#comment-15404141 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #2282: [FLINK-3940] [table] Add support for ORDER BY OFFS...

2016-08-02 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2282#discussion_r73171110 --- Diff: docs/apis/table.md --- @@ -606,6 +606,28 @@ Table result = in.orderBy("a.asc"); + + Offset +

[jira] [Commented] (FLINK-3940) Add support for ORDER BY OFFSET FETCH

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404133#comment-15404133 ] ASF GitHub Bot commented on FLINK-3940: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

2016-08-02 Thread Maximilian Michels (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404120#comment-15404120 ] Maximilian Michels commented on FLINK-4094: --- Yes, it was undocumented. Initially, I thought

[jira] [Resolved] (FLINK-4203) Improve Table API documentation

2016-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4203. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed in 3f1e8b91574d66a8e9d8b74a6be1227535064405.

[GitHub] flink pull request #2293: [FLINK-4203] [table] [docs] Improve Table API docu...

2016-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4203) Improve Table API documentation

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404108#comment-15404108 ] ASF GitHub Bot commented on FLINK-4203: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-4081) FieldParsers should support empty strings

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404107#comment-15404107 ] ASF GitHub Bot commented on FLINK-4081: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2297: [FLINK-4081] [core] [table] FieldParsers should support e...

2016-08-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2297 Using an error state for an empty string seems a bit unorthodox. I take it returning `0` does not work for some reason? --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (FLINK-4247) CsvTableSource.getDataSet() expects Java ExecutionEnvironment

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404102#comment-15404102 ] ASF GitHub Bot commented on FLINK-4247: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2298: [FLINK-4247] [table] CsvTableSource.getDataSet() expects ...

2016-08-02 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2298 Would be great to reflect the "do not use" with proper visibility. A JavaDoc comment is usually not helping at all. Also, the dependency on the java API classes in the Scala classes does

[GitHub] flink issue #2109: [FLINK-3677] FileInputFormat: Allow to specify include/ex...

2016-08-02 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2109 Just had a brief look. Looks nice. Actually, I like how you moved the file filter to the `FileInputFormat` instead of having it as a special case of the file monitoring source. I think you

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404097#comment-15404097 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mxm commented on the issue:

[jira] [Commented] (FLINK-4203) Improve Table API documentation

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404096#comment-15404096 ] ASF GitHub Bot commented on FLINK-4203: --- Github user twalthr commented on the issue:

[GitHub] flink issue #2293: [FLINK-4203] [table] [docs] Improve Table API documentati...

2016-08-02 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/2293 I will merge this now. The doc is still not perfect but we can further improve it in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-4094) Off heap memory deallocation might not properly work

2016-08-02 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404095#comment-15404095 ] Till Rohrmann commented on FLINK-4094: -- Is {{preallocate == false}} really supposed to return the

[jira] [Resolved] (FLINK-4181) Add a basic streaming Table API example

2016-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4181. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed in 123c637e804bfdd6569051cf705ec73b5cb95352.

[jira] [Resolved] (FLINK-4180) Create a batch SQL example

2016-08-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4180. - Resolution: Fixed Fix Version/s: 1.2.0 Fixed in 123c637e804bfdd6569051cf705ec73b5cb95352.

[jira] [Commented] (FLINK-4180) Create a batch SQL example

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404074#comment-15404074 ] ASF GitHub Bot commented on FLINK-4180: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2274: [FLINK-4180] [FLINK-4181] [table] add Batch SQL an...

2016-08-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2274 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404060#comment-15404060 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73162978 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/FileInputFormatTest.java --- @@ -257,41 +257,22 @@ public void testFileInputSplit() {

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404050#comment-15404050 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73162125 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -274,7 +272,7 @@

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404049#comment-15404049 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73162167 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404048#comment-15404048 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73162004 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java --- @@ -274,7 +272,7 @@

[jira] [Commented] (FLINK-3677) FileInputFormat: Allow to specify include/exclude file name patterns

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404047#comment-15404047 ] ASF GitHub Bot commented on FLINK-3677: --- Github user mxm commented on a diff in the pull request:

[GitHub] flink pull request #2109: [FLINK-3677] FileInputFormat: Allow to specify inc...

2016-08-02 Thread mxm
Github user mxm commented on a diff in the pull request: https://github.com/apache/flink/pull/2109#discussion_r73161791 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java --- @@ -995,8 +993,7 @@ public

[jira] [Commented] (FLINK-3298) Streaming connector for ActiveMQ

2016-08-02 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404033#comment-15404033 ] Stephan Ewen commented on FLINK-3298: - Another option we have been discussing a lot, is to have a

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404021#comment-15404021 ] ASF GitHub Bot commented on FLINK-3929: --- Github user mxm commented on a diff in the pull request:

[jira] [Commented] (FLINK-3929) Support for Kerberos Authentication with Keytab Credential

2016-08-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404003#comment-15404003 ] ASF GitHub Bot commented on FLINK-3929: --- Github user mxm commented on a diff in the pull request:

  1   2   >