[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534886#comment-15534886 ] ASF GitHub Bot commented on FLINK-4068: --- Github user wuchong commented on the issue:

[GitHub] flink issue #2560: [FLINK-4068] [table] Move constant computations out of co...

2016-09-29 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/2560 @twalthr I add some Table API tests but skip some tests doesn't supported in Table API, such as `NULLIF`, `IN`, `EXTRACT` --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-4718) Confusing label in Parallel Streams Diagram

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534817#comment-15534817 ] ASF GitHub Bot commented on FLINK-4718: --- GitHub user nderraugh opened a pull request:

[GitHub] flink pull request #2575: 'Id' is the key of the stream and not the id of th...

2016-09-29 Thread nderraugh
GitHub user nderraugh opened a pull request: https://github.com/apache/flink/pull/2575 'Id' is the key of the stream and not the id of the event. FLINK-4718 Confusing label in Parallel Streams Diagram Minor text change to clarify a mildly confusing label in a diagram. You

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534809#comment-15534809 ] ASF GitHub Bot commented on FLINK-4068: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...

2016-09-29 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/2560#discussion_r81270921 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala --- @@ -60,6 +60,7 @@ class FlinkPlannerImpl(

[jira] [Comment Edited] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-09-29 Thread Zhijiang Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534797#comment-15534797 ] Zhijiang Wang edited comment on FLINK-4715 at 9/30/16 2:31 AM: --- Yes, we

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534800#comment-15534800 ] ASF GitHub Bot commented on FLINK-4348: --- Github user beyond1920 commented on the issue:

[jira] [Created] (FLINK-4718) Confusing label in Parallel Streams Diagram

2016-09-29 Thread Neil Derraugh (JIRA)
Neil Derraugh created FLINK-4718: Summary: Confusing label in Parallel Streams Diagram Key: FLINK-4718 URL: https://issues.apache.org/jira/browse/FLINK-4718 Project: Flink Issue Type: Bug

[GitHub] flink issue #2571: [FLINK-4348] Simplify logic of SlotManager

2016-09-29 Thread beyond1920
Github user beyond1920 commented on the issue: https://github.com/apache/flink/pull/2571 @mxm, What would happen under following cases: taskExecutor releases a registered slot, then taskExecutor reports its latest slotReport to ResourceManager, ResourceManager should remove the old

[jira] [Commented] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-09-29 Thread Zhijiang Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534797#comment-15534797 ] Zhijiang Wang commented on FLINK-4715: -- Yes, we already experienced this problem in real production

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534249#comment-15534249 ] ASF GitHub Bot commented on FLINK-2254: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81246840 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java --- @@ -0,0 +1,231 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534241#comment-15534241 ] ASF GitHub Bot commented on FLINK-2254: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81246465 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/Edge.java --- @@ -34,10 +34,10 @@ public Edge(){} -

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534239#comment-15534239 ] ASF GitHub Bot commented on FLINK-2254: --- Github user mushketyk commented on the issue:

[GitHub] flink issue #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread mushketyk
Github user mushketyk commented on the issue: https://github.com/apache/flink/pull/2564 Hi @greghogan, I like your ideas about providing different API for projections. This should be better than my approach. @vasia What do you think about this? --- If your project is

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534224#comment-15534224 ] ASF GitHub Bot commented on FLINK-2254: --- Github user mushketyk commented on a diff in the pull

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread mushketyk
Github user mushketyk commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81245767 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java --- @@ -480,7 +480,8 @@ protected static

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534216#comment-15534216 ] ASF GitHub Bot commented on FLINK-4329: --- Github user kl0u commented on the issue:

[GitHub] flink issue #2546: [FLINK-4329] Fix Streaming File Source Timestamps/Waterma...

2016-09-29 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/2546 Hi @StephanEwen . If I understand correctly, your suggestion is to make the test something like the following: 1) put the split in the reader 2) read the split 3) when the split finishes update the

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534014#comment-15534014 ] ASF GitHub Bot commented on FLINK-2254: --- Github user greghogan commented on a diff in the pull

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15534015#comment-15534015 ] ASF GitHub Bot commented on FLINK-2254: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81225166 --- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestBaseUtils.java --- @@ -480,7 +480,8 @@ protected static

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81226805 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java --- @@ -0,0 +1,231 @@ +/* + * Licensed to the

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81217922 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81218538 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/Edge.java --- @@ -34,10 +34,10 @@ public Edge(){} - public

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81218403 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81218056 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #2564: [FLINK-2254] Add BipartiateGraph class

2016-09-29 Thread vasia
Github user vasia commented on a diff in the pull request: https://github.com/apache/flink/pull/2564#discussion_r81218490 --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/BipartiteGraph.java --- @@ -0,0 +1,231 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533864#comment-15533864 ] ASF GitHub Bot commented on FLINK-2254: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533866#comment-15533866 ] ASF GitHub Bot commented on FLINK-2254: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533865#comment-15533865 ] ASF GitHub Bot commented on FLINK-2254: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533863#comment-15533863 ] ASF GitHub Bot commented on FLINK-2254: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-2254) Add Bipartite Graph Support for Gelly

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533862#comment-15533862 ] ASF GitHub Bot commented on FLINK-2254: --- Github user vasia commented on a diff in the pull request:

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533663#comment-15533663 ] ASF GitHub Bot commented on FLINK-4329: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2546#discussion_r81204726 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java --- @@ -440,10 +491,50 @@ public void

[jira] [Commented] (FLINK-4329) Fix Streaming File Source Timestamps/Watermarks Handling

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533662#comment-15533662 ] ASF GitHub Bot commented on FLINK-4329: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2546#discussion_r81204990 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java --- @@ -190,12 +213,30 @@ public void

[GitHub] flink pull request #2546: [FLINK-4329] Fix Streaming File Source Timestamps/...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/2546#discussion_r81204828 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileMonitoringTest.java --- @@ -440,10 +491,50 @@ public void

[jira] [Commented] (FLINK-4636) AbstractCEPPatternOperator fails to restore state

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533563#comment-15533563 ] ASF GitHub Bot commented on FLINK-4636: --- Github user greghogan commented on a diff in the pull

[jira] [Commented] (FLINK-4643) Average Clustering Coefficient

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533562#comment-15533562 ] ASF GitHub Bot commented on FLINK-4643: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2568: [FLINK-4636] Add boundary check for priorityqueue ...

2016-09-29 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/2568#discussion_r81200110 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractCEPPatternOperator.java --- @@ -126,11 +126,12 @@ public void

[GitHub] flink issue #2528: [FLINK-4643] [gelly] Average Clustering Coefficient

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2528 Looks good to me. Test failure is unrelated. From my side, feel free to merge... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] flink pull request #2568: [FLINK-4636] Add boundary check for priorityqueue ...

2016-09-29 Thread jaxbihani
Github user jaxbihani commented on a diff in the pull request: https://github.com/apache/flink/pull/2568#discussion_r81199485 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractCEPPatternOperator.java --- @@ -126,11 +126,12 @@ public void

[jira] [Commented] (FLINK-4636) AbstractCEPPatternOperator fails to restore state

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533555#comment-15533555 ] ASF GitHub Bot commented on FLINK-4636: --- Github user jaxbihani commented on a diff in the pull

[jira] [Created] (FLINK-4717) Naive version of atomic stop signal with savepoint

2016-09-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4717: Summary: Naive version of atomic stop signal with savepoint Key: FLINK-4717 URL: https://issues.apache.org/jira/browse/FLINK-4717 Project: Flink Issue Type:

[jira] [Commented] (FLINK-4573) Potential resource leak due to unclosed RandomAccessFile in TaskManagerLogHandler

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533528#comment-15533528 ] ASF GitHub Bot commented on FLINK-4573: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #2556: [FLINK-4573] Fix potential resource leak due to unclosed ...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2556 Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Updated] (FLINK-4650) Frequent task manager disconnects from JobManager

2016-09-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-4650: - Fix Version/s: 1.2.0 > Frequent task manager disconnects from JobManager >

[jira] [Updated] (FLINK-4650) Frequent task manager disconnects from JobManager

2016-09-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-4650: - Affects Version/s: 1.2.0 > Frequent task manager disconnects from JobManager >

[jira] [Created] (FLINK-4716) Add trigger full recovery button to web UI

2016-09-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4716: Summary: Add trigger full recovery button to web UI Key: FLINK-4716 URL: https://issues.apache.org/jira/browse/FLINK-4716 Project: Flink Issue Type:

[jira] [Created] (FLINK-4715) TaskManager should commit suicide after cancellation failure

2016-09-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4715: Summary: TaskManager should commit suicide after cancellation failure Key: FLINK-4715 URL: https://issues.apache.org/jira/browse/FLINK-4715 Project: Flink

[jira] [Created] (FLINK-4714) Set task state to RUNNING after state has been restored

2016-09-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4714: Summary: Set task state to RUNNING after state has been restored Key: FLINK-4714 URL: https://issues.apache.org/jira/browse/FLINK-4714 Project: Flink Issue

[jira] [Commented] (FLINK-4700) Harden the TimeProvider test

2016-09-29 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533260#comment-15533260 ] Kostas Kloudas commented on FLINK-4700: --- [~StephanEwen] I am thinking that the best solution to

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533216#comment-15533216 ] ASF GitHub Bot commented on FLINK-4702: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533215#comment-15533215 ] ASF GitHub Bot commented on FLINK-4711: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #2574: [FLINK-4702] [kafka connector] Commit offsets to Kafka as...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2574 @tzulitai @rmetzger We need to make sure that the Kafka 0.10 code picks up this change and the test case. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #2569: [FLINK-4711] Let the Task trigger partition state request...

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2569 Thanks for the review @uce. If Travis gives green light, I'll merge the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533211#comment-15533211 ] ASF GitHub Bot commented on FLINK-4702: --- Github user StephanEwen closed the pull request at:

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533210#comment-15533210 ] ASF GitHub Bot commented on FLINK-4702: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #2559: [FLINK-4702] [kafka connector] Commit offets to Ka...

2016-09-29 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/2559 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2559: [FLINK-4702] [kafka connector] Commit offets to Kafka asy...

2016-09-29 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2559 Closing this for #2574 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-4702) Kafka consumer must commit offsets asynchronously

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533206#comment-15533206 ] ASF GitHub Bot commented on FLINK-4702: --- GitHub user StephanEwen opened a pull request:

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533204#comment-15533204 ] ASF GitHub Bot commented on FLINK-4348: --- Github user mxm commented on the issue:

[GitHub] flink pull request #2574: [FLINK-4702] [kafka connector] Commit offsets to K...

2016-09-29 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/2574 [FLINK-4702] [kafka connector] Commit offsets to Kafka asynchronously and don't block on polls This fix is quite critical! While the KafkaConsumer is polling for new data (with a

[GitHub] flink issue #2571: [FLINK-4348] Simplify logic of SlotManager

2016-09-29 Thread mxm
Github user mxm commented on the issue: https://github.com/apache/flink/pull/2571 CC @beyond1920 @KurtYoung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533193#comment-15533193 ] ASF GitHub Bot commented on FLINK-4711: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533194#comment-15533194 ] ASF GitHub Bot commented on FLINK-4711: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2569: [FLINK-4711] Let the Task trigger partition state ...

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2569#discussion_r81173562 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/messages/TaskControlMessages.scala --- @@ -92,16 +92,6 @@ object TaskMessages {

[GitHub] flink pull request #2569: [FLINK-4711] Let the Task trigger partition state ...

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2569#discussion_r81173599 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -873,8 +873,7 @@ class JobManager( }

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533192#comment-15533192 ] ASF GitHub Bot commented on FLINK-4711: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #2569: [FLINK-4711] Let the Task trigger partition state ...

2016-09-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2569#discussion_r81173481 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/JobManagerCommunicationFactory.java --- @@ -27,15 +26,6 @@ public

[GitHub] flink pull request #2573: Refactor StreamOperator Hierachy to make Keys Expl...

2016-09-29 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2573 Refactor StreamOperator Hierachy to make Keys Explicit This is more of a preview PR, I'm not yet completely done with testing and making sure that everything works. R: @StephanEwen You

[jira] [Commented] (FLINK-4552) Refactor WindowOperator/Trigger Tests

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533144#comment-15533144 ] ASF GitHub Bot commented on FLINK-4552: --- GitHub user aljoscha opened a pull request:

[GitHub] flink pull request #2572: [FLINK-4552] Refactor WindowOperator/Trigger Tests

2016-09-29 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2572 [FLINK-4552] Refactor WindowOperator/Trigger Tests This builds on #2570 Before, tests for WindowOperator, WindowAssigner, Trigger and WindowFunction were all conflated in

[jira] [Commented] (FLINK-4348) Implement slot allocation protocol with TaskExecutor

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533113#comment-15533113 ] ASF GitHub Bot commented on FLINK-4348: --- GitHub user mxm opened a pull request:

[GitHub] flink pull request #2571: [FLINK-4348] Simplify logic of SlotManager

2016-09-29 Thread mxm
GitHub user mxm opened a pull request: https://github.com/apache/flink/pull/2571 [FLINK-4348] Simplify logic of SlotManager This pull request is split up into two commits: 1. It removes some code from the `SlotManager` to make it simpler. - It makes use of

[GitHub] flink pull request #2569: [FLINK-4711] Let the Task trigger partition state ...

2016-09-29 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2569#discussion_r81164326 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/messages/TaskControlMessages.scala --- @@ -92,16 +92,6 @@ object TaskMessages { //

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533098#comment-15533098 ] ASF GitHub Bot commented on FLINK-4711: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2569: [FLINK-4711] Let the Task trigger partition state ...

2016-09-29 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2569#discussion_r81162283 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/JobManagerCommunicationFactory.java --- @@ -27,15 +26,6 @@ public interface

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533100#comment-15533100 ] ASF GitHub Bot commented on FLINK-4711: --- Github user uce commented on a diff in the pull request:

[GitHub] flink pull request #2569: [FLINK-4711] Let the Task trigger partition state ...

2016-09-29 Thread uce
Github user uce commented on a diff in the pull request: https://github.com/apache/flink/pull/2569#discussion_r81164597 --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala --- @@ -873,8 +873,7 @@ class JobManager( }

[jira] [Commented] (FLINK-4711) TaskManager can crash due to failing onPartitionStateUpdate call

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533099#comment-15533099 ] ASF GitHub Bot commented on FLINK-4711: --- Github user uce commented on a diff in the pull request:

[jira] [Updated] (FLINK-4712) Implementing ranking predictions for ALS

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Domokos Miklós Kelen updated FLINK-4712: Description: We started working on implementing ranking predictions for recommender

[GitHub] flink pull request #2570: [FLINK-3674] Add an interface for Time aware User ...

2016-09-29 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/2570 [FLINK-3674] Add an interface for Time aware User Functions This moves the event-time/processing-time trigger code from `WindowOperator` behind a well defined interface that can be used by

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533076#comment-15533076 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #2560: [FLINK-4068] [table] Move constant computations ou...

2016-09-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/2560#discussion_r81163353 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/FlinkPlannerImpl.scala --- @@ -60,6 +60,7 @@ class FlinkPlannerImpl(

[jira] [Updated] (FLINK-4712) Implementing ranking predictions for ALS

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Domokos Miklós Kelen updated FLINK-4712: Description: We started working on implementing ranking predictions for recommender

[jira] [Commented] (FLINK-4068) Move constant computations out of code-generated `flatMap` functions.

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533067#comment-15533067 ] ASF GitHub Bot commented on FLINK-4068: --- Github user twalthr commented on the issue:

[jira] [Created] (FLINK-4713) Implementing ranking evaluation scores for recommender systems

2016-09-29 Thread JIRA
Domokos Miklós Kelen created FLINK-4713: --- Summary: Implementing ranking evaluation scores for recommender systems Key: FLINK-4713 URL: https://issues.apache.org/jira/browse/FLINK-4713 Project:

[GitHub] flink issue #2542: [FLINK-4613] [ml] Extend ALS to handle implicit feedback ...

2016-09-29 Thread thvasilo
Github user thvasilo commented on the issue: https://github.com/apache/flink/pull/2542 @gaborhermann I think have a larger scale test would boost our confidence in the implementation, and maybe point out some problems that do not manifest with small data, which is very common.

[jira] [Updated] (FLINK-4712) Implementing ranking predictions for ALS

2016-09-29 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Domokos Miklós Kelen updated FLINK-4712: Description: We started working on implementing ranking predictions for recommender

[jira] [Created] (FLINK-4712) Implementing ranking predictions for ALS

2016-09-29 Thread JIRA
Domokos Miklós Kelen created FLINK-4712: --- Summary: Implementing ranking predictions for ALS Key: FLINK-4712 URL: https://issues.apache.org/jira/browse/FLINK-4712 Project: Flink Issue

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533048#comment-15533048 ] ASF GitHub Bot commented on FLINK-4613: --- Github user thvasilo commented on the issue:

[GitHub] flink pull request #2547: [FLINK-4552] Refactor WindowOperator/Trigger Tests

2016-09-29 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/2547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533029#comment-15533029 ] ASF GitHub Bot commented on FLINK-4613: --- Github user thvasilo commented on a diff in the pull

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81159482 --- Diff: flink-libraries/flink-ml/src/test/scala/org/apache/flink/ml/recommendation/ImplicitALSTest.scala --- @@ -0,0 +1,171 @@ +/* + * Licensed

[jira] [Commented] (FLINK-4613) Extend ALS to handle implicit feedback datasets

2016-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533024#comment-15533024 ] ASF GitHub Bot commented on FLINK-4613: --- Github user thvasilo commented on a diff in the pull

[GitHub] flink pull request #2542: [FLINK-4613] [ml] Extend ALS to handle implicit fe...

2016-09-29 Thread thvasilo
Github user thvasilo commented on a diff in the pull request: https://github.com/apache/flink/pull/2542#discussion_r81159171 --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/recommendation/ALS.scala --- @@ -581,6 +637,16 @@ object ALS { val

  1   2   >