[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927536#comment-15927536 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3547: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-15 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3547#discussion_r106343179 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -130,32

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927534#comment-15927534 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3547: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-15 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3547#discussion_r106343147 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -130,32

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927530#comment-15927530 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3547: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-15 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3547#discussion_r106342776 --- Diff: flink-libraries/flink-table/src/test/java/org/apache/flink/table/api/java/stream/sql/ProcTimeRowStreamAggregationSqlITCase.java --- @@

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927520#comment-15927520 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on the issue:

[GitHub] flink issue #3520: [FLINK-3849] [table] Add FilterableTableSource interface ...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3520 Hi @fhueske @godfreyhe, thanks for the review, i addressed most all your comments. @fhueske Except for letting `TableSourceScan` be aware of whether filter has been pushed down. I'm not

[jira] [Commented] (FLINK-5978) JM WebFrontend address ConfigOption is defined in ConfigConstants

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927494#comment-15927494 ] ASF GitHub Bot commented on FLINK-5978: --- GitHub user zjureel opened a pull request:

[GitHub] flink pull request #3552: [FLINK-5978] Fix JM WebFrontend address ConfigOpti...

2017-03-15 Thread zjureel
GitHub user zjureel opened a pull request: https://github.com/apache/flink/pull/3552 [FLINK-5978] Fix JM WebFrontend address ConfigOption is defined in Co… …nfigConstants Thanks for contributing to Apache Flink. Before you open your pull request, please take the

[jira] [Resolved] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-03-15 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-5701. Resolution: Fixed Additionally fixed for 1.1.5 with

[jira] [Commented] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927479#comment-15927479 ] ASF GitHub Bot commented on FLINK-5701: --- Github user tzulitai closed the pull request at:

[GitHub] flink pull request #3549: [backport-1.1] [FLINK-5701] [kafka] FlinkKafkaProd...

2017-03-15 Thread tzulitai
Github user tzulitai closed the pull request at: https://github.com/apache/flink/pull/3549 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927464#comment-15927464 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3547: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-15 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3547#discussion_r106336720 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -19,33 +19,124 @@ package

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927457#comment-15927457 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106335718 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/FilterableTableSource.scala --- @@ -0,0 +1,66 @@ +/* + *

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927456#comment-15927456 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927453#comment-15927453 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106335709 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala --- @@ -0,0 +1,184 @@ +/* + *

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106335660 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala --- @@ -0,0 +1,184 @@ +/* + *

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927451#comment-15927451 ] ASF GitHub Bot commented on FLINK-3930: --- Github user WangTaoTheTonic commented on a diff in the pull

[GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...

2017-03-15 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on a diff in the pull request: https://github.com/apache/flink/pull/2425#discussion_r106335560 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CookieHandler.java --- @@ -0,0 +1,130 @@ +/** + * Licensed

[GitHub] flink pull request #2425: FLINK-3930 Added shared secret based authorization...

2017-03-15 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on a diff in the pull request: https://github.com/apache/flink/pull/2425#discussion_r106335331 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CookieHandler.java --- @@ -0,0 +1,130 @@ +/** + * Licensed

[jira] [Commented] (FLINK-3930) Implement Service-Level Authorization

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927446#comment-15927446 ] ASF GitHub Bot commented on FLINK-3930: --- Github user WangTaoTheTonic commented on a diff in the pull

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927442#comment-15927442 ] ASF GitHub Bot commented on FLINK-5653: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #3547: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-15 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/3547#discussion_r106335062 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/rel/LogicalWindowAggregate.scala --- @@ -18,8 +18,6 @@

[jira] [Commented] (FLINK-5701) FlinkKafkaProducer should check asyncException on checkpoints

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927441#comment-15927441 ] ASF GitHub Bot commented on FLINK-5701: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3549: [backport-1.1] [FLINK-5701] [kafka] FlinkKafkaProducer sh...

2017-03-15 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3549 Thanks for the review! Travis is green (local branch), with only test timeouts: https://travis-ci.org/tzulitai/flink Merging this .. --- If your project is set up for it, you can

[jira] [Resolved] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2017-03-15 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-5048. Resolution: Fixed Fix Version/s: (was: 1.1.5) > Kafka Consumer

[jira] [Comment Edited] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2017-03-15 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927427#comment-15927427 ] Tzu-Li (Gordon) Tai edited comment on FLINK-5048 at 3/16/17 3:43 AM: -

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2017-03-15 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927427#comment-15927427 ] Tzu-Li (Gordon) Tai commented on FLINK-5048: Agreed, let's resolve this issue and remove

[jira] [Commented] (FLINK-5978) JM WebFrontend address ConfigOption is defined in ConfigConstants

2017-03-15 Thread fang yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927411#comment-15927411 ] fang yong commented on FLINK-5978: -- Hi Chesnay Schepler, glad to see an easy issue while I'm new, could

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106329219 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/dataSet/PushFilterIntoBatchTableSourceScanRule.scala --- @@ -0,0

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106329225 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/PushFilterIntoStreamTableSourceScanRule.scala --- @@

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927379#comment-15927379 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106328751 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/TableSourceTable.scala --- @@ -25,6 +25,7 @@ import

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927380#comment-15927380 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106329099 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala --- @@ -0,0 +1,184 @@ +/* + *

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927377#comment-15927377 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927378#comment-15927378 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106329079 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala --- @@ -0,0

[jira] [Updated] (FLINK-5650) Flink-python tests executing cost too long time

2017-03-15 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shijinkui updated FLINK-5650: - Labels: osx (was: ) > Flink-python tests executing cost too long time >

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927371#comment-15927371 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-5981) SSL version and ciper suites cannot be constrained as configured

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927368#comment-15927368 ] ASF GitHub Bot commented on FLINK-5981: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3486: [FLINK-5981][SECURITY]make ssl version and cipher suites ...

2017-03-15 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3486 Since not merged, I've turned them around. Sorry for the carelessness :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-5498) Add support for left/right outer joins with non-equality predicates (and 1+ equality predicates)

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927355#comment-15927355 ] ASF GitHub Bot commented on FLINK-5498: --- Github user lincoln-lil commented on the issue:

[GitHub] flink issue #3379: [FLINK-5498] [table] Add support for left/right outer joi...

2017-03-15 Thread lincoln-lil
Github user lincoln-lil commented on the issue: https://github.com/apache/flink/pull/3379 Part of integration tests will occasionally fail when submit this pr, and I configured Travis CI for my repository then got a whole pass. see

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927353#comment-15927353 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106327707 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/common/PushFilterIntoTableSourceScanRuleBase.scala --- @@ -0,0

[jira] [Commented] (FLINK-5883) Re-adding the Exception-thrown code for ListKeyGroupedIterator when the iterator is requested the second time

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927325#comment-15927325 ] ASF GitHub Bot commented on FLINK-5883: --- Github user lincoln-lil commented on the issue:

[GitHub] flink issue #3392: [FLINK-5883] Re-adding the Exception-thrown code for List...

2017-03-15 Thread lincoln-lil
Github user lincoln-lil commented on the issue: https://github.com/apache/flink/pull/3392 Appreciated if someone can merge this pr --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-5658) Add event time OVER RANGE BETWEEN UNBOUNDED PRECEDING aggregation to SQL

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927322#comment-15927322 ] ASF GitHub Bot commented on FLINK-5658: --- Github user hongyuhong commented on a diff in the pull

[GitHub] flink pull request #3386: [FLINK-5658][table] support unbounded eventtime ov...

2017-03-15 Thread hongyuhong
Github user hongyuhong commented on a diff in the pull request: https://github.com/apache/flink/pull/3386#discussion_r106324953 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/UnboundedEventTimeOverProcessFunction.scala --- @@ -0,0

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927319#comment-15927319 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927318#comment-15927318 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106324883 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/BatchTableSourceScan.scala --- @@ -58,16 +60,24 @@ class

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106324868 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/TableSource.scala --- @@ -39,4 +39,6 @@ trait TableSource[T] {

[jira] [Commented] (FLINK-5668) passing taskmanager configuration through taskManagerEnv instead of file

2017-03-15 Thread Bill Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927308#comment-15927308 ] Bill Liu commented on FLINK-5668: - it still doesn't solve my problem. I want to start Flink Job without

[jira] [Commented] (FLINK-4364) Implement TaskManager side of heartbeat from JobManager

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927296#comment-15927296 ] ASF GitHub Bot commented on FLINK-4364: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-5865) Throw original exception in states

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927295#comment-15927295 ] ASF GitHub Bot commented on FLINK-5865: --- Github user shixiaogang commented on the issue:

[GitHub] flink issue #3151: [FLINK-4364] [runtime] [FLIP-6] Implement TaskManager sid...

2017-03-15 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/3151 @tillrohrmann , just remind to review my modifications for your free time, because this would block my next pull request of heartbeat between `TaskManager` and `ResourceManager`. Thank you! ---

[GitHub] flink issue #3380: [FLINK-5865][state] Throw original exception in the state...

2017-03-15 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/3380 I prefer to throw more detailed exceptions e.g. `IncompatibleTypeSerializerException`, `StateAccessException` and `StateNotFoundException`. They all are extended from `FlinkRuntimeException`.

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106322568 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala --- @@ -42,63 +41,40 @@ class

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927290#comment-15927290 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[jira] [Commented] (FLINK-3849) Add FilterableTableSource interface and translation rule

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927277#comment-15927277 ] ASF GitHub Bot commented on FLINK-3849: --- Github user KurtYoung commented on a diff in the pull

[GitHub] flink pull request #3520: [FLINK-3849] [table] Add FilterableTableSource int...

2017-03-15 Thread KurtYoung
Github user KurtYoung commented on a diff in the pull request: https://github.com/apache/flink/pull/3520#discussion_r106321885 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/ProjectableTableSource.scala --- @@ -24,7 +24,7 @@ package

[jira] [Closed] (FLINK-6026) Return type of flatMap with lambda function not correctly resolved

2017-03-15 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Hutchison closed FLINK-6026. - Resolution: Not A Bug > Return type of flatMap with lambda function not correctly resolved >

[jira] [Commented] (FLINK-6026) Return type of flatMap with lambda function not correctly resolved

2017-03-15 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927065#comment-15927065 ] Luke Hutchison commented on FLINK-6026: --- Makes sense. I was wondering if there was some sort of type

[jira] [Commented] (FLINK-3414) Add Scala API for CEP's pattern definition

2017-03-15 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15927063#comment-15927063 ] Ivan Mushketyk commented on FLINK-3414: --- Hi [~dawidwys] I don't have time to work on this task now,

[jira] [Assigned] (FLINK-3414) Add Scala API for CEP's pattern definition

2017-03-15 Thread Ivan Mushketyk (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Mushketyk reassigned FLINK-3414: - Assignee: Dawid Wysakowicz (was: Ivan Mushketyk) > Add Scala API for CEP's pattern

[GitHub] flink issue #3523: [FLINK-5985] Report no task states for stateless tasks on...

2017-03-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3523 Can we slightly adapt the test to target more the typical use case: - Original job has some stateless ops (no uid), and some stateful ones (with uid) - Create a modified job that has

[jira] [Commented] (FLINK-5985) Flink treats every task as stateful (making topology changes impossible)

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926831#comment-15926831 ] ASF GitHub Bot commented on FLINK-5985: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5048) Kafka Consumer (0.9/0.10) threading model leads problematic cancellation behavior

2017-03-15 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926820#comment-15926820 ] Robert Metzger commented on FLINK-5048: --- I'm not aware of any user on 1.1 affected by this. The

[jira] [Commented] (FLINK-5962) Cancel checkpoint canceller tasks in CheckpointCoordinator

2017-03-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926812#comment-15926812 ] Stephan Ewen commented on FLINK-5962: - Fixed in 1.2 via 9d59e008d8849cdfe2daf302e251454435bb997f >

[GitHub] flink pull request #:

2017-03-15 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/commit/0a501e9f7f56baba2905002b74746998458db007#commitcomment-21337504 In flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/triggers/ContinuousEventTimeTrigger.java:

[jira] [Commented] (FLINK-6044) TypeSerializerSerializationProxy.read() doesn't verify the read buffer length

2017-03-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926785#comment-15926785 ] Stephan Ewen commented on FLINK-6044: - The {{read()}} / {{readFully()}} issue has occurred before, it

[jira] [Commented] (FLINK-6044) TypeSerializerSerializationProxy.read() doesn't verify the read buffer length

2017-03-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926779#comment-15926779 ] Stephan Ewen commented on FLINK-6044: - [~srichter] I think we should try and safeguard Flink against

[jira] [Commented] (FLINK-6018) Properly initialise StateDescriptor in AbstractStateBackend.getPartitionedState()

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926772#comment-15926772 ] ASF GitHub Bot commented on FLINK-6018: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3534: [FLINK-6018][statebackend] Properly initialise StateDescr...

2017-03-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3534 This change may alter the format of savepoints, because it now forwards type-registrations to the Kryo serializer, which it did not do before. Since we announced savepoint compatibility,

[jira] [Commented] (FLINK-6018) Properly initialise StateDescriptor in AbstractStateBackend.getPartitionedState()

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926770#comment-15926770 ] ASF GitHub Bot commented on FLINK-6018: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3534: [FLINK-6018][statebackend] Properly initialise StateDescr...

2017-03-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3534 There is also another method in `AbstractKeyedStateBackend`: `getOrCreateKeyedState` which does not silently use an empty `ExecutionConfig` but throws an exception. That method could also use

[jira] [Commented] (FLINK-6018) Properly initialise StateDescriptor in AbstractStateBackend.getPartitionedState()

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926768#comment-15926768 ] ASF GitHub Bot commented on FLINK-6018: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3534: [FLINK-6018][statebackend] Properly initialise StateDescr...

2017-03-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3534 I think this could have really used a test. It is tricky bug that will easily be re-introduced without a test that guards the fix. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-6063) HA Configuration doesn't work with Flink 1.2

2017-03-15 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926682#comment-15926682 ] Till Rohrmann commented on FLINK-6063: -- Hi Razvan, sometimes it can take a little while until

[jira] [Commented] (FLINK-5095) Add explicit notifyOfAddedX methods to MetricReporter interface

2017-03-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926684#comment-15926684 ] Bowen Li commented on FLINK-5095: - Agree that MetricReporter interface is not extendable and scalable, and

[jira] [Commented] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

2017-03-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926665#comment-15926665 ] Bowen Li commented on FLINK-6053: - Cool. Adding a NumberGauge or NumericGauge was my first impression when

[jira] [Commented] (FLINK-5756) When there are many values under the same key in ListState, RocksDBStateBackend performances poor

2017-03-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926662#comment-15926662 ] Stephan Ewen commented on FLINK-5756: - Just validated that compactions actually help, but compactions

[GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...

2017-03-15 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3483#discussion_r106138741 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackendSnapshotBackwardsCompatibilityTest.java --- @@ -0,0 +1,107

[GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...

2017-03-15 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3483#discussion_r106137929 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/CopyOnWriteStateTable.java --- @@ -0,0 +1,1021 @@ +/* + * Licensed to

[GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...

2017-03-15 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3483#discussion_r106132349 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyContext.java --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3547: [FLINK-5653] Add processing time OVER ROWS BETWEEN...

2017-03-15 Thread huawei-flink
Github user huawei-flink commented on a diff in the pull request: https://github.com/apache/flink/pull/3547#discussion_r106238200 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -19,33 +19,124 @@ package

[jira] [Commented] (FLINK-5653) Add processing time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926658#comment-15926658 ] ASF GitHub Bot commented on FLINK-5653: --- Github user huawei-flink commented on a diff in the pull

[jira] [Created] (FLINK-6065) Make TransportClient for ES5 pluggable

2017-03-15 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-6065: - Summary: Make TransportClient for ES5 pluggable Key: FLINK-6065 URL: https://issues.apache.org/jira/browse/FLINK-6065 Project: Flink Issue Type:

[jira] [Closed] (FLINK-6018) Properly initialise StateDescriptor in AbstractStateBackend.getPartitionedState()

2017-03-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-6018. --- Resolution: Fixed Fix Version/s: 1.3.0 Fixed on master in

[jira] [Commented] (FLINK-6018) Properly initialise StateDescriptor in AbstractStateBackend.getPartitionedState()

2017-03-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926635#comment-15926635 ] ASF GitHub Bot commented on FLINK-6018: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3534: [FLINK-6018][statebackend] Properly initialise StateDescr...

2017-03-15 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3534 Thanks for your contribution! 😃 I just merged. Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...

2017-03-15 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3483#discussion_r106136980 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackendSnapshotBackwardsCompatibilityTest.java --- @@ -0,0 +1,107

[GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...

2017-03-15 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3483#discussion_r106133243 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/AbstractHeapMergingState.java --- @@ -47,77 +44,62 @@ /** *

[GitHub] flink pull request #3483: [FLINK-5979] Backwards compatibility for HeapKeyed...

2017-03-15 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3483#discussion_r106139194 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/StateEntry.java --- @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache

  1   2   3   4   5   6   >