[jira] [Commented] (FLINK-6312) Update curator version to 2.12.0

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975121#comment-15975121 ] ASF GitHub Bot commented on FLINK-6312: --- Github user WangTaoTheTonic commented on th

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

2017-04-19 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3727 Sure. Seems like it will take a little long time but i'll try my best :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Closed] (FLINK-6149) add additional flink logical relation nodes

2017-04-19 Thread Dmytro Shkvyra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Shkvyra closed FLINK-6149. - Resolution: Fixed Ok [~ykt836], I will close it. Thanks for clarification. > add additional flin

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975118#comment-15975118 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on th

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-19 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 That means every time EGHolder received a request, it will check if the job status in request is suspended or not, right? This will make cache in EGHolder unmeaningful. --- If your project

[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975114#comment-15975114 ] ASF GitHub Bot commented on FLINK-5256: --- Github user DmytroShkvyra commented on the

[GitHub] flink issue #3673: [FLINK-5256] Extend DataSetSingleRowJoin to support Left ...

2017-04-19 Thread DmytroShkvyra
Github user DmytroShkvyra commented on the issue: https://github.com/apache/flink/pull/3673 Hi @fhueske could you review this variant. I had to removed tests with non-equality predicates (https://issues.apache.org/jira/browse/FLINK-5520) --- If your project is set up for it, you can

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975105#comment-15975105 ] ASF GitHub Bot commented on FLINK-6311: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3738 The `shardConsumersExecutor` variable is final. No need to make it `volatile`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-5646) REST api documentation missing details on jar upload

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975101#comment-15975101 ] ASF GitHub Bot commented on FLINK-5646: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3722: [FLINK-5646] Document JAR upload with the REST API

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3722 Looks good, thanks. Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-6303) Documentation support build in docker on OSX

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975085#comment-15975085 ] ASF GitHub Bot commented on FLINK-6303: --- Github user patricklucas commented on the i

[GitHub] flink issue #3719: [FLINK-6303] Documentation support build in docker on OSX

2017-04-19 Thread patricklucas
Github user patricklucas commented on the issue: https://github.com/apache/flink/pull/3719 Thanks for the PR @mtunique! I actually ran into this today and have a fix [in a branch](https://github.com/patricklucas/flink/tree/FLINK-6330_improve_docker_docs) that I will hopefully open a

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975074#comment-15975074 ] ASF GitHub Bot commented on FLINK-6295: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3709 @WangTaoTheTonic Yes, that is correct. @zentol's suggestion should work. On access, if the `JobStatus` is suspended, remove the entry from the `WeakHashMap`. --- If your project is set

[jira] [Commented] (FLINK-5005) Publish Scala 2.12 artifacts

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975055#comment-15975055 ] ASF GitHub Bot commented on FLINK-5005: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3703: [FLINK-5005] WIP: publish scala 2.12 artifacts

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3703 We cannot add any other dependencies to the pom files. Adding "akka" back will create a conflict with the "flakka" files. What we can do is wither of the following two options: - Re

[jira] [Commented] (FLINK-6280) Allow logging with Java flags

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975046#comment-15975046 ] ASF GitHub Bot commented on FLINK-6280: --- Github user greghogan commented on the issu

[jira] [Commented] (FLINK-6046) Add support for oversized messages during deployment

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975044#comment-15975044 ] ASF GitHub Bot commented on FLINK-6046: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3701: [FLINK-6280] [scripts] Allow logging with Java flags

2017-04-19 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3701 I had provided some examples in the JIRA, but yes, it allows delaying evaluation of the java opts (with double quotes) until immediately before the daemon is started. This allows creating additiona

[GitHub] flink issue #3742: [FLINK-6046] Add support for oversized messages during de...

2017-04-19 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3742 ok, between my last tests and the rebase, something must have broken - I'll re-evaluate (merge conflicts + travis) --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-5005) Publish Scala 2.12 artifacts

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975032#comment-15975032 ] ASF GitHub Bot commented on FLINK-5005: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3703: [FLINK-5005] WIP: publish scala 2.12 artifacts

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3703 One thing you can try and do is to run `TypeExtractionUtils.checkAndExtractLambda` to see if it is a generated serializable Lambda. In the case of a Lambda, you could switch to a different co

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975018#comment-15975018 ] ASF GitHub Bot commented on FLINK-6103: --- Github user zentol commented on the issue:

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-04-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3598 @fpompermaier have you addressed the comment @StephanEwen regarding logging? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[jira] [Commented] (FLINK-6280) Allow logging with Java flags

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975013#comment-15975013 ] ASF GitHub Bot commented on FLINK-6280: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3701: [FLINK-6280] [scripts] Allow logging with Java flags

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3701 Can you explain a bit more what this change does exactly? Does it make sure that if you put bash commands into the java opts to compute flags, it evaluates those? Can you elaborate why t

[jira] [Commented] (FLINK-6046) Add support for oversized messages during deployment

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975005#comment-15975005 ] ASF GitHub Bot commented on FLINK-6046: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #3742: [FLINK-6046] Add support for oversized messages du...

2017-04-19 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/3742 [FLINK-6046] Add support for oversized messages during deployment (builds upon #3512) This adds offloading of large data from the `TaskDeploymentDescriptor` to the `BlobServer`, i.e. `seriali

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975002#comment-15975002 ] ASF GitHub Bot commented on FLINK-6103: --- Github user fpompermaier commented on the i

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-04-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3598 Anyone willing to merge this PR...? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[jira] [Comment Edited] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974984#comment-15974984 ] Seth Wiesman edited comment on FLINK-6315 at 4/19/17 4:20 PM: --

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974988#comment-15974988 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112248789 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -398,3 +428,106 @@ readSlaves() { useOffHeapMemory() { [[ "`echo ${FLINK_TM_OFFHEAP}

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974984#comment-15974984 ] Seth Wiesman commented on FLINK-6315: - [~StephanEwen] Regarding the first two points

[jira] [Created] (FLINK-6331) StreamingOperatorsITCase.testAsyncWaitOperator spuriously failing on Travis

2017-04-19 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6331: Summary: StreamingOperatorsITCase.testAsyncWaitOperator spuriously failing on Travis Key: FLINK-6331 URL: https://issues.apache.org/jira/browse/FLINK-6331 Project: Fl

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974981#comment-15974981 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112247760 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java --- @@ -450,7 +450,7 @@ public FileBaseStatistics getStatistics(B

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112246946 --- Diff: flink-dist/src/test/java/org/apache/flink/dist/TaskManagerHeapSizeCalculationJavaBashTest.java --- @@ -0,0 +1,306 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974977#comment-15974977 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974974#comment-15974974 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112246505 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/io/DelimitedInputFormat.java --- @@ -450,7 +450,7 @@ public FileBaseStatistics getStatistics(Ba

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974970#comment-15974970 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112246105 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesTest.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-5623) TempBarrier dam has been closed

2017-04-19 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974953#comment-15974953 ] Greg Hogan commented on FLINK-5623: --- [~fhueske] or [~StephanEwen], would you have a chan

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974950#comment-15974950 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974951#comment-15974951 ] ASF GitHub Bot commented on FLINK-4545: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112242996 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -398,3 +428,106 @@ readSlaves() { useOffHeapMemory() { [[ "`echo ${FLINK_TM_OFFHEAP}

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112242842 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesTest.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974938#comment-15974938 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112239687 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskManagerServicesTest.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974927#comment-15974927 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3721 For the two tests that failed on Travis CI: they were simply killed and a "`Killed`" appeared in their logs which is usually an indicator that memory ran out and the kernel killed a process --- If yo

[jira] [Commented] (FLINK-4545) Flink automatically manages TM network buffer

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974920#comment-15974920 ] ASF GitHub Bot commented on FLINK-4545: --- Github user NicoK commented on a diff in th

[GitHub] flink pull request #3721: [FLINK-4545] replace the network buffers parameter

2017-04-19 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/3721#discussion_r112236022 --- Diff: flink-dist/src/main/flink-bin/bin/config.sh --- @@ -398,3 +428,106 @@ readSlaves() { useOffHeapMemory() { [[ "`echo ${FLINK_TM_OFFHEAP}

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974912#comment-15974912 ] Stephan Ewen commented on FLINK-6315: - [~sjwiesman] Adding a few bits of information h

[jira] [Created] (FLINK-6330) Improve Docker documentation

2017-04-19 Thread Patrick Lucas (JIRA)
Patrick Lucas created FLINK-6330: Summary: Improve Docker documentation Key: FLINK-6330 URL: https://issues.apache.org/jira/browse/FLINK-6330 Project: Flink Issue Type: Bug Componen

[jira] [Commented] (FLINK-6312) Update curator version to 2.12.0

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974889#comment-15974889 ] ASF GitHub Bot commented on FLINK-6312: --- Github user StephanEwen commented on the is

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3727 Good idea to upgrade Curator. Unfortunately, it seems some behavior in Curator has changed. The change causes many tests to hang/fail: https://travis-ci.org/apache/flink/builds/222777

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974855#comment-15974855 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974849#comment-15974849 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974846#comment-15974846 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974848#comment-15974848 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974851#comment-15974851 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974871#comment-15974871 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112212687 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974845#comment-15974845 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974864#comment-15974864 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974856#comment-15974856 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974847#comment-15974847 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974860#comment-15974860 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974862#comment-15974862 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974857#comment-15974857 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974870#comment-15974870 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974844#comment-15974844 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974865#comment-15974865 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974868#comment-15974868 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974872#comment-15974872 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974867#comment-15974867 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974859#comment-15974859 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974866#comment-15974866 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974861#comment-15974861 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974863#comment-15974863 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974852#comment-15974852 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974853#comment-15974853 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974850#comment-15974850 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974858#comment-15974858 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974854#comment-15974854 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974869#comment-15974869 ] ASF GitHub Bot commented on FLINK-6075: --- Github user fhueske commented on a diff in

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112200218 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112198072 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamSortRule.scala --- @@ -0,0 +1,67 @@ +/*

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112207628 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112217315 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112220799 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112203345 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamSortRule.scala --- @@ -0,0 +1,67 @@ +/*

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112225554 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/ProcTimeBoundedSortProcessFunction.scala --- @@ -0,0 +1,114 @@

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112217063 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112226928 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/aggregate/BoundedProcessingOverRangeProcessFunctionTest.scala --- @@ -28

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112207488 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamSort.scala --- @@ -0,0 +1,169 @@ +/* + *

[GitHub] flink pull request #3714: [FLINK-6075] - Support Limit/Top(Sort) for Stream ...

2017-04-19 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112214518 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/SortUtil.scala --- @@ -0,0 +1,353 @@ +/* + * Licensed

<    1   2   3   4   >