[jira] [Commented] (FLINK-6341) JobManager can go to definite message sending loop when TaskManager registered

[ https://issues.apache.org/jira/browse/FLINK-6341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980686#comment-15980686 ] ASF GitHub Bot commented on FLINK-6341: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3745: [FLINK-6341]Don't let JM fall into infinite loop

Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3745 @tillrohrmann What problem it will bring if we access `currentResourceManager` from another thread? It is a variable in JobManager and can be shared across multi threads, right? The new

[jira] [Assigned] (FLINK-6352) FlinkKafkaConsumer should support to use timestamp to set up start offset

[ https://issues.apache.org/jira/browse/FLINK-6352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fang Yong reassigned FLINK-6352: Assignee: Fang Yong > FlinkKafkaConsumer should support to use timestamp to set up start offset >

[jira] [Assigned] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang reassigned FLINK-5855: --- Assignee: mingleizhang > Unprotected access to pendingFilesPerCheckpoint in BucketingSink >

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980672#comment-15980672 ] ASF GitHub Bot commented on FLINK-5855: --- GitHub user zhangminglei opened a pull request:

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980673#comment-15980673 ] ASF GitHub Bot commented on FLINK-5855: --- Github user zhangminglei commented on the issue:

[GitHub] flink pull request #3758: [FLINK-5855][Streaming Connectors] Unprotected acc...

GitHub user zhangminglei opened a pull request: https://github.com/apache/flink/pull/3758 [FLINK-5855][Streaming Connectors] Unprotected access to pendingFiles… …PerCheckpoint in BucketingSink. Thanks for contributing to Apache Flink. Before you open your pull request,

[GitHub] flink issue #3758: [FLINK-5855][Streaming Connectors] Unprotected access to ...

Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3758 cc @tillrohrmann --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980671#comment-15980671 ] mingleizhang commented on FLINK-5855: - Okay, thanks. I will give a PR to this. I dont know really, why

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980669#comment-15980669 ] Ted Yu commented on FLINK-5855: --- lgtm > Unprotected access to pendingFilesPerCheckpoint in BucketingSink >

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980668#comment-15980668 ] mingleizhang commented on FLINK-5855: - I think the code snippet would follow your suggestion. How do

[jira] [Issue Comment Deleted] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mingleizhang updated FLINK-5855: Comment: was deleted (was: Yep. That is right. So, follow your suggestion. I would write the code

[jira] [Comment Edited] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980664#comment-15980664 ] mingleizhang edited comment on FLINK-5855 at 4/24/17 2:57 AM: -- Yep. That is

[jira] [Comment Edited] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980664#comment-15980664 ] mingleizhang edited comment on FLINK-5855 at 4/24/17 2:57 AM: -- Yep. That is

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980664#comment-15980664 ] mingleizhang commented on FLINK-5855: - @Ted Yu, Yep. That is right. So, follow your suggestion. I

[jira] [Updated] (FLINK-6295) Update suspended ExecutionGraph to lower latency

[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tao Wang updated FLINK-6295: Summary: Update suspended ExecutionGraph to lower latency (was: use LoadingCache instead of WeakHashMap to

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980657#comment-15980657 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 I've testet and the function is ok. Please check if it's good to go, thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980646#comment-15980646 ] Ted Yu commented on FLINK-5855: --- Didn't get your question: clear() is called after

[jira] [Comment Edited] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980636#comment-15980636 ] Fang Yong edited comment on FLINK-6288 at 4/24/17 2:18 AM: --- Thanks for

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980636#comment-15980636 ] Fang Yong commented on FLINK-6288: -- Thanks for providing the mailing list for this issue, I think this is

[jira] [Comment Edited] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980624#comment-15980624 ] mingleizhang edited comment on FLINK-5855 at 4/24/17 1:50 AM: -- [~tedyu] Hi,

[jira] [Commented] (FLINK-5855) Unprotected access to pendingFilesPerCheckpoint in BucketingSink

[ https://issues.apache.org/jira/browse/FLINK-5855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980624#comment-15980624 ] mingleizhang commented on FLINK-5855: - [~tedyu] Hi, Ted. I would ask if

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980607#comment-15980607 ] ASF GitHub Bot commented on FLINK-6228: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3743: [FLINK-6228][table] Integrating the OVER windows in the T...

Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3743 @fhueske Thanks a lot for your comments and suggestions. And I like the idea of move all validations into `validateInput` method. I have updated the PR with following changes: 1.Check

[GitHub] flink pull request #3757: (refactor) some opportunities to use multi-catch

GitHub user rbonifacio opened a pull request: https://github.com/apache/flink/pull/3757 (refactor) some opportunities to use multi-catch You can merge this pull request into a Git repository by running: $ git pull https://github.com/rbonifacio/flink refactor-multi-catch

[jira] [Updated] (FLINK-6365) Adapt default values of the Kinesis connector

[ https://issues.apache.org/jira/browse/FLINK-6365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steffen Hausmann updated FLINK-6365: Description: As discussed in

[jira] [Created] (FLINK-6365) Adapt default values of the Kinesis connector

Steffen Hausmann created FLINK-6365: --- Summary: Adapt default values of the Kinesis connector Key: FLINK-6365 URL: https://issues.apache.org/jira/browse/FLINK-6365 Project: Flink Issue

[jira] [Commented] (FLINK-5781) Generation HTML from ConfigOption

[ https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980505#comment-15980505 ] ASF GitHub Bot commented on FLINK-5781: --- Github user zentol commented on the issue:

[GitHub] flink issue #3495: [FLINK-5781][config] Generation HTML from ConfigOption

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3495 I'm also not sure about including the short description. Looking at the existing documentation descriptions this would result in pretty large table entries with a lot of whitespace in the short

[GitHub] flink issue #3495: [FLINK-5781][config] Generation HTML from ConfigOption

Github user zentol commented on the issue: https://github.com/apache/flink/pull/3495 This is working pretty nicely. Just tried out appending the generated table to the SSL documentation, here's the result:

[jira] [Commented] (FLINK-5781) Generation HTML from ConfigOption

[ https://issues.apache.org/jira/browse/FLINK-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980503#comment-15980503 ] ASF GitHub Bot commented on FLINK-5781: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6360) Failed to create assembly for Scala 2.11 due to tools/change-scala-version.sh not changing flink-gelly-examples_2.10

[ https://issues.apache.org/jira/browse/FLINK-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980393#comment-15980393 ] Greg Hogan commented on FLINK-6360: --- That sounds good. > Failed to create assembly for Scala 2.11 due

[jira] [Commented] (FLINK-6360) Failed to create assembly for Scala 2.11 due to tools/change-scala-version.sh not changing flink-gelly-examples_2.10

[ https://issues.apache.org/jira/browse/FLINK-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980382#comment-15980382 ] Jacek Laskowski commented on FLINK-6360: Thanks [~greghogan]. I'll fix the root cause of it and

[jira] [Commented] (FLINK-6360) Failed to create assembly for Scala 2.11 due to tools/change-scala-version.sh not changing flink-gelly-examples_2.10

[ https://issues.apache.org/jira/browse/FLINK-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980372#comment-15980372 ] Greg Hogan commented on FLINK-6360: --- [~jlaskowski] thanks for reporting this. I think your reasoning is

[jira] [Created] (FLINK-6364) Implement incremental checkpointing in RocksDBStateBackend

Xiaogang Shi created FLINK-6364: --- Summary: Implement incremental checkpointing in RocksDBStateBackend Key: FLINK-6364 URL: https://issues.apache.org/jira/browse/FLINK-6364 Project: Flink Issue

[jira] [Closed] (FLINK-6014) Allow the registration of state objects in checkpoints

[ https://issues.apache.org/jira/browse/FLINK-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaogang Shi closed FLINK-6014. --- Resolution: Fixed Fixed via 218bed8b8e49b0e4c61c61f696a8f010eafea1b7 and

[jira] [Commented] (FLINK-6014) Allow the registration of state objects in checkpoints

[ https://issues.apache.org/jira/browse/FLINK-6014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980363#comment-15980363 ] ASF GitHub Bot commented on FLINK-6014: --- Github user shixiaogang closed the pull request at:

[GitHub] flink pull request #3524: [FLINK-6014][checkpoint] Allow the registration of...

Github user shixiaogang closed the pull request at: https://github.com/apache/flink/pull/3524 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Updated] (FLINK-6363) Document precedence rules of Kryo serializer registrations

[ https://issues.apache.org/jira/browse/FLINK-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6363: --- Description: Currently, there is no documentation / Javadoc mentioning the precedence

[jira] [Updated] (FLINK-6363) Document precedence rules of Kryo serializer registrations

[ https://issues.apache.org/jira/browse/FLINK-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6363: --- Description: Currently, there is no documentation / Javadoc mentioning the precedence

[jira] [Updated] (FLINK-6363) Document precedence rules of Kryo serializer registrations

[ https://issues.apache.org/jira/browse/FLINK-6363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai updated FLINK-6363: --- Description: Currently, there is no documentation / Javadoc mentioning the precedence

[jira] [Created] (FLINK-6363) Document precedence rules of Kryo serializer registrations

Tzu-Li (Gordon) Tai created FLINK-6363: -- Summary: Document precedence rules of Kryo serializer registrations Key: FLINK-6363 URL: https://issues.apache.org/jira/browse/FLINK-6363 Project: Flink

[jira] [Commented] (FLINK-4821) Implement rescalable non-partitioned state for Kinesis Connector

[ https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980310#comment-15980310 ] ASF GitHub Bot commented on FLINK-4821: --- Github user tony810430 commented on the issue:

[GitHub] flink issue #3001: [FLINK-4821] [kinesis] Implement rescalable non-partition...

Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/3001 @tzulitai Thanks for your reviewing and nice comments. I have already addressed them. =) --- If your project is set up for it, you can reply to this email and have your reply appear on