[jira] [Commented] (FLINK-6492) Unclosed DataOutputViewStream in GenericArraySerializerConfigSnapshot#write()

2017-05-14 Thread Huafeng Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010006#comment-16010006 ] Huafeng Wang commented on FLINK-6492: - If nobody is woking on this, I'd like to take this one. >

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010003#comment-16010003 ] ASF GitHub Bot commented on FLINK-6288: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-14 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3766 @zjureel the rebases don't seem to be done correctly. The PR should contain the diff commits only. I'm not sure what went wrong, but perhaps the most easiest way right now is cherry-pick your

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16010001#comment-16010001 ] ASF GitHub Bot commented on FLINK-6288: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-14 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3766 @zjureel thanks. You would need a proper rebase: `git rebase master` when you finish your feature branch, instead of merging the latest master. Regarding timeout: doesn't the Kafka client

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009993#comment-16009993 ] ASF GitHub Bot commented on FLINK-6288: --- Github user zjureel commented on the issue:

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-05-14 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/3766 @tzulitai Thank you for your replay. For 1, the `ExecutorService` is used to control timeout of fetching kafka partitions. When fetch kafka partitions, a `Future` will be created and

[jira] [Commented] (FLINK-4864) Shade Calcite dependency in flink-table

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009922#comment-16009922 ] ASF GitHub Bot commented on FLINK-4864: --- Github user wuchong closed the pull request at:

[GitHub] flink pull request #2673: [FLINK-4864] [table] Shade Calcite dependency in f...

2017-05-14 Thread wuchong
Github user wuchong closed the pull request at: https://github.com/apache/flink/pull/2673 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6557) RocksDbStateBackendTest fails on Windows

2017-05-14 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009910#comment-16009910 ] Xiaogang Shi commented on FLINK-6557: - [~Zentol] Thanks a lot for pointing it out. As far as i know,

[GitHub] flink issue #3889: [FLINK-6075] - Support Limit/Top(Sort) for Stream SQL

2017-05-14 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/3889 @hongyuhong @stefanobortoli @shijinkui i forgot to add you to the PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009906#comment-16009906 ] ASF GitHub Bot commented on FLINK-6075: --- Github user rtudoran commented on the issue:

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009905#comment-16009905 ] ASF GitHub Bot commented on FLINK-6232: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-05-14 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r116397679 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/FilterRunner.scala --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009904#comment-16009904 ] ASF GitHub Bot commented on FLINK-6232: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-05-14 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r116397441 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -199,31 +157,38 @@ object JoinUtil {

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009899#comment-16009899 ] ASF GitHub Bot commented on FLINK-6232: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-05-14 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r116397057 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamJoin.scala --- @@ -0,0 +1,180 @@ +/* +

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009896#comment-16009896 ] ASF GitHub Bot commented on FLINK-6232: --- Github user rtudoran commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-05-14 Thread rtudoran
Github user rtudoran commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r116396723 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,323 @@ +/* + *

[jira] [Commented] (FLINK-3620) Remove DbStateBackend

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009855#comment-16009855 ] ASF GitHub Bot commented on FLINK-3620: --- Github user xhook commented on the issue:

[GitHub] flink issue #1800: [FLINK-3620] [streaming] Remove DbStateBackend

2017-05-14 Thread xhook
Github user xhook commented on the issue: https://github.com/apache/flink/pull/1800 Hi @gyfora, in https://issues.apache.org/jira/browse/FLINK-3620 it's said that it's decided to make DbStateBackend and external library. Unfortunately I can't find it anywhere. Does it exist?

[jira] [Updated] (FLINK-6551) OutputTag name should not be allowed to be empty

2017-05-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6551: Summary: OutputTag name should not be allowed to be empty (was: OutputTag name should not

[jira] [Comment Edited] (FLINK-6440) Noisy logs from metric fetcher

2017-05-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009838#comment-16009838 ] Chesnay Schepler edited comment on FLINK-6440 at 5/14/17 8:23 PM: -- I'm

[jira] [Commented] (FLINK-6440) Noisy logs from metric fetcher

2017-05-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009838#comment-16009838 ] Chesnay Schepler commented on FLINK-6440: - I'm wondering what our options are here. We can't just

[jira] [Commented] (FLINK-6370) FileAlreadyExistsException on startup

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009832#comment-16009832 ] ASF GitHub Bot commented on FLINK-6370: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #3896: [FLINK-6370] [webUI] Handle races for single file ...

2017-05-14 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3896 [FLINK-6370] [webUI] Handle races for single file in FileServerHandler This PR prevents a race between multiple requests trying to create the same file, which previously would cause one request to

[jira] [Assigned] (FLINK-6370) FileAlreadyExistsException on startup

2017-05-14 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6370: --- Assignee: Chesnay Schepler > FileAlreadyExistsException on startup >

[jira] [Created] (FLINK-6578) SharedBuffer creates self-loops when having elements with same value/timestamp.

2017-05-14 Thread Kostas Kloudas (JIRA)
Kostas Kloudas created FLINK-6578: - Summary: SharedBuffer creates self-loops when having elements with same value/timestamp. Key: FLINK-6578 URL: https://issues.apache.org/jira/browse/FLINK-6578

[jira] [Updated] (FLINK-6537) Umbrella issue for fixes to incremental snapshots

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-6537: -- Priority: Major (was: Blocker) > Umbrella issue for fixes to incremental snapshots >

[jira] [Updated] (FLINK-6505) Proactively cleanup local FS for RocksDBKeyedStateBackend on startup

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-6505: -- Priority: Major (was: Blocker) > Proactively cleanup local FS for RocksDBKeyedStateBackend on

[jira] [Updated] (FLINK-6540) Add more thorough tests for RocksDB and incremental checkpointing

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-6540: -- Priority: Major (was: Blocker) > Add more thorough tests for RocksDB and incremental

[jira] [Closed] (FLINK-6545) Make incremental checkpoints externalizable

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6545. - Resolution: Fixed fixed in 098e46f2d2 > Make incremental checkpoints externalizable >

[jira] [Closed] (FLINK-6535) JobID should not be part of the registration key to the SharedStateRegistry

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6535. - Resolution: Fixed fixed in 4745d0c082 > JobID should not be part of the registration key to the

[jira] [Closed] (FLINK-6534) SharedStateRegistry is disposing state handles from main thread

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6534. - Resolution: Fixed fixed in 44fb035e02. > SharedStateRegistry is disposing state handles from

[jira] [Closed] (FLINK-6533) Duplicated registration of new shared state when checkpoint confirmations are still pending

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6533. - Resolution: Fixed fixed in 4745d0c082 > Duplicated registration of new shared state when

[jira] [Closed] (FLINK-6527) OperatorSubtaskState has empty implementations of (un)/registerSharedStates

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6527. - Resolution: Fixed fixed in efbb41bc63 > OperatorSubtaskState has empty implementations of

[jira] [Closed] (FLINK-6504) Lack of synchronization on materializedSstFiles in RocksDBKEyedStateBackend

2017-05-14 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter closed FLINK-6504. - Resolution: Fixed fixed in 958773b71c > Lack of synchronization on materializedSstFiles in

[jira] [Commented] (FLINK-6535) JobID should not be part of the registration key to the SharedStateRegistry

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009707#comment-16009707 ] ASF GitHub Bot commented on FLINK-6535: --- Github user StefanRRichter closed the pull request at:

[GitHub] flink pull request #3870: [Flink 6537] Fixes and improvements for incrementa...

2017-05-14 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/3870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...

2017-05-14 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3870 Thanks @rmetzger ! Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-6569) flink-table KafkaJsonTableSource example doesn't work

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009685#comment-16009685 ] ASF GitHub Bot commented on FLINK-6569: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #3890: [FLINK-6569] flink-table KafkaJsonTableSource example doe...

2017-05-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3890 Thank you for addressing this so quickly. +1 from my side. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] flink issue #3870: [Flink 6537] Fixes and improvements for incremental check...

2017-05-14 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3870 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-6221) Add Prometheus support to metrics

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009658#comment-16009658 ] ASF GitHub Bot commented on FLINK-6221: --- Github user zentol commented on the issue:

[GitHub] flink issue #3833: [FLINK-6221] Add PrometheusReporter

2017-05-14 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3833 Yu can find an example on how to shade here: https://github.com/apache/flink/blob/master/flink-metrics/flink-metrics-datadog/pom.xml. Shading dependencies in reporters/connectors has become a

[jira] [Commented] (FLINK-6221) Add Prometheus support to metrics

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009654#comment-16009654 ] ASF GitHub Bot commented on FLINK-6221: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3833: [FLINK-6221] Add PrometheusReporter

2017-05-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3833#discussion_r116377143 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java --- @@ -133,61 +136,58 @@ public

[jira] [Commented] (FLINK-6221) Add Prometheus support to metrics

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009649#comment-16009649 ] ASF GitHub Bot commented on FLINK-6221: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3833: [FLINK-6221] Add PrometheusReporter

2017-05-14 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3833#discussion_r116376926 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java --- @@ -0,0 +1,256 @@ +/*

[jira] [Commented] (FLINK-6221) Add Prometheus support to metrics

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009646#comment-16009646 ] ASF GitHub Bot commented on FLINK-6221: --- Github user mbode commented on the issue:

[GitHub] flink issue #3833: [FLINK-6221] Add PrometheusReporter

2017-05-14 Thread mbode
Github user mbode commented on the issue: https://github.com/apache/flink/pull/3833 Okay, guava is not used anymore. I am not sure about the shading part. Would you expect either prometheus clients or nanohttpd to be used in Flink user code? Or are there other advantages to shading?

[jira] [Commented] (FLINK-6221) Add Prometheus support to metrics

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009643#comment-16009643 ] ASF GitHub Bot commented on FLINK-6221: --- Github user mbode commented on a diff in the pull request:

[GitHub] flink pull request #3833: [FLINK-6221] Add PrometheusReporter

2017-05-14 Thread mbode
Github user mbode commented on a diff in the pull request: https://github.com/apache/flink/pull/3833#discussion_r116376242 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java --- @@ -0,0 +1,256 @@ +/*

[jira] [Commented] (FLINK-6221) Add Prometheus support to metrics

2017-05-14 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009639#comment-16009639 ] ASF GitHub Bot commented on FLINK-6221: --- Github user mbode commented on a diff in the pull request:

[GitHub] flink pull request #3833: [FLINK-6221] Add PrometheusReporter

2017-05-14 Thread mbode
Github user mbode commented on a diff in the pull request: https://github.com/apache/flink/pull/3833#discussion_r116375209 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusReporter.java --- @@ -0,0 +1,256 @@ +/*