[jira] [Commented] (FLINK-6763) Inefficient PojoSerializerConfigSnapshot serialization format

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028755#comment-16028755 ] ASF GitHub Bot commented on FLINK-6763: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #4014: [FLINK-6763] [core] Make serialization of composit...

2017-05-29 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/4014 [FLINK-6763] [core] Make serialization of composite serializer configs more efficient This PR affects the serialization formats of configuration snapshots of composite serializers, most notably

[jira] [Updated] (FLINK-6493) Ineffective null check in RegisteredOperatorBackendStateMetaInfo#equals()

2017-05-29 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-6493: -- Description: {code} && ((partitionStateSerializer == null && ((Snapshot)

[jira] [Commented] (FLINK-6617) Improve JAVA and SCALA logical plans consistent test

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028665#comment-16028665 ] ASF GitHub Bot commented on FLINK-6617: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3943: [FLINK-6617][table] Improve JAVA and SCALA logical plans ...

2017-05-29 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3943 @twalthr I have rebased code against master. Best, SunJincheng --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-6746) Table API / SQL Docs: Common Page

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028654#comment-16028654 ] ASF GitHub Bot commented on FLINK-6746: --- GitHub user fhueske opened a pull request:

[jira] [Commented] (FLINK-6745) Table API / SQL Docs: Overview Page

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028655#comment-16028655 ] ASF GitHub Bot commented on FLINK-6745: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #4013: [FLINK-6745] [docs] Updated Table API / SQL docs: ...

2017-05-29 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/4013 [FLINK-6745] [docs] Updated Table API / SQL docs: Overview You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhueske/flink tableDocs-overview

[GitHub] flink pull request #4012: [FLINK-6746] [docs] Updated Table API / SQL docs: ...

2017-05-29 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/4012 [FLINK-6746] [docs] Updated Table API / SQL docs: Common API You can merge this pull request into a Git repository by running: $ git pull https://github.com/fhueske/flink tableDocs-common

[jira] [Assigned] (FLINK-5354) Split up Table API documentation into multiple pages

2017-05-29 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-5354: Assignee: Fabian Hueske > Split up Table API documentation into multiple pages >

[jira] [Commented] (FLINK-6725) make requiresOver as a contracted method in udagg

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028649#comment-16028649 ] ASF GitHub Bot commented on FLINK-6725: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3993: [FLINK-6725][table] make requiresOver as a contracted met...

2017-05-29 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3993 Hi @shaoxuan-wang, the suggestions of @fhueske make sense to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Updated] (FLINK-6767) Cannot load user class on local environment

2017-05-29 Thread Matt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt updated FLINK-6767: Description: There is a bug in Flink 1.2.1 that results in a "cannot load user class" exception even when the

[jira] [Updated] (FLINK-6767) Cannot load user class on local environment

2017-05-29 Thread Matt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt updated FLINK-6767: Description: There is a bug in Flink 1.2.1 that results in a "cannot load user class" exception even when the

[jira] [Updated] (FLINK-6767) Cannot load user class on local environment

2017-05-29 Thread Matt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt updated FLINK-6767: Description: This bug was discussed in [1], and a fix was proposed in [2]. In summary the fix requires replacing

[jira] [Created] (FLINK-6767) Cannot load user class on local environment

2017-05-29 Thread Matt (JIRA)
Matt created FLINK-6767: --- Summary: Cannot load user class on local environment Key: FLINK-6767 URL: https://issues.apache.org/jira/browse/FLINK-6767 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-6767) Cannot load user class on local environment

2017-05-29 Thread Matt (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt updated FLINK-6767: Description: This bug was discussed in [1], and a fix was proposed in [2]. In summary the fix requires replacing

[jira] [Assigned] (FLINK-6735) Add a checkbox to hide the plan visualizer

2017-05-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-6735: --- Assignee: (was: Chesnay Schepler) > Add a checkbox to hide the plan visualizer >

[jira] [Commented] (FLINK-6735) Add a checkbox to hide the plan visualizer

2017-05-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028629#comment-16028629 ] Chesnay Schepler commented on FLINK-6735: - I'm unassigning myself as i couldn't figure out how to

[jira] [Commented] (FLINK-6756) Provide RichAsyncFunction to Scala API suite

2017-05-29 Thread Andrea Spina (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028506#comment-16028506 ] Andrea Spina commented on FLINK-6756: - Ok, thank you. I'll provide an implementation of it asap. >

[jira] [Commented] (FLINK-6753) Flaky SqlITCase

2017-05-29 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028503#comment-16028503 ] sunjincheng commented on FLINK-6753: Can you tell me what you did to get this exception? I can do the

[jira] [Comment Edited] (FLINK-6762) Cannot rescale externalized incremental checkpoints

2017-05-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028487#comment-16028487 ] Stefan Richter edited comment on FLINK-6762 at 5/29/17 4:02 PM: FYI, I

[jira] [Commented] (FLINK-6762) Cannot rescale externalized incremental checkpoints

2017-05-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028487#comment-16028487 ] Stefan Richter commented on FLINK-6762: --- FYI, I think we can can ALMOST support this by changing

[jira] [Commented] (FLINK-6766) Update documentation with async backends and incremental checkpoints

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028467#comment-16028467 ] ASF GitHub Bot commented on FLINK-6766: --- GitHub user StefanRRichter opened a pull request:

[GitHub] flink pull request #4011: [FLINK-6766] Update documentation about async back...

2017-05-29 Thread StefanRRichter
GitHub user StefanRRichter opened a pull request: https://github.com/apache/flink/pull/4011 [FLINK-6766] Update documentation about async backends and incrementa… …l checkpoints This PR introduces some documentation about async heap backends and incremental snapshots

[jira] [Created] (FLINK-6766) Update documentation with async backends and incremental checkpoints

2017-05-29 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-6766: - Summary: Update documentation with async backends and incremental checkpoints Key: FLINK-6766 URL: https://issues.apache.org/jira/browse/FLINK-6766 Project: Flink

[jira] [Created] (FLINK-6765) PojoSerializer returns wrong ConvertDeserializer when migration is required

2017-05-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6765: Summary: PojoSerializer returns wrong ConvertDeserializer when migration is required Key: FLINK-6765 URL: https://issues.apache.org/jira/browse/FLINK-6765 Project:

[jira] [Commented] (FLINK-6075) Support Limit/Top(Sort) for Stream SQL

2017-05-29 Thread radu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028458#comment-16028458 ] radu commented on FLINK-6075: - TOP syntax is not supported by Calcite. Basically top is obtained by using

[jira] [Comment Edited] (FLINK-6762) Cannot rescale externalized incremental checkpoints

2017-05-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028449#comment-16028449 ] Stefan Richter edited comment on FLINK-6762 at 5/29/17 3:19 PM:

[jira] [Commented] (FLINK-6762) Cannot rescale externalized incremental checkpoints

2017-05-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028449#comment-16028449 ] Stefan Richter commented on FLINK-6762: --- Officially, we currently do not want to support rescaling

[jira] [Created] (FLINK-6764) Deduplicate stateless TypeSerializers when serializing composite TypeSerializers

2017-05-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6764: Summary: Deduplicate stateless TypeSerializers when serializing composite TypeSerializers Key: FLINK-6764 URL: https://issues.apache.org/jira/browse/FLINK-6764

[jira] [Created] (FLINK-6763) Inefficient PojoSerializerConfigSnapshot serialization format

2017-05-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6763: Summary: Inefficient PojoSerializerConfigSnapshot serialization format Key: FLINK-6763 URL: https://issues.apache.org/jira/browse/FLINK-6763 Project: Flink

[jira] [Commented] (FLINK-6753) Flaky SqlITCase

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028434#comment-16028434 ] ASF GitHub Bot commented on FLINK-6753: --- GitHub user twalthr opened a pull request:

[jira] [Created] (FLINK-6762) Cannot rescale externalized incremental checkpoints

2017-05-29 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-6762: - Summary: Cannot rescale externalized incremental checkpoints Key: FLINK-6762 URL: https://issues.apache.org/jira/browse/FLINK-6762 Project: Flink Issue Type: Bug

[GitHub] flink pull request #4010: [FLINK-6753] [table] Fix flaky SqlITCase due to Ja...

2017-05-29 Thread twalthr
GitHub user twalthr opened a pull request: https://github.com/apache/flink/pull/4010 [FLINK-6753] [table] Fix flaky SqlITCase due to Janino bug I hope this fixes the flaky test. Otherwise we have to ask the Janino guys about this error. You can merge this pull request into a Git

[jira] [Commented] (FLINK-6753) Flaky SqlITCase

2017-05-29 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028427#comment-16028427 ] Timo Walther commented on FLINK-6753: - I also had this issue once. But it is hard to reproduce. I will

[jira] [Assigned] (FLINK-6753) Flaky SqlITCase

2017-05-29 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-6753: --- Assignee: Timo Walther > Flaky SqlITCase > --- > > Key:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028415#comment-16028415 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028422#comment-16028422 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028416#comment-16028416 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028417#comment-16028417 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028419#comment-16028419 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028418#comment-16028418 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028421#comment-16028421 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028420#comment-16028420 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118946203 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/aggregation/SumAggregationFunction.java --- @@ -26,6 +26,10 @@ import

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118946093 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/aggregation/Aggregations.java --- @@ -20,6 +20,9 @@ import

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118948292 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/base/InnerJoinOperatorBaseTest.java --- @@ -45,6 +45,9 @@ import static

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118946444 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/functions/FirstReducer.java --- @@ -23,6 +23,10 @@ import

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118946760 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/functions/FormattingMapper.java --- @@ -23,6 +23,10 @@ import

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118946288 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/aggregation/UnsupportedAggregationTypeException.java --- @@ -20,6 +20,9 @@ import

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118948338 --- Diff: flink-java/src/test/java/org/apache/flink/api/common/operators/base/ReduceOperatorTest.java --- @@ -47,6 +47,9 @@ import static

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118947281 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/functions/GroupReduceIterator.java --- @@ -24,6 +24,11 @@ import java.util.Iterator;

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028402#comment-16028402 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on the issue:

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118943716 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1666,29 +1666,29 @@ public void printToErr() throws Exception {

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028401#comment-16028401 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink issue #4009: [FLINK-6732] Activate strict-checkstyle for flink-java

2017-05-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4009 I've noticed some `` tags here and there, could replace those as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-6710) Remove twitter-inputformat

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028399#comment-16028399 ] ASF GitHub Bot commented on FLINK-6710: --- Github user twalthr commented on the issue:

[GitHub] flink issue #3984: [FLINK-6710] Remove Twitter-InputFormat

2017-05-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/3984 Yes, a generic JsonInputFormat would be a nice addition. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Resolved] (FLINK-6737) Fix over expression parse String error.

2017-05-29 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-6737. - Resolution: Fixed Fix Version/s: 1.4.0 1.3.0 Fixed in 1.4.0:

[jira] [Closed] (FLINK-6734) Exclude org.apache.flink.api.java.tuple from checkstyle AvoidStarImport

2017-05-29 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-6734. --- Resolution: Not A Problem > Exclude org.apache.flink.api.java.tuple from checkstyle

[jira] [Commented] (FLINK-6737) Fix over expression parse String error.

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028396#comment-16028396 ] ASF GitHub Bot commented on FLINK-6737: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4000: [FLINK-6737][table]Add over method supported strin...

2017-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4000 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6734) Exclude org.apache.flink.api.java.tuple from checkstyle AvoidStarImport

2017-05-29 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028394#comment-16028394 ] Dawid Wysakowicz commented on FLINK-6734: - Ok, so I will close this issue. > Exclude

[jira] [Resolved] (FLINK-6736) Fix UDTF codegen bug when window follow by join( UDTF)

2017-05-29 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-6736. - Resolution: Fixed Fix Version/s: 1.4.0 1.3.0 Fixed in 1.4.0:

[jira] [Commented] (FLINK-6736) Fix UDTF codegen bug when window follow by join( UDTF)

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028380#comment-16028380 ] ASF GitHub Bot commented on FLINK-6736: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4008: [FLINK-6736] [table] Fix UDTF field access with ti...

2017-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4008 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4009: [FLINK-6732] Activate strict-checkstyle for flink-java

2017-05-29 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4009 Yes sorry for that, Just wanted to remove the `AvoidStarImport` commit from in the middle. Any further changes will do with new commits. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028379#comment-16028379 ] ASF GitHub Bot commented on FLINK-6732: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-6734) Exclude org.apache.flink.api.java.tuple from checkstyle AvoidStarImport

2017-05-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028378#comment-16028378 ] Chesnay Schepler commented on FLINK-6734: - yes, they will have to be expanded. > Exclude

[GitHub] flink issue #4009: [FLINK-6732] Activate strict-checkstyle for flink-java

2017-05-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4009 eh...the commits just jumped around so i assume you just force pushed? From this point on please don't. As for kryo, well you got me there. Frankly i don't know where we use kryo or

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028376#comment-16028376 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028369#comment-16028369 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028367#comment-16028367 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028364#comment-16028364 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028365#comment-16028365 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028368#comment-16028368 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028366#comment-16028366 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118940257 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/TwoInputUdfOperator.java --- @@ -117,41 +117,41 @@ public O withBroadcastSet(DataSet

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118941471 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/utils/DataSetUtils.java --- @@ -141,7 +141,7 @@ public void mapPartition(Iterable values,

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118940189 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SingleInputUdfOperator.java --- @@ -114,41 +114,41 @@ public O

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118939832 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/io/LocalCollectionOutputFormat.java --- @@ -33,7 +33,7 @@ import java.util.Map;

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118940089 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SingleInputUdfOperator.java --- @@ -114,41 +114,41 @@ public O

[GitHub] flink pull request #4009: [FLINK-6732] Activate strict-checkstyle for flink-...

2017-05-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4009#discussion_r118940280 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/TwoInputUdfOperator.java --- @@ -192,41 +192,41 @@ public O

[jira] [Commented] (FLINK-6761) Limitation for maximum state size per key in RocksDB backend

2017-05-29 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028363#comment-16028363 ] Stefan Richter commented on FLINK-6761: --- Opened a corresponding issue in the RocksDB tracker:

[jira] [Commented] (FLINK-6734) Exclude org.apache.flink.api.java.tuple from checkstyle AvoidStarImport

2017-05-29 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028362#comment-16028362 ] Dawid Wysakowicz commented on FLINK-6734: - Ok, but then we would need to expand the star imports,

[jira] [Commented] (FLINK-6734) Exclude org.apache.flink.api.java.tuple from checkstyle AvoidStarImport

2017-05-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028361#comment-16028361 ] Chesnay Schepler commented on FLINK-6734: - With so few affected classes I would like to remove

[GitHub] flink issue #4009: [FLINK-6732] Activate strict-checkstyle for flink-java

2017-05-29 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/4009 Right, but won't there be any serialization issues? I found a comment like which made me ask that question: `// Nested classes are only "public static" for Kryo serialization, otherwise they'd

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028352#comment-16028352 ] ASF GitHub Bot commented on FLINK-6732: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-6734) Exclude org.apache.flink.api.java.tuple from checkstyle AvoidStarImport

2017-05-29 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028348#comment-16028348 ] Dawid Wysakowicz commented on FLINK-6734: - 6 in flink-java After a quick search in other modules

[jira] [Resolved] (FLINK-6760) Fix OverWindowTest alias test error

2017-05-29 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-6760. - Resolution: Fixed Fix Version/s: 1.4.0 Fixed in 1.4.0:

[GitHub] flink pull request #4007: [FLINK-6760][table]Fix OverWindowTest alias test e...

2017-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6760) Fix OverWindowTest alias test error

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028346#comment-16028346 ] ASF GitHub Bot commented on FLINK-6760: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6737) Fix over expression parse String error.

2017-05-29 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028344#comment-16028344 ] sunjincheng commented on FLINK-6737: [~twalthr][~fhueske] Agree with you. I have updated the PR. And

[GitHub] flink issue #4008: [FLINK-6736] [table] Fix UDTF field access with time attr...

2017-05-29 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4008 @sunjincheng121 I will add another ITCase just to be sure. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-6736) Fix UDTF codegen bug when window follow by join( UDTF)

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028343#comment-16028343 ] ASF GitHub Bot commented on FLINK-6736: --- Github user twalthr commented on the issue:

[GitHub] flink pull request #4008: [FLINK-6736] [table] Fix UDTF field access with ti...

2017-05-29 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/4008#discussion_r118938233 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverterTest.scala --- @@ -391,8 +391,8 @@ object

[jira] [Commented] (FLINK-6736) Fix UDTF codegen bug when window follow by join( UDTF)

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028342#comment-16028342 ] ASF GitHub Bot commented on FLINK-6736: --- Github user twalthr commented on a diff in the pull

[jira] [Commented] (FLINK-6732) Activate strict checkstyle for flink-java

2017-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16028339#comment-16028339 ] ASF GitHub Bot commented on FLINK-6732: --- Github user zentol commented on the issue:

[GitHub] flink issue #4009: [FLINK-6732] Activate strict-checkstyle for flink-java

2017-05-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4009 If a function is tagged as `@Internal` or in a class tagged as such then we should be able to restrict the visibility. Would be good if you could reply in the JIRA for the tuple checkstyle exclusion.

  1   2   >