[jira] [Updated] (FLINK-6937) Fix link markdown in Production Readiness Checklist doc

2017-06-16 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6937: -- Component/s: Documentation > Fix link markdown in Production Readiness Checklist doc >

[GitHub] flink pull request #4135: Flink 6602 -- bug fix

2017-06-16 Thread lmalds
Github user lmalds commented on a diff in the pull request: https://github.com/apache/flink/pull/4135#discussion_r122525124 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala --- @@ -39,6 +39,9 @@ class

[GitHub] flink issue #4102: [FLINK-6886][table]Fix Timestamp field can not be selecte...

2017-06-16 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4102 Hi @fhueske I have update the PR. according your suggestion. Please have a look at the changes. Best, SunJincheng --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052304#comment-16052304 ] ASF GitHub Bot commented on FLINK-6886: --- Github user sunjincheng121 commented on the issue:

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052246#comment-16052246 ] sunjincheng commented on FLINK-6886: Thanks [~fhueske] your code is nicer. I'll update the PR. :) >

[jira] [Comment Edited] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052154#comment-16052154 ] Fabian Hueske edited comment on FLINK-6886 at 6/16/17 5:29 PM: --- You are

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052154#comment-16052154 ] Fabian Hueske commented on FLINK-6886: -- You are right. The problem is in {{translate(dataStreamPlan,

[GitHub] flink pull request #4135: Flink 6602 -- bug fix

2017-06-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4135#discussion_r122487052 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala --- @@ -39,6 +39,9 @@ class

[GitHub] flink pull request #4135: Flink 6602 -- bug fix

2017-06-16 Thread lmalds
Github user lmalds commented on a diff in the pull request: https://github.com/apache/flink/pull/4135#discussion_r122484136 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala --- @@ -39,6 +39,8 @@ class

[jira] [Updated] (FLINK-6939) Not store IterativeCondition with NFA state

2017-06-16 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-6939: --- Component/s: (was: Table API & SQL) > Not store IterativeCondition with NFA state >

[jira] [Updated] (FLINK-6938) IterativeCondition should support RichFunction interface

2017-06-16 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-6938: --- Component/s: (was: Table API & SQL) > IterativeCondition should support RichFunction interface >

[GitHub] flink pull request #4135: Flink 6602 -- bug fix

2017-06-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4135#discussion_r122469825 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/StreamTableSourceTable.scala --- @@ -39,6 +39,8 @@ class

[jira] [Commented] (FLINK-6602) Table source with defined time attributes allows empty string

2017-06-16 Thread Zhe Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052025#comment-16052025 ] Zhe Li commented on FLINK-6602: --- It's my pleasure:) I have opened a pull request just now. Thank you. >

[GitHub] flink pull request #4135: Flink 6602 -- bug fix

2017-06-16 Thread lmalds
GitHub user lmalds opened a pull request: https://github.com/apache/flink/pull/4135 Flink 6602 -- bug fix Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes take all of the items

[jira] [Commented] (FLINK-6933) Refactor NFACompiler to reduce code duplication

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052019#comment-16052019 ] ASF GitHub Bot commented on FLINK-6933: --- Github user kl0u commented on the issue:

[GitHub] flink issue #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce code du...

2017-06-16 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/4132 After an offline discussion with @dianfu , we decided to close this PR and merge this change with https://github.com/apache/flink/pull/4121/ as it is more relevant there. --- If your project is set

[jira] [Created] (FLINK-6939) Not store IterativeCondition with NFA state

2017-06-16 Thread Jark Wu (JIRA)
Jark Wu created FLINK-6939: -- Summary: Not store IterativeCondition with NFA state Key: FLINK-6939 URL: https://issues.apache.org/jira/browse/FLINK-6939 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-6938) IterativeCondition should support RichFunction interface

2017-06-16 Thread Jark Wu (JIRA)
Jark Wu created FLINK-6938: -- Summary: IterativeCondition should support RichFunction interface Key: FLINK-6938 URL: https://issues.apache.org/jira/browse/FLINK-6938 Project: Flink Issue Type:

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051962#comment-16051962 ] ASF GitHub Bot commented on FLINK-6888: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051961#comment-16051961 ] ASF GitHub Bot commented on FLINK-6888: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6888) Can not determine TypeInformation of ACC type of AggregateFunction when ACC is a Scala case/tuple class

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051960#comment-16051960 ] ASF GitHub Bot commented on FLINK-6888: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4105#discussion_r122448432 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -358,20 +358,27 @@ abstract class

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4105#discussion_r122447088 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/UserDefinedFunctionUtils.scala --- @@ -307,9 +315,29 @@ object

[GitHub] flink pull request #4105: [FLINK-6888] [table] Can not determine TypeInforma...

2017-06-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4105#discussion_r122447580 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -192,10 +193,14 @@ class

[jira] [Commented] (FLINK-6652) Problem with DelimitedInputFormat

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051959#comment-16051959 ] ASF GitHub Bot commented on FLINK-6652: --- Github user alpinegizmo commented on the issue:

[GitHub] flink issue #4088: [FLINK-6652] [core] Fix handling of delimiters split by b...

2017-06-16 Thread alpinegizmo
Github user alpinegizmo commented on the issue: https://github.com/apache/flink/pull/4088 FYI, the reference solutions to the batch training exercises are failing, and it looks to me like it's because of this issue. --- If your project is set up for it, you can reply to this email

[jira] [Assigned] (FLINK-6929) Add documentation for Table API OVER windows

2017-06-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng reassigned FLINK-6929: -- Assignee: sunjincheng > Add documentation for Table API OVER windows >

[jira] [Commented] (FLINK-6937) Fix link markdown in Production Readiness Checklist doc

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051774#comment-16051774 ] ASF GitHub Bot commented on FLINK-6937: --- GitHub user juanpaulo opened a pull request:

[GitHub] flink pull request #4134: [FLINK-6937] Fix link markdown in Production Readi...

2017-06-16 Thread juanpaulo
GitHub user juanpaulo opened a pull request: https://github.com/apache/flink/pull/4134 [FLINK-6937] Fix link markdown in Production Readiness Checklist doc [FLINK-6937] Fix link markdown in Production Readiness Checklist doc - [x] General - The pull request references

[jira] [Created] (FLINK-6937) Fix link markdown in Production Readiness Checklist doc

2017-06-16 Thread Juan Paulo Gutierrez (JIRA)
Juan Paulo Gutierrez created FLINK-6937: --- Summary: Fix link markdown in Production Readiness Checklist doc Key: FLINK-6937 URL: https://issues.apache.org/jira/browse/FLINK-6937 Project: Flink

[jira] [Created] (FLINK-6936) Add multiple targets support for custom partitioner

2017-06-16 Thread Xingcan Cui (JIRA)
Xingcan Cui created FLINK-6936: -- Summary: Add multiple targets support for custom partitioner Key: FLINK-6936 URL: https://issues.apache.org/jira/browse/FLINK-6936 Project: Flink Issue Type:

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051710#comment-16051710 ] ASF GitHub Bot commented on FLINK-6930: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #4133: [FLINK-6930] [table] Forbid selecting window start/end on...

2017-06-16 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4133 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-6933) Refactor NFACompiler to reduce code duplication

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051698#comment-16051698 ] ASF GitHub Bot commented on FLINK-6933: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4132: [FLINK-6933] [cep] Refactor NFACompiler to reduce code du...

2017-06-16 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4132 R: @kl0u or @dawidwys for review, please 😃 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Closed] (FLINK-6568) flink-table doesn't work without flink-streaming-scala dependency

2017-06-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai closed FLINK-6568. - Resolution: Duplicate > flink-table doesn't work without flink-streaming-scala dependency >

[jira] [Commented] (FLINK-6568) flink-table doesn't work without flink-streaming-scala dependency

2017-06-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051627#comment-16051627 ] Fabian Hueske commented on FLINK-6568: -- The documentation was updated and explains that `flink-scala`

[jira] [Commented] (FLINK-6433) Unreachable code in SqlToRelConverter#visitCall()

2017-06-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051620#comment-16051620 ] Fabian Hueske commented on FLINK-6433: -- We will remove this class once we upgrade our Calcite

[jira] [Commented] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

2017-06-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051610#comment-16051610 ] Fabian Hueske commented on FLINK-6887: -- I think that's a good idea. What do you think [~twalthr]? >

[jira] [Updated] (FLINK-6887) Split up CodeGenerator into several specific CodeGenerator

2017-06-16 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-6887: - Issue Type: Task (was: Bug) > Split up CodeGenerator into several specific CodeGenerator >

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051601#comment-16051601 ] ASF GitHub Bot commented on FLINK-6930: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4133: [FLINK-6930] [table] Forbid selecting window start/end on...

2017-06-16 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4133 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051588#comment-16051588 ] ASF GitHub Bot commented on FLINK-6930: --- Github user wuchong commented on the issue:

[GitHub] flink issue #4133: [FLINK-6930] [table] Forbid selecting window start/end on...

2017-06-16 Thread wuchong
Github user wuchong commented on the issue: https://github.com/apache/flink/pull/4133 Updated --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Updated] (FLINK-4641) Support branching CEP patterns

2017-06-16 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-4641: --- Issue Type: Sub-task (was: Improvement) Parent: FLINK-6935 > Support branching CEP patterns >

[jira] [Assigned] (FLINK-4641) Support branching CEP patterns

2017-06-16 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-4641: -- Assignee: Dian Fu (was: Alexander Chermenin) > Support branching CEP patterns >

[jira] [Updated] (FLINK-6933) Refactor NFACompiler to reduce code duplication

2017-06-16 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-6933: --- Issue Type: Sub-task (was: Bug) Parent: FLINK-6935 > Refactor NFACompiler to reduce code duplication

[jira] [Updated] (FLINK-6927) Support pattern group in CEP

2017-06-16 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-6927: --- Issue Type: Sub-task (was: Bug) Parent: FLINK-6935 > Support pattern group in CEP >

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051583#comment-16051583 ] ASF GitHub Bot commented on FLINK-6930: --- Github user wuchong commented on a diff in the pull

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread wuchong
Github user wuchong commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122389818 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[jira] [Updated] (FLINK-6904) Support for quantifier range to CEP's pattern API

2017-06-16 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu updated FLINK-6904: --- Issue Type: Sub-task (was: Bug) Parent: FLINK-6935 > Support for quantifier range to CEP's pattern

[jira] [Assigned] (FLINK-6935) Integration of SQL and CEP

2017-06-16 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-6935: -- Assignee: Dian Fu > Integration of SQL and CEP > -- > > Key:

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051581#comment-16051581 ] ASF GitHub Bot commented on FLINK-6930: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4133: [FLINK-6930] [table] Forbid selecting window start/end on...

2017-06-16 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4133 Thanks for the fix @wuchong! I would adjust the error message as proposed but otherwise it's good to merge. Thanks, Fabian --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051579#comment-16051579 ] ASF GitHub Bot commented on FLINK-6930: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122388804 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[jira] [Created] (FLINK-6935) Integration of SQL and CEP

2017-06-16 Thread Jark Wu (JIRA)
Jark Wu created FLINK-6935: -- Summary: Integration of SQL and CEP Key: FLINK-6935 URL: https://issues.apache.org/jira/browse/FLINK-6935 Project: Flink Issue Type: New Feature Components:

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051513#comment-16051513 ] ASF GitHub Bot commented on FLINK-6930: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122378782 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[jira] [Commented] (FLINK-6930) Selecting window start / end on row-based Tumble/Slide window causes NPE

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051514#comment-16051514 ] ASF GitHub Bot commented on FLINK-6930: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4133: [FLINK-6930] [table] Forbid selecting window start...

2017-06-16 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4133#discussion_r122378757 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala --- @@ -652,6 +653,21 @@ case class

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051466#comment-16051466 ] sunjincheng commented on FLINK-6886: So, We have two chances to deal with the problem,one is the PR.

[jira] [Comment Edited] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051451#comment-16051451 ] sunjincheng edited comment on FLINK-6886 at 6/16/17 6:27 AM: - But, I think not

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051451#comment-16051451 ] sunjincheng commented on FLINK-6886: But, I think not the optimization issue, because,

[jira] [Commented] (FLINK-6904) Support for quantifier range to CEP's pattern API

2017-06-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051442#comment-16051442 ] ASF GitHub Bot commented on FLINK-6904: --- Github user dianfu commented on the issue:

[GitHub] flink issue #4121: [FLINK-6904] [cep] Support for quantifier range to CEP's ...

2017-06-16 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/4121 Hi @dawidwys thanks a lot for the review, what's your thought for the updated patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-6886) Fix Timestamp field can not be selected in event time case when toDataStream[T], `T` not a `Row` Type.

2017-06-16 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051425#comment-16051425 ] sunjincheng commented on FLINK-6886: Hi, [~fhueske] Thanks for check this issue. Calcite can not