[jira] [Commented] (FLINK-6426) Update the document of group-window table API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057617#comment-16057617 ] ASF GitHub Bot commented on FLINK-6426: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3806: [FLINK-6426][table]Update the document of group-window ta...

2017-06-21 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3806 Did this PR become obsolete with the recent restructuring of the Table API docs? Can you check that and close this PR if that's the case @sunjincheng121? Thank you, Fabian --- If your

[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057612#comment-16057612 ] ASF GitHub Bot commented on FLINK-6841: --- Github user fhueske commented on the issue:

[GitHub] flink issue #4061: [FLINK-6841][table]Using TableSourceTable for both Stream...

2017-06-21 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4061 Hi @sunjincheng121! I left a comment on the JIRA issue. Short summary: I don't think this PR is a significant improvement. I'd rather keep it as it is unless you have a good argument to convince me.

[jira] [Commented] (FLINK-6841) using TableSourceTable for both Stream and Batch OR remove useless import

2017-06-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057610#comment-16057610 ] Fabian Hueske commented on FLINK-6841: -- To be honest, I don't see a significant improvement by

[jira] [Commented] (FLINK-6649) Improve Non-window group aggregate with configurable `earlyFire`.

2017-06-21 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057595#comment-16057595 ] sunjincheng commented on FLINK-6649: Hi [~fhueske] I have opened the PR. In the

[jira] [Updated] (FLINK-6965) Avro is missing snappy dependency

2017-06-21 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-6965: Description: The shading rework made before 1.3 removed a snappy dependency that was

[jira] [Commented] (FLINK-6960) Add E(2.7182818284590452354),PI(3.14159265358979323846) supported in SQL

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057589#comment-16057589 ] ASF GitHub Bot commented on FLINK-6960: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink pull request #4152: [FLINK-6960][table] Add E supported in SQL.

2017-06-21 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4152#discussion_r123261877 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/scalarSqlFunctions/MathSqlFunctions.scala --- @@ -0,0 +1,35 @@

[jira] [Commented] (FLINK-6457) Clean up ScalarFunction and TableFunction interface

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057575#comment-16057575 ] ASF GitHub Bot commented on FLINK-6457: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6960) Add E(2.7182818284590452354),PI(3.14159265358979323846) supported in SQL

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057574#comment-16057574 ] ASF GitHub Bot commented on FLINK-6960: --- Github user sunjincheng121 commented on a diff in the pull

[GitHub] flink issue #3880: [FLINK-6457] Clean up ScalarFunction and TableFunction in...

2017-06-21 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3880 Hi @Xpray, I left a comment on the related JIRA issue. In short, I do not why we should remove methods with constant signature and call them via reflection. This makes the code more prone for

[GitHub] flink pull request #4152: [FLINK-6960][table] Add E supported in SQL.

2017-06-21 Thread sunjincheng121
Github user sunjincheng121 commented on a diff in the pull request: https://github.com/apache/flink/pull/4152#discussion_r123258425 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala --- @@ -1116,6 +1116,13 @@ class

[jira] [Commented] (FLINK-6457) Clean up ScalarFunction and TableFunction interface

2017-06-21 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057572#comment-16057572 ] Fabian Hueske commented on FLINK-6457: -- I don't understand which problem this issue aims to resolve.

[jira] [Created] (FLINK-6965) Avro is missing snappy dependency

2017-06-21 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-6965: --- Summary: Avro is missing snappy dependency Key: FLINK-6965 URL: https://issues.apache.org/jira/browse/FLINK-6965 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-6964) Fix recovery for incremental checkpoints in StandaloneCompletedCheckpointStore

2017-06-21 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-6964: -- Description: {{StandaloneCompletedCheckpointStore}} does not register shared states ion resume.

[jira] [Updated] (FLINK-6949) Add ability to ship custom resource files to YARN cluster

2017-06-21 Thread Mikhail Pryakhin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikhail Pryakhin updated FLINK-6949: Description: *The problem:* When deploying a flink job on YARN it is not possible to

[jira] [Commented] (FLINK-6916) FLIP-19: Improved BLOB storage architecture

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057536#comment-16057536 ] ASF GitHub Bot commented on FLINK-6916: --- GitHub user NicoK opened a pull request:

[GitHub] flink pull request #4158: [FLINK-6916][blob] remove (unused) NAME_ADDRESSABL...

2017-06-21 Thread NicoK
GitHub user NicoK opened a pull request: https://github.com/apache/flink/pull/4158 [FLINK-6916][blob] remove (unused) NAME_ADDRESSABLE mode This is based upon #4146 and in addition removes the currently unused `NAME_ADDRESSABLE` BLOB addressing mode. There are currently no plans to

[GitHub] flink pull request #4157: [Flink 6649][table]Improve Non-window group aggreg...

2017-06-21 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/4157 [Flink 6649][table]Improve Non-window group aggregate with update int… In this PR. I have add supports updating the calculated data according to the specified time interval on non-window

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123016738 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057460#comment-16057460 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123009399 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123228354 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057466#comment-16057466 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123031759 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057458#comment-16057458 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057469#comment-16057469 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123035300 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123228716 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123030850 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123226695 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123236585 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -0,0 +1,200 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123017357 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123020714 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057463#comment-16057463 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123021563 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057461#comment-16057461 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057479#comment-16057479 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123233427 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinTest.scala --- @@ -0,0 +1,149 @@ +/* + *

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057476#comment-16057476 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057477#comment-16057477 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123226087 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123020909 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123226130 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057456#comment-16057456 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123225232 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057454#comment-16057454 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123232793 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinTest.scala --- @@ -0,0 +1,149 @@ +/* + *

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057478#comment-16057478 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057450#comment-16057450 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057475#comment-16057475 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057483#comment-16057483 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057481#comment-16057481 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123229245 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123227488 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123238837 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -0,0 +1,200 @@ +/* + *

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057480#comment-16057480 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057474#comment-16057474 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123205673 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123238701 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/harness/JoinHarnessTest.scala --- @@ -0,0 +1,200 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123229427 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123222750 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRowStreamJoin.scala --- @@ -0,0 +1,186 @@

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057472#comment-16057472 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057482#comment-16057482 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057470#comment-16057470 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123037106 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057465#comment-16057465 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123025909 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057467#comment-16057467 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123030370 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123209008 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/ProcTimeInnerJoin.scala --- @@ -0,0 +1,316 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123231612 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinITCase.scala --- @@ -0,0 +1,204 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123231931 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinITCase.scala --- @@ -0,0 +1,204 @@ +/* + *

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123189670 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/JoinITCase.scala --- @@ -0,0 +1,204 @@ +/* + *

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057473#comment-16057473 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057462#comment-16057462 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057452#comment-16057452 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057468#comment-16057468 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057464#comment-16057464 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057471#comment-16057471 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057459#comment-16057459 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057453#comment-16057453 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057441#comment-16057441 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057443#comment-16057443 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057457#comment-16057457 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r122843078 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamRowStreamJoin.scala --- @@ -0,0 +1,186 @@

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057455#comment-16057455 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r122838733 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala --- @@ -162,8 +162,25 @@ class

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057448#comment-16057448 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123020420 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123029455 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123026855 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057446#comment-16057446 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057449#comment-16057449 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057451#comment-16057451 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057445#comment-16057445 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057442#comment-16057442 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-6232) Support proctime inner equi-join between two streams in the SQL API

2017-06-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057447#comment-16057447 ] ASF GitHub Bot commented on FLINK-6232: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3715: [FLINK-6232][Table]Support proctime inner equi...

2017-06-21 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3715#discussion_r123023871 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/JoinUtil.scala --- @@ -0,0 +1,385 @@ +/* + * Licensed to

<    1   2   3   >