[GitHub] flink issue #4562: [FLINK-7402] Fix ineffective null check in NettyMessage#w...

2017-08-23 Thread zjureel
Github user zjureel commented on the issue: https://github.com/apache/flink/pull/4562 @NicoK Than you for your review, I have reverted the imports changed by IDE, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139508#comment-16139508 ] ASF GitHub Bot commented on FLINK-7402: --- Github user zjureel commented on the issue:

[jira] [Commented] (FLINK-7129) Dynamically changing patterns

2017-08-23 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139494#comment-16139494 ] Dian Fu commented on FLINK-7129: I think we can firstly create a keyed stream of events {{ds1}} and a

[jira] [Comment Edited] (FLINK-4500) Cassandra sink can lose messages

2017-08-23 Thread Michael Fong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139448#comment-16139448 ] Michael Fong edited comment on FLINK-4500 at 8/24/17 1:36 AM: -- I plan to

[jira] [Commented] (FLINK-4500) Cassandra sink can lose messages

2017-08-23 Thread Michael Fong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139448#comment-16139448 ] Michael Fong commented on FLINK-4500: - I plan to design the first part of the requirement on existing

[GitHub] flink pull request #4576: [FLINK-7398] Table API operators/UDFs must not sto...

2017-08-23 Thread haohui
GitHub user haohui opened a pull request: https://github.com/apache/flink/pull/4576 [FLINK-7398] Table API operators/UDFs must not store Logger. This PR moves all the usages of {{slf4j.Logger}} to a common trait so that we can ensure the Logger object is not serialized over the

[jira] [Commented] (FLINK-7398) Table API operators/UDFs must not store Logger

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139145#comment-16139145 ] ASF GitHub Bot commented on FLINK-7398: --- GitHub user haohui opened a pull request:

[jira] [Commented] (FLINK-3924) Remove protobuf shading from Kinesis connector

2017-08-23 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139012#comment-16139012 ] Aljoscha Krettek commented on FLINK-3924: - [~rmetzger] Is this still an issue? > Remove protobuf

[jira] [Updated] (FLINK-5883) Re-adding the Exception-thrown code for ListKeyGroupedIterator when the iterator is requested the second time

2017-08-23 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-5883: Fix Version/s: 1.3.0 > Re-adding the Exception-thrown code for ListKeyGroupedIterator when

[jira] [Closed] (FLINK-5883) Re-adding the Exception-thrown code for ListKeyGroupedIterator when the iterator is requested the second time

2017-08-23 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-5883. --- Resolution: Fixed This was actually fixed a while back in d5f2647 > Re-adding the

[jira] [Updated] (FLINK-7432) Unclosed HighAvailabilityServices instance in QueryableStateClient

2017-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7432: -- Description: {code} public QueryableStateClient(Configuration config) throws Exception { this(config,

[jira] [Comment Edited] (FLINK-7049) TestingApplicationMaster keeps running after integration tests finish

2017-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16069086#comment-16069086 ] Ted Yu edited comment on FLINK-7049 at 8/23/17 8:02 PM: Stack trace for

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138874#comment-16138874 ] ASF GitHub Bot commented on FLINK-6988: --- Github user rangadi commented on a diff in the pull

[GitHub] flink pull request #4239: [FLINK-6988] flink-connector-kafka-0.11 with exact...

2017-08-23 Thread rangadi
Github user rangadi commented on a diff in the pull request: https://github.com/apache/flink/pull/4239#discussion_r134838729 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -0,0

[jira] [Commented] (FLINK-7495) AbstractUdfStreamOperator#initializeState() should be called in AsyncWaitOperator#initializeState()

2017-08-23 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138719#comment-16138719 ] Ted Yu commented on FLINK-7495: --- AbstractKeyedCEPPatternOperator#restoreState should call

[jira] [Created] (FLINK-7495) AbstractUdfStreamOperator#initializeState() should be called in AsyncWaitOperator#initializeState()

2017-08-23 Thread Ted Yu (JIRA)
Ted Yu created FLINK-7495: - Summary: AbstractUdfStreamOperator#initializeState() should be called in AsyncWaitOperator#initializeState() Key: FLINK-7495 URL: https://issues.apache.org/jira/browse/FLINK-7495

[jira] [Commented] (FLINK-7494) No license headers in ".travis.yml" file

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138553#comment-16138553 ] ASF GitHub Bot commented on FLINK-7494: --- GitHub user yew1eb opened a pull request:

[GitHub] flink pull request #4575: [FLINK-7494][travis] Add license headers to '.trav...

2017-08-23 Thread yew1eb
GitHub user yew1eb opened a pull request: https://github.com/apache/flink/pull/4575 [FLINK-7494][travis] Add license headers to '.travis.yml' file Just add license headers to '.travis.yml' file. :smile: You can merge this pull request into a Git repository by running: $

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138549#comment-16138549 ] ASF GitHub Bot commented on FLINK-7442: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4564: [FLINK-7442] Add option for using child-first classloader...

2017-08-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4564 @StephanEwen I updated the PR. Turns out you also have to override the resource-related methods to change the resolution order. I added checks for that to the end-to-end test. --- If your project

[jira] [Created] (FLINK-7494) No license headers in ".travis.yml" file

2017-08-23 Thread Hai Zhou (JIRA)
Hai Zhou created FLINK-7494: --- Summary: No license headers in ".travis.yml" file Key: FLINK-7494 URL: https://issues.apache.org/jira/browse/FLINK-7494 Project: Flink Issue Type: Wish

[jira] [Commented] (FLINK-7442) Add option for using a child-first classloader for loading user code

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138540#comment-16138540 ] ASF GitHub Bot commented on FLINK-7442: --- Github user aljoscha closed the pull request at:

[GitHub] flink pull request #4554: [FLINK-7442] Add option for using child-first clas...

2017-08-23 Thread aljoscha
Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/4554 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7449) Improve and enhance documentation for incremental checkpoints

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138522#comment-16138522 ] ASF GitHub Bot commented on FLINK-7449: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4543: [FLINK-7449] [docs] Additional documentation for incremen...

2017-08-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4543 CC @alpinegizmo --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Assigned] (FLINK-7078) Support fencing tokens to filter out outdated messages

2017-08-23 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7078: Assignee: Till Rohrmann > Support fencing tokens to filter out outdated messages >

[jira] [Commented] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138435#comment-16138435 ] ASF GitHub Bot commented on FLINK-7476: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4561#discussion_r134771937 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -185,11 +253,44 @@

[jira] [Commented] (FLINK-4947) Make all configuration possible via flink-conf.yaml and CLI.

2017-08-23 Thread Jamie Grier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138418#comment-16138418 ] Jamie Grier commented on FLINK-4947: Sounds good to me :) > Make all configuration possible via

[jira] [Commented] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138390#comment-16138390 ] ASF GitHub Bot commented on FLINK-7476: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink issue #4561: [FLINK-7476][streaming] Continue using previous transacti...

2017-08-23 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4561 I have abandoned last commit. This PR is now pure refactor/hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138393#comment-16138393 ] ASF GitHub Bot commented on FLINK-7476: --- Github user pnowojski commented on the issue:

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4561#discussion_r134759790 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -185,11 +253,44 @@

[jira] [Commented] (FLINK-7429) Add restore from 1.2 / 1.3 migration tests for FlinkKinesisConsumer

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138304#comment-16138304 ] ASF GitHub Bot commented on FLINK-7429: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4565: [FLINK-7429] [kinesis] Add migration test coverage for Fl...

2017-08-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4565 Checkstyle is complaining about `FlinkKinesisConsumerMigrationTest`. I fixed and pushed on travis. The changes look very good. 👍 I'll merge when Travis is green. --- If your project

[jira] [Commented] (FLINK-7476) Try to recover from failure in TwoPhaseCommitSinkFunction.beginTransaction

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138289#comment-16138289 ] ASF GitHub Bot commented on FLINK-7476: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #4561: [FLINK-7476][streaming] Continue using previous tr...

2017-08-23 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/4561#discussion_r134737971 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/sink/TwoPhaseCommitSinkFunctionTest.java --- @@ -185,11 +253,44 @@

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-23 Thread pnowojski
Github user pnowojski commented on the issue: https://github.com/apache/flink/pull/4557 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #4557: [hotifx][streaming] Simplify state of TwoPhaseComm...

2017-08-23 Thread pnowojski
Github user pnowojski closed the pull request at: https://github.com/apache/flink/pull/4557 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink issue #4557: [hotifx][streaming] Simplify state of TwoPhaseCommitSinkF...

2017-08-23 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4557 Merged 👌 Could you please close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138281#comment-16138281 ] ASF GitHub Bot commented on FLINK-7040: --- Github user zentol commented on the issue:

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4569 @tillrohrmann I've address the remaining comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-7129) Dynamically changing patterns

2017-08-23 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138276#comment-16138276 ] Dawid Wysakowicz commented on FLINK-7129: - Yes that would work for the state, but the problem is I

[jira] [Comment Edited] (FLINK-7129) Dynamically changing patterns

2017-08-23 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138276#comment-16138276 ] Dawid Wysakowicz edited comment on FLINK-7129 at 8/23/17 12:20 PM: --- Yes

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138256#comment-16138256 ] ASF GitHub Bot commented on FLINK-7040: --- Github user zentol commented on the issue:

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4569 @tillrohrmann I've reworked the client response parsing: the `ClientHandler` now only parses the response as JSON, whereas the conversion to the respective `ResponseBody` is handled in a future

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138244#comment-16138244 ] ASF GitHub Bot commented on FLINK-6988: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4239: [FLINK-6988] flink-connector-kafka-0.11 with exact...

2017-08-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4239#discussion_r134726007 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -0,0

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138243#comment-16138243 ] ASF GitHub Bot commented on FLINK-6988: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4239: [FLINK-6988] flink-connector-kafka-0.11 with exact...

2017-08-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4239#discussion_r134725699 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -0,0

[jira] [Commented] (FLINK-6751) Table API / SQL Docs: UDFs Page

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138206#comment-16138206 ] ASF GitHub Bot commented on FLINK-6751: --- Github user zentol commented on the issue:

[GitHub] flink issue #4546: [FLINK-6751] [docs] Add missing documentation for User-De...

2017-08-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4546 Please fill out the PR template, this will make the review process easier. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138194#comment-16138194 ] ASF GitHub Bot commented on FLINK-6988: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4239: [FLINK-6988] flink-connector-kafka-0.11 with exact...

2017-08-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4239#discussion_r134711336 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -0,0

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138193#comment-16138193 ] ASF GitHub Bot commented on FLINK-7402: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-08-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134711249 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -18,6 +18,12 @@ package

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138179#comment-16138179 ] ASF GitHub Bot commented on FLINK-7040: --- Github user zentol commented on the issue:

[GitHub] flink issue #4569: [FLINK-7040] [REST] Add basics for REST communication

2017-08-23 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4569 @tillrohrmann I've addressed most of your comments. I have implemented the `HandlerResponse` as you suggested (casting option) for now, and include all query parameter as a list. ##

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138157#comment-16138157 ] ASF GitHub Bot commented on FLINK-7040: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134705260 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerRequest.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138156#comment-16138156 ] ASF GitHub Bot commented on FLINK-7040: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134705172 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerResponse.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138153#comment-16138153 ] ASF GitHub Bot commented on FLINK-7402: --- Github user zjureel commented on a diff in the pull

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-08-23 Thread zjureel
Github user zjureel commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134704354 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,9 +220,7 @@ void releaseBuffer() {

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138150#comment-16138150 ] ASF GitHub Bot commented on FLINK-7040: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134703249 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerResponse.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7402) Ineffective null check in NettyMessage#write()

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138128#comment-16138128 ] ASF GitHub Bot commented on FLINK-7402: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4562: [FLINK-7402] Fix ineffective null check in NettyMe...

2017-08-23 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4562#discussion_r134699645 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -220,9 +220,7 @@ void releaseBuffer() {

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138126#comment-16138126 ] ASF GitHub Bot commented on FLINK-7040: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-4947) Make all configuration possible via flink-conf.yaml and CLI.

2017-08-23 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-4947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138127#comment-16138127 ] Gábor Hermann commented on FLINK-4947: -- [~jgrier] Thanks for the clarification! I agree with all your

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134699407 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerRequest.java --- @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-6864) Remove confusing "invalid POJO type" messages from TypeExtractor

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138029#comment-16138029 ] ASF GitHub Bot commented on FLINK-6864: --- Github user ggevay commented on the issue:

[jira] [Commented] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138090#comment-16138090 ] ASF GitHub Bot commented on FLINK-6244: --- Github user tedyu commented on a diff in the pull request:

[jira] [Commented] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138092#comment-16138092 ] ASF GitHub Bot commented on FLINK-6244: --- Github user tedyu commented on a diff in the pull request:

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134692032 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -348,7 +353,18 @@ private void

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134692117 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java --- @@ -348,7 +353,18 @@ private void

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138070#comment-16138070 ] ASF GitHub Bot commented on FLINK-7040: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138084#comment-16138084 ] ASF GitHub Bot commented on FLINK-7040: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134687041 --- Diff: docs/dev/libs/cep.md --- @@ -1279,63 +1279,75 @@ and `flatSelect` API calls allow a timeout handler to be specified. This timeout partial event

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134690587 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/ParameterMapper.java --- @@ -0,0 +1,83 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138083#comment-16138083 ] ASF GitHub Bot commented on FLINK-6244: --- Github user tedyu commented on a diff in the pull request:

[jira] [Commented] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138082#comment-16138082 ] ASF GitHub Bot commented on FLINK-6244: --- Github user tedyu commented on a diff in the pull request:

[GitHub] flink pull request #4320: [FLINK-6244] Emit timeouted Patterns as Side Outpu...

2017-08-23 Thread tedyu
Github user tedyu commented on a diff in the pull request: https://github.com/apache/flink/pull/4320#discussion_r134689181 --- Diff: flink-libraries/flink-cep-scala/src/main/scala/org/apache/flink/cep/scala/PatternStream.scala --- @@ -84,37 +79,54 @@ class

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134689284 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerResponse.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7040) Flip-6 client-cluster communication

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138062#comment-16138062 ] ASF GitHub Bot commented on FLINK-7040: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #4569: [FLINK-7040] [REST] Add basics for REST communicat...

2017-08-23 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/4569#discussion_r134686921 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerResponse.java --- @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache

[jira] [Resolved] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-23 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-7337. - Resolution: Fixed Fix Version/s: 1.4.0 Fixed in 1.4:

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138053#comment-16138053 ] ASF GitHub Bot commented on FLINK-7337: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138052#comment-16138052 ] ASF GitHub Bot commented on FLINK-7337: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4488: [FLINK-7337] [table] Refactor internal handling of...

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #4532: [FLINK-7337] [table] Refactor internal handling of...

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4532 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-7337) Refactor handling of time indicator attributes

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138039#comment-16138039 ] ASF GitHub Bot commented on FLINK-7337: --- Github user twalthr commented on the issue:

[GitHub] flink issue #4532: [FLINK-7337] [table] Refactor internal handling of time i...

2017-08-23 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4532 Merging... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink issue #4574: [FLINK-6864] Fix confusing "invalid POJO type" messages f...

2017-08-23 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/4574 I agree with @zjureel . Even though I know the POJO rules well, it still happened to me more than once that I accidentally had a non-POJO, and I only noticed this because of these log messages, so I

[jira] [Resolved] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-23 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-6244. - Resolution: Fixed > Emit timeouted Patterns as Side Output >

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16138014#comment-16138014 ] ASF GitHub Bot commented on FLINK-6988: --- Github user pnowojski commented on a diff in the pull

[jira] [Commented] (FLINK-6244) Emit timeouted Patterns as Side Output

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137962#comment-16137962 ] ASF GitHub Bot commented on FLINK-6244: --- Github user dawidwys commented on the issue:

[GitHub] flink pull request #4239: [FLINK-6988] flink-connector-kafka-0.11 with exact...

2017-08-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4239#discussion_r134676224 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -0,0

[jira] [Commented] (FLINK-6988) Add Apache Kafka 0.11 connector

2017-08-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137995#comment-16137995 ] ASF GitHub Bot commented on FLINK-6988: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4239: [FLINK-6988] flink-connector-kafka-0.11 with exact...

2017-08-23 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4239#discussion_r134673133 --- Diff: flink-connectors/flink-connector-kafka-0.11/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011.java --- @@ -0,0

  1   2   >