[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-09-29 Thread KurtYoung
Github user KurtYoung commented on the issue: https://github.com/apache/flink/pull/3511 > So I think a simpler and better approach is to just make sure that most types have a good implementation of putNormalizedKey, and then NormalizedKeySorter.compareRecords would be called only

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186766#comment-16186766 ] ASF GitHub Bot commented on FLINK-6233: --- Github user xccui commented on a diff in the pull request:

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-29 Thread xccui
Github user xccui commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r141993041 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[jira] [Commented] (FLINK-7648) Port TaskManagersHandler to new REST endpoint

2017-09-29 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186631#comment-16186631 ] Bowen Li commented on FLINK-7648: - [~till.rohrmann] I successfully started the cluster in a unit test.

[jira] [Commented] (FLINK-7491) Support COLLECT Aggregate function in Flink SQL

2017-09-29 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186602#comment-16186602 ] Shuyi Chen commented on FLINK-7491: --- [~fhueske] can you help take another look at the PR? I've addressed

[jira] [Created] (FLINK-7740) Add parameter support in CassandraInputFormat

2017-09-29 Thread Bin Wang (JIRA)
Bin Wang created FLINK-7740: --- Summary: Add parameter support in CassandraInputFormat Key: FLINK-7740 URL: https://issues.apache.org/jira/browse/FLINK-7740 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186260#comment-16186260 ] ASF GitHub Bot commented on FLINK-7406: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141945843 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java --- @@ -235,14 +240,15 @@ void releaseBuffer() {

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141945644 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java --- @@ -131,6 +136,63 @@ public void

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186258#comment-16186258 ] ASF GitHub Bot commented on FLINK-7406: --- Github user bowenli86 commented on a diff in the pull

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186255#comment-16186255 ] ASF GitHub Bot commented on FLINK-5544: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-09-29 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r141942758 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java --- @@

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186254#comment-16186254 ] ASF GitHub Bot commented on FLINK-5544: --- Github user bowenli86 commented on a diff in the pull

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186256#comment-16186256 ] ASF GitHub Bot commented on FLINK-5544: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-09-29 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r141944569 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java --- @@

[GitHub] flink pull request #3359: [FLINK-5544][streaming] Add InternalTimerService i...

2017-09-29 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3359#discussion_r141944634 --- Diff: flink-contrib/flink-timerserivce-rocksdb/src/main/java/org/apache/flink/contrib/streaming/api/operators/RocksDBInternalTimerService.java --- @@

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186202#comment-16186202 ] ASF GitHub Bot commented on FLINK-5544: --- Github user EXPjbucher commented on the issue:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186083#comment-16186083 ] ASF GitHub Bot commented on FLINK-7406: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #4509: [FLINK-7406][network] Implement Netty receiver incoming p...

2017-09-29 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4509 @NicoK , thanks for reviews and talking about this key point. I think I understand your point and agree with that. I will submit the modifications before Monday. ---

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186049#comment-16186049 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r141911428 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedClientHandler.java --- @@ -37,20 +43,31 @@ import

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141906648 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -374,6 +376,64 @@ public void

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186043#comment-16186043 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186040#comment-16186040 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186046#comment-16186046 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186038#comment-16186038 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186045#comment-16186045 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141901569 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -209,6 +276,95 @@ public String

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141886467 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141865540 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141890624 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141896356 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -412,23 +468,35 @@ public void

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186035#comment-16186035 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186037#comment-16186037 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186044#comment-16186044 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186041#comment-16186041 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186039#comment-16186039 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186042#comment-16186042 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[jira] [Commented] (FLINK-7406) Implement Netty receiver incoming pipeline for credit-based

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186036#comment-16186036 ] ASF GitHub Bot commented on FLINK-7406: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141902956 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -70,6 +79,21 @@ */

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141865630 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141908388 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannelTest.java --- @@ -374,6 +376,64 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141890343 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141896488 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -412,23 +468,35 @@ public void

[GitHub] flink pull request #4509: [FLINK-7406][network] Implement Netty receiver inc...

2017-09-29 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4509#discussion_r141890051 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -390,7 +390,63 @@ public

[jira] [Commented] (FLINK-7735) Improve date/time handling in publically-facing Expressions

2017-09-29 Thread Alexey Diomin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16186007#comment-16186007 ] Alexey Diomin commented on FLINK-7735: -- Java 7 will be dropped very soon FLINK-7242 Maybe make sense

[jira] [Commented] (FLINK-7700) State merging in RocksDB backend leaves old state

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185950#comment-16185950 ] ASF GitHub Bot commented on FLINK-7700: --- GitHub user aljoscha opened a pull request:

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-09-29 Thread ggevay
Github user ggevay commented on the issue: https://github.com/apache/flink/pull/3511 > IMHO, in addition to these changes, there are still some potential improvements we can do about the sorter, like deserialization when comparing the real records. Do you mean

[GitHub] flink pull request #4752: [FLINK-7700] Fix RocksDB state merging on release-...

2017-09-29 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/4752 [FLINK-7700] Fix RocksDB state merging on release-1.3 This is only for running the tests, which I can't do on my own Travis since tests time out. You can merge this pull request into a Git

[jira] [Commented] (FLINK-7736) Fix some of the alerts raised by lgtm.com

2017-09-29 Thread Malcolm Taylor (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185921#comment-16185921 ] Malcolm Taylor commented on FLINK-7736: --- Identified 14 alerts to address: 1) dereferenced variable

[GitHub] flink pull request #4750: [FLINK-7710] [flip6] Add CheckpointStatisticsHandl...

2017-09-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4750#discussion_r141882415 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/CheckpointStatistics.java --- @@ -0,0 +1,763 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-7710) Port CheckpointStatsHandler to new REST endpoint

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185911#comment-16185911 ] ASF GitHub Bot commented on FLINK-7710: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7739) Improve Kafka*ITCase tests stability

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185839#comment-16185839 ] ASF GitHub Bot commented on FLINK-7739: --- GitHub user pnowojski opened a pull request:

[GitHub] flink pull request #4751: [FLINK-7739][kafka-tests] Throttle down data produ...

2017-09-29 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4751 [FLINK-7739][kafka-tests] Throttle down data producing thread Minor tests improvement in tests to avoid busy loop You can merge this pull request into a Git repository by running: $ git

[GitHub] flink pull request #4750: [FLINK-7710] [flip6] Add CheckpointStatisticsHandl...

2017-09-29 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/4750 [FLINK-7710] [flip6] Add CheckpointStatisticsHandler for the new REST endpoint ## What is the purpose of the change This commit also makes the CheckpointStatsHistory object

[jira] [Commented] (FLINK-7710) Port CheckpointStatsHandler to new REST endpoint

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185821#comment-16185821 ] ASF GitHub Bot commented on FLINK-7710: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-7072) Create RESTful cluster endpoint

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185816#comment-16185816 ] ASF GitHub Bot commented on FLINK-7072: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4730: [hotfix] [REST] Various rest-related hotfixes

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4730 ---

[GitHub] flink issue #4730: [hotfix] [REST] Various rest-related hotfixes

2017-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4730 Changes look good to me. Thanks a lot for your contribution @zentol. Merging this PR. ---

[GitHub] flink pull request #4749: [FLINK-7739][tests] Properly shutdown resources in...

2017-09-29 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4749 [FLINK-7739][tests] Properly shutdown resources in tests This is a fixup of tests, without touching the production code. You can merge this pull request into a Git repository by running: $

[jira] [Commented] (FLINK-7739) Improve Kafka*ITCase tests stability

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185796#comment-16185796 ] ASF GitHub Bot commented on FLINK-7739: --- GitHub user pnowojski opened a pull request:

[jira] [Created] (FLINK-7739) Improve Kafka*ITCase tests stability

2017-09-29 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-7739: - Summary: Improve Kafka*ITCase tests stability Key: FLINK-7739 URL: https://issues.apache.org/jira/browse/FLINK-7739 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185685#comment-16185685 ] ASF GitHub Bot commented on FLINK-7668: --- Github user zentol commented on the issue:

[GitHub] flink issue #4728: [FLINK-7668] Add ExecutionGraphCache for ExecutionGraph b...

2017-09-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4728 +1 from my side too. ---

[GitHub] flink pull request #4748: [hotfix][tests] Use G1GC for tests

2017-09-29 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/4748 [hotfix][tests] Use G1GC for tests We are using G1GC for running TaskManager, I think we should do it so also for tests. You can merge this pull request into a Git repository by running: $

[jira] [Commented] (FLINK-7708) Port CheckpointConfigHandler to new REST endpoint

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185663#comment-16185663 ] ASF GitHub Bot commented on FLINK-7708: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #4744: [FLINK-7708] [flip6] Add CheckpointConfigHandler f...

2017-09-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/4744#discussion_r141836633 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/CheckpointConfigInfo.java --- @@ -0,0 +1,152 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185592#comment-16185592 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on the issue:

[jira] [Commented] (FLINK-6233) Support rowtime inner equi-join between two streams in the SQL API

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185591#comment-16185591 ] ASF GitHub Bot commented on FLINK-6233: --- Github user fhueske commented on a diff in the pull

[GitHub] flink issue #4625: [FLINK-6233] [table] Support time-bounded stream inner jo...

2017-09-29 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/4625 Thanks for the update @xccui. I'll have a look in the next days. ---

[GitHub] flink pull request #4625: [FLINK-6233] [table] Support time-bounded stream i...

2017-09-29 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/4625#discussion_r141831721 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/TimeBoundedStreamInnerJoin.scala --- @@ -131,340 +116,308 @@ class

[GitHub] flink pull request #4747: [FLINK-7728] [DataStream] Flush StatusWatermarkVal...

2017-09-29 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/4747 [FLINK-7728] [DataStream] Flush StatusWatermarkValve once all inputs become idle ## What is the purpose of the change This PR is based on #4738. Only the last three commits are relevant.

[jira] [Commented] (FLINK-7728) StatusWatermarkValve has different min watermark advancement behavior depending on the ordering inputs become idle

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185574#comment-16185574 ] ASF GitHub Bot commented on FLINK-7728: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-09-29 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r141822004 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185544#comment-16185544 ] ASF GitHub Bot commented on FLINK-7076: --- Github user suez1224 commented on a diff in the pull

[jira] [Commented] (FLINK-7076) Implement container release to support dynamic scaling

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185532#comment-16185532 ] ASF GitHub Bot commented on FLINK-7076: --- Github user suez1224 commented on a diff in the pull

[GitHub] flink pull request #4729: [FLINK-7076] [ResourceManager] implement YARN stop...

2017-09-29 Thread suez1224
Github user suez1224 commented on a diff in the pull request: https://github.com/apache/flink/pull/4729#discussion_r141820967 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java --- @@ -228,7 +234,14 @@ public void startNewWorker(ResourceProfile

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185519#comment-16185519 ] ASF GitHub Bot commented on FLINK-7668: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #4728: [FLINK-7668] Add ExecutionGraphCache for ExecutionGraph b...

2017-09-29 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/4728 Thanks for addressing / replying to my comments. LGTM, +1 from me ---

[GitHub] flink pull request #4728: [FLINK-7668] Add ExecutionGraphCache for Execution...

2017-09-29 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/4728#discussion_r141817520 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java --- @@ -0,0 +1,357 @@ +/* + *

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185518#comment-16185518 ] ASF GitHub Bot commented on FLINK-7668: --- Github user tzulitai commented on a diff in the pull

[jira] [Assigned] (FLINK-7710) Port CheckpointStatsHandler to new REST endpoint

2017-09-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-7710: Assignee: Till Rohrmann > Port CheckpointStatsHandler to new REST endpoint >

[jira] [Commented] (FLINK-7668) Add AccessExecutionGraph refresh interval to ExecutionGraphHolder

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185507#comment-16185507 ] ASF GitHub Bot commented on FLINK-7668: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4728: [FLINK-7668] Add ExecutionGraphCache for ExecutionGraph b...

2017-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4728 I've rebased the code onto the latest master. Are all PR comments resolved @zentol and @tzulitai? ---

[jira] [Commented] (FLINK-7667) Add serializable AccessExecutionGraph implementation

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185506#comment-16185506 ] ASF GitHub Bot commented on FLINK-7667: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4727: [FLINK-7667] [flip6] Use ArchivedExecutionGraph as...

2017-09-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4727 ---

[jira] [Closed] (FLINK-7667) Add serializable AccessExecutionGraph implementation

2017-09-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-7667. Resolution: Fixed Fix Version/s: 1.4.0 Fixed via 2dd557fad4a0a205a3e163fa918507d34c933c6a >

[jira] [Commented] (FLINK-7667) Add serializable AccessExecutionGraph implementation

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185503#comment-16185503 ] ASF GitHub Bot commented on FLINK-7667: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #4727: [FLINK-7667] [flip6] Use ArchivedExecutionGraph as serial...

2017-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4727 Merging this PR. ---

[jira] [Commented] (FLINK-7648) Port TaskManagersHandler to new REST endpoint

2017-09-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185502#comment-16185502 ] Till Rohrmann commented on FLINK-7648: -- In order to wait on the completion you can do {code} @Test

[jira] [Closed] (FLINK-7541) Redistribute operator state using OperatorID

2017-09-29 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-7541. - There are still parts of the code in the Flink that Relays on operator order > Redistribute operator

[jira] [Resolved] (FLINK-7541) Redistribute operator state using OperatorID

2017-09-29 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski resolved FLINK-7541. --- Resolution: Fixed Fix Version/s: 1.4.0 > Redistribute operator state using OperatorID

[jira] [Commented] (FLINK-7694) Port JobMetricsHandler to new REST handler

2017-09-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185498#comment-16185498 ] Till Rohrmann commented on FLINK-7694: -- Yes, this will make sure that the web gui will also

[jira] [Closed] (FLINK-7683) Add method to iterate over all of the existing keys in a statebackend

2017-09-29 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-7683. - > Add method to iterate over all of the existing keys in a statebackend >

[jira] [Commented] (FLINK-7695) Port JobConfigHandler to new REST endpoint

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185497#comment-16185497 ] ASF GitHub Bot commented on FLINK-7695: --- Github user tillrohrmann commented on the issue:

[jira] [Resolved] (FLINK-7683) Add method to iterate over all of the existing keys in a statebackend

2017-09-29 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski resolved FLINK-7683. --- Resolution: Fixed Fix Version/s: 1.4.0 > Add method to iterate over all of the

[GitHub] flink issue #4737: [FLINK-7695] [flip6] Add JobConfigHandler for new RestSer...

2017-09-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4737 Thanks for the review @zentol and @yew1eb. I have to throw this PR once more on Travis to see if everything passes. Once this is done and the depended PRs are merged, I'll merge this one as

[jira] [Commented] (FLINK-7704) Port JobPlanHandler to new REST endpoint

2017-09-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185493#comment-16185493 ] Till Rohrmann commented on FLINK-7704: -- Hi [~haizhou], great to hear that you want to help with

[jira] [Commented] (FLINK-7695) Port JobConfigHandler to new REST endpoint

2017-09-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16185473#comment-16185473 ] ASF GitHub Bot commented on FLINK-7695: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #4737: [FLINK-7695] [flip6] Add JobConfigHandler for new RestSer...

2017-09-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/4737 Hey @tillrohrmann, Will you merge this PR ? I want to fix sibling issues (FLINK-7704, FLINK-7705, FLINK-7706). :beers: Best, Hai Zhou ---

  1   2   >