[GitHub] flink pull request #6149: [FLINK-9560] Add RateLimiting for FileSystem

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6149#discussion_r195345480 --- Diff: flink-filesystems/flink-hadoop-fs/src/main/java/org/apache/flink/runtime/util/HadoopUtils.java --- @@ -122,4 +125,28 @@ public static boolean

[GitHub] flink pull request #6149: [FLINK-9560] Add RateLimiting for FileSystem

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6149#discussion_r195344817 --- Diff: flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java --- @@ -132,7 +132,12 @@ else if

[GitHub] flink pull request #6149: [FLINK-9560] Add RateLimiting for FileSystem

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6149#discussion_r195340311 --- Diff: docs/ops/filesystems.md --- @@ -102,8 +102,8 @@ fs..limit.input: (number, 0/-1 mean no limit) fs..limit.output: (number, 0/-1 mean no limit)

[jira] [Commented] (FLINK-9187) add prometheus pushgateway reporter

[ https://issues.apache.org/jira/browse/FLINK-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512180#comment-16512180 ] ASF GitHub Bot commented on FLINK-9187: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5857: [FLINK-9187][METRICS] add prometheus pushgateway r...

Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5857#discussion_r195346637 --- Diff: flink-metrics/flink-metrics-prometheus/src/main/java/org/apache/flink/metrics/prometheus/PrometheusPushGatewayReporter.java --- @@ -0,0

[GitHub] flink pull request #6149: [FLINK-9560] Add RateLimiting for FileSystem

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6149#discussion_r195342365 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java --- @@ -313,14 +313,22 @@ public int

[GitHub] flink pull request #6149: [FLINK-9560] Add RateLimiting for FileSystem

Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/6149#discussion_r195346228 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/LimitedConnectionsFileSystem.java --- @@ -1032,19 +1113,50 @@ public

[jira] [Commented] (FLINK-9494) Race condition in Dispatcher with concurrent granting and revoking of leaderhship

[ https://issues.apache.org/jira/browse/FLINK-9494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512143#comment-16512143 ] ASF GitHub Bot commented on FLINK-9494: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #6155: [FLINK-9494] Fix race condition in Dispatcher with...

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/6155#discussion_r195337102 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherHATest.java --- @@ -0,0 +1,253 @@ +/* + * Licensed to

[jira] [Updated] (FLINK-7591) Support partition by and order by of MATCH_RECOGNIZE

[ https://issues.apache.org/jira/browse/FLINK-7591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-7591: Component/s: Table API & SQL > Support partition by and order by of MATCH_RECOGNIZE >

[jira] [Commented] (FLINK-9579) Remove unnecessary clear with cep elementQueue

[ https://issues.apache.org/jira/browse/FLINK-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512120#comment-16512120 ] ASF GitHub Bot commented on FLINK-9579: --- Github user Aitozi commented on the issue:

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Github user Aitozi commented on the issue: https://github.com/apache/flink/pull/6162 Thanks for your review , remove the same block in `onProcessingTime`. ---

[jira] [Commented] (FLINK-9579) Remove unnecessary clear with cep elementQueue

[ https://issues.apache.org/jira/browse/FLINK-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512113#comment-16512113 ] ASF GitHub Bot commented on FLINK-9579: --- Github user dawidwys commented on the issue:

[jira] [Commented] (FLINK-9579) Remove unnecessary clear with cep elementQueue

[ https://issues.apache.org/jira/browse/FLINK-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512111#comment-16512111 ] ASF GitHub Bot commented on FLINK-9579: --- Github user dawidwys commented on the issue:

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6162 Actually. Could you also remove the same block from `onProcessingTime` ---

[GitHub] flink issue #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQueueSta...

Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6162 I think this is a valid change. LGTM Thanks for the contribution! ---

[jira] [Commented] (FLINK-9579) Remove unnecessary clear with cep elementQueue

[ https://issues.apache.org/jira/browse/FLINK-9579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512048#comment-16512048 ] ASF GitHub Bot commented on FLINK-9579: --- GitHub user Aitozi opened a pull request:

[GitHub] flink pull request #6162: [FLINK-9579][CEP]Remove unneeded clear on elementQ...

GitHub user Aitozi opened a pull request: https://github.com/apache/flink/pull/6162 [FLINK-9579][CEP]Remove unneeded clear on elementQueueState ## What is the purpose of the change Remove unneeded clear on elementQueueState， when soretedTimestamp is empty, the elements

<    1   2   3