GitHub user lamber-ken reopened a pull request:
https://github.com/apache/flink/pull/6230
[FLINK-9666] short-circuit logic should be used in boolean contexts
Backport of #6212 .
@tillrohrmann, hi, cc
You can merge this pull request into a Git repository by running:
$ g
Renjie Liu created FLINK-9719:
-
Summary: Mesos should use hostname as default
jobmanager.rpc.address
Key: FLINK-9719
URL: https://issues.apache.org/jira/browse/FLINK-9719
Project: Flink
Issue Ty
[
https://issues.apache.org/jira/browse/FLINK-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reassigned FLINK-9693:
Assignee: Till Rohrmann
> Possible memory leak in jobmanager retaining archived checkpoint
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531455#comment-16531455
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531456#comment-16531456
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199817513
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * License
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531453#comment-16531453
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199817285
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * License
[
https://issues.apache.org/jira/browse/FLINK-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531454#comment-16531454
]
ASF GitHub Bot commented on FLINK-9554:
---
Github user zjffdu commented on a diff in
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199817158
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * License
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/flink/pull/6140#discussion_r199817183
--- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
@@ -19,6 +19,9 @@
# from scala-lang 2.10.4
+# Uncomment the following li
[
https://issues.apache.org/jira/browse/FLINK-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531450#comment-16531450
]
ASF GitHub Bot commented on FLINK-9718:
---
GitHub user zjffdu opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531451#comment-16531451
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531449#comment-16531449
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816750
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * License
GitHub user zjffdu opened a pull request:
https://github.com/apache/flink/pull/6245
FLINK-9718. Add enviroment variable in start-scala-shell.sh to enable
remote debug
## What is the purpose of the change
Add enviroment variable `FLINK_SCALA_SHELL_JAVA_OPTS` in
`start-scala
[
https://issues.apache.org/jira/browse/FLINK-9718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-9718:
--
Labels: pull-request-available (was: )
> Add enviroment variable in start-scala-shell.sh to en
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816552
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * License
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531448#comment-16531448
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531447#comment-16531447
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816139
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyGroupPartitionedPriorityQueue.java
---
@@ -0,0 +1,280 @@
+/*
+ *
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199816118
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedSetStore.java
---
@@ -
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531444#comment-16531444
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199815863
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyGroupPartitionedPriorityQueue.java
---
@@ -0,0 +1,280 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531433#comment-16531433
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199814790
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueSet.java
---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531430#comment-16531430
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199814578
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531426#comment-16531426
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user zjffdu commented on a diff in the pull request:
https://github.com/apache/flink/pull/6140#discussion_r199813552
--- Diff: flink-scala-shell/start-script/start-scala-shell.sh ---
@@ -19,6 +19,9 @@
# from scala-lang 2.10.4
+# Uncomment the following li
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531424#comment-16531424
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
[
https://issues.apache.org/jira/browse/FLINK-9554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531425#comment-16531425
]
ASF GitHub Bot commented on FLINK-9554:
---
Github user zjffdu commented on a diff in
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199813559
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed to th
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199813529
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed to th
[
https://issues.apache.org/jira/browse/FLINK-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531421#comment-16531421
]
ASF GitHub Bot commented on FLINK-9636:
---
Github user tillrohrmann commented on a di
Jeff Zhang created FLINK-9718:
-
Summary: Add enviroment variable in start-scala-shell.sh to enable
remote debug
Key: FLINK-9718
URL: https://issues.apache.org/jira/browse/FLINK-9718
Project: Flink
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6238#discussion_r199813070
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPoolTest.java
---
@@ -396,4 +398,48 @@ public void go() t
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531419#comment-16531419
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199812541
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyExtractorFunction.java
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/FLINK-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531418#comment-16531418
]
ASF GitHub Bot commented on FLINK-9636:
---
Github user tillrohrmann commented on a di
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6238#discussion_r199811207
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/NetworkBufferPool.java
---
@@ -151,7 +151,12 @@ public void recycle(Me
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531417#comment-16531417
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user StefanRRichter commented on a
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199812074
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/InternalPriorityQueue.java
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531394#comment-16531394
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531396#comment-16531396
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531393#comment-16531393
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531398#comment-16531398
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531402#comment-16531402
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199567018
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531403#comment-16531403
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531397#comment-16531397
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199567167
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apa
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531401#comment-16531401
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531404#comment-16531404
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199806792
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199567240
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyGroupPartitionedPriorityQueue.java
---
@@ -0,0 +1,280 @@
+/*
+ * Lice
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531390#comment-16531390
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531400#comment-16531400
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199567286
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/KeyGroupPartitionedPriorityQueue.java
---
@@ -0,0 +1,280 @@
+/*
+ * Lice
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531391#comment-16531391
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199567420
--- Diff:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOrderedSetStore.java
---
@@ -0,0 +
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199806702
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531399#comment-16531399
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531395#comment-16531395
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531405#comment-16531405
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-9491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531392#comment-16531392
]
ASF GitHub Bot commented on FLINK-9491:
---
Github user azagrebin commented on a diff
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199806862
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199807071
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199567205
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueueSet.java
---
@@ -0,0 +1,186 @@
+/*
+ * Licensed to the
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199473489
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/InternalPriorityQueue.java
---
@@ -0,0 +1,99 @@
+/*
+ * Licensed to the Apach
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199806903
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199566880
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyExtractorFunction.java
---
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199566980
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapPriorityQueue.java
---
@@ -0,0 +1,341 @@
+/*
+ * Licensed to the Apa
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199806997
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to
Github user azagrebin commented on a diff in the pull request:
https://github.com/apache/flink/pull/6228#discussion_r199806942
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/state/InternalPriorityQueueTestBase.java
---
@@ -0,0 +1,452 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-9636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-9636:
-
Fix Version/s: 1.6.0
> Network buffer leaks in requesting a batch of segments during canceling
>
[
https://issues.apache.org/jira/browse/FLINK-9681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531322#comment-16531322
]
Hequn Cheng commented on FLINK-9681:
Hi [~fhueske], thanks for your reply and suggest
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6203#discussion_r199794599
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java
---
@@ -54,18 +69,89 @@ public JobSubmitHandler(
[
https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531319#comment-16531319
]
ASF GitHub Bot commented on FLINK-9280:
---
Github user tillrohrmann commented on a di
[
https://issues.apache.org/jira/browse/FLINK-9280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531320#comment-16531320
]
ASF GitHub Bot commented on FLINK-9280:
---
Github user tillrohrmann commented on a di
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6203#discussion_r199793741
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
@@ -315,36 +315,61 @@ public JobSubmissionResult
[
https://issues.apache.org/jira/browse/FLINK-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531314#comment-16531314
]
ASF GitHub Bot commented on FLINK-9444:
---
Github user twalthr commented on the issue
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/6218
Thanks for the feedback @pnowojski and @zentol. I will merge this...
---
[
https://issues.apache.org/jira/browse/FLINK-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531310#comment-16531310
]
ASF GitHub Bot commented on FLINK-9444:
---
Github user zentol commented on a diff in
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199792051
--- Diff: flink-formats/flink-avro/pom.xml ---
@@ -51,6 +51,17 @@ under the License.
+
+
[
https://issues.apache.org/jira/browse/FLINK-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531307#comment-16531307
]
ASF GitHub Bot commented on FLINK-9444:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6218#discussion_r199791671
--- Diff:
flink-formats/flink-avro/src/main/java/org/apache/flink/formats/avro/AvroRowDeserializationSchema.java
---
@@ -201,71 +202,69 @@ private Object co
[
https://issues.apache.org/jira/browse/FLINK-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531293#comment-16531293
]
ASF GitHub Bot commented on FLINK-8785:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/6222
Merging, will create the issue once I'm done.
---
[
https://issues.apache.org/jira/browse/FLINK-9686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531291#comment-16531291
]
ASF GitHub Bot commented on FLINK-9686:
---
Github user tillrohrmann commented on the
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/6221
Thanks @fmthoma for addressing @tzulitai comments. Merging this PR now.
---
[
https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531285#comment-16531285
]
ASF GitHub Bot commented on FLINK-9513:
---
Github user StefanRRichter commented on th
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6196
Had a few more comments, but they all are basically optimizations. I leave
it up to you if you still want to address all or some of them. Please let me
know. Otherwise, we can merge this. ð
[
https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531277#comment-16531277
]
ASF GitHub Bot commented on FLINK-9513:
---
Github user StefanRRichter commented on a
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6222#discussion_r199783421
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobSubmitHandler.java
---
@@ -66,6 +67,9 @@ public JobSubmitHandler(
[
https://issues.apache.org/jira/browse/FLINK-8785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531275#comment-16531275
]
ASF GitHub Bot commented on FLINK-8785:
---
Github user tillrohrmann commented on a di
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/6196#discussion_r199783587
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeSerializer.java
---
@@ -0,0 +1,275 @@
+/*
+ * Licensed to t
[
https://issues.apache.org/jira/browse/FLINK-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531274#comment-16531274
]
ASF GitHub Bot commented on FLINK-6846:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-9513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531270#comment-16531270
]
ASF GitHub Bot commented on FLINK-9513:
---
Github user StefanRRichter commented on a
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6188#discussion_r199783102
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/scala/expressionDsl.scala
---
@@ -1029,6 +1029,29 @@ object temporalOverlaps
201 - 300 of 495 matches
Mail list logo