[GitHub] tragicjun edited a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-24 Thread GitBox
tragicjun edited a comment on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-415720615 CC @zentol @xccui would you please help review this?

[GitHub] tragicjun commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs

2018-08-24 Thread GitBox
tragicjun commented on issue #6508: [Flink-10079] [table] Automatically register sink table from external catalogs URL: https://github.com/apache/flink/pull/6508#issuecomment-415720615 CC @zentol @xccui would you please review on it?

[jira] [Commented] (FLINK-10136) Add REPEAT supported in Table API and SQL

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591420#comment-16591420 ] ASF GitHub Bot commented on FLINK-10136: xccui commented on issue #6597: [FLINK-10136] [table]

[GitHub] xccui commented on issue #6597: [FLINK-10136] [table] Add REPEAT supported in Table API and SQL

2018-08-24 Thread GitBox
xccui commented on issue #6597: [FLINK-10136] [table] Add REPEAT supported in Table API and SQL URL: https://github.com/apache/flink/pull/6597#issuecomment-415710651 Thanks for your work, @yanghua. The PR looks good to me. +1 to merge.

[jira] [Assigned] (FLINK-10192) SQL Client table visualization mode does not update correctly

2018-08-24 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther reassigned FLINK-10192: Assignee: Timo Walther > SQL Client table visualization mode does not update correctly >

[jira] [Commented] (FLINK-10204) Job is marked as FAILED after serialization exception

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591396#comment-16591396 ] ASF GitHub Bot commented on FLINK-10204: StephanEwen commented on issue #6610: [FLINK-10204] -

[GitHub] StephanEwen commented on issue #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records.

2018-08-24 Thread GitBox
StephanEwen commented on issue #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records. URL: https://github.com/apache/flink/pull/6610#issuecomment-415706823 Good catch! Could you undo the changes to `LatencyMarker`? Keeps the file's change history

[jira] [Commented] (FLINK-9559) The type of a union of CHAR columns of different lengths should be VARCHAR

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591365#comment-16591365 ] ASF GitHub Bot commented on FLINK-9559: --- pnowojski edited a comment on issue #6519: [FLINK-9559]

[GitHub] pnowojski edited a comment on issue #6519: [FLINK-9559] [table] The type of a union of CHAR columns of different lengths should be VARCHAR

2018-08-24 Thread GitBox
pnowojski edited a comment on issue #6519: [FLINK-9559] [table] The type of a union of CHAR columns of different lengths should be VARCHAR URL: https://github.com/apache/flink/pull/6519#issuecomment-415699060 @hequn8128 may I ask what is the use case that you are trying to solve? I'm

[GitHub] pnowojski commented on issue #6519: [FLINK-9559] [table] The type of a union of CHAR columns of different lengths should be VARCHAR

2018-08-24 Thread GitBox
pnowojski commented on issue #6519: [FLINK-9559] [table] The type of a union of CHAR columns of different lengths should be VARCHAR URL: https://github.com/apache/flink/pull/6519#issuecomment-415699060 @hequn8128 may I ask what is the use case that you are trying to solve? I'm asking

[jira] [Commented] (FLINK-9559) The type of a union of CHAR columns of different lengths should be VARCHAR

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591358#comment-16591358 ] ASF GitHub Bot commented on FLINK-9559: --- pnowojski commented on issue #6519: [FLINK-9559] [table]

[jira] [Created] (FLINK-10209) Exclude jdk.tools dependency from hadoop when running with java 9

2018-08-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-10209: Summary: Exclude jdk.tools dependency from hadoop when running with java 9 Key: FLINK-10209 URL: https://issues.apache.org/jira/browse/FLINK-10209 Project:

[jira] [Created] (FLINK-10208) Bump mockito to 2.0+

2018-08-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-10208: Summary: Bump mockito to 2.0+ Key: FLINK-10208 URL: https://issues.apache.org/jira/browse/FLINK-10208 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-10207) Bump checkstyle-plugo to 8.9

2018-08-24 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-10207: Summary: Bump checkstyle-plugo to 8.9 Key: FLINK-10207 URL: https://issues.apache.org/jira/browse/FLINK-10207 Project: Flink Issue Type: Sub-task

[jira] [Assigned] (FLINK-8033) Build Flink with JDK 9

2018-08-24 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-8033: --- Assignee: Chesnay Schepler > Build Flink with JDK 9 > -- > >

[jira] [Commented] (FLINK-10142) Reduce synchronization overhead for credit notifications

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591331#comment-16591331 ] ASF GitHub Bot commented on FLINK-10142: zhijiangW commented on issue #6555:

[jira] [Commented] (FLINK-10204) Job is marked as FAILED after serialization exception

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591329#comment-16591329 ] ASF GitHub Bot commented on FLINK-10204: zentol commented on a change in pull request #6610:

[GitHub] zhijiangW commented on issue #6555: [FLINK-10142][network] reduce locking around credit notification

2018-08-24 Thread GitBox
zhijiangW commented on issue #6555: [FLINK-10142][network] reduce locking around credit notification URL: https://github.com/apache/flink/pull/6555#issuecomment-415692414 Thanks @NicoK for polishing the related processes. Actually there are two main changes in this pr: 1. Remove

[GitHub] xccui commented on issue #6605: [FLINK-10201] [table] [test] The batchTestUtil was mistakenly used in some stream sql tests

2018-08-24 Thread GitBox
xccui commented on issue #6605: [FLINK-10201] [table] [test] The batchTestUtil was mistakenly used in some stream sql tests URL: https://github.com/apache/flink/pull/6605#issuecomment-415692162 Thanks for your review, @fhueske. I'll merge this.

[GitHub] zentol commented on a change in pull request #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records.

2018-08-24 Thread GitBox
zentol commented on a change in pull request #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records. URL: https://github.com/apache/flink/pull/6610#discussion_r212558074 ## File path:

[jira] [Commented] (FLINK-10204) Job is marked as FAILED after serialization exception

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591330#comment-16591330 ] ASF GitHub Bot commented on FLINK-10204: zentol commented on a change in pull request #6610:

[jira] [Commented] (FLINK-10201) The batchTestUtil was mistakenly used in some stream sql tests

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591328#comment-16591328 ] ASF GitHub Bot commented on FLINK-10201: xccui commented on issue #6605: [FLINK-10201] [table]

[GitHub] zentol commented on a change in pull request #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records.

2018-08-24 Thread GitBox
zentol commented on a change in pull request #6610: [FLINK-10204] - fix serialization/copy error for LatencyMarker records. URL: https://github.com/apache/flink/pull/6610#discussion_r212558104 ## File path:

[jira] [Commented] (FLINK-9626) Possible resource leak in FileSystem

2018-08-24 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591323#comment-16591323 ] Piotr Nowojski commented on FLINK-9626: --- I have reported this as a candidate to explain resource

[jira] [Updated] (FLINK-9626) Possible resource leak in FileSystem

2018-08-24 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-9626: -- Priority: Major (was: Critical) > Possible resource leak in FileSystem >

[jira] [Assigned] (FLINK-10206) Add hbase stream connector

2018-08-24 Thread Shimin Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shimin Yang reassigned FLINK-10206: --- Assignee: Shimin Yang > Add hbase stream connector > -- > >

[jira] [Commented] (FLINK-9061) add entropy to s3 path for better scalability

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591292#comment-16591292 ] ASF GitHub Bot commented on FLINK-9061: --- StephanEwen commented on issue #6604: [FLINK-9061]

[GitHub] StephanEwen commented on issue #6604: [FLINK-9061] Optionally add entropy to checkpoint paths better S3 scalability

2018-08-24 Thread GitBox
StephanEwen commented on issue #6604: [FLINK-9061] Optionally add entropy to checkpoint paths better S3 scalability URL: https://github.com/apache/flink/pull/6604#issuecomment-415683885 Test failures fixed - needed to adjust the mocking in some other tests. Classic ;-)

[jira] [Commented] (FLINK-10206) Add hbase stream connector

2018-08-24 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591288#comment-16591288 ] buptljy commented on FLINK-10206: - [~igloo1986] I think we should have a HBaseBatchTableSink first? From

[GitHub] fhueske commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-08-24 Thread GitBox
fhueske commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r212542167 ## File path:

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591254#comment-16591254 ] ASF GitHub Bot commented on FLINK-7243: --- fhueske commented on a change in pull request #6483:

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-08-24 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591251#comment-16591251 ] Fabian Hueske commented on FLINK-10205: --- Most jobs are implemented in a way that the split

[jira] [Updated] (FLINK-10206) Add hbase stream connector

2018-08-24 Thread Igloo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igloo updated FLINK-10206: -- Description: Now, there is a hbase connector for batch operation.    In some cases, we need to save 

[jira] [Commented] (FLINK-10206) Add hbase stream connector

2018-08-24 Thread Igloo (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591237#comment-16591237 ] Igloo commented on FLINK-10206: --- is that necessary? I would like to do it. > Add hbase stream connector >

[jira] [Created] (FLINK-10206) Add hbase stream connector

2018-08-24 Thread Igloo (JIRA)
Igloo created FLINK-10206: - Summary: Add hbase stream connector Key: FLINK-10206 URL: https://issues.apache.org/jira/browse/FLINK-10206 Project: Flink Issue Type: Improvement Components:

[jira] [Commented] (FLINK-10205) Batch Job: InputSplit Fault tolerant for DataSourceTask

2018-08-24 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591218#comment-16591218 ] vinoyang commented on FLINK-10205: -- [~isunjin] Can you assign this issue to yourself? If not, you may

[GitHub] asfgit closed pull request #6609: [hotfix][docs] missing breaking metrics page

2018-08-24 Thread GitBox
asfgit closed pull request #6609: [hotfix][docs] missing breaking metrics page URL: https://github.com/apache/flink/pull/6609 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591208#comment-16591208 ] ASF GitHub Bot commented on FLINK-7243: --- docete commented on a change in pull request #6483:

[jira] [Updated] (FLINK-7243) Add ParquetInputFormat

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-7243: -- Labels: pull-request-available (was: ) > Add ParquetInputFormat > -- > >

[jira] [Updated] (FLINK-7243) Add ParquetInputFormat

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-7243: -- Labels: pull-request-available (was: ) > Add ParquetInputFormat > -- > >

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591206#comment-16591206 ] ASF GitHub Bot commented on FLINK-7243: --- docete commented on a change in pull request #6483:

[jira] [Updated] (FLINK-7243) Add ParquetInputFormat

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-7243: -- Labels: pull-request-available (was: ) > Add ParquetInputFormat > -- > >

[jira] [Commented] (FLINK-7243) Add ParquetInputFormat

2018-08-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591207#comment-16591207 ] ASF GitHub Bot commented on FLINK-7243: --- docete commented on a change in pull request #6483:

[GitHub] docete commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-08-24 Thread GitBox
docete commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r212530605 ## File path:

[GitHub] docete commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-08-24 Thread GitBox
docete commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r212531176 ## File path:

[GitHub] docete commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format

2018-08-24 Thread GitBox
docete commented on a change in pull request #6483: [FLINK-7243][flink-formats] Add parquet input format URL: https://github.com/apache/flink/pull/6483#discussion_r212530857 ## File path:

[jira] [Commented] (FLINK-10202) Enable configuration for state.checkpoint.dir in StreamExecutionEnvironment

2018-08-24 Thread buptljy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591188#comment-16591188 ] buptljy commented on FLINK-10202: - [~StephanEwen] Here is my code. I think the checkpoint directory in 

<    1   2