[jira] [Commented] (FLINK-10980) Wrong statement in CEP Scala part

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698568#comment-16698568 ] ASF GitHub Bot commented on FLINK-10980: dubin555 commented on issue #7158: [FLINK-10980][docs]

[GitHub] dubin555 commented on issue #7158: [FLINK-10980][docs] Fix Iterable Scala code in CEP part

2018-11-25 Thread GitBox
dubin555 commented on issue #7158: [FLINK-10980][docs] Fix Iterable Scala code in CEP part URL: https://github.com/apache/flink/pull/7158#issuecomment-441544686 np This is an automated message from the Apache Git Service. To

[jira] [Commented] (FLINK-10930) Refactor checkpoint directory layout

2018-11-25 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698560#comment-16698560 ] Yun Tang commented on FLINK-10930: -- [~StephanEwen] I know this suggested changes would impact your

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698550#comment-16698550 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on issue #7167: [FLINK-10973] [table]

[GitHub] dianfu commented on issue #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on issue #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#issuecomment-441540254 @sunjincheng121 Thanks a lot for the review. Make sense to me and have added more tests.

[jira] [Commented] (FLINK-10884) Flink on yarn TM container will be killed by nodemanager because of the exceeded physical memory.

2018-11-25 Thread wgcn (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698537#comment-16698537 ] wgcn commented on FLINK-10884: -- thanks for your suggestion:D > Flink on yarn TM container will be killed

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698535#comment-16698535 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698536#comment-16698536 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236137655 ## File path:

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236138055 ## File path:

[jira] [Commented] (FLINK-10918) incremental Keyed state with RocksDB throws cannot create directory error in windows

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698521#comment-16698521 ] ASF GitHub Bot commented on FLINK-10918: imamitsehgal closed pull request #7171: FLINK-10918 Fix

[jira] [Commented] (FLINK-10918) incremental Keyed state with RocksDB throws cannot create directory error in windows

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698522#comment-16698522 ] ASF GitHub Bot commented on FLINK-10918: imamitsehgal opened a new pull request #7171:

[GitHub] imamitsehgal closed pull request #7171: FLINK-10918 Fix error while checkpointing on window keyed state rock …

2018-11-25 Thread GitBox
imamitsehgal closed pull request #7171: FLINK-10918 Fix error while checkpointing on window keyed state rock … URL: https://github.com/apache/flink/pull/7171 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] imamitsehgal opened a new pull request #7171: FLINK-10918 Fix error while checkpointing on window keyed state rock …

2018-11-25 Thread GitBox
imamitsehgal opened a new pull request #7171: FLINK-10918 Fix error while checkpointing on window keyed state rock … URL: https://github.com/apache/flink/pull/7171 …db backend ## What is the purpose of the change *To fix the directory creation error while running on

[jira] [Commented] (FLINK-10990) Pre-check timespan in meterview to avoid NAN

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698517#comment-16698517 ] ASF GitHub Bot commented on FLINK-10990: Aitozi commented on issue #7165:

[GitHub] Aitozi commented on issue #7165: [FLINK-10990][Metric]Pre-check timespan in meterview to avoid NAN

2018-11-25 Thread GitBox
Aitozi commented on issue #7165: [FLINK-10990][Metric]Pre-check timespan in meterview to avoid NAN URL: https://github.com/apache/flink/pull/7165#issuecomment-441532392 have addressed according your comment @zentol This is

[jira] [Created] (FLINK-11002) Trigger.clear() will not be called after purged window

2018-11-25 Thread Yuan Yifan (JIRA)
Yuan Yifan created FLINK-11002: -- Summary: Trigger.clear() will not be called after purged window Key: FLINK-11002 URL: https://issues.apache.org/jira/browse/FLINK-11002 Project: Flink Issue

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698500#comment-16698500 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on a change in pull request #7167:

[GitHub] dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236129587 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow` defines a

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698491#comment-16698491 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on issue #7167: [FLINK-10973] [table]

[GitHub] dianfu commented on issue #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on issue #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#issuecomment-441524746 @sunjincheng121 @hequn8128 Thanks a lot for your review. Have updated the PR according to your comments.

[jira] [Commented] (FLINK-10884) Flink on yarn TM container will be killed by nodemanager because of the exceeded physical memory.

2018-11-25 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698453#comment-16698453 ] zhijiang commented on FLINK-10884: -- [~1026688210],my above comments was just for explaining the reason

[GitHub] dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236114331 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698449#comment-16698449 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on a change in pull request #7167:

[jira] [Commented] (FLINK-10958) Add overload support for user defined function

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698441#comment-16698441 ] ASF GitHub Bot commented on FLINK-10958: asfgit closed pull request #7152: [FLINK-10958] [table]

[GitHub] asfgit closed pull request #7152: [FLINK-10958] [table] Add overload support for user defined function

2018-11-25 Thread GitBox
asfgit closed pull request #7152: [FLINK-10958] [table] Add overload support for user defined function URL: https://github.com/apache/flink/pull/7152 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[jira] [Closed] (FLINK-10958) Add overload support for user defined function

2018-11-25 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng closed FLINK-10958. --- Resolution: Fixed Fixed in master: d9c7f97790a8d396ffed59feee6b3e0c523aa173 > Add overload support

[GitHub] tzulitai closed pull request #7029: [BP-1.7] [FLINK-10789] New serializer snapshots after 1.6 should implement TypeSerializerSnapshot

2018-11-25 Thread GitBox
tzulitai closed pull request #7029: [BP-1.7] [FLINK-10789] New serializer snapshots after 1.6 should implement TypeSerializerSnapshot URL: https://github.com/apache/flink/pull/7029 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed

[GitHub] tzulitai commented on issue #7029: [BP-1.7] [FLINK-10789] New serializer snapshots after 1.6 should implement TypeSerializerSnapshot

2018-11-25 Thread GitBox
tzulitai commented on issue #7029: [BP-1.7] [FLINK-10789] New serializer snapshots after 1.6 should implement TypeSerializerSnapshot URL: https://github.com/apache/flink/pull/7029#issuecomment-441507053 This has been backported already, closing the PR.

[jira] [Commented] (FLINK-10009) Fix the casting problem for function TIMESTAMPADD in Table

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698438#comment-16698438 ] ASF GitHub Bot commented on FLINK-10009: sunjincheng121 commented on issue #7155: [FLINK-10009]

[GitHub] sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table

2018-11-25 Thread GitBox
sunjincheng121 commented on issue #7155: [FLINK-10009] [table] Fix the casting problem for function TIMESTAMPADD in Table URL: https://github.com/apache/flink/pull/7155#issuecomment-441506111 @XuQianJin-Stars Thanks for file the JIARs for the issue of timestampadd's time type both in

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698431#comment-16698431 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698434#comment-16698434 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236109434 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236108631 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236108631 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698429#comment-16698429 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10966) Optimize the release blocking logic in BarrierBuffer

2018-11-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698419#comment-16698419 ] vinoyang commented on FLINK-10966: -- [~StephanEwen] We found this problem online. The reason for this

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698417#comment-16698417 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on a change in pull request #7167:

[GitHub] dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236106257 ## File path:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698414#comment-16698414 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236105855 ## File path:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698410#comment-16698410 ] ASF GitHub Bot commented on FLINK-10973: hequn8128 commented on a change in pull request #7167:

[GitHub] hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236105010 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[GitHub] dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236105330 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698409#comment-16698409 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on a change in pull request #7167:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698408#comment-16698408 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on a change in pull request #7167:

[GitHub] dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236105191 ## File path:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698391#comment-16698391 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10993) Bring bloomfilter as a public API

2018-11-25 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698405#comment-16698405 ] vinoyang commented on FLINK-10993: -- [~StephanEwen] Thank you for agreeing with the meaning of this

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698397#comment-16698397 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698401#comment-16698401 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on a change in pull request #7167:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698403#comment-16698403 ] ASF GitHub Bot commented on FLINK-10973: hequn8128 commented on a change in pull request #7167:

[GitHub] hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236105010 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[GitHub] dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236104982 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698398#comment-16698398 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236104746 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow`

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698388#comment-16698388 ] ASF GitHub Bot commented on FLINK-10973: dianfu commented on a change in pull request #7167:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698394#comment-16698394 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698396#comment-16698396 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698395#comment-16698395 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698390#comment-16698390 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698392#comment-16698392 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698393#comment-16698393 ] ASF GitHub Bot commented on FLINK-10973: sunjincheng121 commented on a change in pull request

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236101805 ## File path:

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236103754 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow`

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236100313 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236102599 ## File path:

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236101896 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236103767 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236100232 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow`

[GitHub] sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
sunjincheng121 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236100631 ## File path:

[GitHub] dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
dianfu commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236103842 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698384#comment-16698384 ] ASF GitHub Bot commented on FLINK-10973: hequn8128 commented on a change in pull request #7167:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698382#comment-16698382 ] ASF GitHub Bot commented on FLINK-10973: hequn8128 commented on a change in pull request #7167:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698385#comment-16698385 ] ASF GitHub Bot commented on FLINK-10973: hequn8128 commented on a change in pull request #7167:

[jira] [Commented] (FLINK-10973) Add Map operator to Table API

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698383#comment-16698383 ] ASF GitHub Bot commented on FLINK-10973: hequn8128 commented on a change in pull request #7167:

[GitHub] hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236103011 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow` defines a

[GitHub] hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236103235 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow` defines a

[GitHub] hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236102999 ## File path: docs/dev/table/tableApi.md ## @@ -1682,6 +1682,34 @@ The `OverWindow` defines a

[GitHub] hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API

2018-11-25 Thread GitBox
hequn8128 commented on a change in pull request #7167: [FLINK-10973] [table] Add support for map to table API URL: https://github.com/apache/flink/pull/7167#discussion_r236103381 ## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala

[jira] [Commented] (FLINK-8159) Pattern(Flat)SelectFunctions should support RichFunction interface

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698361#comment-16698361 ] ASF GitHub Bot commented on FLINK-8159: --- sunjincheng121 commented on issue #7110: [FLINK-8159]

[GitHub] sunjincheng121 commented on issue #7110: [FLINK-8159] [cep] Pattern(Flat)SelectFunctions should support RichFunction interface

2018-11-25 Thread GitBox
sunjincheng121 commented on issue #7110: [FLINK-8159] [cep] Pattern(Flat)SelectFunctions should support RichFunction interface URL: https://github.com/apache/flink/pull/7110#issuecomment-441486964 @dianfu Thanks for the update! LGTM. +1 to merged

[jira] [Commented] (FLINK-10887) Add source watermark tracking to the JobMaster

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698339#comment-16698339 ] ASF GitHub Bot commented on FLINK-10887: StephanEwen commented on issue #7099: [FLINK-10887]

[GitHub] StephanEwen commented on issue #7099: [FLINK-10887] [jobmaster] Add source watermark tracking to the JobMaster

2018-11-25 Thread GitBox
StephanEwen commented on issue #7099: [FLINK-10887] [jobmaster] Add source watermark tracking to the JobMaster URL: https://github.com/apache/flink/pull/7099#issuecomment-441478603 I think this is a very nice feature, +1 to have this. We have seen other use cases that need a similar

[jira] [Commented] (FLINK-10930) Refactor checkpoint directory layout

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698333#comment-16698333 ] Stephan Ewen commented on FLINK-10930: -- The suggested changes would undo quite a lot of what

[jira] [Commented] (FLINK-10953) InterruptedException on KafkaProducer

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698327#comment-16698327 ] Stephan Ewen commented on FLINK-10953: -- Does this cause any errors / failures, or is this mainly

[jira] [Commented] (FLINK-10954) Hardlink from files of previous local stored state might cross devices

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698322#comment-16698322 ] Stephan Ewen commented on FLINK-10954: -- The spirit of local recovery is to avoid copying, so this

[jira] [Commented] (FLINK-10966) Optimize the release blocking logic in BarrierBuffer

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698317#comment-16698317 ] Stephan Ewen commented on FLINK-10966: -- A "notifyCheckpointFailed" would be helpful and the right

[jira] [Commented] (FLINK-10981) Add or modify metrics to show the maximum usage of InputBufferPool/OutputBufferPool to help debugging back pressure

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698310#comment-16698310 ] Stephan Ewen commented on FLINK-10981: -- Do you think this metric would be better usable for the

[jira] [Commented] (FLINK-10967) Update kafka dependency to 2.1.0

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698314#comment-16698314 ] Stephan Ewen commented on FLINK-10967: -- There are currently massive test instabilities with the

[jira] [Commented] (FLINK-10971) Dependency convergence issue when building flink-s3-fs-presto

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698312#comment-16698312 ] Stephan Ewen commented on FLINK-10971: -- It could be the maven issue after all because: -

[jira] [Updated] (FLINK-10997) Avro-confluent-registry does not bundle any dependency

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10997: --- Labels: pull-request-available (was: ) > Avro-confluent-registry does not bundle any

[jira] [Commented] (FLINK-10984) Move flink-shaded-hadoop to flink-shaded

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698307#comment-16698307 ] Stephan Ewen commented on FLINK-10984: -- +1 to this Given that users can still put any Hadoop in

[jira] [Commented] (FLINK-10993) Bring bloomfilter as a public API

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698306#comment-16698306 ] Stephan Ewen commented on FLINK-10993: -- I think this could be an interesting feature, but it loos

[jira] [Commented] (FLINK-10996) Enable state ttl in cep

2018-11-25 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698304#comment-16698304 ] Stephan Ewen commented on FLINK-10996: -- +1 that sounds like it is needed to harden CEP. If you

[jira] [Commented] (FLINK-10997) Avro-confluent-registry does not bundle any dependency

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698303#comment-16698303 ] ASF GitHub Bot commented on FLINK-10997: StephanEwen commented on issue #7170:

[GitHub] StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client

2018-11-25 Thread GitBox
StephanEwen commented on issue #7170: [FLINK-10997][formats] Bundle kafka-scheme-registry-client URL: https://github.com/apache/flink/pull/7170#issuecomment-441473526 +1 to the idea, but we should do it differently. If you want the Avro dependency not in the shaded jar, simply set

[jira] [Commented] (FLINK-10998) flink-metrics-ganglia has LGPL dependency

2018-11-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698295#comment-16698295 ] ASF GitHub Bot commented on FLINK-10998: StephanEwen commented on issue #7169:

[GitHub] StephanEwen commented on issue #7169: [FLINK-10998][metrics][ganglia] Remove Ganglia reporter

2018-11-25 Thread GitBox
StephanEwen commented on issue #7169: [FLINK-10998][metrics][ganglia] Remove Ganglia reporter URL: https://github.com/apache/flink/pull/7169#issuecomment-441472981 +1 to remove the reporter for now, to be safe license-wise We could later try and make this available again via a

  1   2   >