[GitHub] [flink] fhueske commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework

2019-03-04 Thread GitBox
fhueske commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework URL: https://github.com/apache/flink/pull/7754#issuecomment-469578268 Oh, I see. Then links would need to be converted to `{{ baseurl_i18n }}/zn` or relative paths. Anyway, I think

[jira] [Updated] (FLINK-11820) KafkaDeserializationSchemaWrapper should handle record which value is null

2019-03-04 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated FLINK-11820: --- Attachment: updateKafkaDeserialization.patch > KafkaDeserializationSchemaWrapper should handle

[GitHub] [flink] flinkbot edited a comment on issue #7781: [FLINK-8354] Add KafkaDeserializationSchema that directly uses ConsumerRecord

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7781: [FLINK-8354] Add KafkaDeserializationSchema that directly uses ConsumerRecord URL: https://github.com/apache/flink/pull/7781#issuecomment-465645232 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] lamber-ken commented on issue #7781: [FLINK-8354] Add KafkaDeserializationSchema that directly uses ConsumerRecord

2019-03-04 Thread GitBox
lamber-ken commented on issue #7781: [FLINK-8354] Add KafkaDeserializationSchema that directly uses ConsumerRecord URL: https://github.com/apache/flink/pull/7781#issuecomment-469572614 @aljoscha hi, the java file was placed at wrong package

[GitHub] [flink] TisonKun commented on a change in pull request #7880: [FLINK-11336][zk] Delete ZNodes when ZooKeeperHaServices#closeAndCleanupAllData

2019-03-04 Thread GitBox
TisonKun commented on a change in pull request #7880: [FLINK-11336][zk] Delete ZNodes when ZooKeeperHaServices#closeAndCleanupAllData URL: https://github.com/apache/flink/pull/7880#discussion_r262375236 ## File path:

[GitHub] [flink] flinkbot commented on issue #7901: [FLINK-11819][Documentation] fix wrong description about attribute order by supported now

2019-03-04 Thread GitBox
flinkbot commented on issue #7901: [FLINK-11819][Documentation] fix wrong description about attribute order by supported now URL: https://github.com/apache/flink/pull/7901#issuecomment-469570527 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[jira] [Updated] (FLINK-11819) Additional attribute for order by not support by flink sql, but told supported in doc

2019-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11819: --- Labels: pull-request-available (was: ) > Additional attribute for order by not support by

[GitHub] [flink] hustclf opened a new pull request #7901: [FLINK-11819][Documentation] fix wrong description about attribute order by supported now

2019-03-04 Thread GitBox
hustclf opened a new pull request #7901: [FLINK-11819][Documentation] fix wrong description about attribute order by supported now URL: https://github.com/apache/flink/pull/7901 ## What is the purpose of the change This pull request fix mistake about the description of attribute

[jira] [Updated] (FLINK-11820) KafkaDeserializationSchemaWrapper should handle record which value is null

2019-03-04 Thread lamber-ken (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lamber-ken updated FLINK-11820: --- Summary: KafkaDeserializationSchemaWrapper should handle record which value is null (was:

[jira] [Created] (FLINK-11820) KafkaDeserializationSchemaWrapper should filter record which value is null

2019-03-04 Thread lamber-ken (JIRA)
lamber-ken created FLINK-11820: -- Summary: KafkaDeserializationSchemaWrapper should filter record which value is null Key: FLINK-11820 URL: https://issues.apache.org/jira/browse/FLINK-11820 Project:

[jira] [Created] (FLINK-11818) Provide pipe transformation function for DataSet API

2019-03-04 Thread vinoyang (JIRA)
vinoyang created FLINK-11818: Summary: Provide pipe transformation function for DataSet API Key: FLINK-11818 URL: https://issues.apache.org/jira/browse/FLINK-11818 Project: Flink Issue Type:

[GitHub] [flink] flinkbot commented on issue #7900: Test fix to flaky Kafka ratelimiter test

2019-03-04 Thread GitBox
flinkbot commented on issue #7900: Test fix to flaky Kafka ratelimiter test URL: https://github.com/apache/flink/pull/7900#issuecomment-469563693 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will

[GitHub] [flink] glaksh100 opened a new pull request #7900: Test fix to flaky Kafka ratelimiter test

2019-03-04 Thread GitBox
glaksh100 opened a new pull request #7900: Test fix to flaky Kafka ratelimiter test URL: https://github.com/apache/flink/pull/7900 ## What is the purpose of the change A test PR to re-run and remove flakiness from`testRateLimitedConsumer()` in `Kafka09ITCase` ## Brief change

[jira] [Updated] (FLINK-11819) Additional attribute for order by not support by flink sql, but told supported in doc

2019-03-04 Thread Lifei Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lifei Chen updated FLINK-11819: --- Description: I am using flink v1.7.1, when I use flink sql to order by an attribute (not time

[jira] [Updated] (FLINK-11819) Additional attribute for order by not support by flink sql, but told supported in doc

2019-03-04 Thread Lifei Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lifei Chen updated FLINK-11819: --- Description: I am using flink v1.7.1, when I use flink sql to order by an attribute (not time

[jira] [Created] (FLINK-11819) Additional attribute for order by not support by flink sql, but told supported in doc

2019-03-04 Thread Lifei Chen (JIRA)
Lifei Chen created FLINK-11819: -- Summary: Additional attribute for order by not support by flink sql, but told supported in doc Key: FLINK-11819 URL: https://issues.apache.org/jira/browse/FLINK-11819

[GitHub] [flink] TisonKun commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-03-04 Thread GitBox
TisonKun commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262366190 ## File path:

[GitHub] [flink] TisonKun commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher

2019-03-04 Thread GitBox
TisonKun commented on a change in pull request #7889: [FLINK-11665] Wait for job termination before recovery in Dispatcher URL: https://github.com/apache/flink/pull/7889#discussion_r262365998 ## File path:

[jira] [Updated] (FLINK-11803) Improve FlinkTypeFactory for Blink

2019-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11803: --- Labels: pull-request-available (was: ) > Improve FlinkTypeFactory for Blink >

[jira] [Commented] (FLINK-11818) Provide pipe transformation function for DataSet API

2019-03-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784151#comment-16784151 ] vinoyang commented on FLINK-11818: -- [~fhueske] and [~till.rohrmann] what do you think about this issue? 

[jira] [Updated] (FLINK-11731) Make DefaultOperatorStateBackend follow the builder pattern

2019-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11731: --- Labels: pull-request-available (was: ) > Make DefaultOperatorStateBackend follow the

[GitHub] [flink] flinkbot commented on issue #7899: [FLINK-11731] [State Backends] Make DefaultOperatorStateBackend follow the builder pattern

2019-03-04 Thread GitBox
flinkbot commented on issue #7899: [FLINK-11731] [State Backends] Make DefaultOperatorStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7899#issuecomment-469557664 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] carp84 opened a new pull request #7899: [FLINK-11731] [State Backends] Make DefaultOperatorStateBackend follow the builder pattern

2019-03-04 Thread GitBox
carp84 opened a new pull request #7899: [FLINK-11731] [State Backends] Make DefaultOperatorStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7899 ## What is the purpose of the change This PR makes `DefaultOperatorStateBackend` construction follow the

[GitHub] [flink] flinkbot edited a comment on issue #7865: [FLINK-9650] [formats] add support for protobuf objects

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7865: [FLINK-9650] [formats] add support for protobuf objects URL: https://github.com/apache/flink/pull/7865#issuecomment-468415774 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] twalthr commented on issue #7865: [FLINK-9650] [formats] add support for protobuf objects

2019-03-04 Thread GitBox
twalthr commented on issue #7865: [FLINK-9650] [formats] add support for protobuf objects URL: https://github.com/apache/flink/pull/7865#issuecomment-469556015 @flinkbot approve description @flinkbot approve consensus

[jira] [Assigned] (FLINK-11072) KafkaITCase.testKeyValueSupport failure

2019-03-04 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11072?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-11072: Assignee: Gary Yao > KafkaITCase.testKeyValueSupport failure >

[GitHub] [flink] twalthr commented on issue #7898: [FLINK-11803][table-runtime-blink] Improve FlinkTypeFactory for Blink

2019-03-04 Thread GitBox
twalthr commented on issue #7898: [FLINK-11803][table-runtime-blink] Improve FlinkTypeFactory for Blink URL: https://github.com/apache/flink/pull/7898#issuecomment-469554194 Please update your commit message. This PR does not change runtime but planner-related code.

[GitHub] [flink] flinkbot edited a comment on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-461438683 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] twalthr commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes.

2019-03-04 Thread GitBox
twalthr commented on issue #7664: [FLINK-11449][table] Uncouple the Expression class from RexNodes. URL: https://github.com/apache/flink/pull/7664#issuecomment-469553423 FYI: I merged table function removal commit in dcd8c74b504046802cebf278b718e4753928a260.

[GitHub] [flink] flinkbot commented on issue #7898: [FLINK-11803][table-runtime-blink] Improve FlinkTypeFactory for Blink

2019-03-04 Thread GitBox
flinkbot commented on issue #7898: [FLINK-11803][table-runtime-blink] Improve FlinkTypeFactory for Blink URL: https://github.com/apache/flink/pull/7898#issuecomment-469553000 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] JingsongLi opened a new pull request #7898: [FLINK-11803][table-runtime-blink] Improve FlinkTypeFactory for Blink

2019-03-04 Thread GitBox
JingsongLi opened a new pull request #7898: [FLINK-11803][table-runtime-blink] Improve FlinkTypeFactory for Blink URL: https://github.com/apache/flink/pull/7898 ## What is the purpose of the change Improve FlinkTypeFactory for createTypeFromInternalType and toInternalType ##

[GitHub] [flink] link3280 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials

2019-03-04 Thread GitBox
link3280 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials URL: https://github.com/apache/flink/pull/7895#discussion_r262345469 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java

[jira] [Updated] (FLINK-11817) DataStream API Tutorial uses deprecated fold function

2019-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11817: --- Labels: pull-request-available (was: ) > DataStream API Tutorial uses deprecated fold

[GitHub] [flink] flinkbot commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-04 Thread GitBox
flinkbot commented on issue #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897#issuecomment-469527787 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[GitHub] [flink] leesf opened a new pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial

2019-03-04 Thread GitBox
leesf opened a new pull request #7897: [FLINK-11817] Uses aggregate function in DataStream API Tutorial URL: https://github.com/apache/flink/pull/7897 ## What is the purpose of the change Fold function is deprecated, thus change it to Aggregate function in DataStream API

[jira] [Commented] (FLINK-10988) Improve debugging / visibility of job state

2019-03-04 Thread Scott Sue (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784029#comment-16784029 ] Scott Sue commented on FLINK-10988: --- This is something that we can do in the code.  However, the

[GitHub] [flink] flinkbot edited a comment on issue #7851: [FLINK-11703] [table-planner-blink] Add a basic framework for Blink SQL

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7851: [FLINK-11703] [table-planner-blink] Add a basic framework for Blink SQL URL: https://github.com/apache/flink/pull/7851#issuecomment-467924695 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] wuchong closed pull request #7851: [FLINK-11703] [table-planner-blink] Add a basic framework for Blink SQL

2019-03-04 Thread GitBox
wuchong closed pull request #7851: [FLINK-11703] [table-planner-blink] Add a basic framework for Blink SQL URL: https://github.com/apache/flink/pull/7851 This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] flinkbot edited a comment on issue #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo…

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo… URL: https://github.com/apache/flink/pull/7809#issuecomment-466376137 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] TisonKun commented on issue #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo…

2019-03-04 Thread GitBox
TisonKun commented on issue #7809: [FLINK-11710][tests] Refactor SimpleSlotProvider to TestingLogicalSlo… URL: https://github.com/apache/flink/pull/7809#issuecomment-469514592 @tillrohrmann I think this refactor is ready to be reviewed. Changes are minor and it would be good if you

[GitHub] [flink] flinkbot edited a comment on issue #7762: [FLINK-11146] Remove invalid codes in ClusterClient

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7762: [FLINK-11146] Remove invalid codes in ClusterClient URL: https://github.com/apache/flink/pull/7762#issuecomment-465485078 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your

[GitHub] [flink] TisonKun commented on issue #7762: [FLINK-11146] Remove invalid codes in ClusterClient

2019-03-04 Thread GitBox
TisonKun commented on issue #7762: [FLINK-11146] Remove invalid codes in ClusterClient URL: https://github.com/apache/flink/pull/7762#issuecomment-469514057 @mxm do you know if there is a committer could help review these changes? It stalls for several days but the changes look not quite

[GitHub] [flink] gaoyunhaii commented on issue #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode

2019-03-04 Thread GitBox
gaoyunhaii commented on issue #7368: [FLINK-10742][network] Let Netty use Flink's buffers directly in credit-based mode URL: https://github.com/apache/flink/pull/7368#issuecomment-469513004 OK, I will complement the results. Besides, a more obvious advantage of receiver-side zero-copy is

[GitHub] [flink] wuchong commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework

2019-03-04 Thread GitBox
wuchong commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework URL: https://github.com/apache/flink/pull/7754#issuecomment-469509807 Hi @fhueske , thanks for the suggestion. I think it's a good idea. But I'm afraid we can not use {{ baseurl_i18n

[GitHub] [flink] klion26 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials

2019-03-04 Thread GitBox
klion26 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials URL: https://github.com/apache/flink/pull/7895#discussion_r262322484 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java

[GitHub] [flink] klion26 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials

2019-03-04 Thread GitBox
klion26 commented on a change in pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials URL: https://github.com/apache/flink/pull/7895#discussion_r262322484 ## File path: flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java

[jira] [Commented] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2019-03-04 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783977#comment-16783977 ] TisonKun commented on FLINK-11813: -- We would never keep forever the {{RunningJobsRegistry}} since it

[jira] [Commented] (FLINK-10506) Introduce minimum, target and maximum parallelism to JobGraph

2019-03-04 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783962#comment-16783962 ] vinoyang commented on FLINK-10506: -- [~till.rohrmann] I agree with you. As we have communicated before,

[jira] [Assigned] (FLINK-11817) DataStream API Tutorial uses deprecated fold function

2019-03-04 Thread leesf (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] leesf reassigned FLINK-11817: - Assignee: leesf > DataStream API Tutorial uses deprecated fold function >

[jira] [Updated] (FLINK-11817) DataStream API Tutorial uses deprecated fold function

2019-03-04 Thread Michael Holler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Holler updated FLINK-11817: --- Description: {{WindowedStream.fold}} is deprecated, but it's still recommended in the

[jira] [Created] (FLINK-11817) DataStream API Tutorial uses deprecated fold function

2019-03-04 Thread Michael Holler (JIRA)
Michael Holler created FLINK-11817: -- Summary: DataStream API Tutorial uses deprecated fold function Key: FLINK-11817 URL: https://issues.apache.org/jira/browse/FLINK-11817 Project: Flink

[jira] [Resolved] (FLINK-11730) Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter resolved FLINK-11730. Resolution: Implemented Fix Version/s: 1.8.0 Merged in: master: 237d07c7

[jira] [Resolved] (FLINK-11804) Make sure the CloseableRegistry used in backend builder is registered with task

2019-03-04 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter resolved FLINK-11804. Resolution: Fixed Fix Version/s: 1.8.0 Merged in: master: eada52be release-1.8:

[GitHub] [flink] asfgit closed pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
asfgit closed pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866 This is an automated message from the Apache Git Service.

[jira] [Resolved] (FLINK-11420) Serialization of case classes containing a Map[String, Any] sometimes throws ArrayIndexOutOfBoundsException

2019-03-04 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz resolved FLINK-11420. -- Resolution: Fixed Fixed in: master 00e59e7afe2f6a60cfd91c4c75fedd4b96d463a3 1.8

[jira] [Updated] (FLINK-9007) End-to-end test: Kinesis connector

2019-03-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9007: -- Labels: pull-request-available (was: ) > End-to-end test: Kinesis connector >

[GitHub] [flink] tweise commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-04 Thread GitBox
tweise commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#discussion_r262176060 ## File path:

[GitHub] [flink] tweise commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-04 Thread GitBox
tweise commented on a change in pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#discussion_r262175650 ## File path:

[GitHub] [flink] flinkbot commented on issue #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-04 Thread GitBox
flinkbot commented on issue #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896#issuecomment-469352078 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] tweise opened a new pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test

2019-03-04 Thread GitBox
tweise opened a new pull request #7896: [WIP] [FLINK-9007] [kinesis] Add Kinesis e2e test URL: https://github.com/apache/flink/pull/7896 ## What is the purpose of the change This PR adds an end to end test for Kinesis consumer and producer, similar to what we already have for

[GitHub] [flink] dawidwys merged pull request #7894: [FLINK-11420][core][bp-1.8] Fixed duplicate method of TraversableSerializer

2019-03-04 Thread GitBox
dawidwys merged pull request #7894: [FLINK-11420][core][bp-1.8] Fixed duplicate method of TraversableSerializer URL: https://github.com/apache/flink/pull/7894 This is an automated message from the Apache Git Service. To

[GitHub] [flink] dawidwys merged pull request #7872: [FLINK-11420][core] Fixed duplicate method of TraversableSerializer

2019-03-04 Thread GitBox
dawidwys merged pull request #7872: [FLINK-11420][core] Fixed duplicate method of TraversableSerializer URL: https://github.com/apache/flink/pull/7872 This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] zentol closed pull request #7893: [hotfix] Fix checkstyle violations and remove unnecessary symbol in IOManagerAsync

2019-03-04 Thread GitBox
zentol closed pull request #7893: [hotfix] Fix checkstyle violations and remove unnecessary symbol in IOManagerAsync URL: https://github.com/apache/flink/pull/7893 This is an automated message from the Apache Git Service.

[GitHub] [flink] zentol commented on issue #7893: [hotfix] Fix checkstyle violations and remove unnecessary symbol in IOManagerAsync

2019-03-04 Thread GitBox
zentol commented on issue #7893: [hotfix] Fix checkstyle violations and remove unnecessary symbol in IOManagerAsync URL: https://github.com/apache/flink/pull/7893#issuecomment-469340940 Rejecting; same story as in #7859.

[jira] [Closed] (FLINK-11816) Changes of FLINK-11516 causes compilation failure

2019-03-04 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-11816. --- Resolution: Cannot Reproduce I cannot reproduce this issue locally and I guess it's a cache issue and you 

[GitHub] [flink] StefanRRichter commented on issue #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
StefanRRichter commented on issue #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#issuecomment-469330592 Thanks for your work @carp84 ! Changes LGTM  Merging once I have a green build.

[jira] [Commented] (FLINK-11775) Introduce MemorySegmentWritable to let DataOutputView direct copy to internal bytes

2019-03-04 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783528#comment-16783528 ] Piotr Nowojski commented on FLINK-11775: Couldn't we provide an implementation of

[jira] [Commented] (FLINK-11816) Changes of FLINK-11516 causes compilation failure

2019-03-04 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783527#comment-16783527 ] Dian Fu commented on FLINK-11816: - Thanks [~carp84] for reporting this issue. I'll take a look at it. >

[GitHub] [flink] kl0u commented on issue #7890: [FLINK-9003][E2E] Add operators with input type that goes through custom, stateful serialization

2019-03-04 Thread GitBox
kl0u commented on issue #7890: [FLINK-9003][E2E] Add operators with input type that goes through custom, stateful serialization URL: https://github.com/apache/flink/pull/7890#issuecomment-469317914 Thanks for the work @azagrebin . Just merged on `release-1.7`.

[GitHub] [flink] kl0u closed pull request #7890: [FLINK-9003][E2E] Add operators with input type that goes through custom, stateful serialization

2019-03-04 Thread GitBox
kl0u closed pull request #7890: [FLINK-9003][E2E] Add operators with input type that goes through custom, stateful serialization URL: https://github.com/apache/flink/pull/7890 This is an automated message from the Apache

[GitHub] [flink] pnowojski commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode

2019-03-04 Thread GitBox
pnowojski commented on issue #7713: [FLINK-10995][network] Copy intermediate serialization results only once for broadcast mode URL: https://github.com/apache/flink/pull/7713#issuecomment-469315464 `Watermark` and `StreamStatus` I was aware of, I was a bit unsure that you have found some

[GitHub] [flink] carp84 commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
carp84 commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262132756 ## File path:

[jira] [Updated] (FLINK-11727) JSON row format is not serializable

2019-03-04 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-11727: - Description: {\{JsonRowSerializationSchema}} and  \{{JsonRowDeserializationSchema}} use

[jira] [Assigned] (FLINK-11727) JSON row format is not serializable

2019-03-04 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz reassigned FLINK-11727: Assignee: Dawid Wysakowicz (was: Timo Walther) > JSON row format is not

[GitHub] [flink] StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262128953 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
carp84 commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262128277 ## File path:

[GitHub] [flink] pnowojski commented on issue #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-03-04 Thread GitBox
pnowojski commented on issue #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#issuecomment-469308727 Hi @hequn8128, sorry for not responding for 2 weeks, but this time I was on the holidays :(

[GitHub] [flink] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-03-04 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r262126111 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion

2019-03-04 Thread GitBox
pnowojski commented on a change in pull request #6787: [FLINK-8577][table] Implement proctime DataStream to Table upsert conversion URL: https://github.com/apache/flink/pull/6787#discussion_r262126111 ## File path:

[GitHub] [flink] flinkbot commented on issue #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials

2019-03-04 Thread GitBox
flinkbot commented on issue #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials URL: https://github.com/apache/flink/pull/7895#issuecomment-469305093 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] link3280 opened a new pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials

2019-03-04 Thread GitBox
link3280 opened a new pull request #7895: [FLINK-11126][YARN][security] Filter out AMRMToken in TaskManager‘s credentials URL: https://github.com/apache/flink/pull/7895 ## What is the purpose of the change Currently, Flink JobManager propagates its storage tokens to TaskManager to

[jira] [Updated] (FLINK-11815) Support execution with static resources (Flip-6): E.g. spreading tasks across available set of TMs

2019-03-04 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-11815: -- Affects Version/s: 1.8.0 > Support execution with static resources (Flip-6): E.g. spreading

[jira] [Created] (FLINK-11816) Changes of FLINK-11516 causes compilation failure

2019-03-04 Thread Yu Li (JIRA)
Yu Li created FLINK-11816: - Summary: Changes of FLINK-11516 causes compilation failure Key: FLINK-11816 URL: https://issues.apache.org/jira/browse/FLINK-11816 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-11814) Changes of FLINK-11516 causes compilation failure

2019-03-04 Thread Yu Li (JIRA)
Yu Li created FLINK-11814: - Summary: Changes of FLINK-11516 causes compilation failure Key: FLINK-11814 URL: https://issues.apache.org/jira/browse/FLINK-11814 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-11815) Support execution with static resources (Flip-6): E.g. spreading tasks across available set of TMs

2019-03-04 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-11815: -- Summary: Support execution with static resources (Flip-6): E.g. spreading tasks across available set of TMs Key: FLINK-11815 URL:

[jira] [Closed] (FLINK-11565) Translate "Improving the Website" page into Chinese

2019-03-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-11565. --- Resolution: Fixed Fixed in flink-web: 4e13ba149feed3ac2dd5fc5e7964130c0dbc07ff > Translate "Improving the

[GitHub] [flink] flinkbot edited a comment on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework URL: https://github.com/apache/flink/pull/7754#issuecomment-465170230 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Created] (FLINK-11813) Standby per job mode Dispatchers don't know job's JobSchedulingStatus

2019-03-04 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-11813: - Summary: Standby per job mode Dispatchers don't know job's JobSchedulingStatus Key: FLINK-11813 URL: https://issues.apache.org/jira/browse/FLINK-11813 Project:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262115368 ## File path:

[GitHub] [flink] fhueske commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework

2019-03-04 Thread GitBox
fhueske commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework URL: https://github.com/apache/flink/pull/7754#issuecomment-469300071 @flinkbot approve architecture @flinkbot approve quality

[GitHub] [flink] flinkbot edited a comment on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework URL: https://github.com/apache/flink/pull/7754#issuecomment-465170230 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[GitHub] [flink] fhueske commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework

2019-03-04 Thread GitBox
fhueske commented on issue #7754: [FLINK-11530] [docs] Support multiple languages for the docs framework URL: https://github.com/apache/flink/pull/7754#issuecomment-469299578 Hi @wuchong, thanks for splitting commit and the pointers to the variables. Adding the switch later makes total

[GitHub] [flink] flinkbot edited a comment on issue #7872: [FLINK-11420][core] Fixed duplicate method of TraversableSerializer

2019-03-04 Thread GitBox
flinkbot edited a comment on issue #7872: [FLINK-11420][core] Fixed duplicate method of TraversableSerializer URL: https://github.com/apache/flink/pull/7872#issuecomment-468577664 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] aljoscha commented on issue #7872: [FLINK-11420][core] Fixed duplicate method of TraversableSerializer

2019-03-04 Thread GitBox
aljoscha commented on issue #7872: [FLINK-11420][core] Fixed duplicate method of TraversableSerializer URL: https://github.com/apache/flink/pull/7872#issuecomment-469298577 @flinkbot approve consensus This is an automated

[GitHub] [flink] StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262112444 ## File path:

[GitHub] [flink] StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
StefanRRichter commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262111077 ## File path:

[GitHub] [flink] carp84 commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern

2019-03-04 Thread GitBox
carp84 commented on a change in pull request #7866: [FLINK-11730] [State Backends] Make HeapKeyedStateBackend follow the builder pattern URL: https://github.com/apache/flink/pull/7866#discussion_r262107825 ## File path:

[jira] [Commented] (FLINK-10506) Introduce minimum, target and maximum parallelism to JobGraph

2019-03-04 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783453#comment-16783453 ] Till Rohrmann commented on FLINK-10506: --- Hi [~yanghua], this is a bit of tricky issue because we

[GitHub] [flink] GJL commented on a change in pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar

2019-03-04 Thread GitBox
GJL commented on a change in pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar URL: https://github.com/apache/flink/pull/7883#discussion_r262099481 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar

2019-03-04 Thread GitBox
GJL commented on a change in pull request #7883: [FLINK-11781][yarn] Remove "DISABLED" as possible value for yarn.per-job-cluster.include-user-jar URL: https://github.com/apache/flink/pull/7883#discussion_r262099481 ## File path:

  1   2   3   >